Hi Gaby
Thanks for your update.
Please send a PR with your code for review.
Open a new ticket in Jira for the documentation, you have to send a patch
for the website.
Example: https://issues.apache.org/jira/browse/GORA-625
Best,
John
El lun, 1 mar 2021 a las 2:11, gabriela ortiz ()
escribió:
Hi all.
I wanted to inform the tasks I worked on this week: Feb 20 - Feb 26 .
* Develop deleteByQuery method.
* Develop the Metadata Analyzer classes for Neo4j
* Enable Map Reduce tests
* Enable all tests of Neo4jStoreTest.
* Upload the documentation Neo4j -
Hi Gaby
Thanks for your report
The delete method should return true when a record is actually deleted. If
the key does not exist it should return false.
Try to use the executeUpdate method of PreparedStatement. It returns the
number of affected rows, if this number is greater than zero you can
Hi all.
I wanted to inform the tasks I worked on this week: Feb 13 - Feb 19 .
* Develop method newQuery.
* Develop classes Neo4jResult and Neo4jQuery.
* Develop method execute(query).
* Activate tests:
testTruncateSchema
testDeleteSchema
testQuery
testQueryStartKey
testQueryEndKey
Hi Gaby
Thanks for the update.
Overall the code looks good, I do not have specific feedback for you this
week.
According to your proposed timeline you should start working on the Query
features, let's do it. Let me know if you have questions.
Thanks,
John
El sáb, 13 feb 2021 a las 0:57,
Hi all.
I wanted to inform the tasks I worked on this week: Feb 06 - Feb 12 .
* Enhance variable names.
* Add enum for neo4j protocols.
* Enhance getUnionSchema method for Maps.
* Implement partitons.
* Activate tests:
testUpdate
testGetRecursive
testGetDoubleRecursive
testGetWebPage
Hi John.
Thanks for the feedback I will work on your comments.
Regards,
Gaby
El mié, 10 de feb. de 2021 a la(s) 12:04, John Mora (jhnmora...@gmail.com)
escribió:
> Hi Gaby
>
> Thanks for the update.
>
> BTW, I am sorry that I did not provide feedback on your code last week, I
> have been
Hi Gaby
Thanks for the update.
BTW, I am sorry that I did not provide feedback on your code last week, I
have been busy.
Some comments:
Please use more descriptive variable names:
Hi all.
I wanted to inform the tasks I worked on this week: Jan 30 - Feb 05 .
* Enhance the deleteSchema method (delete existing nodes when deleting the
schema constraints)
* Enhance Map, Record, Array and Bytes serialization / de-serialization
process using Base64 encoding.
* Activate tests:
Hi all.
I wanted to inform the tasks I worked on this week: Jan 17 - Jan 29 .
* Add suggested javadocs.
* Add suggested constants.
* Make EXIST constraints optional.
* Activate tests:
testNewInstance
testAutoCreateSchema
testPut
testBenchmarkExists
testGetNonExisting
Hi Gaby
Thanks for your report.
Some comments:
Please use constants instead of literal values here:
https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L204
Hi all.
I wanted to inform the tasks I worked on this week: Jan 16 - Jan 22 .
- Add EXISTS constraints for properties.
- Develop put method.
- Enable test of the put & get methods.
- Switch to fixed version docker image 'neo4j:4.2.2-enterprise' instead of
'enterprise' tag.
My code is here:
Hi
Thanks for your comments. I am working on them.
Best regards,
Gaby
El lun, 18 de ene. de 2021 a la(s) 17:11, John Mora (jhnmora...@gmail.com)
escribió:
> Hi Gaby.
>
> Thanks for your update.
>
> Some comments.
>
>
>
Hi Gaby.
Thanks for your update.
Some comments.
https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L156
Please create EXISTS constraints for the other properties of the Node as
well.
Hi all.
I wanted to inform the tasks I worked on this week: Jan 09 - Jan 15 .
- Enhance the javadocs documentation.
- Replace literal values with constants.
- Develop the put() method of the datastore.
- Test the put / exists methods.
- Write a blog for this week.
My code is here:
Hi
Thanks for your comments. I will add the missing documentation and thanks
for your reminder I will fill the form now.
Best regards,
Gaby
El lun, 11 de ene. de 2021 a la(s) 00:16, John Mora (jhnmora...@gmail.com)
escribió:
> Hi.
>
> Thanks for the update.
>
> Some comments:
>
> Please use
Hi.
Thanks for the update.
Some comments:
Please use constants instead of literal values here:
https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/test/java/org/apache/gora/neo4j/GoraNeo4jTestDriver.java#L37
Add javadocs in these classes:
Hi all.
I wanted to inform the tasks I worked on this week: Jan 01 - Jan 08
- Develop a test for XSD validations.
- Develop methods: exists and delete in the datastore.
- Switch to Neo4j Enterprise from Neo4j Community in the container of the
tests.
- Add comments and javadocs
- Change the
Hi John
Thanks for your comments.
El mié, 6 de ene. de 2021 a la(s) 16:10, John Mora (jhnmora...@gmail.com)
escribió:
> Hi
>
> Thanks for your report.
>
> Some comments:
>
> You are creating a UNIQUE index instead of the NODE KEY you mentioned on
> your design document. why?
>
>
>
Hi
Thanks for your report.
Some comments:
You are creating a UNIQUE index instead of the NODE KEY you mentioned on
your design document. why?
https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L141
Also, can you write the CREATE
Hi
I wanted to inform the tasks I worked on this week: Dec 26 - Dec 31
* Develop the Datastore methods: getSchemaName, createSchema, deleteSchema,
schemaExists
* Enable tests in Neo4jStoreTest : testCreateSchema , testSchemaExists
* Enhance the implementation of the connection to the backend.
*
21 matches
Mail list logo
