cuent opened a new pull request #158: GORA-555: Improve Lucene query
implementation with NumericRangeQuery
URL: https://github.com/apache/gora/pull/158
Infer data type for building range queries. First, check if there is a
numeric type if so cast to the appropriate type otherwise set to st
lewismc commented on issue #158: GORA-555: Improve Lucene query implementation
with NumericRangeQuery
URL: https://github.com/apache/gora/pull/158#issuecomment-480010966
This looks good @cuent thank you for taking the issue on. Please augment
your pull request with Unit tests. Thank you
-
djkevincr commented on issue #158: GORA-555: Improve Lucene query
implementation with NumericRangeQuery
URL: https://github.com/apache/gora/pull/158#issuecomment-480031983
+1 @cuent This look certainly great. @lewismc mentioned you may add Lucene
store specific tests. ( in TestLuceneStore.
cuent commented on issue #158: GORA-555: Improve Lucene query implementation
with NumericRangeQuery
URL: https://github.com/apache/gora/pull/158#issuecomment-480081077
I was trying to add that but it creates two examples, employees and website,
which have string keys. How can I extend that
lewismc commented on issue #158: GORA-555: Improve Lucene query implementation
with NumericRangeQuery
URL: https://github.com/apache/gora/pull/158#issuecomment-480168630
@cuent you can easily implement individual tests for the module and use the
`@Override` convention to implement the spec
5 matches
Mail list logo