[GitHub] [gora] cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-04 Thread GitBox
cuent commented on issue #158: GORA-555: Improve Lucene query implementation 
with NumericRangeQuery
URL: https://github.com/apache/gora/pull/158#issuecomment-480081077
 
 
   I was trying to add that but it creates two examples, employees and website, 
which have string keys. How can I extend that for creating a key with a 
numerical type? I was looking for that but I didn't found. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [gora] djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-04 Thread GitBox
djkevincr commented on issue #158: GORA-555: Improve Lucene query 
implementation with NumericRangeQuery
URL: https://github.com/apache/gora/pull/158#issuecomment-480031983
 
 
   +1 @cuent This look certainly great. @lewismc mentioned you may add Lucene 
store specific tests. ( in TestLuceneStore.java. )


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [gora] lewismc commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-04 Thread GitBox
lewismc commented on issue #158: GORA-555: Improve Lucene query implementation 
with NumericRangeQuery
URL: https://github.com/apache/gora/pull/158#issuecomment-480010966
 
 
   This looks good @cuent thank you for taking the issue on. Please augment 
your pull request with Unit tests. Thank you


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [gora] cuent opened a new pull request #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-04 Thread GitBox
cuent opened a new pull request #158: GORA-555: Improve Lucene query 
implementation with NumericRangeQuery
URL: https://github.com/apache/gora/pull/158
 
 
   Infer data type for building range queries. First, check if there is a 
numeric type if so cast to the appropriate type otherwise set to string 
datatype.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services