[jira] [Commented] (GORA-495) Gora compiler generates uncompilable databeans

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GORA-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15497838#comment-15497838
 ] 

ASF GitHub Bot commented on GORA-495:
-

Github user lewismc commented on the issue:

https://github.com/apache/gora/pull/88
  
Yes it does come from velocity. It's in the record template though I am
sure.
I am +1 to merge and then we can address that issue elsewhere... Actually
we may have already created a hit a issue for it.

On Sep 16, 2016 4:09 PM, "Kevin Ratnasekera" 
wrote:

> @lewismc  I added license headers. I think
> that compiler flag comes from record.vm velocity template,
> How do we proceed with this?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or mute
> the thread
> 

> .
>



> Gora compiler generates uncompilable databeans
> --
>
> Key: GORA-495
> URL: https://issues.apache.org/jira/browse/GORA-495
> Project: Apache Gora
>  Issue Type: Bug
>  Components: gora-compiler
>Affects Versions: 0.6
>Reporter: Kevin Ratnasekera
>Assignee: Kevin Ratnasekera
> Fix For: 0.7
>
>
> This is due to 2 missing variable declarations in record velocity template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] gora issue #88: GORA-495 fix

[lewismc]

Github user lewismc commented on the issue:

https://github.com/apache/gora/pull/88
  
Yes it does come from velocity. It's in the record template though I am
sure.
I am +1 to merge and then we can address that issue elsewhere... Actually
we may have already created a hit a issue for it.

On Sep 16, 2016 4:09 PM, "Kevin Ratnasekera" 
wrote:

> @lewismc  I added license headers. I think
> that compiler flag comes from record.vm velocity template,
> How do we proceed with this?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or mute
> the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GORA-495) Gora compiler generates uncompilable databeans

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GORA-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15497690#comment-15497690
 ] 

ASF GitHub Bot commented on GORA-495:
-

Github user djkevincr commented on the issue:

https://github.com/apache/gora/pull/88
  
@lewismc  I added license headers. I think that compiler flag comes from 
record.vm velocity template,
How do we proceed with this?


> Gora compiler generates uncompilable databeans
> --
>
> Key: GORA-495
> URL: https://issues.apache.org/jira/browse/GORA-495
> Project: Apache Gora
>  Issue Type: Bug
>  Components: gora-compiler
>Affects Versions: 0.6
>Reporter: Kevin Ratnasekera
>Assignee: Kevin Ratnasekera
> Fix For: 0.7
>
>
> This is due to 2 missing variable declarations in record velocity template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GORA-495) Gora compiler generates uncompilable databeans

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GORA-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15497642#comment-15497642
 ] 

ASF GitHub Bot commented on GORA-495:
-

Github user lewismc commented on the issue:

https://github.com/apache/gora/pull/88
  
Dynamite. Some comments
 * can you add back in the Apache license headers.. Right now this is a 
manual task.. We used to have a compiler flag to enable license header 
generation but that was with old compiler. 
 * I wonder if we can investigate removal of the SupresdAll compiler flag. 
I think this is another issue though. 

Thanks 


> Gora compiler generates uncompilable databeans
> --
>
> Key: GORA-495
> URL: https://issues.apache.org/jira/browse/GORA-495
> Project: Apache Gora
>  Issue Type: Bug
>  Components: gora-compiler
>Affects Versions: 0.6
>Reporter: Kevin Ratnasekera
>Assignee: Kevin Ratnasekera
> Fix For: 0.7
>
>
> This is due to 2 missing variable declarations in record velocity template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GORA-495) Gora compiler generates uncompilable databeans

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GORA-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15497592#comment-15497592
 ] 

ASF GitHub Bot commented on GORA-495:
-

Github user djkevincr commented on the issue:

https://github.com/apache/gora/pull/88
  
@lewismc I have recompiled all the databeans again and pushed the changes. 
There is no code change except for formatting and newly generated 
serialVersionUID. Please let me know if you have any further concerns.


> Gora compiler generates uncompilable databeans
> --
>
> Key: GORA-495
> URL: https://issues.apache.org/jira/browse/GORA-495
> Project: Apache Gora
>  Issue Type: Bug
>  Components: gora-compiler
>Affects Versions: 0.6
>Reporter: Kevin Ratnasekera
>Assignee: Kevin Ratnasekera
> Fix For: 0.7
>
>
> This is due to 2 missing variable declarations in record velocity template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] gora issue #88: GORA-495 fix

[djkevincr]

Github user djkevincr commented on the issue:

https://github.com/apache/gora/pull/88
  
@lewismc I have recompiled all the databeans again and pushed the changes. 
There is no code change except for formatting and newly generated 
serialVersionUID. Please let me know if you have any further concerns.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GORA-495) Gora compiler generates uncompilable databeans

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GORA-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15497336#comment-15497336
 ] 

ASF GitHub Bot commented on GORA-495:
-

Github user lewismc commented on the issue:

https://github.com/apache/gora/pull/88
  
No problems... I was just checking up. If you could add the newly compiled 
data beans to the PR then we can test and merge.


> Gora compiler generates uncompilable databeans
> --
>
> Key: GORA-495
> URL: https://issues.apache.org/jira/browse/GORA-495
> Project: Apache Gora
>  Issue Type: Bug
>  Components: gora-compiler
>Affects Versions: 0.6
>Reporter: Kevin Ratnasekera
>Assignee: Kevin Ratnasekera
> Fix For: 0.7
>
>
> This is due to 2 missing variable declarations in record velocity template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] gora issue #88: GORA-495 fix

[lewismc]

Github user lewismc commented on the issue:

https://github.com/apache/gora/pull/88
  
No problems... I was just checking up. If you could add the newly compiled 
data beans to the PR then we can test and merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GORA-495) Gora compiler generates uncompilable databeans

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GORA-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15497323#comment-15497323
 ] 

ASF GitHub Bot commented on GORA-495:
-

Github user djkevincr commented on the issue:

https://github.com/apache/gora/pull/88
  
@lewismc All the databeans Gora codebase have been updated with this. All 
the data beans currently have this 2 variable declaration. Just looking at 
commit history in my final pull request, these two variable declarations 
unintentionally got missing after adding java docs record velocity template. 
Apologize for the confusion.


> Gora compiler generates uncompilable databeans
> --
>
> Key: GORA-495
> URL: https://issues.apache.org/jira/browse/GORA-495
> Project: Apache Gora
>  Issue Type: Bug
>  Components: gora-compiler
>Affects Versions: 0.6
>Reporter: Kevin Ratnasekera
>Assignee: Kevin Ratnasekera
> Fix For: 0.7
>
>
> This is due to 2 missing variable declarations in record velocity template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] gora issue #88: GORA-495 fix

[djkevincr]

Github user djkevincr commented on the issue:

https://github.com/apache/gora/pull/88
  
@lewismc All the databeans Gora codebase have been updated with this. All 
the data beans currently have this 2 variable declaration. Just looking at 
commit history in my final pull request, these two variable declarations 
unintentionally got missing after adding java docs record velocity template. 
Apologize for the confusion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora issue #88: GORA-495 fix

[lewismc]

Github user lewismc commented on the issue:

https://github.com/apache/gora/pull/88
  
Hi @djkevincr is it not necessary to recompile all of the existing data 
beans within the Gora codebase?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GORA-495) Gora compiler generates uncompilable databeans

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GORA-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15497291#comment-15497291
 ] 

ASF GitHub Bot commented on GORA-495:
-

Github user lewismc commented on the issue:

https://github.com/apache/gora/pull/88
  
Hi @djkevincr is it not necessary to recompile all of the existing data 
beans within the Gora codebase?


> Gora compiler generates uncompilable databeans
> --
>
> Key: GORA-495
> URL: https://issues.apache.org/jira/browse/GORA-495
> Project: Apache Gora
>  Issue Type: Bug
>  Components: gora-compiler
>Affects Versions: 0.6
>Reporter: Kevin Ratnasekera
>Assignee: Kevin Ratnasekera
> Fix For: 0.7
>
>
> This is due to 2 missing variable declarations in record velocity template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GORA-495) Gora compiler generates uncompilable databeans

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GORA-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15497198#comment-15497198
 ] 

ASF GitHub Bot commented on GORA-495:
-

GitHub user djkevincr opened a pull request:

https://github.com/apache/gora/pull/88

GORA-495 fix



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/djkevincr/gora GORA-495

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/gora/pull/88.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #88


commit c103f8951106f037b7e2b075c69610372d65aa4c
Author: Kevin Ratnasekera 
Date:   2016-09-16T19:43:47Z

GORA-495 fix




> Gora compiler generates uncompilable databeans
> --
>
> Key: GORA-495
> URL: https://issues.apache.org/jira/browse/GORA-495
> Project: Apache Gora
>  Issue Type: Bug
>  Components: gora-compiler
>Affects Versions: 0.6
>Reporter: Kevin Ratnasekera
>Assignee: Kevin Ratnasekera
> Fix For: 0.7
>
>
> This is due to 2 missing variable declarations in record velocity template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (GORA-495) Gora compiler generates uncompilable databeans

[Kevin Ratnasekera (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GORA-495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Ratnasekera updated GORA-495:
---
Description: This is due to 2 missing variable declarations in record 
velocity template.  (was: This is due to missing variable declarations in 
record velocity template.)

> Gora compiler generates uncompilable databeans
> --
>
> Key: GORA-495
> URL: https://issues.apache.org/jira/browse/GORA-495
> Project: Apache Gora
>  Issue Type: Bug
>  Components: gora-compiler
>Affects Versions: 0.6
>Reporter: Kevin Ratnasekera
>Assignee: Kevin Ratnasekera
> Fix For: 0.7
>
>
> This is due to 2 missing variable declarations in record velocity template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] gora pull request #88: GORA-495 fix

[djkevincr]

GitHub user djkevincr opened a pull request:

https://github.com/apache/gora/pull/88

GORA-495 fix



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/djkevincr/gora GORA-495

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/gora/pull/88.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #88


commit c103f8951106f037b7e2b075c69610372d65aa4c
Author: Kevin Ratnasekera 
Date:   2016-09-16T19:43:47Z

GORA-495 fix




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (GORA-495) Gora compiler generates uncompilable databeans

[Kevin Ratnasekera (JIRA)]

Kevin Ratnasekera created GORA-495:
--

 Summary: Gora compiler generates uncompilable databeans
 Key: GORA-495
 URL: https://issues.apache.org/jira/browse/GORA-495
 Project: Apache Gora
  Issue Type: Bug
  Components: gora-compiler
Affects Versions: 0.6
Reporter: Kevin Ratnasekera
Assignee: Kevin Ratnasekera
 Fix For: 0.7


This is due to missing variable declarations in record velocity template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GORA-494) Lack of synchronization accessing cacheManager in InfinispanClient#createSchema()

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/GORA-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15497179#comment-15497179
 ] 

Hudson commented on GORA-494:
-

SUCCESS: Integrated in Jenkins build gora-trunk #1686 (See 
[https://builds.apache.org/job/gora-trunk/1686/])
GORA-494 Lack of synchronization accessing cacheManager in (lewis.mcgibbney: 
rev 882fac9790e64183999cf6d3714d12d0e73da351)
* (edit) 
gora-infinispan/src/main/java/org/apache/gora/infinispan/store/InfinispanClient.java


> Lack of synchronization accessing cacheManager in 
> InfinispanClient#createSchema()
> -
>
> Key: GORA-494
> URL: https://issues.apache.org/jira/browse/GORA-494
> Project: Apache Gora
>  Issue Type: Bug
>  Components: gora-infinispan
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 0.7
>
> Attachments: GORA-494.v1.patch
>
>
> {code}
>   public void createSchema() {
> try {
>   Support.registerSchema(cacheManager, 
> persistentClass.newInstance().getSchema());
> {code}
> Access to cacheManager should be synchronized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GORA-493) Unclosed DataInputBuffer in IOUtils#deserialize()

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/GORA-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15497178#comment-15497178
 ] 

Hudson commented on GORA-493:
-

SUCCESS: Integrated in Jenkins build gora-trunk #1686 (See 
[https://builds.apache.org/job/gora-trunk/1686/])
GORA-493 Unclosed DataInputBuffer in IOUtils#deserialize() (lewis.mcgibbney: 
rev 854899e5db38fa14e7be56c1f850c35387d4df06)
* (edit) gora-core/src/main/java/org/apache/gora/util/IOUtils.java


> Unclosed DataInputBuffer in IOUtils#deserialize()
> -
>
> Key: GORA-493
> URL: https://issues.apache.org/jira/browse/GORA-493
> Project: Apache Gora
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Fix For: 0.7
>
> Attachments: GORA-493.v1.patch
>
>
> {code}
> DataInputBuffer buffer = new DataInputBuffer();
> buffer.reset(in, in.length);
> return deserialize(conf, buffer, obj);
> {code}
> buffer should be closed upon return from the method.
> In serialize(), there is similar problem for DataOutputBuffer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (GORA-493) Unclosed DataInputBuffer in IOUtils#deserialize()

[Lewis John McGibbney (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GORA-493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lewis John McGibbney updated GORA-493:
--
Assignee: Ted Yu

> Unclosed DataInputBuffer in IOUtils#deserialize()
> -
>
> Key: GORA-493
> URL: https://issues.apache.org/jira/browse/GORA-493
> Project: Apache Gora
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Fix For: 0.7
>
> Attachments: GORA-493.v1.patch
>
>
> {code}
> DataInputBuffer buffer = new DataInputBuffer();
> buffer.reset(in, in.length);
> return deserialize(conf, buffer, obj);
> {code}
> buffer should be closed upon return from the method.
> In serialize(), there is similar problem for DataOutputBuffer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (GORA-494) Lack of synchronization accessing cacheManager in InfinispanClient#createSchema()

[Lewis John McGibbney (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GORA-494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lewis John McGibbney updated GORA-494:
--
Assignee: Ted Yu

> Lack of synchronization accessing cacheManager in 
> InfinispanClient#createSchema()
> -
>
> Key: GORA-494
> URL: https://issues.apache.org/jira/browse/GORA-494
> Project: Apache Gora
>  Issue Type: Bug
>  Components: gora-infinispan
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 0.7
>
> Attachments: GORA-494.v1.patch
>
>
> {code}
>   public void createSchema() {
> try {
>   Support.registerSchema(cacheManager, 
> persistentClass.newInstance().getSchema());
> {code}
> Access to cacheManager should be synchronized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (GORA-494) Lack of synchronization accessing cacheManager in InfinispanClient#createSchema()

[Ted Yu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GORA-494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated GORA-494:

Attachment: GORA-494.v1.patch

> Lack of synchronization accessing cacheManager in 
> InfinispanClient#createSchema()
> -
>
> Key: GORA-494
> URL: https://issues.apache.org/jira/browse/GORA-494
> Project: Apache Gora
>  Issue Type: Bug
>  Components: gora-infinispan
>Reporter: Ted Yu
> Fix For: 0.7
>
> Attachments: GORA-494.v1.patch
>
>
> {code}
>   public void createSchema() {
> try {
>   Support.registerSchema(cacheManager, 
> persistentClass.newInstance().getSchema());
> {code}
> Access to cacheManager should be synchronized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (GORA-493) Unclosed DataInputBuffer in IOUtils#deserialize()

[Ted Yu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GORA-493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated GORA-493:

Attachment: GORA-493.v1.patch

> Unclosed DataInputBuffer in IOUtils#deserialize()
> -
>
> Key: GORA-493
> URL: https://issues.apache.org/jira/browse/GORA-493
> Project: Apache Gora
>  Issue Type: Bug
>Reporter: Ted Yu
>Priority: Minor
> Fix For: 0.7
>
> Attachments: GORA-493.v1.patch
>
>
> {code}
> DataInputBuffer buffer = new DataInputBuffer();
> buffer.reset(in, in.length);
> return deserialize(conf, buffer, obj);
> {code}
> buffer should be closed upon return from the method.
> In serialize(), there is similar problem for DataOutputBuffer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GORA-401) Serialization and deserialization of Persistent does not hold the entity dirty state from Map to Reduce

[Kevin Ratnasekera (JIRA)]

[ 
https://issues.apache.org/jira/browse/GORA-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495844#comment-15495844
 ] 

Kevin Ratnasekera commented on GORA-401:


[~lewismc] I faced the same issue when I was implementing the JCache store 
where I wanted preserve/protect the dirty bytes of persistent beans when they 
are putting and getting back from caches. ( Since cache maintains databeans in 
serialized form ) To address this I have explicitly handled persistent bean 
serialization by extending  java.io.Externalizable at 
PersistentBase. Please see [1] where I have introduced public getter/setter for 
dirty bytes ( also discussed in this thread ), at explicit serialization of 
databean I have introduced  logic to preserve dirty bytes [2].

[1] 
https://github.com/apache/gora/blob/master/gora-core/src/main/java/org/apache/gora/persistency/impl/PersistentBase.java#L186-L219
[2] 
https://github.com/apache/gora/blob/master/gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm#L357-L387

> Serialization and deserialization of Persistent does not hold the entity 
> dirty state from Map to Reduce
> ---
>
> Key: GORA-401
> URL: https://issues.apache.org/jira/browse/GORA-401
> Project: Apache Gora
>  Issue Type: Bug
>  Components: gora-core
>Affects Versions: 0.4, 0.5
> Environment: Tested on gora-0.4, but seems logically to hold on 
> gora-0.5. HBase backend.
>Reporter: Alfonso Nishikawa
>Assignee: Alfonso Nishikawa
>Priority: Critical
>  Labels: serialization
> Fix For: 0.8
>
> Attachments: GORA-401-tests.patch, GORA-401v1.patch, 
> GORA-401v2.patch, GORA-401v3.patch, GORA-401v4.patch, GORA-401v5.patch
>
>   Original Estimate: 35h
>  Time Spent: 21h
>  Remaining Estimate: 14h
>
> After removing __g__dirty field in GORA-326, dirty field is not serialized. 
> In GORA-321 
> {{[PersistentSerializer|https://github.com/apache/gora/blob/master/gora-core/src/main/java/org/apache/gora/mapreduce/PersistentSerializer.java]}}
>  went from using 
> {{[PersistentDatumWriter|https://github.com/apache/gora/blob/apache-gora-0.3/gora-core/src/main/java/org/apache/gora/avro/PersistentDatumWriter.java](/Reader)}}
>  to Avro's {{SpecificDatumWriter}}, delegating the serialization of the dirty 
> field to Avro (but really not desirable to have that field as a main field in 
> the entities).
> The proposal is to reintroduce the {{PersistentDatumWriter/Reader}} which 
> will serialize the internal fields of the entities.
> This bug affects, for example, Nutch, which loads only some fields in it's 
> phases, serializes entities (from Map to Reduce), and when deserializes finds 
> all fields as "dirty", independently of what fields were modified in the Map, 
> and overwrite all data in datastore (deleting much things: downloaded 
> content, parsed content, etc).
> This effect can be seen in 
> {{TestPersistentSerialization#testSerderEmployeeTwoFields}}, when debuging in 
> {{TestIOUtils#testSerializeDeserialize}}. Proper breakpoints an inspections 
> shows that, entities are "equal" when it's fields are equal. This is fine as 
> "equal" definition, but another test must be added to check that 
> serialization an deserialization keeps the dirty state.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GORA-401) Serialization and deserialization of Persistent does not hold the entity dirty state from Map to Reduce

[Lewis John McGibbney (JIRA)]

[ 
https://issues.apache.org/jira/browse/GORA-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495738#comment-15495738
 ] 

Lewis John McGibbney commented on GORA-401:
---

[~alfonso.nishikawa] are you able to convert this into a Github pull request?

> Serialization and deserialization of Persistent does not hold the entity 
> dirty state from Map to Reduce
> ---
>
> Key: GORA-401
> URL: https://issues.apache.org/jira/browse/GORA-401
> Project: Apache Gora
>  Issue Type: Bug
>  Components: gora-core
>Affects Versions: 0.4, 0.5
> Environment: Tested on gora-0.4, but seems logically to hold on 
> gora-0.5. HBase backend.
>Reporter: Alfonso Nishikawa
>Assignee: Alfonso Nishikawa
>Priority: Critical
>  Labels: serialization
> Fix For: 0.8
>
> Attachments: GORA-401-tests.patch, GORA-401v1.patch, 
> GORA-401v2.patch, GORA-401v3.patch, GORA-401v4.patch, GORA-401v5.patch
>
>   Original Estimate: 35h
>  Time Spent: 21h
>  Remaining Estimate: 14h
>
> After removing __g__dirty field in GORA-326, dirty field is not serialized. 
> In GORA-321 
> {{[PersistentSerializer|https://github.com/apache/gora/blob/master/gora-core/src/main/java/org/apache/gora/mapreduce/PersistentSerializer.java]}}
>  went from using 
> {{[PersistentDatumWriter|https://github.com/apache/gora/blob/apache-gora-0.3/gora-core/src/main/java/org/apache/gora/avro/PersistentDatumWriter.java](/Reader)}}
>  to Avro's {{SpecificDatumWriter}}, delegating the serialization of the dirty 
> field to Avro (but really not desirable to have that field as a main field in 
> the entities).
> The proposal is to reintroduce the {{PersistentDatumWriter/Reader}} which 
> will serialize the internal fields of the entities.
> This bug affects, for example, Nutch, which loads only some fields in it's 
> phases, serializes entities (from Map to Reduce), and when deserializes finds 
> all fields as "dirty", independently of what fields were modified in the Map, 
> and overwrite all data in datastore (deleting much things: downloaded 
> content, parsed content, etc).
> This effect can be seen in 
> {{TestPersistentSerialization#testSerderEmployeeTwoFields}}, when debuging in 
> {{TestIOUtils#testSerializeDeserialize}}. Proper breakpoints an inspections 
> shows that, entities are "equal" when it's fields are equal. This is fine as 
> "equal" definition, but another test must be added to check that 
> serialization an deserialization keeps the dirty state.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (GORA-295) Dynamic support for Cache Providers using JCache

[Lewis John McGibbney (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GORA-295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lewis John McGibbney resolved GORA-295.
---
Resolution: Fixed

> Dynamic support for Cache Providers using JCache
> 
>
> Key: GORA-295
> URL: https://issues.apache.org/jira/browse/GORA-295
> Project: Apache Gora
>  Issue Type: New Feature
>  Components: gora-core
>Reporter: Apostolos Giannakidis
>Assignee: Kevin Ratnasekera
>Priority: Minor
>  Labels: Ehcache, gsoc2014
> Fix For: 0.7
>
>
> Gora should be able to support external Cache Providers, such as Ehcache. 
> MemStore would be the first candidate to use the Cache Provider but ideally 
> caching should be independent from the back-end datastore module. So, users 
> can combine the back-end datastore of their choice with the Caching Provider 
> of their choice. The caching module should be dynamic in the sense that 
> different Cache Providers may be supported.
> Benefits for Gora: 
> 1) Caching may provide significant performance improvements
> 2) Integrate with Ehcache; Java's most widely-used Cache (fast, simple to 
> use, small foot print)
> Ehcache is under the Apache 2.0 license.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (GORA-295) Dynamic support for Cache Providers using JCache

[Lewis John McGibbney (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GORA-295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lewis John McGibbney updated GORA-295:
--
Fix Version/s: (was: 0.8)
   0.7

> Dynamic support for Cache Providers using JCache
> 
>
> Key: GORA-295
> URL: https://issues.apache.org/jira/browse/GORA-295
> Project: Apache Gora
>  Issue Type: New Feature
>  Components: gora-core
>Reporter: Apostolos Giannakidis
>Assignee: Kevin Ratnasekera
>Priority: Minor
>  Labels: Ehcache, gsoc2014
> Fix For: 0.7
>
>
> Gora should be able to support external Cache Providers, such as Ehcache. 
> MemStore would be the first candidate to use the Cache Provider but ideally 
> caching should be independent from the back-end datastore module. So, users 
> can combine the back-end datastore of their choice with the Caching Provider 
> of their choice. The caching module should be dynamic in the sense that 
> different Cache Providers may be supported.
> Benefits for Gora: 
> 1) Caching may provide significant performance improvements
> 2) Integrate with Ehcache; Java's most widely-used Cache (fast, simple to 
> use, small foot print)
> Ehcache is under the Apache 2.0 license.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GORA-494) Lack of synchronization accessing cacheManager in InfinispanClient#createSchema()

[Lewis John McGibbney (JIRA)]

[ 
https://issues.apache.org/jira/browse/GORA-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495700#comment-15495700
 ] 

Lewis John McGibbney commented on GORA-494:
---

Thanks for logging these issue Ted. Do you have a patch? Would be very good to 
get this into 0.7.

> Lack of synchronization accessing cacheManager in 
> InfinispanClient#createSchema()
> -
>
> Key: GORA-494
> URL: https://issues.apache.org/jira/browse/GORA-494
> Project: Apache Gora
>  Issue Type: Bug
>  Components: gora-infinispan
>Reporter: Ted Yu
> Fix For: 0.7
>
>
> {code}
>   public void createSchema() {
> try {
>   Support.registerSchema(cacheManager, 
> persistentClass.newInstance().getSchema());
> {code}
> Access to cacheManager should be synchronized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (GORA-494) Lack of synchronization accessing cacheManager in InfinispanClient#createSchema()

[Lewis John McGibbney (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GORA-494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lewis John McGibbney updated GORA-494:
--
Component/s: gora-infinispan

> Lack of synchronization accessing cacheManager in 
> InfinispanClient#createSchema()
> -
>
> Key: GORA-494
> URL: https://issues.apache.org/jira/browse/GORA-494
> Project: Apache Gora
>  Issue Type: Bug
>  Components: gora-infinispan
>Reporter: Ted Yu
> Fix For: 0.7
>
>
> {code}
>   public void createSchema() {
> try {
>   Support.registerSchema(cacheManager, 
> persistentClass.newInstance().getSchema());
> {code}
> Access to cacheManager should be synchronized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GORA-493) Unclosed DataInputBuffer in IOUtils#deserialize()

[Lewis John McGibbney (JIRA)]

[ 
https://issues.apache.org/jira/browse/GORA-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495699#comment-15495699
 ] 

Lewis John McGibbney commented on GORA-493:
---

Thanks for logging these issue Ted. Do you have a patch? Would be very good to 
get this into 0.7.

> Unclosed DataInputBuffer in IOUtils#deserialize()
> -
>
> Key: GORA-493
> URL: https://issues.apache.org/jira/browse/GORA-493
> Project: Apache Gora
>  Issue Type: Bug
>Reporter: Ted Yu
>Priority: Minor
> Fix For: 0.7
>
>
> {code}
> DataInputBuffer buffer = new DataInputBuffer();
> buffer.reset(in, in.length);
> return deserialize(conf, buffer, obj);
> {code}
> buffer should be closed upon return from the method.
> In serialize(), there is similar problem for DataOutputBuffer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (GORA-494) Lack of synchronization accessing cacheManager in InfinispanClient#createSchema()

[Lewis John McGibbney (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GORA-494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lewis John McGibbney updated GORA-494:
--
Fix Version/s: 0.7

> Lack of synchronization accessing cacheManager in 
> InfinispanClient#createSchema()
> -
>
> Key: GORA-494
> URL: https://issues.apache.org/jira/browse/GORA-494
> Project: Apache Gora
>  Issue Type: Bug
>Reporter: Ted Yu
> Fix For: 0.7
>
>
> {code}
>   public void createSchema() {
> try {
>   Support.registerSchema(cacheManager, 
> persistentClass.newInstance().getSchema());
> {code}
> Access to cacheManager should be synchronized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (GORA-493) Unclosed DataInputBuffer in IOUtils#deserialize()

[Lewis John McGibbney (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GORA-493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lewis John McGibbney updated GORA-493:
--
Fix Version/s: 0.7

> Unclosed DataInputBuffer in IOUtils#deserialize()
> -
>
> Key: GORA-493
> URL: https://issues.apache.org/jira/browse/GORA-493
> Project: Apache Gora
>  Issue Type: Bug
>Reporter: Ted Yu
>Priority: Minor
> Fix For: 0.7
>
>
> {code}
> DataInputBuffer buffer = new DataInputBuffer();
> buffer.reset(in, in.length);
> return deserialize(conf, buffer, obj);
> {code}
> buffer should be closed upon return from the method.
> In serialize(), there is similar problem for DataOutputBuffer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)