lewismc commented on issue #152: GORA-266 Lucene datastore for Gora - lewismc
URL: https://github.com/apache/gora/pull/152#issuecomment-473757077
I think this looks good. The only suggestion I have right now is to expand
support for other `keyClass` implementations in LuceneQuery. There is
alfonsonishikawa commented on issue #135: Goraexplorer needed changes
URL: https://github.com/apache/gora/pull/135#issuecomment-473711809
Hi! Finished the changes. You can see all in the [Files
Tab](https://github.com/apache/gora/pull/135/files?file-filters%5B%5D=).
Thank you!!
alfonsonishikawa commented on a change in pull request #135: Goraexplorer
needed changes
URL: https://github.com/apache/gora/pull/135#discussion_r266256724
##
File path: gora-pig/src/test/examples/README.md
##
@@ -0,0 +1,46 @@
+
Review comment:
The Gora-Pig example R
alfonsonishikawa commented on a change in pull request #135: Goraexplorer
needed changes
URL: https://github.com/apache/gora/pull/135#discussion_r266256724
##
File path: gora-pig/src/test/examples/README.md
##
@@ -0,0 +1,46 @@
+
Review comment:
The Gora-Pig example R
alfonsonishikawa commented on a change in pull request #135: Goraexplorer
needed changes
URL: https://github.com/apache/gora/pull/135#discussion_r266256105
##
File path: gora-pig/src/test/examples/example.pig
##
@@ -0,0 +1,4 @@
+set job.name 'GoraStorage test' ;
+register
alfonsonishikawa commented on a change in pull request #135: Goraexplorer
needed changes
URL: https://github.com/apache/gora/pull/135#discussion_r266256014
##
File path:
gora-core/src/examples/java/org/apache/gora/examples/generated/package-info.java
##
@@ -1,20 +0,0 @@
-
alfonsonishikawa commented on a change in pull request #135: Goraexplorer
needed changes
URL: https://github.com/apache/gora/pull/135#discussion_r266255944
##
File path: conf/log4j.properties
##
@@ -24,7 +24,7 @@ log4j.threshhold=ALL
log4j.rootLogger=${gora.root.logger}
alfonsonishikawa commented on a change in pull request #135: Goraexplorer
needed changes
URL: https://github.com/apache/gora/pull/135#discussion_r266249623
##
File path: gora-core/src/main/java/org/apache/gora/store/DataStoreFactory.java
##
@@ -412,7 +484,7 @@ public stati
alfonsonishikawa commented on a change in pull request #135: Goraexplorer
needed changes
URL: https://github.com/apache/gora/pull/135#discussion_r224998986
##
File path:
gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm
##
@@ -180,6 +180,11 @@ p
alfonsonishikawa commented on a change in pull request #135: Goraexplorer
needed changes
URL: https://github.com/apache/gora/pull/135#discussion_r222506186
##
File path:
gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm
##
@@ -180,6 +180,11 @@ p
10 matches
Mail list logo
