[GitHub] [gora] djkevincr commented on issue #174: GORA-396 Correct GoraCompiler formatting for embedded Tombstone class

2019-08-09 Thread GitBox
djkevincr commented on issue #174: GORA-396 Correct GoraCompiler formatting for embedded Tombstone class URL: https://github.com/apache/gora/pull/174#issuecomment-520121153 @lewismc +1, Shall we get this to release after 0.9? We actually faced some last moment issues and had to call off

[GitHub] [gora] carlosrmng commented on issue #174: GORA-396 Correct GoraCompiler formatting for embedded Tombstone class

2019-08-09 Thread GitBox
carlosrmng commented on issue #174: GORA-396 Correct GoraCompiler formatting for embedded Tombstone class URL: https://github.com/apache/gora/pull/174#issuecomment-520120143 LGTM, +1 This is an automated message from the

[GitHub] [gora] sneceesay77 commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-09 Thread GitBox
sneceesay77 commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r312690799 ## File path: gora-tutorial/conf/gora.properties ## @@ -66,3 +66,18 @@

[GitHub] [gora] sneceesay77 commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-09 Thread GitBox
sneceesay77 commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r312689641 ## File path: gora-tutorial/conf/gora.properties ## @@ -66,3 +66,18 @@

[GitHub] [gora] sneceesay77 commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-09 Thread GitBox
sneceesay77 commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r312689269 ## File path: gora-benchmark/pom.xml ## @@ -0,0 +1,188 @@ + +

[GitHub] [gora] djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-09 Thread GitBox
djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r312689165 ## File path:

[GitHub] [gora] djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-09 Thread GitBox
djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r312689210 ## File path:

[GitHub] [gora] djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-09 Thread GitBox
djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r312689173 ## File path:

[GitHub] [gora] djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-09 Thread GitBox
djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r312689132 ## File path:

[GitHub] [gora] djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-09 Thread GitBox
djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r312689206 ## File path:

[GitHub] [gora] djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-09 Thread GitBox
djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r312688962 ## File path: gora-tutorial/conf/gora.properties ## @@ -66,3 +66,18 @@

[GitHub] [gora] sneceesay77 commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-09 Thread GitBox
sneceesay77 commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r312688778 ## File path: gora-benchmark/pom.xml ## @@ -0,0 +1,188 @@ + +

[GitHub] [gora] lewismc commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-09 Thread GitBox
lewismc commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r312680635 ## File path: gora-benchmark/pom.xml ## @@ -0,0 +1,188 @@ + +

[GitHub] [gora] lewismc commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-09 Thread GitBox
lewismc commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r312680421 ## File path: gora-benchmark/pom.xml ## @@ -0,0 +1,188 @@ + +

[GitHub] [gora] lewismc commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-09 Thread GitBox
lewismc commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r312680051 ## File path: gora-benchmark/README.md ## @@ -0,0 +1,48 @@ +/** + * Licensed

[GitHub] [gora] lewismc commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-09 Thread GitBox
lewismc commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r312680021 ## File path: gora-benchmark/README.md ## @@ -0,0 +1,48 @@ +/** + * Licensed

[GitHub] [gora] lewismc commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-09 Thread GitBox
lewismc commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r312680102 ## File path: gora-benchmark/README.md ## @@ -0,0 +1,48 @@ +/** + * Licensed

[GitHub] [gora] lewismc commented on issue #174: GORA-396 Correct GoraCompiler formatting for embedded Tombstone class

2019-08-09 Thread GitBox
lewismc commented on issue #174: GORA-396 Correct GoraCompiler formatting for embedded Tombstone class URL: https://github.com/apache/gora/pull/174#issuecomment-520099260 +1 any comments before I merge? @cuent sorry this sat for so long.

[GitHub] [gora] sneceesay77 commented on issue #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-09 Thread GitBox
sneceesay77 commented on issue #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#issuecomment-520091737 > Please ping me here @sneceesay77 when the PR updated and you've provided a README of how we can run this.

[GitHub] [gora] cuent commented on issue #177: [GORA-527] Implement a data store for redis

2019-08-09 Thread GitBox
cuent commented on issue #177: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/177#issuecomment-520080639 Thanks @madhawa-gunasekara and @carlosrmng! I will solve conflicts and comments by the end of this week.

[GitHub] [gora] carlosrmng commented on issue #177: [GORA-527] Implement a data store for redis

2019-08-09 Thread GitBox
carlosrmng commented on issue #177: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/177#issuecomment-520069840 @cuent , Please keep your PR synchronized with master. Some PR were merged and there is a conflict.

[GitHub] [gora] carlosrmng commented on a change in pull request #177: [GORA-527] Implement a data store for redis

2019-08-09 Thread GitBox
carlosrmng commented on a change in pull request #177: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/177#discussion_r312650152 ## File path: gora-redis/src/main/java/org/apache/gora/redis/store/RedisStore.java ## @@ -0,0 +1,519 @@

[GitHub] [gora] carlosrmng commented on a change in pull request #177: [GORA-527] Implement a data store for redis

2019-08-09 Thread GitBox
carlosrmng commented on a change in pull request #177: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/177#discussion_r312648541 ## File path: gora-redis/src/main/java/org/apache/gora/redis/store/RedisStore.java ## @@ -0,0 +1,519 @@

[GitHub] [gora] carlosrmng commented on a change in pull request #177: [GORA-527] Implement a data store for redis

2019-08-09 Thread GitBox
carlosrmng commented on a change in pull request #177: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/177#discussion_r312651216 ## File path: gora-redis/src/main/java/org/apache/gora/redis/store/RedisStore.java ## @@ -0,0 +1,519 @@

[GitHub] [gora] carlosrmng commented on a change in pull request #177: [GORA-527] Implement a data store for redis

2019-08-09 Thread GitBox
carlosrmng commented on a change in pull request #177: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/177#discussion_r312651463 ## File path: gora-redis/src/main/java/org/apache/gora/redis/util/DatumHandler.java ## @@ -0,0 +1,329 @@

[GitHub] [gora] carlosrmng commented on a change in pull request #177: [GORA-527] Implement a data store for redis

2019-08-09 Thread GitBox
carlosrmng commented on a change in pull request #177: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/177#discussion_r312652873 ## File path: gora-redis/src/test/java/org/apache/gora/redis/GoraRedisTestDriver.java ## @@ -0,0 +1,105

[GitHub] [gora] carlosrmng commented on a change in pull request #177: [GORA-527] Implement a data store for redis

2019-08-09 Thread GitBox
carlosrmng commented on a change in pull request #177: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/177#discussion_r312651508 ## File path: gora-redis/src/main/java/org/apache/gora/redis/util/DatumHandler.java ## @@ -0,0 +1,329 @@

[GitHub] [gora] carlosrmng commented on a change in pull request #177: [GORA-527] Implement a data store for redis

2019-08-09 Thread GitBox
carlosrmng commented on a change in pull request #177: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/177#discussion_r312649716 ## File path: gora-redis/src/main/java/org/apache/gora/redis/store/RedisStore.java ## @@ -0,0 +1,519 @@

[GitHub] [gora] carlosrmng commented on a change in pull request #177: [GORA-527] Implement a data store for redis

2019-08-09 Thread GitBox
carlosrmng commented on a change in pull request #177: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/177#discussion_r312651056 ## File path: gora-redis/src/main/java/org/apache/gora/redis/store/RedisStore.java ## @@ -0,0 +1,519 @@

[GitHub] [gora] carlosrmng commented on a change in pull request #177: [GORA-527] Implement a data store for redis

2019-08-09 Thread GitBox
carlosrmng commented on a change in pull request #177: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/177#discussion_r312650879 ## File path: gora-redis/src/main/java/org/apache/gora/redis/util/DatumHandler.java ## @@ -0,0 +1,329 @@

[GitHub] [gora] carlosrmng commented on a change in pull request #177: [GORA-527] Implement a data store for redis

2019-08-09 Thread GitBox
carlosrmng commented on a change in pull request #177: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/177#discussion_r312649058 ## File path: gora-redis/src/main/java/org/apache/gora/redis/store/RedisStore.java ## @@ -0,0 +1,519 @@

[GitHub] [gora] carlosrmng commented on a change in pull request #177: [GORA-527] Implement a data store for redis

2019-08-09 Thread GitBox
carlosrmng commented on a change in pull request #177: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/177#discussion_r312650318 ## File path: gora-redis/src/main/java/org/apache/gora/redis/store/RedisStore.java ## @@ -0,0 +1,519 @@

Re: Kudu datastore reports

2019-08-09 Thread John Mora
Hi. I updated my PR[2] with some improvements. Also, I tested my code with this docker image [3] and it worked fine. This what I did: Run docker container: docker run --hostname localhost -d --rm --name apache-kudu -p 7051:7051 -p 7050:7050 -p 8051:8051 -p 8050:8050

Re: Kudu datastore reports

2019-08-09 Thread John Mora
Hi Alfonso, Please take into a consideration that the property 'gora.datastore.kudu.masterAddress' is overridden in the class GoraKuduTestDriver [1]. Because KuduTestHarness generates random ports which need to be configured at runtime. Probably, you should change the property there too. I will