[GitHub] [gora] lewismc commented on issue #140: GORA-548 Apache Flink support for Gora
lewismc commented on issue #140: GORA-548 Apache Flink support for Gora URL: https://github.com/apache/gora/pull/140#issuecomment-478381991 ``` [ERROR] Failures: [ERROR] TestHBaseStore>DataStoreTestBase.testDelete:341 expected:<9> but was:<8> [ERROR] TestHBaseStore>DataStoreTestBase.testDeleteByQuery:347 expected:<10> but was:<9> [ERROR] TestHBaseStore>DataStoreTestBase.testDeleteByQueryFields:353 expected:<10> but was:<9> [ERROR] TestHBaseStore>DataStoreTestBase.testGetWebPageDefaultFields:287 [ERROR] TestHBaseStore>DataStoreTestBase.testQueryEndKey:311 expected:<9> but was:<8> [ERROR] TestHBaseStore>DataStoreTestBase.testQueryKeyRange:317 expected:<10> but was:<9> [ERROR] TestHBaseStore>DataStoreTestBase.testQueryStartKey:305 expected:<10> but was:<9> [ERROR] TestHBaseStore>DataStoreTestBase.testQueryWebPageSingleKey:323 [ERROR] TestHBaseStore>DataStoreTestBase.testQueryWebPageSingleKeyDefaultFields:329 [ERROR] TestHBaseStore>DataStoreTestBase.testResultSizeKeyRangeWithLimit:407 expected:<0> but was:<1> [ERROR] Errors: [ERROR] org.apache.gora.hbase.mapreduce.TestHBaseStoreWordCount.testFlinkWordCountFlink(org.apache.gora.hbase.mapreduce.TestHBaseStoreWordCount) [ERROR] Run 1: TestHBaseStoreWordCount.setUp:44 ยป SocketTimeout callTimeout=120, callDura... [ERROR] Run 2: TestHBaseStoreWordCount.tearDown:53 NullPointer [INFO] [INFO] [ERROR] Tests run: 53, Failures: 10, Errors: 1, Skipped: 4 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] lewismc commented on issue #140: GORA-548 Apache Flink support for Gora
lewismc commented on issue #140: GORA-548 Apache Flink support for Gora URL: https://github.com/apache/gora/pull/140#issuecomment-478382125 [org.apache.gora.hbase.mapreduce.TestHBaseStoreWordCount.txt](https://github.com/apache/gora/files/3027131/org.apache.gora.hbase.mapreduce.TestHBaseStoreWordCount.txt) [org.apache.gora.hbase.store.TestHBaseStore.txt](https://github.com/apache/gora/files/3027132/org.apache.gora.hbase.store.TestHBaseStore.txt) Test logs attached This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr opened a new pull request #157: GORA-549: Remove PersistentBase extending java.io.Externalizable
djkevincr opened a new pull request #157: GORA-549: Remove PersistentBase extending java.io.Externalizable URL: https://github.com/apache/gora/pull/157 This is no longer required since SpecificRecordBase extends java.io.Externalizable with AVRO upgrade. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface
djkevincr commented on a change in pull request #156: GORA 411 - Add
exists(key) to DataStore interface
URL: https://github.com/apache/gora/pull/156#discussion_r271661575
##
File path:
gora-dynamodb/src/main/java/org/apache/gora/dynamodb/store/DynamoDBStore.java
##
@@ -583,4 +583,9 @@ public AmazonDynamoDB getDynamoDBClient() {
public void setDynamoDBClient(AmazonDynamoDB dynamoDBClient) {
this.dynamoDBClient = dynamoDBClient;
}
+
+ @Override
+ public boolean exists(K key) throws GoraException {
+ return dynamoDbStore.exists(key);
Review comment:
Fix indentation of 2 spaces.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] djkevincr commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface
djkevincr commented on a change in pull request #156: GORA 411 - Add
exists(key) to DataStore interface
URL: https://github.com/apache/gora/pull/156#discussion_r271653309
##
File path:
gora-cassandra/src/main/java/org/apache/gora/cassandra/serializers/NativeSerializer.java
##
@@ -258,4 +259,25 @@ private K getKey(T object) {
}
return key;
}
+
+ @Override
+ public boolean exists(Object key) throws GoraException {
Review comment:
This is different from method signature
boolean exists(K key) throws GoraException
Is there a reason to use - Object key?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] djkevincr commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface
djkevincr commented on a change in pull request #156: GORA 411 - Add
exists(key) to DataStore interface
URL: https://github.com/apache/gora/pull/156#discussion_r271653309
##
File path:
gora-cassandra/src/main/java/org/apache/gora/cassandra/serializers/NativeSerializer.java
##
@@ -258,4 +259,25 @@ private K getKey(T object) {
}
return key;
}
+
+ @Override
+ public boolean exists(Object key) throws GoraException {
Review comment:
This is different from method signature
- boolean exists(K key) throws GoraException
Is there a reason to use - Object key?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] djkevincr commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface
djkevincr commented on a change in pull request #156: GORA 411 - Add
exists(key) to DataStore interface
URL: https://github.com/apache/gora/pull/156#discussion_r271626749
##
File path:
gora-infinispan/src/main/java/org/apache/gora/infinispan/store/InfinispanStore.java
##
@@ -179,6 +179,16 @@ public T get(K key) throws GoraException {
throw new GoraException(e);
}
}
+
+ @Override
+ public boolean exists(K key) throws GoraException {
+LOG.debug("exists("+key+")");
Review comment:
Please use parameterized logging in all cases, avoid using String
concatenation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] djkevincr commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface
djkevincr commented on a change in pull request #156: GORA 411 - Add
exists(key) to DataStore interface
URL: https://github.com/apache/gora/pull/156#discussion_r271628751
##
File path:
gora-dynamodb/src/main/java/org/apache/gora/dynamodb/store/DynamoDBNativeStore.java
##
@@ -542,4 +542,9 @@ private Object getRangeKeyFromObj(T obj) throws
IllegalArgumentException,
return rangeKey;
}
+ @Override
+ public boolean exists(K key) throws GoraException {
Review comment:
What is the reason overriding DataStoreBase.java exists(K key) here? You
have already defined a default behavior at DataStoreBase class.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] djkevincr commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface
djkevincr commented on a change in pull request #156: GORA 411 - Add
exists(key) to DataStore interface
URL: https://github.com/apache/gora/pull/156#discussion_r271654155
##
File path:
gora-cassandra/src/main/java/org/apache/gora/cassandra/serializers/CassandraQueryFactory.java
##
@@ -313,6 +313,24 @@ static String
getSelectObjectWithFieldsQuery(CassandraMapping mapping, String[]
String[] columnNames = getColumnNames(mapping, keyFields);
return processKeys(columnNames, select);
}
+
+ /**
+ * This method returns CQL Select query to check if a key exists.
+ * This method is used for Avro Serialization
+ * refer:
http://docs.datastax.com/en/cql/3.3/cql/cql_reference/cqlSelect.html
+ *
+ * @param mapping Cassandra Mapping {@link CassandraMapping}
+ * @param keyFields key fields
+ * @return CQL Query
+ */
+ static String getCheckExistsQuery(CassandraMapping mapping, List
keyFields) {
+Select select =
QueryBuilder.select().countAll().from(mapping.getKeySpace().getName(),
mapping.getCoreName());
+if (Boolean.parseBoolean(mapping.getProperty("allowFiltering"))) {
Review comment:
+1 to document this.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] jhnmora000 opened a new pull request #156: GORA 411 - Add exists(key) to DataStore interface
jhnmora000 opened a new pull request #156: GORA 411 - Add exists(key) to DataStore interface URL: https://github.com/apache/gora/pull/156 Adds a **exists(key)** method to the DataStores. - Custom implementations for all backends. - Two new tests for: operability and benchmark. Your feedback would be appreciated :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr merged pull request #154: GORA-560:Fix Java doc comments to stabalize the build
djkevincr merged pull request #154: GORA-560:Fix Java doc comments to stabalize the build URL: https://github.com/apache/gora/pull/154 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on issue #154: GORA-560:Fix Java doc comments to stabalize the build
djkevincr commented on issue #154: GORA-560:Fix Java doc comments to stabalize the build URL: https://github.com/apache/gora/pull/154#issuecomment-475975272 +1, mvn javadoc:aggregate build without any issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr edited a comment on issue #154: GORA-560:Fix Java doc comments to stabalize the build
djkevincr edited a comment on issue #154: GORA-560:Fix Java doc comments to stabalize the build URL: https://github.com/apache/gora/pull/154#issuecomment-475975148 ``` [INFO] Reactor Summary: [INFO] [INFO] Apache Gora SUCCESS [ 29.755 s] [INFO] Apache Gora :: Compiler SKIPPED [INFO] Apache Gora :: Compiler-CLI SKIPPED [INFO] Apache Gora :: Core SKIPPED [INFO] Apache Gora :: Pig . SKIPPED [INFO] Apache Gora :: Accumulo SKIPPED [INFO] Apache Gora :: HBase ... SKIPPED [INFO] Apache Gora :: Cassandra - CQL . SKIPPED [INFO] Apache Gora :: GoraCI .. SKIPPED [INFO] Apache Gora :: Infinispan .. SKIPPED [INFO] Apache Gora :: JCache .. SKIPPED [INFO] Apache Gora :: OrientDB SKIPPED [INFO] Apache Gora :: Lucene .. SKIPPED [INFO] Apache Gora :: Dynamodb SKIPPED [INFO] Apache Gora :: CouchDB . SKIPPED [INFO] Apache Gora :: Maven Plugin SKIPPED [INFO] Apache Gora :: MongoDB . SKIPPED [INFO] Apache Gora :: Solr SKIPPED [INFO] Apache Gora :: Aerospike ... SKIPPED [INFO] Apache Gora :: Ignite .. SKIPPED [INFO] Apache Gora :: Tutorial SKIPPED [INFO] Apache Gora :: Sources-Dist SKIPPED [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 30.506 s [INFO] Finished at: 2019-03-24T21:59:07+05:30 [INFO] Final Memory: 105M/1409M [INFO] ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on issue #154: GORA-560:Fix Java doc comments to stabalize the build
djkevincr commented on issue #154: GORA-560:Fix Java doc comments to stabalize the build URL: https://github.com/apache/gora/pull/154#issuecomment-475975148 `[INFO] Reactor Summary: [INFO] [INFO] Apache Gora SUCCESS [ 29.755 s] [INFO] Apache Gora :: Compiler SKIPPED [INFO] Apache Gora :: Compiler-CLI SKIPPED [INFO] Apache Gora :: Core SKIPPED [INFO] Apache Gora :: Pig . SKIPPED [INFO] Apache Gora :: Accumulo SKIPPED [INFO] Apache Gora :: HBase ... SKIPPED [INFO] Apache Gora :: Cassandra - CQL . SKIPPED [INFO] Apache Gora :: GoraCI .. SKIPPED [INFO] Apache Gora :: Infinispan .. SKIPPED [INFO] Apache Gora :: JCache .. SKIPPED [INFO] Apache Gora :: OrientDB SKIPPED [INFO] Apache Gora :: Lucene .. SKIPPED [INFO] Apache Gora :: Dynamodb SKIPPED [INFO] Apache Gora :: CouchDB . SKIPPED [INFO] Apache Gora :: Maven Plugin SKIPPED [INFO] Apache Gora :: MongoDB . SKIPPED [INFO] Apache Gora :: Solr SKIPPED [INFO] Apache Gora :: Aerospike ... SKIPPED [INFO] Apache Gora :: Ignite .. SKIPPED [INFO] Apache Gora :: Tutorial SKIPPED [INFO] Apache Gora :: Sources-Dist SKIPPED [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 30.506 s [INFO] Finished at: 2019-03-24T21:59:07+05:30 [INFO] Final Memory: 105M/1409M [INFO] ` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] madhawa-gunasekara opened a new pull request #155: GORA-545 Fix split size in infinispan store
madhawa-gunasekara opened a new pull request #155: GORA-545 Fix split size in infinispan store URL: https://github.com/apache/gora/pull/155 Hi @djkevincr, Can you review and merge this pull request This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on issue #154: GORA-560:Fix Java doc comments to stabalize the build
djkevincr commented on issue #154: GORA-560:Fix Java doc comments to stabalize the build URL: https://github.com/apache/gora/pull/154#issuecomment-475975355 This is great @madhawa-gunasekara , I have merged your PR. Thank you for the contribution. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] madhawa-gunasekara opened a new pull request #154: GORA-560:Fix Java doc comments to stabalize the build
madhawa-gunasekara opened a new pull request #154: GORA-560:Fix Java doc comments to stabalize the build URL: https://github.com/apache/gora/pull/154 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] madhawa-gunasekara commented on issue #154: GORA-560:Fix Java doc comments to stabalize the build
madhawa-gunasekara commented on issue #154: GORA-560:Fix Java doc comments to stabalize the build URL: https://github.com/apache/gora/pull/154#issuecomment-475957714 @djkevincr Can you review and merge this pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr merged pull request #155: GORA-545 Fix split size in infinispan store
djkevincr merged pull request #155: GORA-545 Fix split size in infinispan store URL: https://github.com/apache/gora/pull/155 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on issue #155: GORA-545 Fix split size in infinispan store
djkevincr commented on issue #155: GORA-545 Fix split size in infinispan store URL: https://github.com/apache/gora/pull/155#issuecomment-476077247 @madhawa-gunasekara Thank you for the contribution. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] alfonsonishikawa commented on issue #154: GORA-560:Fix Java doc comments to stabalize the build
alfonsonishikawa commented on issue #154: GORA-560:Fix Java doc comments to stabalize the build URL: https://github.com/apache/gora/pull/154#issuecomment-475987480 @madhawa-gunasekara So sorry for the javadoc bugs :( Thank you very much for fixing it! I will add to my own development procedures to execute `mvn javadoc:javadoc` before creating the pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on issue #153: GORA-554: Upgrade Solr dependency to latest
djkevincr commented on issue #153: GORA-554: Upgrade Solr dependency to latest URL: https://github.com/apache/gora/pull/153#issuecomment-475862398 @madhawa-gunasekara Updated the PR. Can you please have a look and merge the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480031983 +1 @cuent This look certainly great. @lewismc mentioned you may add Lucene store specific tests. ( in TestLuceneStore.java. ) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] lewismc commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
lewismc commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480168630 @cuent you can easily implement individual tests for the module and use the `@Override` convention to implement the specific keys you need. See [TestHBaseStore.java](https://github.com/apache/gora/blob/master/gora-hbase/src/test/java/org/apache/gora/hbase/store/TestHBaseStore.java) for more details. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480081077 I was trying to add that but it creates two examples, employees and website, which have string keys. How can I extend that for creating a key with a numerical type? I was looking for that but I didn't found. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480299253 Yes, I reviewed the `DataStoreTestBase`, but it creates a `employeeStore` and a `webPageStore` which both have String kes. So even if I override the method, Query will ask for a String. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] lewismc commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
lewismc commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480384094 So why don't you just create individual tests such as https://github.com/apache/gora/blob/master/gora-accumulo/src/test/java/org/apache/gora/accumulo/store/PartitionTest.java This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on a change in pull request #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
djkevincr commented on a change in pull request #158: GORA-555: Improve Lucene
query implementation with NumericRangeQuery
URL: https://github.com/apache/gora/pull/158#discussion_r272787031
##
File path:
gora-lucene/src/test/java/org/apache/gora/lucene/store/EmployeeInt.java
##
@@ -0,0 +1,356 @@
+/**
+ *Licensed to the Apache Software Foundation (ASF) under one
+ *or more contributor license agreements. See the NOTICE file
+ *distributed with this work for additional information
+ *regarding copyright ownership. The ASF licenses this file
+ *to you under the Apache License, Version 2.0 (the"
+ *License"); you may not use this file except in compliance
+ *with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *Unless required by applicable law or agreed to in writing, software
+ *distributed under the License is distributed on an "AS IS" BASIS,
+ *WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *See the License for the specific language governing permissions and
+ *limitations under the License.
+ */
+package org.apache.gora.lucene.store;
+
+public class EmployeeInt extends
org.apache.gora.persistency.impl.PersistentBase implements
org.apache.avro.specific.SpecificRecord, org.apache.gora.persistency.Persistent
{
Review comment:
Did you commit AVRO schema ( EmployeeInt.json ) for this EmployeeInt? Just
to make sure, always use GoraCompiler to convert EmployeeInt.json -->
EmployeeInt.Java.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480482576 @cuent Thanks for considering my suggestions over the discussion we had on ticket. Noticed you have added changes that needed for put method in order use native types opposed to converting to Strings. This is Awesome. Please address my comments, I will go ahead and locally test your PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on a change in pull request #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
djkevincr commented on a change in pull request #158: GORA-555: Improve Lucene
query implementation with NumericRangeQuery
URL: https://github.com/apache/gora/pull/158#discussion_r272787651
##
File path:
gora-lucene/src/main/java/org/apache/gora/lucene/store/LuceneStore.java
##
@@ -545,7 +546,17 @@ public void put(K key, T persistent) {
}
LOG.info("DOCUMENT: {}", doc);
try {
- doc.add(new StringField(mapping.getPrimaryKey(), key.toString(),
Store.YES));
+ if (key instanceof Integer) {
+doc.add(new IntPoint(mapping.getPrimaryKey(), ((Integer)
key).intValue()));
Review comment:
You could use auto unboxing - wrapper class to the primitive class
new IntPoint(mapping.getPrimaryKey(), ((Integer) key).intValue()) ===
new IntPoint(mapping.getPrimaryKey(), (Integer) key)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] djkevincr commented on a change in pull request #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
djkevincr commented on a change in pull request #158: GORA-555: Improve Lucene
query implementation with NumericRangeQuery
URL: https://github.com/apache/gora/pull/158#discussion_r272787885
##
File path:
gora-lucene/src/main/java/org/apache/gora/lucene/query/LuceneQuery.java
##
@@ -51,22 +57,41 @@ public Query toLuceneQuery() {
if (getKey() != null) {
q = new TermQuery(new Term(pk, getKey().toString()));
} else {
- //TODO: Change this to a NumericRangeQuery when necessary (it's faster)
- String lower = null;
- String upper = null;
- if (getStartKey() != null) {
-//Do we need to escape the term?
-lower = getStartKey().toString();
- }
- if (getEndKey() != null) {
-upper = getEndKey().toString();
- }
- if (upper == null && lower == null) {
-q = new MatchAllDocsQuery();
+ if (getEndKey() == null && getStartKey() == null) {
+return new MatchAllDocsQuery();
} else {
-q = TermRangeQuery.newStringRange(pk, lower, upper, true, true);
+q = inferType(pk, getStartKey(), getEndKey());
}
}
return q;
}
+
+ private Query inferType(String pk, T lower, T upper) {
+if (((lower != null && lower.getClass() == Integer.class)
+|| (upper != null && upper.getClass() == Integer.class))) {
+ int ilower = lower == null ? Integer.MIN_VALUE :
Integer.valueOf(lower.toString());
Review comment:
int ilower = lower == null ? Integer.MIN_VALUE :
Integer.valueOf(lower.toString());
If the value here is in Integer class ( lower.getClass() == Integer.class )
Is it necessary to convert to String and take the Integer value using
Integer.valueOf(lower.toString()) === (Integer) lower;
Above statement can be written as,
int ilower = lower == null ? Integer.MIN_VALUE : (Integer) lower;
This is the same for other cases in below for float, long, double.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] djkevincr commented on a change in pull request #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
djkevincr commented on a change in pull request #158: GORA-555: Improve Lucene
query implementation with NumericRangeQuery
URL: https://github.com/apache/gora/pull/158#discussion_r272787885
##
File path:
gora-lucene/src/main/java/org/apache/gora/lucene/query/LuceneQuery.java
##
@@ -51,22 +57,41 @@ public Query toLuceneQuery() {
if (getKey() != null) {
q = new TermQuery(new Term(pk, getKey().toString()));
} else {
- //TODO: Change this to a NumericRangeQuery when necessary (it's faster)
- String lower = null;
- String upper = null;
- if (getStartKey() != null) {
-//Do we need to escape the term?
-lower = getStartKey().toString();
- }
- if (getEndKey() != null) {
-upper = getEndKey().toString();
- }
- if (upper == null && lower == null) {
-q = new MatchAllDocsQuery();
+ if (getEndKey() == null && getStartKey() == null) {
+return new MatchAllDocsQuery();
} else {
-q = TermRangeQuery.newStringRange(pk, lower, upper, true, true);
+q = inferType(pk, getStartKey(), getEndKey());
}
}
return q;
}
+
+ private Query inferType(String pk, T lower, T upper) {
+if (((lower != null && lower.getClass() == Integer.class)
+|| (upper != null && upper.getClass() == Integer.class))) {
+ int ilower = lower == null ? Integer.MIN_VALUE :
Integer.valueOf(lower.toString());
Review comment:
int ilower = lower == null ? Integer.MIN_VALUE :
Integer.valueOf(lower.toString());
If the value here is in Integer class ( lower.getClass() == Integer.class )
Is it necessary to convert to String and take the Integer value using
Integer.valueOf(lower.toString()) ===
int ilower = lower == null ? Integer.MIN_VALUE : (Integer) lower;
This is the same for other cases in below for float, long, double.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480476838 I implemented the test. I also notice that in some places some keys are converted to `String` by default. I solved another issue by inferring the type while creating the document. It is working and passing all the tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on a change in pull request #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
djkevincr commented on a change in pull request #158: GORA-555: Improve Lucene
query implementation with NumericRangeQuery
URL: https://github.com/apache/gora/pull/158#discussion_r272787234
##
File path:
gora-lucene/src/test/java/org/apache/gora/lucene/store/TestLuceneStore.java
##
@@ -18,32 +18,40 @@
package org.apache.gora.lucene.store;
import org.apache.gora.examples.WebPageDataCreator;
+import static org.apache.gora.examples.WebPageDataCreator.SORTED_URLS;
+import static org.apache.gora.examples.WebPageDataCreator.URLS;
import org.apache.gora.examples.generated.WebPage;
import org.apache.gora.query.Query;
+import org.apache.gora.query.Result;
import org.apache.gora.store.DataStore;
import org.apache.gora.store.DataStoreTestBase;
+import static org.apache.gora.store.DataStoreTestBase.log;
import org.apache.gora.store.DataStoreTestUtil;
+import org.apache.gora.util.GoraException;
import org.apache.gora.util.OperationNotSupportedException;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNull;
+import org.junit.Before;
import org.junit.BeforeClass;
import org.junit.Ignore;
import org.junit.Test;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import static org.apache.gora.examples.WebPageDataCreator.SORTED_URLS;
-import static org.apache.gora.examples.WebPageDataCreator.URLS;
-
-import static org.junit.Assert.assertNotNull;
-import static org.junit.Assert.assertNull;
-import static org.junit.Assert.assertEquals;
-
-
/**
- * TestLuceneStore class executes tests for {@link
org.apache.gora.lucene.store.LuceneStore}
+ * TestLuceneStore class executes tests for
+ * {@link org.apache.gora.lucene.store.LuceneStore}
*/
public class TestLuceneStore extends DataStoreTestBase {
private static final Logger LOG =
LoggerFactory.getLogger(DataStoreTestUtil.class);
+ private DataStore employeeIntStore;
+
+ @Before
Review comment:
@Before - means this config() method is executed for each tests. Do we
really need that behavior? It is only required to be executed before -
testInferDataType() test case.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] djkevincr commented on a change in pull request #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
djkevincr commented on a change in pull request #158: GORA-555: Improve Lucene
query implementation with NumericRangeQuery
URL: https://github.com/apache/gora/pull/158#discussion_r272787990
##
File path:
gora-lucene/src/main/java/org/apache/gora/lucene/query/LuceneQuery.java
##
@@ -51,22 +57,41 @@ public Query toLuceneQuery() {
if (getKey() != null) {
q = new TermQuery(new Term(pk, getKey().toString()));
} else {
- //TODO: Change this to a NumericRangeQuery when necessary (it's faster)
- String lower = null;
- String upper = null;
- if (getStartKey() != null) {
-//Do we need to escape the term?
-lower = getStartKey().toString();
- }
- if (getEndKey() != null) {
-upper = getEndKey().toString();
- }
- if (upper == null && lower == null) {
-q = new MatchAllDocsQuery();
+ if (getEndKey() == null && getStartKey() == null) {
+return new MatchAllDocsQuery();
} else {
-q = TermRangeQuery.newStringRange(pk, lower, upper, true, true);
+q = inferType(pk, getStartKey(), getEndKey());
}
}
return q;
}
+
+ private Query inferType(String pk, T lower, T upper) {
Review comment:
Don't you think it s more readable when we use Key type - K directly here as
-
private Query inferType(String pk, K lower, K upper) {
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] jhnmora000 commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface
jhnmora000 commented on a change in pull request #156: GORA 411 - Add
exists(key) to DataStore interface
URL: https://github.com/apache/gora/pull/156#discussion_r272802075
##
File path:
gora-accumulo/src/main/java/org/apache/gora/accumulo/store/AccumuloStore.java
##
@@ -642,6 +642,20 @@ private void setFetchColumns(Scanner scanner, String[]
fields) {
}
}
}
+
+ @Override
+ public boolean exists(K key) throws GoraException {
+try {
+ // TODO make isolated scanner optional?
Review comment:
Sorry for that... I based the new method on get() and I copied accidentally
that comment.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] jhnmora000 commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface
jhnmora000 commented on a change in pull request #156: GORA 411 - Add
exists(key) to DataStore interface
URL: https://github.com/apache/gora/pull/156#discussion_r272802277
##
File path:
gora-cassandra/src/main/java/org/apache/gora/cassandra/serializers/CassandraQueryFactory.java
##
@@ -313,6 +313,24 @@ static String
getSelectObjectWithFieldsQuery(CassandraMapping mapping, String[]
String[] columnNames = getColumnNames(mapping, keyFields);
return processKeys(columnNames, select);
}
+
+ /**
+ * This method returns CQL Select query to check if a key exists.
+ * This method is used for Avro Serialization
+ * refer:
http://docs.datastax.com/en/cql/3.3/cql/cql_reference/cqlSelect.html
+ *
+ * @param mapping Cassandra Mapping {@link CassandraMapping}
+ * @param keyFields key fields
+ * @return CQL Query
+ */
+ static String getCheckExistsQuery(CassandraMapping mapping, List
keyFields) {
+Select select =
QueryBuilder.select().countAll().from(mapping.getKeySpace().getName(),
mapping.getCoreName());
+if (Boolean.parseBoolean(mapping.getProperty("allowFiltering"))) {
Review comment:
Please let me know where can I add the documentation
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480521014 @cuent Thank you for addressing my comments. Were you able add the EmployeeInt.json AVRO schema? This should be added to gora-core/src/examples/avro directory. You will see - employee.json You will have to rename the name and type for ssn. Please make sure you regenerate using the json file. This looks Awesome and ready to be merged :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr edited a comment on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
djkevincr edited a comment on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480521014 @cuent Thank you for addressing my comments. Were you able add the EmployeeInt.json AVRO schema? This should be added to gora-core/src/examples/avro directory. You will see - employee.json file. You will have to rename the name and type for ssn, the file should be added separately. Please make sure you regenerate using the json file. This looks Awesome and ready to be merged :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on a change in pull request #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
djkevincr commented on a change in pull request #158: GORA-555: Improve Lucene
query implementation with NumericRangeQuery
URL: https://github.com/apache/gora/pull/158#discussion_r272802460
##
File path:
gora-lucene/src/test/java/org/apache/gora/lucene/store/EmployeeInt.java
##
@@ -0,0 +1,356 @@
+/**
+ *Licensed to the Apache Software Foundation (ASF) under one
+ *or more contributor license agreements. See the NOTICE file
+ *distributed with this work for additional information
+ *regarding copyright ownership. The ASF licenses this file
+ *to you under the Apache License, Version 2.0 (the"
+ *License"); you may not use this file except in compliance
+ *with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *Unless required by applicable law or agreed to in writing, software
+ *distributed under the License is distributed on an "AS IS" BASIS,
+ *WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *See the License for the specific language governing permissions and
+ *limitations under the License.
+ */
+package org.apache.gora.lucene.store;
+
+public class EmployeeInt extends
org.apache.gora.persistency.impl.PersistentBase implements
org.apache.avro.specific.SpecificRecord, org.apache.gora.persistency.Persistent
{
Review comment:
Please add EmployeeInt.json file separately to gora-core module.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] jhnmora000 commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface
jhnmora000 commented on a change in pull request #156: GORA 411 - Add
exists(key) to DataStore interface
URL: https://github.com/apache/gora/pull/156#discussion_r272802625
##
File path:
gora-cassandra/src/main/java/org/apache/gora/cassandra/serializers/NativeSerializer.java
##
@@ -258,4 +259,25 @@ private K getKey(T object) {
}
return key;
}
+
+ @Override
+ public boolean exists(Object key) throws GoraException {
Review comment:
This method actually overrides CassandraSerializer - an intermediate
abstract class independent to DataStore and other methods (get, put) in this
classs also use Object instead of K , so I tried to stick to that.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] cuent commented on a change in pull request #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
cuent commented on a change in pull request #158: GORA-555: Improve Lucene
query implementation with NumericRangeQuery
URL: https://github.com/apache/gora/pull/158#discussion_r272804698
##
File path:
gora-lucene/src/test/java/org/apache/gora/lucene/store/EmployeeInt.java
##
@@ -0,0 +1,356 @@
+/**
+ *Licensed to the Apache Software Foundation (ASF) under one
+ *or more contributor license agreements. See the NOTICE file
+ *distributed with this work for additional information
+ *regarding copyright ownership. The ASF licenses this file
+ *to you under the Apache License, Version 2.0 (the"
+ *License"); you may not use this file except in compliance
+ *with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *Unless required by applicable law or agreed to in writing, software
+ *distributed under the License is distributed on an "AS IS" BASIS,
+ *WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *See the License for the specific language governing permissions and
+ *limitations under the License.
+ */
+package org.apache.gora.lucene.store;
+
+public class EmployeeInt extends
org.apache.gora.persistency.impl.PersistentBase implements
org.apache.avro.specific.SpecificRecord, org.apache.gora.persistency.Persistent
{
Review comment:
it was added, forgot to push the commit ๏
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480526888 I have approved the PR, will locally test and merge to the master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480527044 @lewismc Please raise if you do have any concerns. Otherwise will proceed to merge. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480512928 @djkevincr done! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] cuent opened a new pull request #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
cuent opened a new pull request #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158 Infer data type for building range queries. First, check if there is a numeric type if so cast to the appropriate type otherwise set to string datatype. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] lewismc commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
lewismc commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480010966 This looks good @cuent thank you for taking the issue on. Please augment your pull request with Unit tests. Thank you This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface
lewismc commented on a change in pull request #156: GORA 411 - Add exists(key)
to DataStore interface
URL: https://github.com/apache/gora/pull/156#discussion_r270284412
##
File path:
gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraStore.java
##
@@ -333,6 +333,11 @@ public boolean schemaExists() throws GoraException{
return cassandraSerializer.schemaExists();
}
+ @Override
+ public boolean exists(K key) throws GoraException {
+ return cassandraSerializer.exists(key);
Review comment:
Fix formatting.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface
lewismc commented on a change in pull request #156: GORA 411 - Add exists(key)
to DataStore interface
URL: https://github.com/apache/gora/pull/156#discussion_r270284458
##
File path: gora-core/src/test/java/org/apache/gora/store/DataStoreTestBase.java
##
@@ -214,6 +214,18 @@ public void testEmptyUpdate() throws Exception {
DataStoreTestUtil.testEmptyUpdateEmployee(employeeStore);
}
+ @Test
+ public void testExists() throws Exception {
+ log.info("test method: testExists");
Review comment:
Fix formatting.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface
lewismc commented on a change in pull request #156: GORA 411 - Add exists(key)
to DataStore interface
URL: https://github.com/apache/gora/pull/156#discussion_r270284519
##
File path: gora-core/src/test/java/org/apache/gora/store/DataStoreTestUtil.java
##
@@ -167,6 +168,49 @@ public static void testDeleteSchema(DataStore dataStore)
dataStore.deleteSchema();
assertFalse(dataStore.schemaExists());
}
+
+ public static void testExistsEmployee(DataStore
dataStore)
+ throws Exception {
+ dataStore.createSchema();
Review comment:
UUID
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface
lewismc commented on a change in pull request #156: GORA 411 - Add exists(key)
to DataStore interface
URL: https://github.com/apache/gora/pull/156#discussion_r270284492
##
File path: gora-core/src/test/java/org/apache/gora/store/DataStoreTestBase.java
##
@@ -214,6 +214,18 @@ public void testEmptyUpdate() throws Exception {
DataStoreTestUtil.testEmptyUpdateEmployee(employeeStore);
}
+ @Test
+ public void testExists() throws Exception {
+ log.info("test method: testExists");
+ DataStoreTestUtil.testExistsEmployee(employeeStore);
+ }
+
+ @Test
+ public void testBenchamarkExists() throws Exception {
+ log.info("test method: testBenchamarkExists");
Review comment:
Fix formatting.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface
lewismc commented on a change in pull request #156: GORA 411 - Add exists(key)
to DataStore interface
URL: https://github.com/apache/gora/pull/156#discussion_r270284368
##
File path:
gora-cassandra/src/main/java/org/apache/gora/cassandra/serializers/CassandraSerializer.java
##
@@ -179,6 +179,14 @@ public boolean schemaExists() throws GoraException {
* @return persistent value
*/
public abstract T get(K key) throws GoraException;
+
+ /**
Review comment:
Fix formatting.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface
lewismc commented on a change in pull request #156: GORA 411 - Add exists(key)
to DataStore interface
URL: https://github.com/apache/gora/pull/156#discussion_r270284398
##
File path:
gora-cassandra/src/main/java/org/apache/gora/cassandra/serializers/NativeSerializer.java
##
@@ -258,4 +259,25 @@ private K getKey(T object) {
}
return key;
}
+
+ @Override
+ public boolean exists(Object key) throws GoraException {
+ try {
+ ArrayList cassandraKeys = new ArrayList<>();
Review comment:
Fix formatting.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface
lewismc commented on a change in pull request #156: GORA 411 - Add exists(key)
to DataStore interface
URL: https://github.com/apache/gora/pull/156#discussion_r270284149
##
File path:
gora-aerospike/src/main/java/org/apache/gora/aerospike/store/AerospikeStore.java
##
@@ -185,6 +185,16 @@ public T get(K key, String[] fields) throws GoraException
{
throw new GoraException(e);
}
}
+
+ @Override
+ public boolean exists(K key) throws GoraException {
Review comment:
Fix formatting.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface
lewismc commented on a change in pull request #156: GORA 411 - Add exists(key)
to DataStore interface
URL: https://github.com/apache/gora/pull/156#discussion_r270284452
##
File path:
gora-core/src/main/java/org/apache/gora/store/impl/DataStoreBase.java
##
@@ -150,6 +150,11 @@ public void setBeanFactory(BeanFactory beanFactory)
{
return beanFactory;
}
+ @Override
+ public boolean exists(K key) throws GoraException {
+ return get(key, new String[0]) != null;
Review comment:
Fix formatting.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface
lewismc commented on a change in pull request #156: GORA 411 - Add exists(key)
to DataStore interface
URL: https://github.com/apache/gora/pull/156#discussion_r270284062
##
File path:
gora-accumulo/src/main/java/org/apache/gora/accumulo/store/AccumuloStore.java
##
@@ -642,6 +642,20 @@ private void setFetchColumns(Scanner scanner, String[]
fields) {
}
}
}
+
+ @Override
Review comment:
Please fix formatting
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface
lewismc commented on a change in pull request #156: GORA 411 - Add exists(key)
to DataStore interface
URL: https://github.com/apache/gora/pull/156#discussion_r270284428
##
File path: gora-core/src/main/java/org/apache/gora/memory/store/MemStore.java
##
@@ -195,6 +195,12 @@ public T get(K key, String[] fields) {
}
return getPersistent(obj, getFieldsToQuery(fields));
}
+
+ @SuppressWarnings("unchecked")
Review comment:
Fix formatting.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface
lewismc commented on a change in pull request #156: GORA 411 - Add exists(key)
to DataStore interface
URL: https://github.com/apache/gora/pull/156#discussion_r270284347
##
File path:
gora-cassandra/src/main/java/org/apache/gora/cassandra/serializers/CassandraQueryFactory.java
##
@@ -313,6 +313,24 @@ static String
getSelectObjectWithFieldsQuery(CassandraMapping mapping, String[]
String[] columnNames = getColumnNames(mapping, keyFields);
return processKeys(columnNames, select);
}
+
+ /**
+ * This method returns CQL Select query to check if a key exists.
+ * This method is used for Avro Serialization
+ * refer:
http://docs.datastax.com/en/cql/3.3/cql/cql_reference/cqlSelect.html
+ *
+ * @param mapping Cassandra Mapping {@link CassandraMapping}
+ * @param keyFields key fields
+ * @return CQL Query
+ */
+ static String getCheckExistsQuery(CassandraMapping mapping, List
keyFields) {
+Select select =
QueryBuilder.select().countAll().from(mapping.getKeySpace().getName(),
mapping.getCoreName());
+if (Boolean.parseBoolean(mapping.getProperty("allowFiltering"))) {
Review comment:
We need some example showing this or maybe for documentation somewhere to
reflect this otherwise no-one is going to know it exists.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface
lewismc commented on a change in pull request #156: GORA 411 - Add exists(key)
to DataStore interface
URL: https://github.com/apache/gora/pull/156#discussion_r270284126
##
File path:
gora-accumulo/src/main/java/org/apache/gora/accumulo/store/AccumuloStore.java
##
@@ -642,6 +642,20 @@ private void setFetchColumns(Scanner scanner, String[]
fields) {
}
}
}
+
+ @Override
+ public boolean exists(K key) throws GoraException {
+try {
+ // TODO make isolated scanner optional?
Review comment:
Are you suggesting to drive this from configuration or via the API?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface
lewismc commented on a change in pull request #156: GORA 411 - Add exists(key)
to DataStore interface
URL: https://github.com/apache/gora/pull/156#discussion_r270284172
##
File path:
gora-cassandra/src/main/java/org/apache/gora/cassandra/serializers/AvroSerializer.java
##
@@ -466,4 +466,25 @@ public Result execute(DataStore dataStore, Query query)
throws GoraException {
}
}
+ @Override
+ public boolean exists(Object key) throws GoraException {
+ try {
Review comment:
Fix formatting.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] djkevincr commented on issue #140: GORA-548 Apache Flink support for Gora
djkevincr commented on issue #140: GORA-548 Apache Flink support for Gora URL: https://github.com/apache/gora/pull/140#issuecomment-478509012 I will monitor over this @lewismc, I sometime notice this intermittent failures with HBase. I will address that separately. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr merged pull request #140: GORA-548 Apache Flink support for Gora
djkevincr merged pull request #140: GORA-548 Apache Flink support for Gora URL: https://github.com/apache/gora/pull/140 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on issue #140: GORA-548 Apache Flink support for Gora
djkevincr commented on issue #140: GORA-548 Apache Flink support for Gora URL: https://github.com/apache/gora/pull/140#issuecomment-478415577 Test passes without any issue in my machine locally for HBase, I will have a another look. [INFO] --- [INFO] T E S T S [INFO] --- [INFO] Running org.apache.gora.hbase.util.TestHBaseByteInterface [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.851 s - in org.apache.gora.hbase.util.TestHBaseByteInterface [INFO] Running org.apache.gora.hbase.mapreduce.TestHBaseStoreWordCount Formatting using clusterid: testClusterID [WARNING] Tests run: 3, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 62.243 s - in org.apache.gora.hbase.mapreduce.TestHBaseStoreWordCount java.lang.ThreadGroup[name=PEWorkerGroup,maxpri=10] Thread[IPC Client (1234715829) connection to localhost/127.0.0.1:41613 from djkevincr,5,PEWorkerGroup] [INFO] Running org.apache.gora.hbase.mapreduce.TestHBaseStoreMapReduceSerialization Formatting using clusterid: testClusterID [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 18.424 s - in org.apache.gora.hbase.mapreduce.TestHBaseStoreMapReduceSerialization [INFO] Running org.apache.gora.hbase.mapreduce.TestHBaseStoreCountQuery Formatting using clusterid: testClusterID [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.039 s - in org.apache.gora.hbase.mapreduce.TestHBaseStoreCountQuery [INFO] Running org.apache.gora.hbase.store.TestHBaseStore Formatting using clusterid: testClusterID [WARNING] Tests run: 46, Failures: 0, Errors: 0, Skipped: 3, Time elapsed: 121.957 s - in org.apache.gora.hbase.store.TestHBaseStore [INFO] [INFO] Results: [INFO] [WARNING] Tests run: 53, Failures: 0, Errors: 0, Skipped: 4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr merged pull request #157: GORA-549: Remove PersistentBase extending java.io.Externalizable
djkevincr merged pull request #157: GORA-549: Remove PersistentBase extending java.io.Externalizable URL: https://github.com/apache/gora/pull/157 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr opened a new pull request #160: GORA-611: Fix intermittent test failures with HBase module
djkevincr opened a new pull request #160: GORA-611: Fix intermittent test failures with HBase module URL: https://github.com/apache/gora/pull/160 Fix various issues such as resource closing, auto flush etc. https://issues.apache.org/jira/browse/HBASE-2256 - main concern here is sometime back we addressed this issue, by differentiating timestamp values for HBase put/delete in put (K key, V value). However it seems, sometimes this fails intermittently. I have used atomic row update - RowMutations instead of buffered mutator and the tests seems to passing solidly. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr merged pull request #159: GORA-564: Remove deprecated method usages of HBase module after upgrading to 2
djkevincr merged pull request #159: GORA-564: Remove deprecated method usages of HBase module after upgrading to 2 URL: https://github.com/apache/gora/pull/159 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] jhnmora000 commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface
jhnmora000 commented on a change in pull request #156: GORA 411 - Add
exists(key) to DataStore interface
URL: https://github.com/apache/gora/pull/156#discussion_r272807465
##
File path:
gora-core/src/main/java/org/apache/gora/store/impl/DataStoreBase.java
##
@@ -150,6 +150,11 @@ public void setBeanFactory(BeanFactory beanFactory)
{
return beanFactory;
}
+ @Override
+ public boolean exists(K key) throws GoraException {
+ return get(key, new String[0]) != null;
Review comment:
As discussed on Jira[1] it would be better to not implement a default
behavior for exists(), since future developers could ignore to code custom
solutions and led to performance issues. I will remove this.
[1] https://issues.apache.org/jira/browse/GORA-411
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] jhnmora000 commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface
jhnmora000 commented on a change in pull request #156: GORA 411 - Add
exists(key) to DataStore interface
URL: https://github.com/apache/gora/pull/156#discussion_r272807723
##
File path:
gora-dynamodb/src/main/java/org/apache/gora/dynamodb/store/DynamoDBNativeStore.java
##
@@ -542,4 +542,9 @@ private Object getRangeKeyFromObj(T obj) throws
IllegalArgumentException,
return rangeKey;
}
+ @Override
+ public boolean exists(K key) throws GoraException {
Review comment:
DynamoDBNativeStore extends to WSDataStoreBase which implements the
DataStore interface. And the default behavior is coded in the DataStoreBase
class, so the default is not inherited and should be added.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] madhawa-gunasekara commented on issue #153: GORA-554: Upgrade Solr dependency to latest
madhawa-gunasekara commented on issue #153: GORA-554: Upgrade Solr dependency to latest URL: https://github.com/apache/gora/pull/153#issuecomment-475914648 I tested locally, all good. ``` [INFO] [INFO] Results: [INFO] [INFO] Tests run: 82, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] [INFO] --- maven-bundle-plugin:2.5.3:bundle (default-bundle) @ gora-solr --- [INFO] [INFO] --- maven-site-plugin:3.7.1:attach-descriptor (attach-descriptor) @ gora-solr --- [INFO] Skipping because packaging 'bundle' is not pom. [INFO] [INFO] --- maven-dependency-plugin:2.9:copy-dependencies (copy) @ gora-solr --- [INFO] Installing /home/madhawa/gora/sources-dist/target/apache-gora-0.9-SNAPSHOT-src.tar.gz to /home/madhawa/.m2/repository/org/apache/gora/sources-dist/0.9-SNAPSHOT/sources-dist-0.9-SNAPSHOT-src.tar.gz [INFO] Installing /home/madhawa/gora/sources-dist/target/apache-gora-0.9-SNAPSHOT-src.zip to /home/madhawa/.m2/repository/org/apache/gora/sources-dist/0.9-SNAPSHOT/sources-dist-0.9-SNAPSHOT-src.zip [INFO] [INFO] Reactor Summary for Apache Gora 0.9-SNAPSHOT: [INFO] [INFO] Apache Gora SUCCESS [04:08 min] [INFO] Apache Gora :: Compiler SUCCESS [ 38.032 s] [INFO] Apache Gora :: Compiler-CLI SUCCESS [ 1.538 s] [INFO] Apache Gora :: Core SUCCESS [05:33 min] [INFO] Apache Gora :: Pig . SUCCESS [ 36.047 s] [INFO] Apache Gora :: Accumulo SUCCESS [16:37 min] [INFO] Apache Gora :: HBase ... SUCCESS [05:15 min] [INFO] Apache Gora :: Cassandra - CQL . SUCCESS [06:24 min] [INFO] Apache Gora :: GoraCI .. SUCCESS [ 30.014 s] [INFO] Apache Gora :: Infinispan .. SUCCESS [02:24 min] [INFO] Apache Gora :: JCache .. SUCCESS [01:29 min] [INFO] Apache Gora :: OrientDB SUCCESS [02:04 min] [INFO] Apache Gora :: Lucene .. SUCCESS [01:28 min] [INFO] Apache Gora :: Dynamodb SUCCESS [ 49.611 s] [INFO] Apache Gora :: CouchDB . SUCCESS [ 41.710 s] [INFO] Apache Gora :: Maven Plugin SUCCESS [ 19.499 s] [INFO] Apache Gora :: MongoDB . SUCCESS [06:55 min] [INFO] Apache Gora :: Solr SUCCESS [08:48 min] [INFO] Apache Gora :: Aerospike ... SUCCESS [ 9.409 s] [INFO] Apache Gora :: Ignite .. SUCCESS [01:25 min] [INFO] Apache Gora :: Tutorial SUCCESS [ 27.670 s] [INFO] Apache Gora :: Sources-Dist SUCCESS [ 4.935 s] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 01:07 h [INFO] Finished at: 2019-03-24T02:40:21+05:30 [INFO] ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] carlosrmng commented on issue #156: GORA 411 - Add exists(key) to DataStore interface
carlosrmng commented on issue #156: GORA 411 - Add exists(key) to DataStore interface URL: https://github.com/apache/gora/pull/156#issuecomment-476932498 Nice work @jhnmora000 . The implementation for the Ignite Datastore looks good in my opinion. But, I would suggest you to use two-space tab indentation and format your code. Thanks for your contribution. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr merged pull request #153: GORA-554: Upgrade Solr dependency to latest
djkevincr merged pull request #153: GORA-554: Upgrade Solr dependency to latest URL: https://github.com/apache/gora/pull/153 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] djkevincr opened a new pull request #151: Update developer role information
djkevincr opened a new pull request #151: Update developer role information URL: https://github.com/apache/gora/pull/151 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] djkevincr merged pull request #151: Update developer role information
djkevincr merged pull request #151: Update developer role information URL: https://github.com/apache/gora/pull/151 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes
alfonsonishikawa commented on a change in pull request #135: Goraexplorer
needed changes
URL: https://github.com/apache/gora/pull/135#discussion_r266249623
##
File path: gora-core/src/main/java/org/apache/gora/store/DataStoreFactory.java
##
@@ -412,7 +484,7 @@ public static String getMappingFile(Properties properties,
DataStore store
return mappingFilename;
}
- private static String getDefaultDataStore(Properties properties) {
+ public static String getDefaultDataStore(Properties properties) {
Review comment:
Sadly the MetadataAnalyzer (to retrieve native information from the backend)
depends on the name of the DataStore.
I acknowledge I went into a rush about implementing the feature, so any
suggestions about are welcomed :)
I see you found out why by yourself!
(https://github.com/apache/gora/pull/135/files/2974126a934bddc526830182b402767c0f1eefd0?file-filters%5B%5D=.java=true#diff-d9701987f6844457a897d30a5786e5a4)
:D
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes
alfonsonishikawa commented on a change in pull request #135: Goraexplorer
needed changes
URL: https://github.com/apache/gora/pull/135#discussion_r222506186
##
File path:
gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm
##
@@ -180,6 +180,11 @@ public class ${this.mangle($schema.getName())}#if
($schema.isError()) extends or
return new #if
($schema.getNamespace())$schema.getNamespace().#end${this.mangle($schema.getName())}.Builder(other);
}
+ @Override
Review comment:
A clone method. I used it
[here](https://bitbucket.org/alfonsonishikawa/goraexplorer/src/12f226408e7f9686aa6b5975692edf270b94182e/src/main/java/com/nishilua/goraexplorer/tables/TableEntityServiceImpl.java#lines-121)
because `get()` reuses the instance.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes
alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#discussion_r266256014 ## File path: gora-core/src/examples/java/org/apache/gora/examples/generated/package-info.java ## @@ -1,20 +0,0 @@ -/** Review comment: Now the package-info.java files are moved to the parent directory temporarily at `compile-examples.sh` before deleting the generated classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes
alfonsonishikawa commented on a change in pull request #135: Goraexplorer
needed changes
URL: https://github.com/apache/gora/pull/135#discussion_r266256105
##
File path: gora-pig/src/test/examples/example.pig
##
@@ -0,0 +1,4 @@
+set job.name 'GoraStorage test' ;
+register gora/*.jar ;
+webpage = LOAD '.' using
org.apache.gora.pig.GoraStorage('java.lang.String','admin.WebPage','baseUrl,status,content')
;
+dump webpage;
Review comment:
Deleted `webpage.jar` and updated README.md to describe the steps to execute
an example.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes
alfonsonishikawa commented on a change in pull request #135: Goraexplorer
needed changes
URL: https://github.com/apache/gora/pull/135#discussion_r266255944
##
File path: conf/log4j.properties
##
@@ -24,7 +24,7 @@ log4j.threshhold=ALL
log4j.rootLogger=${gora.root.logger}
#special logging requirements for some commandline tools
-log4j.logger.org.apache.gora.compiler.GoraCompiler=INFO,console
+log4j.logger.org.apache.gora.compiler.GoraCompiler=INFO
Review comment:
Logs in console about compiled files appeared twice because the root,logger
is already configured to log to console.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes
alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#discussion_r266256724 ## File path: gora-pig/src/test/examples/README.md ## @@ -0,0 +1,46 @@ + Review comment: The Gora-Pig example README.txt renamed to README.md and updated to include steps. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] lewismc commented on issue #152: GORA-266 Lucene datastore for Gora - lewismc
lewismc commented on issue #152: GORA-266 Lucene datastore for Gora - lewismc URL: https://github.com/apache/gora/pull/152#issuecomment-473757077 I think this looks good. The only suggestion I have right now is to expand support for other `keyClass` implementations in LuceneQuery. There is currently a comment for NumericRangeQuery... maybe we can address this in a future pull request? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr edited a comment on issue #135: Goraexplorer needed changes
djkevincr edited a comment on issue #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#issuecomment-472522370 @alfonsonishikawa Are you done with updating PR as per the reviews? Is there anything else that we should address or do you need further time on this? Its awesome if we can get to the release coming shortly. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on issue #135: Goraexplorer needed changes
djkevincr commented on issue #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#issuecomment-472522370 @alfonsonishikawa Are you done with updating PR as per the reviews? Is there anything else that we should address or do you need further time on this? Its awesome if we can get to the release coming shortly? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr edited a comment on issue #131: GORA-266 Lucene datastore for Gora
djkevincr edited a comment on issue #131: GORA-266 Lucene datastore for Gora URL: https://github.com/apache/gora/pull/131#issuecomment-472522958 @lewismc Are you happy with this PR or is there anything else that we should address or Do you need further time on this? Its awesome if we can get to the release coming shortly :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on issue #131: GORA-266 Lucene datastore for Gora
djkevincr commented on issue #131: GORA-266 Lucene datastore for Gora URL: https://github.com/apache/gora/pull/131#issuecomment-472522958 @lewismc Are you happy with this PR or is there anything else that we should address or do you need further time on this? Its awesome if we can get to the release coming shortly. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr edited a comment on issue #131: GORA-266 Lucene datastore for Gora
djkevincr edited a comment on issue #131: GORA-266 Lucene datastore for Gora URL: https://github.com/apache/gora/pull/131#issuecomment-472522958 @lewismc Are you happy with this PR or Is there anything else that we should address? Its awesome if we can get this to the release coming shortly :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr edited a comment on issue #135: Goraexplorer needed changes
djkevincr edited a comment on issue #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#issuecomment-472522370 @alfonsonishikawa Are you done with updating PR as per the reviews? Is there anything else that we should address or Do you need further time on this? Its awesome if we can get this to the release coming shortly. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] lewismc commented on issue #131: GORA-266 Lucene datastore for Gora
lewismc commented on issue #131: GORA-266 Lucene datastore for Gora URL: https://github.com/apache/gora/pull/131#issuecomment-472565167 I don't have time to go back right now and code this implementation. I would suggest the following * upgrade Lucene and fix any deprecated API usage * fix the conflicts * implement tests if they have no already be done. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr edited a comment on issue #131: GORA-266 Lucene datastore for Gora
djkevincr edited a comment on issue #131: GORA-266 Lucene datastore for Gora URL: https://github.com/apache/gora/pull/131#issuecomment-472566647 @lewismc Thanks for the input Lewis, I will have look and take over this :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on issue #131: GORA-266 Lucene datastore for Gora
djkevincr commented on issue #131: GORA-266 Lucene datastore for Gora URL: https://github.com/apache/gora/pull/131#issuecomment-472566647 @lewismc Thanks for the input Lewis, I will have look and take over this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on issue #152: GORA-266 Lucene datastore for Gora - lewismc
djkevincr commented on issue #152: GORA-266 Lucene datastore for Gora - lewismc URL: https://github.com/apache/gora/pull/152#issuecomment-473925982 @lewismc I have created issue [1] on NumericRangeQuery. I think this PR is in good shape to be merged. All major test cases passes without any issue. [1] https://issues.apache.org/jira/browse/GORA-555 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr closed pull request #131: GORA-266 Lucene datastore for Gora
djkevincr closed pull request #131: GORA-266 Lucene datastore for Gora URL: https://github.com/apache/gora/pull/131 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr edited a comment on issue #152: GORA-266 Lucene datastore for Gora - lewismc
djkevincr edited a comment on issue #152: GORA-266 Lucene datastore for Gora - lewismc URL: https://github.com/apache/gora/pull/152#issuecomment-473925982 @lewismc I have created issue [1] on NumericRangeQuery. Let s address this separately. I think this PR is in good shape to be merged. All major test cases passes without any issue. [1] https://issues.apache.org/jira/browse/GORA-555 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on issue #131: GORA-266 Lucene datastore for Gora
djkevincr commented on issue #131: GORA-266 Lucene datastore for Gora URL: https://github.com/apache/gora/pull/131#issuecomment-473918146 Closing this PR after submitting more update version of the same work in https://github.com/apache/gora/pull/152 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on a change in pull request #135: Goraexplorer needed changes
djkevincr commented on a change in pull request #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#discussion_r266567600 ## File path: gora-pig/src/test/java/org/apache/gora/pig/GoraStorageTest.java-disabled ## @@ -0,0 +1,352 @@ +package org.apache.gora.pig; Review comment: Were you able to try the same with HBase 2 upgrade? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on issue #135: Goraexplorer needed changes
djkevincr commented on issue #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#issuecomment-474034153 @alfonsonishikawa One concern I do have is, I noticed record.vm velocity template changes, hopefully I think you have regenerated all the AVRO databean classes again to avoid any inconsistent updates, due to multiple updates to velocity template. This is really great :) as first step. We can continue this work, with the improvements you suggested to me offline. @lewismc Do you have any concern over your review on this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on issue #135: Goraexplorer needed changes
djkevincr commented on issue #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#issuecomment-474029378 Locally tested the PR, build passes without any test failures. [INFO] [INFO] Reactor Summary: [INFO] [INFO] Apache Gora SUCCESS [ 2.381 s] [INFO] Apache Gora :: Compiler SUCCESS [ 3.077 s] [INFO] Apache Gora :: Compiler-CLI SUCCESS [ 1.385 s] [INFO] Apache Gora :: Core SUCCESS [01:56 min] [INFO] Apache Gora :: Pig . SUCCESS [ 3.235 s] [INFO] Apache Gora :: Accumulo SUCCESS [08:07 min] [INFO] Apache Gora :: HBase ... SUCCESS [03:24 min] [INFO] Apache Gora :: Cassandra - CQL . SUCCESS [01:53 min] [INFO] Apache Gora :: GoraCI .. SUCCESS [ 3.998 s] [INFO] Apache Gora :: Infinispan .. SUCCESS [01:22 min] [INFO] Apache Gora :: JCache .. SUCCESS [01:21 min] [INFO] Apache Gora :: OrientDB SUCCESS [01:48 min] [INFO] Apache Gora :: Dynamodb SUCCESS [ 4.441 s] [INFO] Apache Gora :: CouchDB . SUCCESS [ 4.872 s] [INFO] Apache Gora :: Maven Plugin SUCCESS [ 3.021 s] [INFO] Apache Gora :: MongoDB . SUCCESS [02:04 min] [INFO] Apache Gora :: Solr SUCCESS [02:59 min] [INFO] Apache Gora :: Aerospike ... SUCCESS [ 2.849 s] [INFO] Apache Gora :: Ignite .. SUCCESS [02:56 min] [INFO] Apache Gora :: Tutorial SUCCESS [ 6.486 s] [INFO] Apache Gora :: Sources-Dist SUCCESS [ 0.364 s] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 28:32 min [INFO] Finished at: 2019-03-18T23:14:41+05:30 [INFO] Final Memory: 101M/1679M [INFO] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on issue #152: GORA-266 Lucene datastore for Gora - lewismc
djkevincr commented on issue #152: GORA-266 Lucene datastore for Gora - lewismc URL: https://github.com/apache/gora/pull/152#issuecomment-474608512 @lewismc I have merged the PR. Thank you very much for your hard work on implementation and reviewing PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] alfonsonishikawa commented on issue #135: Goraexplorer needed changes
alfonsonishikawa commented on issue #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#issuecomment-474603882 Oh! Thank you for the pull! I was working on the Gora-Pig tests as @djkevincr suggested. I will continue working on them anyway but will open a Jira issue. Thank you both for the reviews! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on issue #135: Goraexplorer needed changes
djkevincr commented on issue #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#issuecomment-474603912 @alfonsonishikawa I have merged you PR, thank you very much for your hard work on this :) I went through your design documents and all looked very impressive. It s really nice to see Apache Pig integrated to our project. Let's continue this work :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr merged pull request #152: GORA-266 Lucene datastore for Gora - lewismc
djkevincr merged pull request #152: GORA-266 Lucene datastore for Gora - lewismc URL: https://github.com/apache/gora/pull/152 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
