[jira] [Commented] (GORA-715) Gora uses a version of org.json:json jar that is not permitted by ASF
[ https://issues.apache.org/jira/browse/GORA-715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820052#comment-17820052 ] ASF GitHub Bot commented on GORA-715: - pjfanning opened a new pull request, #293: URL: https://github.com/apache/gora/pull/293 https://issues.apache.org/jira/browse/GORA-715 > Gora uses a version of org.json:json jar that is not permitted by ASF > - > > Key: GORA-715 > URL: https://issues.apache.org/jira/browse/GORA-715 > Project: Apache Gora > Issue Type: Bug >Reporter: PJ Fanning >Priority: Major > > Up until late 2022, org.json:json used a nonsensical license that banned the > use of the jar for evil - no kidding. This is not within OSS principles and > is called out as a Category X license by the ASF. > See https://www.apache.org/legal/resolved.html - see `JSON license` part. > There are also security fixes in the public domain and permissable versions > released in the last year or 2. > https://github.com/apache/gora/blob/master/pom.xml#L864 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-698) Add GEODE Support
[ https://issues.apache.org/jira/browse/GORA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805532#comment-17805532 ] ASF GitHub Bot commented on GORA-698: - djkevincr merged PR #292: URL: https://github.com/apache/gora/pull/292 > Add GEODE Support > - > > Key: GORA-698 > URL: https://issues.apache.org/jira/browse/GORA-698 > Project: Apache Gora > Issue Type: New Feature >Reporter: Himanshu >Priority: Major > > [1]https://geode.apache.org/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-537) Upgrade to Hadoop 3.X
[ https://issues.apache.org/jira/browse/GORA-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805530#comment-17805530 ] ASF GitHub Bot commented on GORA-537: - djkevincr closed pull request #220: GORA-537: [WIP] Upgrade to Hadoop 3.X URL: https://github.com/apache/gora/pull/220 > Upgrade to Hadoop 3.X > - > > Key: GORA-537 > URL: https://issues.apache.org/jira/browse/GORA-537 > Project: Apache Gora > Issue Type: Improvement > Components: build process >Reporter: Lewis John McGibbney >Priority: Major > Fix For: 1.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Hadoop 3 has been out for some time, we should consider upgrading. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-537) Upgrade to Hadoop 3.X
[ https://issues.apache.org/jira/browse/GORA-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805529#comment-17805529 ] ASF GitHub Bot commented on GORA-537: - djkevincr commented on PR #220: URL: https://github.com/apache/gora/pull/220#issuecomment-1886951055 @balashashanka I am closing this PR for now. We need migrate code base due API changes from 2x to 3x. Feel free to open the PR again if you would like to work on it. > Upgrade to Hadoop 3.X > - > > Key: GORA-537 > URL: https://issues.apache.org/jira/browse/GORA-537 > Project: Apache Gora > Issue Type: Improvement > Components: build process >Reporter: Lewis John McGibbney >Priority: Major > Fix For: 1.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Hadoop 3 has been out for some time, we should consider upgrading. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-650) Add datastore for ArangoDB
[ https://issues.apache.org/jira/browse/GORA-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805525#comment-17805525 ] ASF GitHub Bot commented on GORA-650: - djkevincr commented on PR #218: URL: https://github.com/apache/gora/pull/218#issuecomment-1886947772 This work is redundant and superseded by work here. [1] Hence closing the ticket. [1] https://github.com/apache/gora/pull/291 > Add datastore for ArangoDB > -- > > Key: GORA-650 > URL: https://issues.apache.org/jira/browse/GORA-650 > Project: Apache Gora > Issue Type: New Feature >Affects Versions: 0.9 >Reporter: Kevin Ratnasekera >Assignee: Chaminda Neluka >Priority: Major > Labels: gsoc2020 > Fix For: 1.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > May be we should consider extending our multimodal datastore support with > ArangoDB. [1] > [1] https://www.arangodb.com/why-arangodb/multi-model/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-650) Add datastore for ArangoDB
[ https://issues.apache.org/jira/browse/GORA-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805526#comment-17805526 ] ASF GitHub Bot commented on GORA-650: - djkevincr closed pull request #218: [GORA-650] [WIP] Add initial ArangoDB datastore URL: https://github.com/apache/gora/pull/218 > Add datastore for ArangoDB > -- > > Key: GORA-650 > URL: https://issues.apache.org/jira/browse/GORA-650 > Project: Apache Gora > Issue Type: New Feature >Affects Versions: 0.9 >Reporter: Kevin Ratnasekera >Assignee: Chaminda Neluka >Priority: Major > Labels: gsoc2020 > Fix For: 1.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > May be we should consider extending our multimodal datastore support with > ArangoDB. [1] > [1] https://www.arangodb.com/why-arangodb/multi-model/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-698) Add GEODE Support
[ https://issues.apache.org/jira/browse/GORA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805517#comment-17805517 ] ASF GitHub Bot commented on GORA-698: - djkevincr opened a new pull request, #292: URL: https://github.com/apache/gora/pull/292 Reverts apache/gora#273 > Add GEODE Support > - > > Key: GORA-698 > URL: https://issues.apache.org/jira/browse/GORA-698 > Project: Apache Gora > Issue Type: New Feature >Reporter: Himanshu >Priority: Major > > [1]https://geode.apache.org/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-650) Add datastore for ArangoDB
[ https://issues.apache.org/jira/browse/GORA-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17757729#comment-17757729 ] ASF GitHub Bot commented on GORA-650: - chaminda-neluka opened a new pull request, #291: URL: https://github.com/apache/gora/pull/291 (no comment) > Add datastore for ArangoDB > -- > > Key: GORA-650 > URL: https://issues.apache.org/jira/browse/GORA-650 > Project: Apache Gora > Issue Type: New Feature >Affects Versions: 0.9 >Reporter: Kevin Ratnasekera >Priority: Major > Labels: gsoc2020 > Time Spent: 0.5h > Remaining Estimate: 0h > > May be we should consider extending our multimodal datastore support with > ArangoDB. [1] > [1] https://www.arangodb.com/why-arangodb/multi-model/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-714) FTBFS: Conjars.org repository is dead
[
https://issues.apache.org/jira/browse/GORA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755047#comment-17755047
]
ASF GitHub Bot commented on GORA-714:
-
drazzib merged PR #290:
URL: https://github.com/apache/gora/pull/290
> FTBFS: Conjars.org repository is dead
> -
>
> Key: GORA-714
> URL: https://issues.apache.org/jira/browse/GORA-714
> Project: Apache Gora
> Issue Type: Bug
> Components: maven
>Affects Versions: 1.0
>Reporter: Damien Raude-Morvan
>Assignee: Damien Raude-Morvan
>Priority: Major
>
> AFAICT, the maven repository previously at conjars.org has been removed (see
> [1])
> Since Apache Gora {{pom.xml}} reference this repo, it currently fails to
> builds from source
> {code:java}
>
> conjars
> https://conjars.org/repo
>
> {code}
> {quote}This repos has been added with the following commit
> [https://github.com/apache/gora/commit/22d3af831dbd279151a55f610a747859fc20c74e]
> {quote}
> h5. Proposed change
> It seems we don't have *direct usage* for any conjars related, I will try to
> track we have added this repository and suggest to remove this reference.
> h5. Reference informations
> * [1] [https://groups.google.com/g/cascading-user/c/qAQvajapawI]
> * [2] [https://conjars.wensel.net/]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (GORA-714) FTBFS: Conjars.org repository is dead
[
https://issues.apache.org/jira/browse/GORA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17754575#comment-17754575
]
ASF GitHub Bot commented on GORA-714:
-
drazzib opened a new pull request, #290:
URL: https://github.com/apache/gora/pull/290
(no comment)
> FTBFS: Conjars.org repository is dead
> -
>
> Key: GORA-714
> URL: https://issues.apache.org/jira/browse/GORA-714
> Project: Apache Gora
> Issue Type: Bug
> Components: maven
>Affects Versions: 1.0
>Reporter: Damien Raude-Morvan
>Assignee: Damien Raude-Morvan
>Priority: Major
>
> AFAICT, the maven repository previously at conjars.org has been removed (see
> [1])
> Since Apache Gora {{pom.xml}} reference this repo, it currently fails to
> builds from source
> {code:java}
>
> conjars
> https://conjars.org/repo
>
> {code}
> {quote}This repos has been added with the following commit
> [https://github.com/apache/gora/commit/22d3af831dbd279151a55f610a747859fc20c74e]
> {quote}
> h5. Proposed change
> It seems we don't have *direct usage* for any conjars related, I will try to
> track we have added this repository and suggest to remove this reference.
> h5. Reference informations
> * [1] [https://groups.google.com/g/cascading-user/c/qAQvajapawI]
> * [2] [https://conjars.wensel.net/]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (GORA-698) Add GEODE Support
[ https://issues.apache.org/jira/browse/GORA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702383#comment-17702383 ] ASF GitHub Bot commented on GORA-698: - djkevincr commented on PR #273: URL: https://github.com/apache/gora/pull/273#issuecomment-1475455904 @himanshuacharya95 Can you please address the remaining request changes? > Add GEODE Support > - > > Key: GORA-698 > URL: https://issues.apache.org/jira/browse/GORA-698 > Project: Apache Gora > Issue Type: New Feature >Reporter: Himanshu >Priority: Major > > [1]https://geode.apache.org/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-651) Upgrade OrientDB to the latest version 3
[ https://issues.apache.org/jira/browse/GORA-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701936#comment-17701936 ] ASF GitHub Bot commented on GORA-651: - djkevincr commented on PR #210: URL: https://github.com/apache/gora/pull/210#issuecomment-1474242690 @dinuka-perera Thank you for the contribution. > Upgrade OrientDB to the latest version 3 > > > Key: GORA-651 > URL: https://issues.apache.org/jira/browse/GORA-651 > Project: Apache Gora > Issue Type: Improvement >Reporter: Kevin Ratnasekera >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > It seem version 3 based releases [1] have been there for a while, we should > upgrade from 2.2.22. > [1] https://orientdb.com/releases/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-651) Upgrade OrientDB to the latest version 3
[ https://issues.apache.org/jira/browse/GORA-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701935#comment-17701935 ] ASF GitHub Bot commented on GORA-651: - djkevincr merged PR #210: URL: https://github.com/apache/gora/pull/210 > Upgrade OrientDB to the latest version 3 > > > Key: GORA-651 > URL: https://issues.apache.org/jira/browse/GORA-651 > Project: Apache Gora > Issue Type: Improvement >Reporter: Kevin Ratnasekera >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > It seem version 3 based releases [1] have been there for a while, we should > upgrade from 2.2.22. > [1] https://orientdb.com/releases/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-651) Upgrade OrientDB to the latest version 3
[ https://issues.apache.org/jira/browse/GORA-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701429#comment-17701429 ] ASF GitHub Bot commented on GORA-651: - djkevincr closed pull request #210: GORA-651 upgrade Orient DB driver to version 3 URL: https://github.com/apache/gora/pull/210 > Upgrade OrientDB to the latest version 3 > > > Key: GORA-651 > URL: https://issues.apache.org/jira/browse/GORA-651 > Project: Apache Gora > Issue Type: Improvement >Reporter: Kevin Ratnasekera >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > It seem version 3 based releases [1] have been there for a while, we should > upgrade from 2.2.22. > [1] https://orientdb.com/releases/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-663) Add datastore for Neo4j
[ https://issues.apache.org/jira/browse/GORA-663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701424#comment-17701424 ] ASF GitHub Bot commented on GORA-663: - djkevincr commented on PR #235: URL: https://github.com/apache/gora/pull/235#issuecomment-1472902110 @mgov88 Thank you for your hard work. PR looks awesome. Looking forward to your future contributions. > Add datastore for Neo4j > --- > > Key: GORA-663 > URL: https://issues.apache.org/jira/browse/GORA-663 > Project: Apache Gora > Issue Type: New Feature >Affects Versions: 0.9 >Reporter: Carlos Muñoz >Assignee: Gaby Ortiz >Priority: Major > Labels: outreachy2020 > Attachments: gora-neo4j.md, index.md > > Time Spent: 50m > Remaining Estimate: 0h > > Graph databases are becoming increasingly popular in big data applications. > Maybe we should consider work with them in Apache Gora. > [https://neo4j.com/developer/get-started/] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-663) Add datastore for Neo4j
[ https://issues.apache.org/jira/browse/GORA-663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701425#comment-17701425 ] ASF GitHub Bot commented on GORA-663: - djkevincr merged PR #235: URL: https://github.com/apache/gora/pull/235 > Add datastore for Neo4j > --- > > Key: GORA-663 > URL: https://issues.apache.org/jira/browse/GORA-663 > Project: Apache Gora > Issue Type: New Feature >Affects Versions: 0.9 >Reporter: Carlos Muñoz >Assignee: Gaby Ortiz >Priority: Major > Labels: outreachy2020 > Attachments: gora-neo4j.md, index.md > > Time Spent: 50m > Remaining Estimate: 0h > > Graph databases are becoming increasingly popular in big data applications. > Maybe we should consider work with them in Apache Gora. > [https://neo4j.com/developer/get-started/] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-698) Add GEODE Support
[ https://issues.apache.org/jira/browse/GORA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699462#comment-17699462 ] ASF GitHub Bot commented on GORA-698: - CalvinKirs commented on PR #273: URL: https://github.com/apache/gora/pull/273#issuecomment-1465561868 > @CalvinKirs Do you have any input on the PR related to Geode work? I will take a look later :) > Add GEODE Support > - > > Key: GORA-698 > URL: https://issues.apache.org/jira/browse/GORA-698 > Project: Apache Gora > Issue Type: New Feature >Reporter: Himanshu >Priority: Major > > [1]https://geode.apache.org/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-698) Add GEODE Support
[ https://issues.apache.org/jira/browse/GORA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699414#comment-17699414 ] ASF GitHub Bot commented on GORA-698: - djkevincr commented on PR #273: URL: https://github.com/apache/gora/pull/273#issuecomment-1465352565 @CalvinKirs Do you have any input on the PR related to Geode work? > Add GEODE Support > - > > Key: GORA-698 > URL: https://issues.apache.org/jira/browse/GORA-698 > Project: Apache Gora > Issue Type: New Feature >Reporter: Himanshu >Priority: Major > > [1]https://geode.apache.org/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-694) Upgrade Aerospike datastore java driver to the latest
[ https://issues.apache.org/jira/browse/GORA-694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699412#comment-17699412 ] ASF GitHub Bot commented on GORA-694: - djkevincr merged PR #256: URL: https://github.com/apache/gora/pull/256 > Upgrade Aerospike datastore java driver to the latest > - > > Key: GORA-694 > URL: https://issues.apache.org/jira/browse/GORA-694 > Project: Apache Gora > Issue Type: Improvement > Components: gora-aerospike >Affects Versions: 0.9 >Reporter: Trisha Melani >Priority: Major > Fix For: 1.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-694) Upgrade Aerospike datastore java driver to the latest
[ https://issues.apache.org/jira/browse/GORA-694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699413#comment-17699413 ] ASF GitHub Bot commented on GORA-694: - djkevincr commented on PR #256: URL: https://github.com/apache/gora/pull/256#issuecomment-1465350867 @trisha-melani Thank you for the contribution. > Upgrade Aerospike datastore java driver to the latest > - > > Key: GORA-694 > URL: https://issues.apache.org/jira/browse/GORA-694 > Project: Apache Gora > Issue Type: Improvement > Components: gora-aerospike >Affects Versions: 0.9 >Reporter: Trisha Melani >Priority: Major > Fix For: 1.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-693) Improve Gora Jet Test Cases
[ https://issues.apache.org/jira/browse/GORA-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699376#comment-17699376 ] ASF GitHub Bot commented on GORA-693: - djkevincr commented on PR #255: URL: https://github.com/apache/gora/pull/255#issuecomment-1465249982 @trisha-melani Thank you for the contribution. > Improve Gora Jet Test Cases > --- > > Key: GORA-693 > URL: https://issues.apache.org/jira/browse/GORA-693 > Project: Apache Gora > Issue Type: Improvement > Components: gora-jet >Affects Versions: 0.9 >Reporter: Trisha Melani >Priority: Major > Fix For: 1.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-693) Improve Gora Jet Test Cases
[ https://issues.apache.org/jira/browse/GORA-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699375#comment-17699375 ] ASF GitHub Bot commented on GORA-693: - djkevincr merged PR #255: URL: https://github.com/apache/gora/pull/255 > Improve Gora Jet Test Cases > --- > > Key: GORA-693 > URL: https://issues.apache.org/jira/browse/GORA-693 > Project: Apache Gora > Issue Type: Improvement > Components: gora-jet >Affects Versions: 0.9 >Reporter: Trisha Melani >Priority: Major > Fix For: 1.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-693) Improve Gora Jet Test Cases
[ https://issues.apache.org/jira/browse/GORA-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699367#comment-17699367 ] ASF GitHub Bot commented on GORA-693: - djkevincr closed pull request #255: GORA-693 Improve gora-jet test cases URL: https://github.com/apache/gora/pull/255 > Improve Gora Jet Test Cases > --- > > Key: GORA-693 > URL: https://issues.apache.org/jira/browse/GORA-693 > Project: Apache Gora > Issue Type: Improvement > Components: gora-jet >Affects Versions: 0.9 >Reporter: Trisha Melani >Priority: Major > Fix For: 1.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-663) Add datastore for Neo4j
[ https://issues.apache.org/jira/browse/GORA-663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699351#comment-17699351 ] ASF GitHub Bot commented on GORA-663: - djkevincr closed pull request #235: [GORA-663] Add datastore for Neo4j URL: https://github.com/apache/gora/pull/235 > Add datastore for Neo4j > --- > > Key: GORA-663 > URL: https://issues.apache.org/jira/browse/GORA-663 > Project: Apache Gora > Issue Type: New Feature >Affects Versions: 0.9 >Reporter: Carlos Muñoz >Assignee: Gaby Ortiz >Priority: Major > Labels: outreachy2020 > Attachments: gora-neo4j.md, index.md > > Time Spent: 50m > Remaining Estimate: 0h > > Graph databases are becoming increasingly popular in big data applications. > Maybe we should consider work with them in Apache Gora. > [https://neo4j.com/developer/get-started/] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-663) Add datastore for Neo4j
[ https://issues.apache.org/jira/browse/GORA-663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699352#comment-17699352 ] ASF GitHub Bot commented on GORA-663: - mgov88 opened a new pull request, #235: URL: https://github.com/apache/gora/pull/235 This pull request contains the implementation of the Neo4j Datastore for Apache Gora Please let me know if you have feedback. Intern: Gaby Ortiz Project: Add datastore for Neo4j Outreachy: 2020 Winter > Add datastore for Neo4j > --- > > Key: GORA-663 > URL: https://issues.apache.org/jira/browse/GORA-663 > Project: Apache Gora > Issue Type: New Feature >Affects Versions: 0.9 >Reporter: Carlos Muñoz >Assignee: Gaby Ortiz >Priority: Major > Labels: outreachy2020 > Attachments: gora-neo4j.md, index.md > > Time Spent: 50m > Remaining Estimate: 0h > > Graph databases are becoming increasingly popular in big data applications. > Maybe we should consider work with them in Apache Gora. > [https://neo4j.com/developer/get-started/] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-693) Improve Gora Jet Test Cases
[ https://issues.apache.org/jira/browse/GORA-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699350#comment-17699350 ] ASF GitHub Bot commented on GORA-693: - djkevincr closed pull request #255: GORA-693 Improve gora-jet test cases URL: https://github.com/apache/gora/pull/255 > Improve Gora Jet Test Cases > --- > > Key: GORA-693 > URL: https://issues.apache.org/jira/browse/GORA-693 > Project: Apache Gora > Issue Type: Improvement > Components: gora-jet >Affects Versions: 0.9 >Reporter: Trisha Melani >Priority: Major > Fix For: 1.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-694) Upgrade Aerospike datastore java driver to the latest
[ https://issues.apache.org/jira/browse/GORA-694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699344#comment-17699344 ] ASF GitHub Bot commented on GORA-694: - djkevincr closed pull request #256: GORA-694 Upgrade Aerospike to the latest driver URL: https://github.com/apache/gora/pull/256 > Upgrade Aerospike datastore java driver to the latest > - > > Key: GORA-694 > URL: https://issues.apache.org/jira/browse/GORA-694 > Project: Apache Gora > Issue Type: Improvement > Components: gora-aerospike >Affects Versions: 0.9 >Reporter: Trisha Melani >Priority: Major > Fix For: 1.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-699) Unstable build due to test Redis test failures
[ https://issues.apache.org/jira/browse/GORA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699342#comment-17699342 ] ASF GitHub Bot commented on GORA-699: - djkevincr merged PR #281: URL: https://github.com/apache/gora/pull/281 > Unstable build due to test Redis test failures > -- > > Key: GORA-699 > URL: https://issues.apache.org/jira/browse/GORA-699 > Project: Apache Gora > Issue Type: Bug >Reporter: Kevin Ratnasekera >Priority: Major > > [main] INFO [grokzen/redis-cluster:latest] - Creating container for image: > grokzen/redis-cluster:latest > [main] INFO [grokzen/redis-cluster:latest] - Starting container with ID: > fd00f67a80705cc56cf16e9ccf1c1b74605dbf30755f26d3743e664c8b3ca991 > [main] INFO [grokzen/redis-cluster:latest] - Container > grokzen/redis-cluster:latest is starting: > fd00f67a80705cc56cf16e9ccf1c1b74605dbf30755f26d3743e664c8b3ca991 > [main] ERROR [grokzen/redis-cluster:latest] - Could not start container > org.testcontainers.containers.ContainerLaunchException: Timed out waiting for > log output matching '.*Background AOF rewrite finished successfully.*' > at > org.testcontainers.containers.wait.strategy.LogMessageWaitStrategy.waitUntilReady(LogMessageWaitStrategy.java:49) > at > org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:35) > at > org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:892) > at > org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:440) > at > org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:325) > at > org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81) > at > org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:323) > at > org.testcontainers.containers.GenericContainer.start(GenericContainer.java:311) > at > org.apache.gora.redis.GoraRedisTestDriver.setUpClass(GoraRedisTestDriver.java:57) > at > org.apache.gora.store.DataStoreTestBase.setUpClass(DataStoreTestBase.java:61) > at > org.apache.gora.store.DataStoreTestBase.setUp(DataStoreTestBase.java:80) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:27) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30) > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47) > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231) > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60) > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229) > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50) > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30) > at org.junit.runners.ParentRunner.run(ParentRunner.java:300) > at > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:236) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159) > at > org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:386) > at > org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:323) > at > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:143) > [main] ERROR [grokzen/redis-cluster:latest] - Log output from the failed > container: > -- IP Before trim: '172.17.0.3 ' > -- IP Before split: '172.17.0.3' > -- IP
[jira] [Commented] (GORA-699) Unstable build due to test Redis test failures
[ https://issues.apache.org/jira/browse/GORA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699341#comment-17699341 ] ASF GitHub Bot commented on GORA-699: - djkevincr commented on PR #281: URL: https://github.com/apache/gora/pull/281#issuecomment-1465193991 build passes on CI - https://ci-builds.apache.org/job/Gora/job/gora-pipeline/job/GORA-699-new/1/ > Unstable build due to test Redis test failures > -- > > Key: GORA-699 > URL: https://issues.apache.org/jira/browse/GORA-699 > Project: Apache Gora > Issue Type: Bug >Reporter: Kevin Ratnasekera >Priority: Major > > [main] INFO [grokzen/redis-cluster:latest] - Creating container for image: > grokzen/redis-cluster:latest > [main] INFO [grokzen/redis-cluster:latest] - Starting container with ID: > fd00f67a80705cc56cf16e9ccf1c1b74605dbf30755f26d3743e664c8b3ca991 > [main] INFO [grokzen/redis-cluster:latest] - Container > grokzen/redis-cluster:latest is starting: > fd00f67a80705cc56cf16e9ccf1c1b74605dbf30755f26d3743e664c8b3ca991 > [main] ERROR [grokzen/redis-cluster:latest] - Could not start container > org.testcontainers.containers.ContainerLaunchException: Timed out waiting for > log output matching '.*Background AOF rewrite finished successfully.*' > at > org.testcontainers.containers.wait.strategy.LogMessageWaitStrategy.waitUntilReady(LogMessageWaitStrategy.java:49) > at > org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:35) > at > org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:892) > at > org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:440) > at > org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:325) > at > org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81) > at > org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:323) > at > org.testcontainers.containers.GenericContainer.start(GenericContainer.java:311) > at > org.apache.gora.redis.GoraRedisTestDriver.setUpClass(GoraRedisTestDriver.java:57) > at > org.apache.gora.store.DataStoreTestBase.setUpClass(DataStoreTestBase.java:61) > at > org.apache.gora.store.DataStoreTestBase.setUp(DataStoreTestBase.java:80) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:27) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30) > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47) > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231) > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60) > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229) > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50) > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30) > at org.junit.runners.ParentRunner.run(ParentRunner.java:300) > at > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:236) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159) > at > org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:386) > at > org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:323) > at > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:143) > [main] ERROR
[jira] [Commented] (GORA-699) Unstable build due to test Redis test failures
[ https://issues.apache.org/jira/browse/GORA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699292#comment-17699292 ] ASF GitHub Bot commented on GORA-699: - djkevincr closed pull request #280: GORA-699 fix redis tests URL: https://github.com/apache/gora/pull/280 > Unstable build due to test Redis test failures > -- > > Key: GORA-699 > URL: https://issues.apache.org/jira/browse/GORA-699 > Project: Apache Gora > Issue Type: Bug >Reporter: Kevin Ratnasekera >Priority: Major > > [main] INFO [grokzen/redis-cluster:latest] - Creating container for image: > grokzen/redis-cluster:latest > [main] INFO [grokzen/redis-cluster:latest] - Starting container with ID: > fd00f67a80705cc56cf16e9ccf1c1b74605dbf30755f26d3743e664c8b3ca991 > [main] INFO [grokzen/redis-cluster:latest] - Container > grokzen/redis-cluster:latest is starting: > fd00f67a80705cc56cf16e9ccf1c1b74605dbf30755f26d3743e664c8b3ca991 > [main] ERROR [grokzen/redis-cluster:latest] - Could not start container > org.testcontainers.containers.ContainerLaunchException: Timed out waiting for > log output matching '.*Background AOF rewrite finished successfully.*' > at > org.testcontainers.containers.wait.strategy.LogMessageWaitStrategy.waitUntilReady(LogMessageWaitStrategy.java:49) > at > org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:35) > at > org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:892) > at > org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:440) > at > org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:325) > at > org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81) > at > org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:323) > at > org.testcontainers.containers.GenericContainer.start(GenericContainer.java:311) > at > org.apache.gora.redis.GoraRedisTestDriver.setUpClass(GoraRedisTestDriver.java:57) > at > org.apache.gora.store.DataStoreTestBase.setUpClass(DataStoreTestBase.java:61) > at > org.apache.gora.store.DataStoreTestBase.setUp(DataStoreTestBase.java:80) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:27) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30) > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47) > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231) > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60) > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229) > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50) > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30) > at org.junit.runners.ParentRunner.run(ParentRunner.java:300) > at > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:236) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159) > at > org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:386) > at > org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:323) > at > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:143) > [main] ERROR [grokzen/redis-cluster:latest] - Log output from the failed > container: > -- IP Before trim: '172.17.0.3 ' > -- IP
[jira] [Commented] (GORA-694) Upgrade Aerospike datastore java driver to the latest
[ https://issues.apache.org/jira/browse/GORA-694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698622#comment-17698622 ] ASF GitHub Bot commented on GORA-694: - djkevincr closed pull request #256: GORA-694 Upgrade Aerospike to the latest driver URL: https://github.com/apache/gora/pull/256 > Upgrade Aerospike datastore java driver to the latest > - > > Key: GORA-694 > URL: https://issues.apache.org/jira/browse/GORA-694 > Project: Apache Gora > Issue Type: Improvement > Components: gora-aerospike >Affects Versions: 0.9 >Reporter: Trisha Melani >Priority: Major > Fix For: 1.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-701) Fix Github workflow build for PRs
[ https://issues.apache.org/jira/browse/GORA-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698621#comment-17698621 ] ASF GitHub Bot commented on GORA-701: - djkevincr merged PR #278: URL: https://github.com/apache/gora/pull/278 > Fix Github workflow build for PRs > - > > Key: GORA-701 > URL: https://issues.apache.org/jira/browse/GORA-701 > Project: Apache Gora > Issue Type: Bug >Reporter: Kevin Ratnasekera >Priority: Major > > Currently this Error - The runner has received a shutdown signal prevent us > running builds on pull requests. > This is already reported and solution is discussed here - > https://github.com/actions/runner-images/issues/6709 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-694) Upgrade Aerospike datastore java driver to the latest
[ https://issues.apache.org/jira/browse/GORA-694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697548#comment-17697548 ] ASF GitHub Bot commented on GORA-694: - djkevincr closed pull request #256: GORA-694 Upgrade Aerospike to the latest driver URL: https://github.com/apache/gora/pull/256 > Upgrade Aerospike datastore java driver to the latest > - > > Key: GORA-694 > URL: https://issues.apache.org/jira/browse/GORA-694 > Project: Apache Gora > Issue Type: Improvement > Components: gora-aerospike >Affects Versions: 0.9 >Reporter: Trisha Melani >Priority: Major > Fix For: 1.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-690) Upgrade to Apache pom parent 24
[ https://issues.apache.org/jira/browse/GORA-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697541#comment-17697541 ] ASF GitHub Bot commented on GORA-690: - djkevincr commented on PR #252: URL: https://github.com/apache/gora/pull/252#issuecomment-1458534124 @trisha-melani Thank you for the contribution. > Upgrade to Apache pom parent 24 > --- > > Key: GORA-690 > URL: https://issues.apache.org/jira/browse/GORA-690 > Project: Apache Gora > Issue Type: Improvement >Affects Versions: 0.9 >Reporter: Trisha Melani >Priority: Minor > Fix For: 1.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-690) Upgrade to Apache pom parent 24
[ https://issues.apache.org/jira/browse/GORA-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697540#comment-17697540 ] ASF GitHub Bot commented on GORA-690: - djkevincr merged PR #252: URL: https://github.com/apache/gora/pull/252 > Upgrade to Apache pom parent 24 > --- > > Key: GORA-690 > URL: https://issues.apache.org/jira/browse/GORA-690 > Project: Apache Gora > Issue Type: Improvement >Affects Versions: 0.9 >Reporter: Trisha Melani >Priority: Minor > Fix For: 1.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-698) Add GEODE Support
[ https://issues.apache.org/jira/browse/GORA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606353#comment-17606353 ] ASF GitHub Bot commented on GORA-698: - himanshuacharya95 commented on code in PR #273: URL: https://github.com/apache/gora/pull/273#discussion_r973775993 ## gora-geode/src/main/java/org/apache/gora/geode/store/GeodeStore.java: ## @@ -0,0 +1,187 @@ +package org.apache.gora.geode.store; + +import org.apache.geode.cache.*; Review Comment: Replaced wildcard import statements with only required ones. > Add GEODE Support > - > > Key: GORA-698 > URL: https://issues.apache.org/jira/browse/GORA-698 > Project: Apache Gora > Issue Type: New Feature >Reporter: Himanshu >Priority: Major > > [1]https://geode.apache.org/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-698) Add GEODE Support
[
https://issues.apache.org/jira/browse/GORA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606348#comment-17606348
]
ASF GitHub Bot commented on GORA-698:
-
kamaci commented on code in PR #273:
URL: https://github.com/apache/gora/pull/273#discussion_r973769144
##
gora-geode/src/test/java/store/TestGeodeStore.java:
##
@@ -0,0 +1,161 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package store;
+
+
+
+import org.apache.avro.util.Utf8;
+import org.apache.gora.examples.WebPageDataCreator;
+import org.apache.gora.examples.generated.WebPage;
+import org.apache.gora.geode.GeodeStartupLogWaitStrategy;
+import org.apache.gora.geode.GoraGeodeTestDriver;
+import org.apache.gora.geode.query.GeodeResult;
+import org.apache.gora.query.Query;
+import org.apache.gora.store.DataStoreTestBase;
+import org.apache.gora.util.GoraException;
+import org.junit.ClassRule;
+import org.junit.Ignore;
+import org.junit.Test;
+import org.testcontainers.containers.GenericContainer;
+
+
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.nio.charset.Charset;
+import java.time.Duration;
+
+import static org.junit.Assert.*;
+
+/**
+ * Tests extending {@link DataStoreTestBase}
+ * which run the base JUnit test suite for Gora.
+ */
+public class TestGeodeStore extends DataStoreTestBase {
Review Comment:
Could you add more tests?
> Add GEODE Support
> -
>
> Key: GORA-698
> URL: https://issues.apache.org/jira/browse/GORA-698
> Project: Apache Gora
> Issue Type: New Feature
>Reporter: Himanshu
>Priority: Major
>
> [1]https://geode.apache.org/
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (GORA-698) Add GEODE Support
[ https://issues.apache.org/jira/browse/GORA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606347#comment-17606347 ] ASF GitHub Bot commented on GORA-698: - kamaci commented on code in PR #273: URL: https://github.com/apache/gora/pull/273#discussion_r973768766 ## gora-geode/src/main/java/org/apache/gora/geode/store/GeodeStore.java: ## @@ -0,0 +1,187 @@ +package org.apache.gora.geode.store; + +import org.apache.geode.cache.*; Review Comment: Please not use wildcard imports > Add GEODE Support > - > > Key: GORA-698 > URL: https://issues.apache.org/jira/browse/GORA-698 > Project: Apache Gora > Issue Type: New Feature >Reporter: Himanshu >Priority: Major > > [1]https://geode.apache.org/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-698) Add GEODE Support
[
https://issues.apache.org/jira/browse/GORA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600526#comment-17600526
]
ASF GitHub Bot commented on GORA-698:
-
himanshuacharya95 commented on code in PR #273:
URL: https://github.com/apache/gora/pull/273#discussion_r963144285
##
gora-geode/src/main/java/org/apache/gora/geode/store/GeodeStore.java:
##
@@ -0,0 +1,190 @@
+package org.apache.gora.geode.store;
+
+import org.apache.geode.cache.*;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.client.ClientCacheFactory;
+import org.apache.gora.geode.query.GeodeQuery;
+import org.apache.gora.geode.query.GeodeResult;
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.query.PartitionQuery;
+import org.apache.gora.query.Query;
+import org.apache.gora.query.Result;
+import org.apache.gora.query.impl.PartitionQueryImpl;
+import org.apache.gora.store.impl.DataStoreBase;
+import org.apache.gora.util.GoraException;
+
+import java.io.IOException;
+import java.util.*;
+import java.util.concurrent.ConcurrentSkipListSet;
+
+import static org.apache.geode.cache.RegionShortcut.REPLICATE;
+import static org.apache.gora.geode.store.GeodeStoreParameters.*;
+
+
+public class GeodeStore extends DataStoreBase {
+
+private ClientCache clientCache;
+private Region region;
+private Properties geodeProperties;
+
+
+private CacheFactory cacheFactory;
+
+@Override
+public void initialize(Class keyClass, Class persistentClass,
Properties properties) throws GoraException {
+super.initialize(keyClass, persistentClass, properties);
+String geodeHostName = (String) properties.get(GEODE_SERVER_HOST);
+int portNumber = Integer.parseInt((String)
properties.get(GEODE_SERVER_PORT));
+clientCache = new ClientCacheFactory().addPoolLocator(geodeHostName,
portNumber).create();
+String userName = properties.getProperty(GEODE_USERNAME);
+String password = properties.getProperty(GEODE_PASSWORD);
+geodeProperties = properties;
+
+Properties clientProperties =
clientCache.getDistributedSystem().getProperties();
+if (userName != null) {
+clientProperties.setProperty("security-username", userName);
+clientProperties.setProperty("security-password", password);
+}
+cacheFactory = new CacheFactory(clientProperties);
+}
+
+@Override
+/*
+ Schema Name can be assigned via Property file using
@PREFERRED_SCHEMA_NAME, or else PersistentClass name is used as the default
schema name.
+ */
+public String getSchemaName() {
+String preferredSchemaName =
properties.getProperty(PREFERRED_SCHEMA_NAME);
+if (preferredSchemaName == null) {
+return persistentClass.getSimpleName();
+}
+return preferredSchemaName;
+}
+
+@Override
+public void createSchema() throws GoraException {
+try {
+Cache cache = cacheFactory.create();
+String regionShortCut =
geodeProperties.getProperty(GEODE_REGION_SHORTCUT);
+RegionFactory regionFactory;
+if (regionShortCut != null) {
+regionFactory =
cache.createRegionFactory(RegionShortcut.valueOf(regionShortCut));
+} else {
+regionFactory = cache.createRegionFactory(REPLICATE);
+}
+region = regionFactory.create(getSchemaName());
+} catch (Exception e) {
+throw new GoraException(e);
+}
+}
+
+@Override
+public void deleteSchema() {
+region.destroyRegion();
+}
+
+@Override
+public boolean schemaExists() {
+Properties properties =
clientCache.getDistributedSystem().getProperties();
+CacheFactory factory = new CacheFactory(properties);
+Cache cache = factory.create();
+Region rf = cache.getRegion(getSchemaName());
+return rf != null;
+}
+
+@Override
+public boolean exists(K key) {
+for (K existingKey : region.getInterestList()) {
+if (existingKey.equals(key)) {
+return true;
+}
+}
+return false;
+}
+
+@Override
+public T get(K key, String[] fields) {
+return region.get(key);
+}
+
+@Override
+public void put(K key, T obj) {
+region.put(key, obj);
+}
+
+@Override
+public boolean delete(K key) {
+region.destroy(key);
+return true;
+}
+
+@Override
+public long deleteByQuery(Query query) throws GoraException {
+try {
+long deletedRows = 0;
+Result result = query.execute();
+while (result.next()) {
+if (delete(result.getKey())) {
+deletedRows++;
+}
+}
+LOG.info("Geode datastore deleted {} rows from
[jira] [Commented] (GORA-698) Add GEODE Support
[
https://issues.apache.org/jira/browse/GORA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600525#comment-17600525
]
ASF GitHub Bot commented on GORA-698:
-
himanshuacharya95 commented on code in PR #273:
URL: https://github.com/apache/gora/pull/273#discussion_r963144223
##
gora-geode/src/main/java/org/apache/gora/geode/store/GeodeStore.java:
##
@@ -0,0 +1,190 @@
+package org.apache.gora.geode.store;
+
+import org.apache.geode.cache.*;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.client.ClientCacheFactory;
+import org.apache.gora.geode.query.GeodeQuery;
+import org.apache.gora.geode.query.GeodeResult;
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.query.PartitionQuery;
+import org.apache.gora.query.Query;
+import org.apache.gora.query.Result;
+import org.apache.gora.query.impl.PartitionQueryImpl;
+import org.apache.gora.store.impl.DataStoreBase;
+import org.apache.gora.util.GoraException;
+
+import java.io.IOException;
+import java.util.*;
+import java.util.concurrent.ConcurrentSkipListSet;
+
+import static org.apache.geode.cache.RegionShortcut.REPLICATE;
+import static org.apache.gora.geode.store.GeodeStoreParameters.*;
+
+
+public class GeodeStore extends DataStoreBase {
+
+private ClientCache clientCache;
+private Region region;
+private Properties geodeProperties;
+
+
+private CacheFactory cacheFactory;
+
+@Override
+public void initialize(Class keyClass, Class persistentClass,
Properties properties) throws GoraException {
+super.initialize(keyClass, persistentClass, properties);
+String geodeHostName = (String) properties.get(GEODE_SERVER_HOST);
+int portNumber = Integer.parseInt((String)
properties.get(GEODE_SERVER_PORT));
+clientCache = new ClientCacheFactory().addPoolLocator(geodeHostName,
portNumber).create();
+String userName = properties.getProperty(GEODE_USERNAME);
+String password = properties.getProperty(GEODE_PASSWORD);
+geodeProperties = properties;
+
+Properties clientProperties =
clientCache.getDistributedSystem().getProperties();
+if (userName != null) {
Review Comment:
Added some code to throw exception
> Add GEODE Support
> -
>
> Key: GORA-698
> URL: https://issues.apache.org/jira/browse/GORA-698
> Project: Apache Gora
> Issue Type: New Feature
>Reporter: Himanshu
>Priority: Major
>
> [1]https://geode.apache.org/
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (GORA-698) Add GEODE Support
[
https://issues.apache.org/jira/browse/GORA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600524#comment-17600524
]
ASF GitHub Bot commented on GORA-698:
-
himanshuacharya95 commented on code in PR #273:
URL: https://github.com/apache/gora/pull/273#discussion_r963143973
##
gora-geode/src/main/java/org/apache/gora/geode/store/GeodeStore.java:
##
@@ -0,0 +1,190 @@
+package org.apache.gora.geode.store;
+
+import org.apache.geode.cache.*;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.client.ClientCacheFactory;
+import org.apache.gora.geode.query.GeodeQuery;
+import org.apache.gora.geode.query.GeodeResult;
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.query.PartitionQuery;
+import org.apache.gora.query.Query;
+import org.apache.gora.query.Result;
+import org.apache.gora.query.impl.PartitionQueryImpl;
+import org.apache.gora.store.impl.DataStoreBase;
+import org.apache.gora.util.GoraException;
+
+import java.io.IOException;
+import java.util.*;
+import java.util.concurrent.ConcurrentSkipListSet;
+
+import static org.apache.geode.cache.RegionShortcut.REPLICATE;
+import static org.apache.gora.geode.store.GeodeStoreParameters.*;
+
+
+public class GeodeStore extends DataStoreBase {
+
+private ClientCache clientCache;
+private Region region;
+private Properties geodeProperties;
+
+
Review Comment:
Extra spaces removed
> Add GEODE Support
> -
>
> Key: GORA-698
> URL: https://issues.apache.org/jira/browse/GORA-698
> Project: Apache Gora
> Issue Type: New Feature
>Reporter: Himanshu
>Priority: Major
>
> [1]https://geode.apache.org/
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (GORA-698) Add GEODE Support
[
https://issues.apache.org/jira/browse/GORA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1758#comment-1758
]
ASF GitHub Bot commented on GORA-698:
-
kamaci commented on code in PR #273:
URL: https://github.com/apache/gora/pull/273#discussion_r962204714
##
gora-geode/src/main/java/org/apache/gora/geode/store/GeodeStore.java:
##
@@ -0,0 +1,190 @@
+package org.apache.gora.geode.store;
+
+import org.apache.geode.cache.*;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.client.ClientCacheFactory;
+import org.apache.gora.geode.query.GeodeQuery;
+import org.apache.gora.geode.query.GeodeResult;
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.query.PartitionQuery;
+import org.apache.gora.query.Query;
+import org.apache.gora.query.Result;
+import org.apache.gora.query.impl.PartitionQueryImpl;
+import org.apache.gora.store.impl.DataStoreBase;
+import org.apache.gora.util.GoraException;
+
+import java.io.IOException;
+import java.util.*;
+import java.util.concurrent.ConcurrentSkipListSet;
+
+import static org.apache.geode.cache.RegionShortcut.REPLICATE;
+import static org.apache.gora.geode.store.GeodeStoreParameters.*;
+
+
+public class GeodeStore extends DataStoreBase {
+
+private ClientCache clientCache;
+private Region region;
+private Properties geodeProperties;
+
+
+private CacheFactory cacheFactory;
+
+@Override
+public void initialize(Class keyClass, Class persistentClass,
Properties properties) throws GoraException {
+super.initialize(keyClass, persistentClass, properties);
+String geodeHostName = (String) properties.get(GEODE_SERVER_HOST);
+int portNumber = Integer.parseInt((String)
properties.get(GEODE_SERVER_PORT));
+clientCache = new ClientCacheFactory().addPoolLocator(geodeHostName,
portNumber).create();
+String userName = properties.getProperty(GEODE_USERNAME);
+String password = properties.getProperty(GEODE_PASSWORD);
+geodeProperties = properties;
+
+Properties clientProperties =
clientCache.getDistributedSystem().getProperties();
+if (userName != null) {
Review Comment:
What if username is null and password is not? How about throwing an
exception in that case?
> Add GEODE Support
> -
>
> Key: GORA-698
> URL: https://issues.apache.org/jira/browse/GORA-698
> Project: Apache Gora
> Issue Type: New Feature
>Reporter: Himanshu
>Priority: Major
>
> [1]https://geode.apache.org/
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (GORA-698) Add GEODE Support
[
https://issues.apache.org/jira/browse/GORA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1759#comment-1759
]
ASF GitHub Bot commented on GORA-698:
-
kamaci commented on code in PR #273:
URL: https://github.com/apache/gora/pull/273#discussion_r962204734
##
gora-geode/src/main/java/org/apache/gora/geode/store/GeodeStore.java:
##
@@ -0,0 +1,190 @@
+package org.apache.gora.geode.store;
+
+import org.apache.geode.cache.*;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.client.ClientCacheFactory;
+import org.apache.gora.geode.query.GeodeQuery;
+import org.apache.gora.geode.query.GeodeResult;
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.query.PartitionQuery;
+import org.apache.gora.query.Query;
+import org.apache.gora.query.Result;
+import org.apache.gora.query.impl.PartitionQueryImpl;
+import org.apache.gora.store.impl.DataStoreBase;
+import org.apache.gora.util.GoraException;
+
+import java.io.IOException;
+import java.util.*;
+import java.util.concurrent.ConcurrentSkipListSet;
+
+import static org.apache.geode.cache.RegionShortcut.REPLICATE;
+import static org.apache.gora.geode.store.GeodeStoreParameters.*;
+
+
+public class GeodeStore extends DataStoreBase {
+
+private ClientCache clientCache;
+private Region region;
+private Properties geodeProperties;
+
+
+private CacheFactory cacheFactory;
+
+@Override
+public void initialize(Class keyClass, Class persistentClass,
Properties properties) throws GoraException {
+super.initialize(keyClass, persistentClass, properties);
+String geodeHostName = (String) properties.get(GEODE_SERVER_HOST);
+int portNumber = Integer.parseInt((String)
properties.get(GEODE_SERVER_PORT));
+clientCache = new ClientCacheFactory().addPoolLocator(geodeHostName,
portNumber).create();
+String userName = properties.getProperty(GEODE_USERNAME);
+String password = properties.getProperty(GEODE_PASSWORD);
+geodeProperties = properties;
+
+Properties clientProperties =
clientCache.getDistributedSystem().getProperties();
+if (userName != null) {
+clientProperties.setProperty("security-username", userName);
+clientProperties.setProperty("security-password", password);
+}
+cacheFactory = new CacheFactory(clientProperties);
+}
+
+@Override
+/*
+ Schema Name can be assigned via Property file using
@PREFERRED_SCHEMA_NAME, or else PersistentClass name is used as the default
schema name.
+ */
+public String getSchemaName() {
+String preferredSchemaName =
properties.getProperty(PREFERRED_SCHEMA_NAME);
+if (preferredSchemaName == null) {
+return persistentClass.getSimpleName();
+}
+return preferredSchemaName;
+}
+
+@Override
+public void createSchema() throws GoraException {
+try {
+Cache cache = cacheFactory.create();
+String regionShortCut =
geodeProperties.getProperty(GEODE_REGION_SHORTCUT);
+RegionFactory regionFactory;
+if (regionShortCut != null) {
+regionFactory =
cache.createRegionFactory(RegionShortcut.valueOf(regionShortCut));
+} else {
+regionFactory = cache.createRegionFactory(REPLICATE);
+}
+region = regionFactory.create(getSchemaName());
+} catch (Exception e) {
+throw new GoraException(e);
+}
+}
+
+@Override
+public void deleteSchema() {
+region.destroyRegion();
+}
+
+@Override
+public boolean schemaExists() {
+Properties properties =
clientCache.getDistributedSystem().getProperties();
+CacheFactory factory = new CacheFactory(properties);
+Cache cache = factory.create();
+Region rf = cache.getRegion(getSchemaName());
+return rf != null;
+}
+
+@Override
+public boolean exists(K key) {
+for (K existingKey : region.getInterestList()) {
+if (existingKey.equals(key)) {
+return true;
+}
+}
+return false;
+}
+
+@Override
+public T get(K key, String[] fields) {
+return region.get(key);
+}
+
+@Override
+public void put(K key, T obj) {
+region.put(key, obj);
+}
+
+@Override
+public boolean delete(K key) {
+region.destroy(key);
+return true;
+}
+
+@Override
+public long deleteByQuery(Query query) throws GoraException {
+try {
+long deletedRows = 0;
+Result result = query.execute();
+while (result.next()) {
+if (delete(result.getKey())) {
+deletedRows++;
+}
+}
+LOG.info("Geode datastore deleted {} rows from Persistent
[jira] [Commented] (GORA-698) Add GEODE Support
[
https://issues.apache.org/jira/browse/GORA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1757#comment-1757
]
ASF GitHub Bot commented on GORA-698:
-
kamaci commented on code in PR #273:
URL: https://github.com/apache/gora/pull/273#discussion_r962204662
##
gora-geode/src/main/java/org/apache/gora/geode/store/GeodeStore.java:
##
@@ -0,0 +1,190 @@
+package org.apache.gora.geode.store;
+
+import org.apache.geode.cache.*;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.client.ClientCacheFactory;
+import org.apache.gora.geode.query.GeodeQuery;
+import org.apache.gora.geode.query.GeodeResult;
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.query.PartitionQuery;
+import org.apache.gora.query.Query;
+import org.apache.gora.query.Result;
+import org.apache.gora.query.impl.PartitionQueryImpl;
+import org.apache.gora.store.impl.DataStoreBase;
+import org.apache.gora.util.GoraException;
+
+import java.io.IOException;
+import java.util.*;
+import java.util.concurrent.ConcurrentSkipListSet;
+
+import static org.apache.geode.cache.RegionShortcut.REPLICATE;
+import static org.apache.gora.geode.store.GeodeStoreParameters.*;
+
+
+public class GeodeStore extends DataStoreBase {
+
+private ClientCache clientCache;
+private Region region;
+private Properties geodeProperties;
+
+
Review Comment:
Please remove extra spaces
> Add GEODE Support
> -
>
> Key: GORA-698
> URL: https://issues.apache.org/jira/browse/GORA-698
> Project: Apache Gora
> Issue Type: New Feature
>Reporter: Himanshu
>Priority: Major
>
> [1]https://geode.apache.org/
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (GORA-698) Add GEODE Support
[ https://issues.apache.org/jira/browse/GORA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1750#comment-1750 ] ASF GitHub Bot commented on GORA-698: - himanshuacharya95 opened a new pull request, #273: URL: https://github.com/apache/gora/pull/273 # Pending Items Test Cases > Add GEODE Support > - > > Key: GORA-698 > URL: https://issues.apache.org/jira/browse/GORA-698 > Project: Apache Gora > Issue Type: New Feature >Reporter: Himanshu >Priority: Major > > [1]https://geode.apache.org/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GORA-691) Upgrade Lucene datastore driver to latest 8.10.1
[ https://issues.apache.org/jira/browse/GORA-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17524136#comment-17524136 ] ASF GitHub Bot commented on GORA-691: - madhawa-gunasekara merged PR #253: URL: https://github.com/apache/gora/pull/253 > Upgrade Lucene datastore driver to latest 8.10.1 > > > Key: GORA-691 > URL: https://issues.apache.org/jira/browse/GORA-691 > Project: Apache Gora > Issue Type: Improvement > Components: gora-lucene >Affects Versions: 0.9 >Reporter: Trisha Melani >Priority: Major > Fix For: 1.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GORA-692) Upgrade MongoDB datastore driver to latest 3.12.10
[ https://issues.apache.org/jira/browse/GORA-692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17523987#comment-17523987 ] ASF GitHub Bot commented on GORA-692: - madhawa-gunasekara merged PR #254: URL: https://github.com/apache/gora/pull/254 > Upgrade MongoDB datastore driver to latest 3.12.10 > -- > > Key: GORA-692 > URL: https://issues.apache.org/jira/browse/GORA-692 > Project: Apache Gora > Issue Type: Improvement > Components: gora-mongodb >Affects Versions: 0.9 >Reporter: Trisha Melani >Priority: Major > Fix For: 1.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GORA-651) Upgrade OrientDB to the latest version 3
[ https://issues.apache.org/jira/browse/GORA-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440901#comment-17440901 ] ASF GitHub Bot commented on GORA-651: - nbrendah commented on pull request #249: URL: https://github.com/apache/gora/pull/249#issuecomment-963811996 Hello @djkevincr @lewismc May your please take a look at this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade OrientDB to the latest version 3 > > > Key: GORA-651 > URL: https://issues.apache.org/jira/browse/GORA-651 > Project: Apache Gora > Issue Type: Improvement >Reporter: Kevin Ratnasekera >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > It seem version 3 based releases [1] have been there for a while, we should > upgrade from 2.2.22. > [1] https://orientdb.com/releases/ -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GORA-651) Upgrade OrientDB to the latest version 3
[ https://issues.apache.org/jira/browse/GORA-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440902#comment-17440902 ] ASF GitHub Bot commented on GORA-651: - nbrendah edited a comment on pull request #249: URL: https://github.com/apache/gora/pull/249#issuecomment-963811996 Hello @djkevincr @lewismc May you please kindly take a look at this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade OrientDB to the latest version 3 > > > Key: GORA-651 > URL: https://issues.apache.org/jira/browse/GORA-651 > Project: Apache Gora > Issue Type: Improvement >Reporter: Kevin Ratnasekera >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > It seem version 3 based releases [1] have been there for a while, we should > upgrade from 2.2.22. > [1] https://orientdb.com/releases/ -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GORA-276) Refactor and organize o.a.g.mapreduce package naming
[ https://issues.apache.org/jira/browse/GORA-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440840#comment-17440840 ] ASF GitHub Bot commented on GORA-276: - nbrendah commented on pull request #251: URL: https://github.com/apache/gora/pull/251#issuecomment-963728763 I had to send an empty commit to re-run the build. I guess it passes and we continue with our discussion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Refactor and organize o.a.g.mapreduce package naming > > > Key: GORA-276 > URL: https://issues.apache.org/jira/browse/GORA-276 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core >Affects Versions: 0.3 >Reporter: Lewis John McGibbney >Priority: Major > Fix For: 1.0 > > > In Hadoop serialization-related classes and interfaces go into a package > structure of org.apache.hadoop.io.serializer whilst in Gora we currently > store everything under org.apache.gora.mapreduce > The Gora mapreduce package contains material which I think should be placed > into a new org.apache.gora.io.serializer package this way the API will be > clearer if we wish to extend this in the future. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GORA-537) Upgrade to Hadoop 3.X
[ https://issues.apache.org/jira/browse/GORA-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440839#comment-17440839 ] ASF GitHub Bot commented on GORA-537: - nbrendah commented on pull request #248: URL: https://github.com/apache/gora/pull/248#issuecomment-963721790 @lewismc @djkevincr Based on the dependence requirements at https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-common/dependency-analysis.html, I thought it would be important to upgrade org.eclipse.jetty to `9.4.40.v20210413` My local instance is still having errors on building with maven. I have reset it to `upstream/master` and pulled the latest changes but keep on getting errors. As far as I know, if it passes on upstream, it must pass locally unless there is some initial developers' setup task I haven't finished yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade to Hadoop 3.X > - > > Key: GORA-537 > URL: https://issues.apache.org/jira/browse/GORA-537 > Project: Apache Gora > Issue Type: Improvement > Components: build process >Reporter: Lewis John McGibbney >Priority: Major > Fix For: 1.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Hadoop 3 has been out for some time, we should consider upgrading. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GORA-276) Refactor and organize o.a.g.mapreduce package naming
[ https://issues.apache.org/jira/browse/GORA-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440810#comment-17440810 ] ASF GitHub Bot commented on GORA-276: - nbrendah commented on pull request #251: URL: https://github.com/apache/gora/pull/251#issuecomment-963651500 Sorry @lewismc for taking long without replying to this. I was finishing my outreachy application > This patch introduces a major API break... so we need to think about how clients will address that. @lewismc @djkevincr Should we create documentation to show this change or I close this because negative results outweigh the positive? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Refactor and organize o.a.g.mapreduce package naming > > > Key: GORA-276 > URL: https://issues.apache.org/jira/browse/GORA-276 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core >Affects Versions: 0.3 >Reporter: Lewis John McGibbney >Priority: Major > Fix For: 1.0 > > > In Hadoop serialization-related classes and interfaces go into a package > structure of org.apache.hadoop.io.serializer whilst in Gora we currently > store everything under org.apache.gora.mapreduce > The Gora mapreduce package contains material which I think should be placed > into a new org.apache.gora.io.serializer package this way the API will be > clearer if we wish to extend this in the future. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GORA-276) Refactor and organize o.a.g.mapreduce package naming
[ https://issues.apache.org/jira/browse/GORA-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438480#comment-17438480 ] ASF GitHub Bot commented on GORA-276: - lewismc commented on pull request #251: URL: https://github.com/apache/gora/pull/251#issuecomment-960458329 This is a real blast from the past @nbrendah This patch introduces a major API break... so we need to think about how clients will address that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Refactor and organize o.a.g.mapreduce package naming > > > Key: GORA-276 > URL: https://issues.apache.org/jira/browse/GORA-276 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core >Affects Versions: 0.3 >Reporter: Lewis John McGibbney >Priority: Major > Fix For: 1.0 > > > In Hadoop serialization-related classes and interfaces go into a package > structure of org.apache.hadoop.io.serializer whilst in Gora we currently > store everything under org.apache.gora.mapreduce > The Gora mapreduce package contains material which I think should be placed > into a new org.apache.gora.io.serializer package this way the API will be > clearer if we wish to extend this in the future. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-537) Upgrade to Hadoop 3.X
[ https://issues.apache.org/jira/browse/GORA-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437617#comment-17437617 ] ASF GitHub Bot commented on GORA-537: - nbrendah commented on pull request #248: URL: https://github.com/apache/gora/pull/248#issuecomment-958180480 Its so nice to here form you @djkevincr I will add tests for this in 8 hours time Thank you so much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade to Hadoop 3.X > - > > Key: GORA-537 > URL: https://issues.apache.org/jira/browse/GORA-537 > Project: Apache Gora > Issue Type: Improvement > Components: build process >Reporter: Lewis John McGibbney >Priority: Major > Fix For: 1.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Hadoop 3 has been out for some time, we should consider upgrading. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-537) Upgrade to Hadoop 3.X
[ https://issues.apache.org/jira/browse/GORA-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437610#comment-17437610 ] ASF GitHub Bot commented on GORA-537: - djkevincr commented on pull request #248: URL: https://github.com/apache/gora/pull/248#issuecomment-958088664 @nbrendah Thank you for the PR. There s already PR raised for the issue in https://github.com/apache/gora/pull/220 Basically this is basically a major version upgrade, probably there can API changes, please check all the test cases passes with the version upgrade. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade to Hadoop 3.X > - > > Key: GORA-537 > URL: https://issues.apache.org/jira/browse/GORA-537 > Project: Apache Gora > Issue Type: Improvement > Components: build process >Reporter: Lewis John McGibbney >Priority: Major > Fix For: 1.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Hadoop 3 has been out for some time, we should consider upgrading. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-630) Move hadoop-common dependencies from gora-hive pom to gora parent pom
[ https://issues.apache.org/jira/browse/GORA-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437609#comment-17437609 ] ASF GitHub Bot commented on GORA-630: - djkevincr commented on pull request #250: URL: https://github.com/apache/gora/pull/250#issuecomment-958079050 @khadijm Thank you for the PR. we basically had transitive dependency issue where the same jar exists multiple versions in class path that made a build failure. Please do full build using mvn clean install and see whether there s build failure when running tests. And see how can avoid this particular dependency conflict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Move hadoop-common dependencies from gora-hive pom to gora parent pom > - > > Key: GORA-630 > URL: https://issues.apache.org/jira/browse/GORA-630 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core, gora-hive >Reporter: Chanaka Balasooriya >Priority: Minor > > To run hive datastore test cases it is required to have hadoop-common 2.6+ > version. > However, adding this dependency gora parent causes to fail some test cases in > gora-core > as the current hadoop version is 2.5.2 We need to handle this transitive > dependency issue properly. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-651) Upgrade OrientDB to the latest version 3
[ https://issues.apache.org/jira/browse/GORA-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437605#comment-17437605 ] ASF GitHub Bot commented on GORA-651: - djkevincr commented on pull request #249: URL: https://github.com/apache/gora/pull/249#issuecomment-958083777 @nbrendah Thank you for the PR. This is main version upgrade and you will probably have compilation errors due to API changes. Please execute tests using mvn clean install and see how you can upgrade API to new version and the same time check whether all tests pass for orientdb store. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade OrientDB to the latest version 3 > > > Key: GORA-651 > URL: https://issues.apache.org/jira/browse/GORA-651 > Project: Apache Gora > Issue Type: Improvement >Reporter: Kevin Ratnasekera >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > It seem version 3 based releases [1] have been there for a while, we should > upgrade from 2.2.22. > [1] https://orientdb.com/releases/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-537) Upgrade to Hadoop 3.X
[ https://issues.apache.org/jira/browse/GORA-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437544#comment-17437544 ] ASF GitHub Bot commented on GORA-537: - djkevincr commented on pull request #248: URL: https://github.com/apache/gora/pull/248#issuecomment-958088664 @nbrendah Thank you for the PR. There s already PR raised for the issue in https://github.com/apache/gora/pull/220 Basically this is basically a major version upgrade, probably there can API changes, please check all the test cases passes with the version upgrade. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade to Hadoop 3.X > - > > Key: GORA-537 > URL: https://issues.apache.org/jira/browse/GORA-537 > Project: Apache Gora > Issue Type: Improvement > Components: build process >Reporter: Lewis John McGibbney >Priority: Major > Fix For: 1.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Hadoop 3 has been out for some time, we should consider upgrading. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-651) Upgrade OrientDB to the latest version 3
[ https://issues.apache.org/jira/browse/GORA-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437542#comment-17437542 ] ASF GitHub Bot commented on GORA-651: - djkevincr commented on pull request #249: URL: https://github.com/apache/gora/pull/249#issuecomment-958083777 @nbrendah Thank you for the PR. This is main version upgrade and you will probably have compilation errors due to API changes. Please execute tests using mvn clean install and see how you can upgrade API to new version and the same time check whether all tests pass for orientdb store. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade OrientDB to the latest version 3 > > > Key: GORA-651 > URL: https://issues.apache.org/jira/browse/GORA-651 > Project: Apache Gora > Issue Type: Improvement >Reporter: Kevin Ratnasekera >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > It seem version 3 based releases [1] have been there for a while, we should > upgrade from 2.2.22. > [1] https://orientdb.com/releases/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-630) Move hadoop-common dependencies from gora-hive pom to gora parent pom
[ https://issues.apache.org/jira/browse/GORA-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437541#comment-17437541 ] ASF GitHub Bot commented on GORA-630: - djkevincr commented on pull request #250: URL: https://github.com/apache/gora/pull/250#issuecomment-958079050 @khadijm Thank you for the PR. we basically had transitive dependency issue where the same jar exists multiple versions in class path that made a build failure. Please do full build using mvn clean install and see whether there s build failure when running tests. And see how can avoid this particular dependency conflict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Move hadoop-common dependencies from gora-hive pom to gora parent pom > - > > Key: GORA-630 > URL: https://issues.apache.org/jira/browse/GORA-630 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core, gora-hive >Reporter: Chanaka Balasooriya >Priority: Minor > > To run hive datastore test cases it is required to have hadoop-common 2.6+ > version. > However, adding this dependency gora parent causes to fail some test cases in > gora-core > as the current hadoop version is 2.5.2 We need to handle this transitive > dependency issue properly. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-276) Refactor and organize o.a.g.mapreduce package naming
[ https://issues.apache.org/jira/browse/GORA-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435724#comment-17435724 ] ASF GitHub Bot commented on GORA-276: - nbrendah edited a comment on pull request #251: URL: https://github.com/apache/gora/pull/251#issuecomment-954303920 > Yeah I saw that and I tried to fix it. @lewismc I saw your current commit https://github.com/apache/gora/commit/44ecabb241201c37f94ade36806b2070eca0144c . It was passing build, though failing with sonar scanners. However, most of these builds pass locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Refactor and organize o.a.g.mapreduce package naming > > > Key: GORA-276 > URL: https://issues.apache.org/jira/browse/GORA-276 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core >Affects Versions: 0.3 >Reporter: Lewis John McGibbney >Priority: Major > Fix For: 1.0 > > > In Hadoop serialization-related classes and interfaces go into a package > structure of org.apache.hadoop.io.serializer whilst in Gora we currently > store everything under org.apache.gora.mapreduce > The Gora mapreduce package contains material which I think should be placed > into a new org.apache.gora.io.serializer package this way the API will be > clearer if we wish to extend this in the future. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-276) Refactor and organize o.a.g.mapreduce package naming
[ https://issues.apache.org/jira/browse/GORA-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435723#comment-17435723 ] ASF GitHub Bot commented on GORA-276: - nbrendah commented on pull request #251: URL: https://github.com/apache/gora/pull/251#issuecomment-954303920 > Yeah I saw that and I tried to fix it. @lewismc I saw your current build. It was passing build, though failing with sonar scanners. However, most of these builds pass locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Refactor and organize o.a.g.mapreduce package naming > > > Key: GORA-276 > URL: https://issues.apache.org/jira/browse/GORA-276 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core >Affects Versions: 0.3 >Reporter: Lewis John McGibbney >Priority: Major > Fix For: 1.0 > > > In Hadoop serialization-related classes and interfaces go into a package > structure of org.apache.hadoop.io.serializer whilst in Gora we currently > store everything under org.apache.gora.mapreduce > The Gora mapreduce package contains material which I think should be placed > into a new org.apache.gora.io.serializer package this way the API will be > clearer if we wish to extend this in the future. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-276) Refactor and organize o.a.g.mapreduce package naming
[ https://issues.apache.org/jira/browse/GORA-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435721#comment-17435721 ] ASF GitHub Bot commented on GORA-276: - lewismc commented on pull request #251: URL: https://github.com/apache/gora/pull/251#issuecomment-954302442 Yeah I saw that and I tried to fix it. @djkevincr do you know when the Github Actions build started failing? I did see https://github.com/actions/first-interaction/issues/10#issuecomment-910605074 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Refactor and organize o.a.g.mapreduce package naming > > > Key: GORA-276 > URL: https://issues.apache.org/jira/browse/GORA-276 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core >Affects Versions: 0.3 >Reporter: Lewis John McGibbney >Priority: Major > Fix For: 1.0 > > > In Hadoop serialization-related classes and interfaces go into a package > structure of org.apache.hadoop.io.serializer whilst in Gora we currently > store everything under org.apache.gora.mapreduce > The Gora mapreduce package contains material which I think should be placed > into a new org.apache.gora.io.serializer package this way the API will be > clearer if we wish to extend this in the future. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-276) Refactor and organize o.a.g.mapreduce package naming
[ https://issues.apache.org/jira/browse/GORA-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435674#comment-17435674 ] ASF GitHub Bot commented on GORA-276: - nbrendah edited a comment on pull request #251: URL: https://github.com/apache/gora/pull/251#issuecomment-954249750 My PR is failing. @lewismc, what is the cause of ``` Going to parse results form **/*-reports/TEST-*.xml Result: 1352 tests run, 29 skipped, 0 failed. Posting status 'completed' with conclusion 'success' to https://github.com/apache/gora/pull/251 (sha: 07293dc17249838fb781c01ca624318f4b29917e) Error: Resource not accessible by integration ```  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Refactor and organize o.a.g.mapreduce package naming > > > Key: GORA-276 > URL: https://issues.apache.org/jira/browse/GORA-276 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core >Affects Versions: 0.3 >Reporter: Lewis John McGibbney >Priority: Major > Fix For: 1.0 > > > In Hadoop serialization-related classes and interfaces go into a package > structure of org.apache.hadoop.io.serializer whilst in Gora we currently > store everything under org.apache.gora.mapreduce > The Gora mapreduce package contains material which I think should be placed > into a new org.apache.gora.io.serializer package this way the API will be > clearer if we wish to extend this in the future. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-276) Refactor and organize o.a.g.mapreduce package naming
[ https://issues.apache.org/jira/browse/GORA-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435673#comment-17435673 ] ASF GitHub Bot commented on GORA-276: - nbrendah commented on pull request #251: URL: https://github.com/apache/gora/pull/251#issuecomment-954249750 My PR is failing. What is the meaning of ``` Going to parse results form **/*-reports/TEST-*.xml Result: 1352 tests run, 29 skipped, 0 failed. Posting status 'completed' with conclusion 'success' to https://github.com/apache/gora/pull/251 (sha: 07293dc17249838fb781c01ca624318f4b29917e) Error: Resource not accessible by integration ```  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Refactor and organize o.a.g.mapreduce package naming > > > Key: GORA-276 > URL: https://issues.apache.org/jira/browse/GORA-276 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core >Affects Versions: 0.3 >Reporter: Lewis John McGibbney >Priority: Major > Fix For: 1.0 > > > In Hadoop serialization-related classes and interfaces go into a package > structure of org.apache.hadoop.io.serializer whilst in Gora we currently > store everything under org.apache.gora.mapreduce > The Gora mapreduce package contains material which I think should be placed > into a new org.apache.gora.io.serializer package this way the API will be > clearer if we wish to extend this in the future. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-276) Refactor and organize o.a.g.mapreduce package naming
[ https://issues.apache.org/jira/browse/GORA-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17434626#comment-17434626 ] ASF GitHub Bot commented on GORA-276: - nbrendah opened a new pull request #251: URL: https://github.com/apache/gora/pull/251 Issue Link: https://issues.apache.org/jira/browse/GORA-276 Migrated classes in package `org.apache.gora.mapreduce` to org.apache.gora.io.serializer cc @djkevincr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Refactor and organize o.a.g.mapreduce package naming > > > Key: GORA-276 > URL: https://issues.apache.org/jira/browse/GORA-276 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core >Affects Versions: 0.3 >Reporter: Lewis John McGibbney >Priority: Major > Fix For: 1.0 > > > In Hadoop serialization-related classes and interfaces go into a package > structure of org.apache.hadoop.io.serializer whilst in Gora we currently > store everything under org.apache.gora.mapreduce > The Gora mapreduce package contains material which I think should be placed > into a new org.apache.gora.io.serializer package this way the API will be > clearer if we wish to extend this in the future. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-630) Move hadoop-common dependencies from gora-hive pom to gora parent pom
[ https://issues.apache.org/jira/browse/GORA-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433180#comment-17433180 ] ASF GitHub Bot commented on GORA-630: - khadijm commented on pull request #250: URL: https://github.com/apache/gora/pull/250#issuecomment-950010559 this is the first step after that i will be able to move to junit test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Move hadoop-common dependencies from gora-hive pom to gora parent pom > - > > Key: GORA-630 > URL: https://issues.apache.org/jira/browse/GORA-630 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core, gora-hive >Reporter: Chanaka Balasooriya >Priority: Minor > > To run hive datastore test cases it is required to have hadoop-common 2.6+ > version. > However, adding this dependency gora parent causes to fail some test cases in > gora-core > as the current hadoop version is 2.5.2 We need to handle this transitive > dependency issue properly. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-630) Move hadoop-common dependencies from gora-hive pom to gora parent pom
[ https://issues.apache.org/jira/browse/GORA-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433178#comment-17433178 ] ASF GitHub Bot commented on GORA-630: - khadijm opened a new pull request #250: URL: https://github.com/apache/gora/pull/250 as describe here https://issues.apache.org/jira/browse/GORA-630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Move hadoop-common dependencies from gora-hive pom to gora parent pom > - > > Key: GORA-630 > URL: https://issues.apache.org/jira/browse/GORA-630 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core, gora-hive >Reporter: Chanaka Balasooriya >Priority: Minor > > To run hive datastore test cases it is required to have hadoop-common 2.6+ > version. > However, adding this dependency gora parent causes to fail some test cases in > gora-core > as the current hadoop version is 2.5.2 We need to handle this transitive > dependency issue properly. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-651) Upgrade OrientDB to the latest version 3
[ https://issues.apache.org/jira/browse/GORA-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430486#comment-17430486 ] ASF GitHub Bot commented on GORA-651: - nbrendah opened a new pull request #249: URL: https://github.com/apache/gora/pull/249 **Issue Link:** https://issues.apache.org/jira/browse/GORA-651 I have updated upgraded the version of OrientDB to 3.2.2 All tests are passing locally. Maybe it could on the upstream. cc @djkevincr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade OrientDB to the latest version 3 > > > Key: GORA-651 > URL: https://issues.apache.org/jira/browse/GORA-651 > Project: Apache Gora > Issue Type: Improvement >Reporter: Kevin Ratnasekera >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > It seem version 3 based releases [1] have been there for a while, we should > upgrade from 2.2.22. > [1] https://orientdb.com/releases/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-537) Upgrade to Hadoop 3.X
[ https://issues.apache.org/jira/browse/GORA-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427569#comment-17427569 ] ASF GitHub Bot commented on GORA-537: - nbrendah opened a new pull request #248: URL: https://github.com/apache/gora/pull/248 This PR is raised in reaction to issue https://issues.apache.org/jira/browse/GORA-537 Some tests are still failing though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade to Hadoop 3.X > - > > Key: GORA-537 > URL: https://issues.apache.org/jira/browse/GORA-537 > Project: Apache Gora > Issue Type: Improvement > Components: build process >Reporter: Lewis John McGibbney >Priority: Major > Fix For: 1.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Hadoop 3 has been out for some time, we should consider upgrading. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-677) Upgrade Java Driver Ignite version to 2.10.0
[ https://issues.apache.org/jira/browse/GORA-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17397629#comment-17397629 ] ASF GitHub Bot commented on GORA-677: - madhawa-gunasekara merged pull request #238: URL: https://github.com/apache/gora/pull/238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade Java Driver Ignite version to 2.10.0 > > > Key: GORA-677 > URL: https://issues.apache.org/jira/browse/GORA-677 > Project: Apache Gora > Issue Type: Improvement > Components: testing >Affects Versions: 0.9 >Reporter: Mohamed Infaz >Priority: Major > Fix For: 1.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Upgrade Java Driver Ignite version to 2.10.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-678) Upgrade to JDK11
[
https://issues.apache.org/jira/browse/GORA-678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17397626#comment-17397626
]
ASF GitHub Bot commented on GORA-678:
-
djkevincr commented on pull request #240:
URL: https://github.com/apache/gora/pull/240#issuecomment-897133583
@lewismc Initial work looks great. Any update on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Upgrade to JDK11
>
>
> Key: GORA-678
> URL: https://issues.apache.org/jira/browse/GORA-678
> Project: Apache Gora
> Issue Type: Improvement
> Components: build process
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Major
> Fix For: 1.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Context is at the following mailing list thread
> https://lists.apache.org/list.html?dev@gora.apache.org
> I cannot build Gora under the following environment
> {code:bash}
> Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3;
> 2018-10-24T11:41:47-07:00)
> Maven home: /usr/local/Cellar/maven/3.6.0/libexec
> Java version: 11.0.10, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk-11.0.10.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.15.7", arch: "x86_64", family: "mac"
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GORA-680) Upgrade Avro from 1.8.2 --> 1.10.2
[ https://issues.apache.org/jira/browse/GORA-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17397625#comment-17397625 ] ASF GitHub Bot commented on GORA-680: - djkevincr commented on pull request #244: URL: https://github.com/apache/gora/pull/244#issuecomment-897132355 @lewismc Initial work looks great. Any update on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade Avro from 1.8.2 --> 1.10.2 > -- > > Key: GORA-680 > URL: https://issues.apache.org/jira/browse/GORA-680 > Project: Apache Gora > Issue Type: Improvement > Components: build process, gora-core >Reporter: Lewis John McGibbney >Priority: Critical > Fix For: 1.0 > > > Avro is a critical dependency in Gora. We should keep this dependency > uo-to-date with the Avro project releases so we do not diverge too much. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-664) Add datastore for Elasticsearch
[ https://issues.apache.org/jira/browse/GORA-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17397558#comment-17397558 ] ASF GitHub Bot commented on GORA-664: - djkevincr merged pull request #247: URL: https://github.com/apache/gora/pull/247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add datastore for Elasticsearch > --- > > Key: GORA-664 > URL: https://issues.apache.org/jira/browse/GORA-664 > Project: Apache Gora > Issue Type: New Feature >Reporter: Carlos Muñoz >Assignee: Mariia Podorvanova >Priority: Major > Labels: outreachy2020 > Time Spent: 10m > Remaining Estimate: 0h > > Elasticsearch is a Lucene-based search engine that primarily focuses on > distribution and availability. It could be a good alternative for the > gora-solr module. > > [https://www.elastic.co/guide/en/elasticsearch/reference/current/index.html] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-664) Add datastore for Elasticsearch
[ https://issues.apache.org/jira/browse/GORA-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17397536#comment-17397536 ] ASF GitHub Bot commented on GORA-664: - djkevincr merged pull request #234: URL: https://github.com/apache/gora/pull/234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add datastore for Elasticsearch > --- > > Key: GORA-664 > URL: https://issues.apache.org/jira/browse/GORA-664 > Project: Apache Gora > Issue Type: New Feature >Reporter: Carlos Muñoz >Assignee: Mariia Podorvanova >Priority: Major > Labels: outreachy2020 > Time Spent: 10m > Remaining Estimate: 0h > > Elasticsearch is a Lucene-based search engine that primarily focuses on > distribution and availability. It could be a good alternative for the > gora-solr module. > > [https://www.elastic.co/guide/en/elasticsearch/reference/current/index.html] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-677) Upgrade Java Driver Ignite version to 2.10.0
[ https://issues.apache.org/jira/browse/GORA-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17358131#comment-17358131 ] ASF GitHub Bot commented on GORA-677: - madhawa-gunasekara commented on pull request #238: URL: https://github.com/apache/gora/pull/238#issuecomment-855409797 Thanks, @100202x for the pull request -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade Java Driver Ignite version to 2.10.0 > > > Key: GORA-677 > URL: https://issues.apache.org/jira/browse/GORA-677 > Project: Apache Gora > Issue Type: Improvement > Components: testing >Affects Versions: 0.9 >Reporter: Mohamed Infaz >Priority: Major > Fix For: 1.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Upgrade Java Driver Ignite version to 2.10.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-676) Upgrade Aerospike Java Driver to 5.0.6
[ https://issues.apache.org/jira/browse/GORA-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17358127#comment-17358127 ] ASF GitHub Bot commented on GORA-676: - madhawa-gunasekara merged pull request #237: URL: https://github.com/apache/gora/pull/237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade Aerospike Java Driver to 5.0.6 > -- > > Key: GORA-676 > URL: https://issues.apache.org/jira/browse/GORA-676 > Project: Apache Gora > Issue Type: Improvement > Components: gora-aerospike >Affects Versions: 0.9 >Reporter: Mohamed Infaz >Priority: Minor > Fix For: 1.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Upgrading Aerospike java driver version to 5.0.6 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-676) Upgrade Aerospike Java Driver to 5.0.6
[ https://issues.apache.org/jira/browse/GORA-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17358126#comment-17358126 ] ASF GitHub Bot commented on GORA-676: - madhawa-gunasekara commented on pull request #237: URL: https://github.com/apache/gora/pull/237#issuecomment-855409178 Thanks, @100202x for the contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade Aerospike Java Driver to 5.0.6 > -- > > Key: GORA-676 > URL: https://issues.apache.org/jira/browse/GORA-676 > Project: Apache Gora > Issue Type: Improvement > Components: gora-aerospike >Affects Versions: 0.9 >Reporter: Mohamed Infaz >Priority: Minor > Fix For: 1.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Upgrading Aerospike java driver version to 5.0.6 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-679) Restlet JARs and third party dependencies aren’t available in the main public Maven repository
[
https://issues.apache.org/jira/browse/GORA-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357937#comment-17357937
]
ASF GitHub Bot commented on GORA-679:
-
lewismc merged pull request #242:
URL: https://github.com/apache/gora/pull/242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Restlet JARs and third party dependencies aren’t available in the main public
> Maven repository
> --
>
> Key: GORA-679
> URL: https://issues.apache.org/jira/browse/GORA-679
> Project: Apache Gora
> Issue Type: Improvement
> Components: build process
>Affects Versions: 0.9
>Reporter: Lewis John McGibbney
>Priority: Blocker
> Fix For: 1.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The CI process complains about the following issue which ultimately fails the
> builds
> {code:bash}
> Error: Failed to execute goal on project gora-solr: Could not resolve
> dependencies for project org.apache.gora:gora-solr:bundle:1.0-SNAPSHOT:
> Failed to collect dependencies at org.apache.solr:solr-core:jar:8.0.0 ->
> org.restlet.jee:org.restlet:jar:2.3.1: Failed to read artifact descriptor for
> org.restlet.jee:org.restlet:jar:2.3.1: Could not transfer artifact
> org.restlet.jee:org.restlet:pom:2.3.1 from/to maven-default-http-blocker
> (http://0.0.0.0/): Blocked mirror for repositories: [maven-restlet
> (http://maven.restlet.org, default, releases+snapshots), apache.snapshots
> (http://repository.apache.org/snapshots, default, disabled)] -> [Help 1]
> {code}
> I took at look at the [Restlet
> website|https://restlet.talend.com/downloads/current/] and discovered the
> following
> {quote}The Maven repository for Restlet is accessible from
> https://maven.restlet.talend.com and contains all Restlet JARs and third
> party dependencies that aren’t available in the main public Maven repository.
> It is automatically refreshed once a day if the build succeeds.{quote}
> So it looks like we need to update the Maven configuration to accommodate the
> change...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GORA-664) Add datastore for Elasticsearch
[ https://issues.apache.org/jira/browse/GORA-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347303#comment-17347303 ] ASF GitHub Bot commented on GORA-664: - podorvanova commented on pull request #234: URL: https://github.com/apache/gora/pull/234#issuecomment-843754824 Thanks @kamaci for your feedback! I have updated the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add datastore for Elasticsearch > --- > > Key: GORA-664 > URL: https://issues.apache.org/jira/browse/GORA-664 > Project: Apache Gora > Issue Type: New Feature >Reporter: Carlos Muñoz >Assignee: Mariia Podorvanova >Priority: Major > Labels: outreachy2020 > Time Spent: 10m > Remaining Estimate: 0h > > Elasticsearch is a Lucene-based search engine that primarily focuses on > distribution and availability. It could be a good alternative for the > gora-solr module. > > [https://www.elastic.co/guide/en/elasticsearch/reference/current/index.html] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-537) Upgrade to Hadoop 3.X
[ https://issues.apache.org/jira/browse/GORA-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17345002#comment-17345002 ] ASF GitHub Bot commented on GORA-537: - balashashanka commented on pull request #220: URL: https://github.com/apache/gora/pull/220#issuecomment-841627206 Hi @kamaci, will take a look at it now. There were few internal dependencies which we might need to upgrade will push new changes in some time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade to Hadoop 3.X > - > > Key: GORA-537 > URL: https://issues.apache.org/jira/browse/GORA-537 > Project: Apache Gora > Issue Type: Improvement > Components: build process >Reporter: Lewis John McGibbney >Priority: Major > Fix For: 1.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Hadoop 3 has been out for some time, we should consider upgrading. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-464) Get gora-dynamodb back up and running and available as part of the examples
[ https://issues.apache.org/jira/browse/GORA-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344776#comment-17344776 ] ASF GitHub Bot commented on GORA-464: - kamaci commented on a change in pull request #189: URL: https://github.com/apache/gora/pull/189#discussion_r632682377 ## File path: gora-dynamodb/howto_upgrade.md ## @@ -0,0 +1,19 @@ +# Howto upgrade aaws-java-sdk version Review comment: Typo, aaws-java-sdk version -> aws-java-sdk version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Get gora-dynamodb back up and running and available as part of the examples > --- > > Key: GORA-464 > URL: https://issues.apache.org/jira/browse/GORA-464 > Project: Apache Gora > Issue Type: Task > Components: gora-dynamodb >Affects Versions: 0.6.1 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Major > Fix For: 1.0 > > Time Spent: 50m > Remaining Estimate: 0h > > We have had the DynamoDB module commented out for a wee while now and it > would be nice to get it brought bang up to date within the 1.0 development > cycle. > [~renato2099] tagging you for context as I know this is your baby :) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-651) Upgrade OrientDB to the latest version 3
[
https://issues.apache.org/jira/browse/GORA-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344772#comment-17344772
]
ASF GitHub Bot commented on GORA-651:
-
kamaci commented on a change in pull request #210:
URL: https://github.com/apache/gora/pull/210#discussion_r632680001
##
File path:
gora-orientdb/src/main/java/org/apache/gora/orientdb/store/OrientDBStore.java
##
@@ -103,20 +109,36 @@ public void initialize(Class keyClass, Class
persistentClass, Properties p
ROOT_URL =
"remote:".concat(orientDbStoreParams.getServerHost()).concat(":")
.concat(orientDbStoreParams.getServerPort());
ROOT_DATABASE_URL =
ROOT_URL.concat("/").concat(orientDbStoreParams.getDatabaseName());
- remoteServerAdmin = new
OServerAdmin(ROOT_URL).connect(orientDbStoreParams.getUserName(),
- orientDbStoreParams.getUserPassword());
- if
(!remoteServerAdmin.existsDatabase(orientDbStoreParams.getDatabaseName(),
"memory")) {
-
remoteServerAdmin.createDatabase(orientDbStoreParams.getDatabaseName(),
"document", "memory");
- }
-
- if (orientDbStoreParams.getConnectionPoolSize() != null) {
-int connPoolSize =
Integer.valueOf(orientDbStoreParams.getConnectionPoolSize());
-connectionPool = new OPartitionedDatabasePoolFactory(connPoolSize)
-.get(ROOT_DATABASE_URL, orientDbStoreParams.getUserName(),
-orientDbStoreParams.getUserPassword());
+ remoteServerAdmin = new OrientDB(ROOT_URL,
orientDbStoreParams.getUserName(),
+ orientDbStoreParams.getUserPassword(),
OrientDBConfig.defaultConfig());
+ if (!remoteServerAdmin.exists(orientDbStoreParams.getDatabaseName())) {
+remoteServerAdmin.create(orientDbStoreParams.getDatabaseName(),
+
ODatabaseType.valueOf(orientDbStoreParams.getStorageType().toUpperCase()));
Review comment:
Please pass `Locale.ENGLISH` to `toUpperCase`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Upgrade OrientDB to the latest version 3
>
>
> Key: GORA-651
> URL: https://issues.apache.org/jira/browse/GORA-651
> Project: Apache Gora
> Issue Type: Improvement
>Reporter: Kevin Ratnasekera
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> It seem version 3 based releases [1] have been there for a while, we should
> upgrade from 2.2.22.
> [1] https://orientdb.com/releases/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GORA-650) Add datastore for ArangoDB
[ https://issues.apache.org/jira/browse/GORA-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344740#comment-17344740 ] ASF GitHub Bot commented on GORA-650: - kamaci commented on pull request #218: URL: https://github.com/apache/gora/pull/218#issuecomment-841386840 Thanks @dinuka-perera! Please review my comments and resolve the conflict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add datastore for ArangoDB > -- > > Key: GORA-650 > URL: https://issues.apache.org/jira/browse/GORA-650 > Project: Apache Gora > Issue Type: New Feature >Affects Versions: 0.9 >Reporter: Kevin Ratnasekera >Priority: Major > Labels: gsoc2020 > Time Spent: 0.5h > Remaining Estimate: 0h > > May be we should consider extending our multimodal datastore support with > ArangoDB. [1] > [1] https://www.arangodb.com/why-arangodb/multi-model/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-650) Add datastore for ArangoDB
[
https://issues.apache.org/jira/browse/GORA-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344738#comment-17344738
]
ASF GitHub Bot commented on GORA-650:
-
kamaci commented on a change in pull request #218:
URL: https://github.com/apache/gora/pull/218#discussion_r632677448
##
File path:
gora-arangodb/src/test/java/org/apache/gora/arangodb/ArangoDBTestDriver.java
##
@@ -0,0 +1,85 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.arangodb;
+
+import org.apache.gora.GoraTestDriver;
+import org.apache.gora.arangodb.store.ArangoDBStore;
+import org.apache.gora.arangodb.store.ArangoDBStoreParameters;
+import org.apache.gora.persistency.Persistent;
+import org.apache.gora.store.DataStore;
+import org.apache.gora.store.DataStoreFactory;
+import org.apache.gora.util.GoraException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.testcontainers.containers.GenericContainer;
+
+/**
+ * Driver to set up an embedded ArangoDB database instance for Gora
+ * dataStore specific integration tests.
+ */
+public class ArangoDBTestDriver extends GoraTestDriver {
+
+ private static Logger log =
LoggerFactory.getLogger(ArangoDBTestDriver.class);
+
+ private GenericContainer arangodbContainer;
+
+ public ArangoDBTestDriver(GenericContainer arangodbContainer) {
+super(ArangoDBStore.class);
+this.arangodbContainer = arangodbContainer;
+ }
+
+
+ public ArangoDBTestDriver() {
+super(ArangoDBStore.class);
+ }
+
+ /**
+ * Initialize embedded ArangoDB server instance as per the
gora-arangodb-mapping.xml
+ * server configuration file.
+ */
+ @Override
+ public void setUpClass() throws Exception {
+log.info("Setting up ArangoDB test driver");
+conf.set(ArangoDBStoreParameters.ARANGO_DB_SERVER_HOST, "localhost");
+conf.set(ArangoDBStoreParameters.ARANGO_DB_SERVER_PORT,
+arangodbContainer.getMappedPort(8529).toString());
+log.info("ArangoDB Embedded Server started successfully.");
+ }
+
+ /**
+ * Terminate embedded ArangoDB server.
+ */
+ @Override
+ public void tearDownClass() throws Exception {
+log.info("ArangoDB Embedded server instance terminated successfully.");
+ }
+
+ @Override
+ public DataStore createDataStore(Class
keyClass,
+ Class
persistentClass) throws GoraException {
+
Review comment:
Remove extra space
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add datastore for ArangoDB
> --
>
> Key: GORA-650
> URL: https://issues.apache.org/jira/browse/GORA-650
> Project: Apache Gora
> Issue Type: New Feature
>Affects Versions: 0.9
>Reporter: Kevin Ratnasekera
>Priority: Major
> Labels: gsoc2020
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> May be we should consider extending our multimodal datastore support with
> ArangoDB. [1]
> [1] https://www.arangodb.com/why-arangodb/multi-model/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GORA-650) Add datastore for ArangoDB
[
https://issues.apache.org/jira/browse/GORA-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344737#comment-17344737
]
ASF GitHub Bot commented on GORA-650:
-
kamaci commented on a change in pull request #218:
URL: https://github.com/apache/gora/pull/218#discussion_r632677158
##
File path:
gora-arangodb/src/main/java/org/apache/gora/arangodb/store/ArangoDBStore.java
##
@@ -0,0 +1,690 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.arangodb.store;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.Base64;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Properties;
+import java.util.List;
+import java.util.ArrayList;
+
+import com.arangodb.ArangoDB;
+import com.arangodb.entity.BaseDocument;
+import org.apache.avro.Schema;
+import org.apache.avro.util.Utf8;
+import org.apache.gora.arangodb.query.ArangoDBQuery;
+import org.apache.gora.persistency.impl.BeanFactoryImpl;
+import org.apache.gora.persistency.impl.DirtyListWrapper;
+import org.apache.gora.persistency.impl.DirtyMapWrapper;
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.query.PartitionQuery;
+import org.apache.gora.query.Query;
+import org.apache.gora.query.Result;
+import org.apache.gora.query.impl.PartitionQueryImpl;
+import org.apache.gora.store.impl.DataStoreBase;
+import org.apache.gora.util.AvroUtils;
+import org.apache.gora.util.ClassLoadingUtils;
+import org.apache.gora.util.GoraException;
+
+
+/**
+ * {@inheritDoc}
+ * {@link org.apache.gora.arangodb.store.ArangoDBStore} is the primary class
+ * responsible for facilitating GORA CRUD operations on ArangoDB documents.
+ */
+public class ArangoDBStore extends
DataStoreBase {
+
+ public static final String DEFAULT_MAPPING_FILE =
"/gora-arangodb-mapping.xml";
+ private ArangoDBStoreParameters arangoDbStoreParams;
+ private ArangoDBMapping arangoDBMapping;
+ private ArangoDB arangoDB;
+
+ /**
+ * {@inheritDoc}
+ * Initialize the ArangoDB dataStore by {@link Properties} parameters.
+ *
+ * @param keyClasskey class type for dataStore.
+ * @param persistentClass persistent class type for dataStore.
+ * @param properties ArangoDB dataStore properties EG:- ArangoDB client
credentials.
+ */
+ @Override
+ public void initialize(Class keyClass, Class persistentClass,
Properties properties) throws GoraException {
+super.initialize(keyClass, persistentClass, properties);
+try {
+ arangoDbStoreParams = ArangoDBStoreParameters.load(properties);
+ arangoDB = new ArangoDB.Builder()
+ .host(arangoDbStoreParams.getServerHost(),
+ Integer.valueOf(arangoDbStoreParams.getServerPort()))
+ .user(arangoDbStoreParams.getUserName())
+ .password(arangoDbStoreParams.getUserPassword())
+
.maxConnections(Integer.valueOf(arangoDbStoreParams.getConnectionPoolSize()))
+ .build();
+ if (!arangoDB.db(arangoDbStoreParams.getDatabaseName()).exists())
+arangoDB.createDatabase(arangoDbStoreParams.getDatabaseName());
+
+ ArangoDBMappingBuilder builder = new
ArangoDBMappingBuilder<>(this);
+ arangoDBMapping =
builder.fromFile(arangoDbStoreParams.getMappingFile()).build();
+ if (!schemaExists()) {
+createSchema();
+ }
+} catch (Exception e) {
+ LOG.error("Error while initializing ArangoDB dataStore: {}",
+ new Object[]{e.getMessage()});
+ throw new RuntimeException(e);
+}
+ }
+
+ /**
+ * {@inheritDoc}
+ */
+ @Override
+ public String getSchemaName(final String mappingSchemaName,
+ final Class persistentClass) {
+return super.getSchemaName(mappingSchemaName, persistentClass);
+ }
+
+ /**
+ * {@inheritDoc}
+ */
+ @Override
+ public String getSchemaName() {
+return arangoDBMapping.getDocumentClass();
+ }
+
+ /**
+ * {@inheritDoc}
+ * Create a new class of ArangoDB documents if necessary. Enforce specified
schema over the document class.
+ */
+ @Override
+ public void
[jira] [Commented] (GORA-650) Add datastore for ArangoDB
[
https://issues.apache.org/jira/browse/GORA-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344735#comment-17344735
]
ASF GitHub Bot commented on GORA-650:
-
kamaci commented on a change in pull request #218:
URL: https://github.com/apache/gora/pull/218#discussion_r632676903
##
File path:
gora-arangodb/src/main/java/org/apache/gora/arangodb/store/ArangoDBStore.java
##
@@ -0,0 +1,690 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.arangodb.store;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.Base64;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Properties;
+import java.util.List;
+import java.util.ArrayList;
+
+import com.arangodb.ArangoDB;
+import com.arangodb.entity.BaseDocument;
+import org.apache.avro.Schema;
+import org.apache.avro.util.Utf8;
+import org.apache.gora.arangodb.query.ArangoDBQuery;
+import org.apache.gora.persistency.impl.BeanFactoryImpl;
+import org.apache.gora.persistency.impl.DirtyListWrapper;
+import org.apache.gora.persistency.impl.DirtyMapWrapper;
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.query.PartitionQuery;
+import org.apache.gora.query.Query;
+import org.apache.gora.query.Result;
+import org.apache.gora.query.impl.PartitionQueryImpl;
+import org.apache.gora.store.impl.DataStoreBase;
+import org.apache.gora.util.AvroUtils;
+import org.apache.gora.util.ClassLoadingUtils;
+import org.apache.gora.util.GoraException;
+
+
+/**
+ * {@inheritDoc}
+ * {@link org.apache.gora.arangodb.store.ArangoDBStore} is the primary class
+ * responsible for facilitating GORA CRUD operations on ArangoDB documents.
+ */
+public class ArangoDBStore extends
DataStoreBase {
+
+ public static final String DEFAULT_MAPPING_FILE =
"/gora-arangodb-mapping.xml";
+ private ArangoDBStoreParameters arangoDbStoreParams;
+ private ArangoDBMapping arangoDBMapping;
+ private ArangoDB arangoDB;
+
+ /**
+ * {@inheritDoc}
+ * Initialize the ArangoDB dataStore by {@link Properties} parameters.
+ *
+ * @param keyClasskey class type for dataStore.
+ * @param persistentClass persistent class type for dataStore.
+ * @param properties ArangoDB dataStore properties EG:- ArangoDB client
credentials.
+ */
+ @Override
+ public void initialize(Class keyClass, Class persistentClass,
Properties properties) throws GoraException {
+super.initialize(keyClass, persistentClass, properties);
+try {
+ arangoDbStoreParams = ArangoDBStoreParameters.load(properties);
+ arangoDB = new ArangoDB.Builder()
+ .host(arangoDbStoreParams.getServerHost(),
+ Integer.valueOf(arangoDbStoreParams.getServerPort()))
+ .user(arangoDbStoreParams.getUserName())
+ .password(arangoDbStoreParams.getUserPassword())
+
.maxConnections(Integer.valueOf(arangoDbStoreParams.getConnectionPoolSize()))
+ .build();
+ if (!arangoDB.db(arangoDbStoreParams.getDatabaseName()).exists())
+arangoDB.createDatabase(arangoDbStoreParams.getDatabaseName());
+
+ ArangoDBMappingBuilder builder = new
ArangoDBMappingBuilder<>(this);
+ arangoDBMapping =
builder.fromFile(arangoDbStoreParams.getMappingFile()).build();
+ if (!schemaExists()) {
+createSchema();
+ }
+} catch (Exception e) {
+ LOG.error("Error while initializing ArangoDB dataStore: {}",
+ new Object[]{e.getMessage()});
+ throw new RuntimeException(e);
+}
+ }
+
+ /**
+ * {@inheritDoc}
+ */
+ @Override
+ public String getSchemaName(final String mappingSchemaName,
+ final Class persistentClass) {
+return super.getSchemaName(mappingSchemaName, persistentClass);
+ }
+
+ /**
+ * {@inheritDoc}
+ */
+ @Override
+ public String getSchemaName() {
+return arangoDBMapping.getDocumentClass();
+ }
+
+ /**
+ * {@inheritDoc}
+ * Create a new class of ArangoDB documents if necessary. Enforce specified
schema over the document class.
+ */
+ @Override
+ public void
[jira] [Commented] (GORA-650) Add datastore for ArangoDB
[
https://issues.apache.org/jira/browse/GORA-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344734#comment-17344734
]
ASF GitHub Bot commented on GORA-650:
-
kamaci commented on a change in pull request #218:
URL: https://github.com/apache/gora/pull/218#discussion_r632676232
##
File path:
gora-arangodb/src/main/java/org/apache/gora/arangodb/store/ArangoDBStore.java
##
@@ -0,0 +1,690 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.arangodb.store;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.Base64;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Properties;
+import java.util.List;
+import java.util.ArrayList;
+
+import com.arangodb.ArangoDB;
+import com.arangodb.entity.BaseDocument;
+import org.apache.avro.Schema;
+import org.apache.avro.util.Utf8;
+import org.apache.gora.arangodb.query.ArangoDBQuery;
+import org.apache.gora.persistency.impl.BeanFactoryImpl;
+import org.apache.gora.persistency.impl.DirtyListWrapper;
+import org.apache.gora.persistency.impl.DirtyMapWrapper;
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.query.PartitionQuery;
+import org.apache.gora.query.Query;
+import org.apache.gora.query.Result;
+import org.apache.gora.query.impl.PartitionQueryImpl;
+import org.apache.gora.store.impl.DataStoreBase;
+import org.apache.gora.util.AvroUtils;
+import org.apache.gora.util.ClassLoadingUtils;
+import org.apache.gora.util.GoraException;
+
+
+/**
+ * {@inheritDoc}
+ * {@link org.apache.gora.arangodb.store.ArangoDBStore} is the primary class
+ * responsible for facilitating GORA CRUD operations on ArangoDB documents.
+ */
+public class ArangoDBStore extends
DataStoreBase {
+
+ public static final String DEFAULT_MAPPING_FILE =
"/gora-arangodb-mapping.xml";
+ private ArangoDBStoreParameters arangoDbStoreParams;
+ private ArangoDBMapping arangoDBMapping;
+ private ArangoDB arangoDB;
+
+ /**
+ * {@inheritDoc}
+ * Initialize the ArangoDB dataStore by {@link Properties} parameters.
+ *
+ * @param keyClasskey class type for dataStore.
+ * @param persistentClass persistent class type for dataStore.
+ * @param properties ArangoDB dataStore properties EG:- ArangoDB client
credentials.
+ */
+ @Override
+ public void initialize(Class keyClass, Class persistentClass,
Properties properties) throws GoraException {
+super.initialize(keyClass, persistentClass, properties);
+try {
+ arangoDbStoreParams = ArangoDBStoreParameters.load(properties);
+ arangoDB = new ArangoDB.Builder()
+ .host(arangoDbStoreParams.getServerHost(),
+ Integer.valueOf(arangoDbStoreParams.getServerPort()))
+ .user(arangoDbStoreParams.getUserName())
+ .password(arangoDbStoreParams.getUserPassword())
+
.maxConnections(Integer.valueOf(arangoDbStoreParams.getConnectionPoolSize()))
+ .build();
+ if (!arangoDB.db(arangoDbStoreParams.getDatabaseName()).exists())
+arangoDB.createDatabase(arangoDbStoreParams.getDatabaseName());
+
+ ArangoDBMappingBuilder builder = new
ArangoDBMappingBuilder<>(this);
+ arangoDBMapping =
builder.fromFile(arangoDbStoreParams.getMappingFile()).build();
+ if (!schemaExists()) {
+createSchema();
+ }
+} catch (Exception e) {
+ LOG.error("Error while initializing ArangoDB dataStore: {}",
+ new Object[]{e.getMessage()});
+ throw new RuntimeException(e);
+}
+ }
+
+ /**
+ * {@inheritDoc}
+ */
+ @Override
+ public String getSchemaName(final String mappingSchemaName,
+ final Class persistentClass) {
+return super.getSchemaName(mappingSchemaName, persistentClass);
+ }
+
+ /**
+ * {@inheritDoc}
+ */
+ @Override
+ public String getSchemaName() {
+return arangoDBMapping.getDocumentClass();
+ }
+
+ /**
+ * {@inheritDoc}
+ * Create a new class of ArangoDB documents if necessary. Enforce specified
schema over the document class.
+ */
+ @Override
+ public void
[jira] [Commented] (GORA-650) Add datastore for ArangoDB
[
https://issues.apache.org/jira/browse/GORA-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344733#comment-17344733
]
ASF GitHub Bot commented on GORA-650:
-
kamaci commented on a change in pull request #218:
URL: https://github.com/apache/gora/pull/218#discussion_r632675878
##
File path:
gora-arangodb/src/main/java/org/apache/gora/arangodb/store/ArangoDBStore.java
##
@@ -0,0 +1,690 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.arangodb.store;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.Base64;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Properties;
+import java.util.List;
+import java.util.ArrayList;
+
+import com.arangodb.ArangoDB;
+import com.arangodb.entity.BaseDocument;
+import org.apache.avro.Schema;
+import org.apache.avro.util.Utf8;
+import org.apache.gora.arangodb.query.ArangoDBQuery;
+import org.apache.gora.persistency.impl.BeanFactoryImpl;
+import org.apache.gora.persistency.impl.DirtyListWrapper;
+import org.apache.gora.persistency.impl.DirtyMapWrapper;
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.query.PartitionQuery;
+import org.apache.gora.query.Query;
+import org.apache.gora.query.Result;
+import org.apache.gora.query.impl.PartitionQueryImpl;
+import org.apache.gora.store.impl.DataStoreBase;
+import org.apache.gora.util.AvroUtils;
+import org.apache.gora.util.ClassLoadingUtils;
+import org.apache.gora.util.GoraException;
+
+
+/**
+ * {@inheritDoc}
+ * {@link org.apache.gora.arangodb.store.ArangoDBStore} is the primary class
+ * responsible for facilitating GORA CRUD operations on ArangoDB documents.
+ */
+public class ArangoDBStore extends
DataStoreBase {
+
+ public static final String DEFAULT_MAPPING_FILE =
"/gora-arangodb-mapping.xml";
+ private ArangoDBStoreParameters arangoDbStoreParams;
+ private ArangoDBMapping arangoDBMapping;
+ private ArangoDB arangoDB;
+
+ /**
+ * {@inheritDoc}
+ * Initialize the ArangoDB dataStore by {@link Properties} parameters.
+ *
+ * @param keyClasskey class type for dataStore.
+ * @param persistentClass persistent class type for dataStore.
+ * @param properties ArangoDB dataStore properties EG:- ArangoDB client
credentials.
+ */
+ @Override
+ public void initialize(Class keyClass, Class persistentClass,
Properties properties) throws GoraException {
+super.initialize(keyClass, persistentClass, properties);
+try {
+ arangoDbStoreParams = ArangoDBStoreParameters.load(properties);
+ arangoDB = new ArangoDB.Builder()
+ .host(arangoDbStoreParams.getServerHost(),
+ Integer.valueOf(arangoDbStoreParams.getServerPort()))
+ .user(arangoDbStoreParams.getUserName())
+ .password(arangoDbStoreParams.getUserPassword())
+
.maxConnections(Integer.valueOf(arangoDbStoreParams.getConnectionPoolSize()))
+ .build();
+ if (!arangoDB.db(arangoDbStoreParams.getDatabaseName()).exists())
+arangoDB.createDatabase(arangoDbStoreParams.getDatabaseName());
+
+ ArangoDBMappingBuilder builder = new
ArangoDBMappingBuilder<>(this);
+ arangoDBMapping =
builder.fromFile(arangoDbStoreParams.getMappingFile()).build();
+ if (!schemaExists()) {
+createSchema();
+ }
+} catch (Exception e) {
+ LOG.error("Error while initializing ArangoDB dataStore: {}",
+ new Object[]{e.getMessage()});
+ throw new RuntimeException(e);
+}
+ }
+
+ /**
+ * {@inheritDoc}
+ */
+ @Override
+ public String getSchemaName(final String mappingSchemaName,
+ final Class persistentClass) {
+return super.getSchemaName(mappingSchemaName, persistentClass);
+ }
+
+ /**
+ * {@inheritDoc}
+ */
+ @Override
+ public String getSchemaName() {
+return arangoDBMapping.getDocumentClass();
+ }
+
+ /**
+ * {@inheritDoc}
+ * Create a new class of ArangoDB documents if necessary. Enforce specified
schema over the document class.
+ */
+ @Override
+ public void
[jira] [Commented] (GORA-650) Add datastore for ArangoDB
[
https://issues.apache.org/jira/browse/GORA-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344732#comment-17344732
]
ASF GitHub Bot commented on GORA-650:
-
kamaci commented on a change in pull request #218:
URL: https://github.com/apache/gora/pull/218#discussion_r632675729
##
File path:
gora-arangodb/src/main/java/org/apache/gora/arangodb/store/ArangoDBStore.java
##
@@ -0,0 +1,690 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.arangodb.store;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.Base64;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Properties;
+import java.util.List;
+import java.util.ArrayList;
+
+import com.arangodb.ArangoDB;
+import com.arangodb.entity.BaseDocument;
+import org.apache.avro.Schema;
+import org.apache.avro.util.Utf8;
+import org.apache.gora.arangodb.query.ArangoDBQuery;
+import org.apache.gora.persistency.impl.BeanFactoryImpl;
+import org.apache.gora.persistency.impl.DirtyListWrapper;
+import org.apache.gora.persistency.impl.DirtyMapWrapper;
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.query.PartitionQuery;
+import org.apache.gora.query.Query;
+import org.apache.gora.query.Result;
+import org.apache.gora.query.impl.PartitionQueryImpl;
+import org.apache.gora.store.impl.DataStoreBase;
+import org.apache.gora.util.AvroUtils;
+import org.apache.gora.util.ClassLoadingUtils;
+import org.apache.gora.util.GoraException;
+
+
+/**
+ * {@inheritDoc}
+ * {@link org.apache.gora.arangodb.store.ArangoDBStore} is the primary class
+ * responsible for facilitating GORA CRUD operations on ArangoDB documents.
+ */
+public class ArangoDBStore extends
DataStoreBase {
+
+ public static final String DEFAULT_MAPPING_FILE =
"/gora-arangodb-mapping.xml";
+ private ArangoDBStoreParameters arangoDbStoreParams;
+ private ArangoDBMapping arangoDBMapping;
+ private ArangoDB arangoDB;
+
+ /**
+ * {@inheritDoc}
+ * Initialize the ArangoDB dataStore by {@link Properties} parameters.
+ *
+ * @param keyClasskey class type for dataStore.
+ * @param persistentClass persistent class type for dataStore.
+ * @param properties ArangoDB dataStore properties EG:- ArangoDB client
credentials.
+ */
+ @Override
+ public void initialize(Class keyClass, Class persistentClass,
Properties properties) throws GoraException {
+super.initialize(keyClass, persistentClass, properties);
+try {
+ arangoDbStoreParams = ArangoDBStoreParameters.load(properties);
+ arangoDB = new ArangoDB.Builder()
+ .host(arangoDbStoreParams.getServerHost(),
+ Integer.valueOf(arangoDbStoreParams.getServerPort()))
+ .user(arangoDbStoreParams.getUserName())
+ .password(arangoDbStoreParams.getUserPassword())
+
.maxConnections(Integer.valueOf(arangoDbStoreParams.getConnectionPoolSize()))
+ .build();
+ if (!arangoDB.db(arangoDbStoreParams.getDatabaseName()).exists())
+arangoDB.createDatabase(arangoDbStoreParams.getDatabaseName());
+
+ ArangoDBMappingBuilder builder = new
ArangoDBMappingBuilder<>(this);
+ arangoDBMapping =
builder.fromFile(arangoDbStoreParams.getMappingFile()).build();
+ if (!schemaExists()) {
+createSchema();
+ }
+} catch (Exception e) {
+ LOG.error("Error while initializing ArangoDB dataStore: {}",
+ new Object[]{e.getMessage()});
+ throw new RuntimeException(e);
+}
+ }
+
+ /**
+ * {@inheritDoc}
+ */
+ @Override
+ public String getSchemaName(final String mappingSchemaName,
+ final Class persistentClass) {
+return super.getSchemaName(mappingSchemaName, persistentClass);
+ }
+
+ /**
+ * {@inheritDoc}
+ */
+ @Override
+ public String getSchemaName() {
+return arangoDBMapping.getDocumentClass();
+ }
+
+ /**
+ * {@inheritDoc}
+ * Create a new class of ArangoDB documents if necessary. Enforce specified
schema over the document class.
+ */
+ @Override
+ public void
[jira] [Commented] (GORA-650) Add datastore for ArangoDB
[
https://issues.apache.org/jira/browse/GORA-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344730#comment-17344730
]
ASF GitHub Bot commented on GORA-650:
-
kamaci commented on a change in pull request #218:
URL: https://github.com/apache/gora/pull/218#discussion_r632675364
##
File path:
gora-arangodb/src/main/java/org/apache/gora/arangodb/store/ArangoDBMappingBuilder.java
##
@@ -0,0 +1,119 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.arangodb.store;
+
+import org.apache.gora.persistency.impl.PersistentBase;
+
+import java.io.FileInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.List;
+
+import org.jdom.Document;
+import org.jdom.Element;
+import org.jdom.input.SAXBuilder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Utility builder for create ArangoDB mapping from gora-arango-mapping.xml.
+ */
+public class ArangoDBMappingBuilder {
+
+ public static final String ATT_NAME = "name";
+ public static final String ATT_TYPE = "type";
+ public static final String TAG_CLASS = "class";
+ public static final String ATT_KEYCLASS = "keyClass";
+ public static final String ATT_DOCUMENT = "document";
+ public static final String TAG_FIELD = "field";
+ public static final String ATT_FIELD = "docfield";
+ public static final Logger log =
LoggerFactory.getLogger(ArangoDBMappingBuilder.class);
+
+ private final ArangoDBStore dataStore;
+
+ private ArangoDBMapping mapping;
+
+ public ArangoDBMappingBuilder(final ArangoDBStore store) {
+this.dataStore = store;
+this.mapping = new ArangoDBMapping();
+ }
+
+ public ArangoDBMapping build() {
+if (mapping.getDocumentClass() == null)
+ throw new IllegalStateException("Document Class is not specified.");
+return mapping;
+ }
+
+ protected ArangoDBMappingBuilder fromFile(String uri) throws IOException {
+try {
+ SAXBuilder saxBuilder = new SAXBuilder();
+ InputStream is = getClass().getResourceAsStream(uri);
+ if (is == null) {
+String msg = "Unable to load the mapping from classpath resource '" +
uri
++ "' Re-trying local from local file system location.";
+log.warn(msg);
+is = new FileInputStream(uri);
+ }
+ Document doc = saxBuilder.build(is);
+ Element root = doc.getRootElement();
+ List classElements = root.getChildren(TAG_CLASS);
+ for (Element classElement : classElements) {
+final Class persistentClass = dataStore.getPersistentClass();
+final Class keyClass = dataStore.getKeyClass();
+if (matchesKeyClassWithMapping(keyClass, classElement)
+&& matchesPersistentClassWithMapping(persistentClass,
classElement)) {
+ loadPersistentClass(classElement, persistentClass);
+ break;
+}
+ }
+} catch (IOException ex) {
+ throw ex;
+} catch (Exception ex) {
Review comment:
Instead of this catch `Exception` and throw `IOException`.
On the other hand, what is the reason to wrap `Exception` as `IOException`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add datastore for ArangoDB
> --
>
> Key: GORA-650
> URL: https://issues.apache.org/jira/browse/GORA-650
> Project: Apache Gora
> Issue Type: New Feature
>Affects Versions: 0.9
>Reporter: Kevin Ratnasekera
>Priority: Major
> Labels: gsoc2020
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> May be we should consider extending our multimodal datastore support with
> ArangoDB. [1]
> [1] https://www.arangodb.com/why-arangodb/multi-model/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GORA-537) Upgrade to Hadoop 3.X
[ https://issues.apache.org/jira/browse/GORA-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344726#comment-17344726 ] ASF GitHub Bot commented on GORA-537: - kamaci commented on pull request #220: URL: https://github.com/apache/gora/pull/220#issuecomment-841381866 Thanks @balashashanka! Did you have a time to check the comment of @lewismc? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade to Hadoop 3.X > - > > Key: GORA-537 > URL: https://issues.apache.org/jira/browse/GORA-537 > Project: Apache Gora > Issue Type: Improvement > Components: build process >Reporter: Lewis John McGibbney >Priority: Major > Fix For: 1.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Hadoop 3 has been out for some time, we should consider upgrading. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-656) Hazelcast IMap backed datastore
[
https://issues.apache.org/jira/browse/GORA-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344717#comment-17344717
]
ASF GitHub Bot commented on GORA-656:
-
kamaci commented on a change in pull request #222:
URL: https://github.com/apache/gora/pull/222#discussion_r632664707
##
File path:
gora-hazelcast/src/test/java/org/apache/gora/hazelcast/mapreduce/HazelcastStoreMapReduceTest.java
##
@@ -0,0 +1,63 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.hazelcast.mapreduce;
+
+import org.apache.gora.hazelcast.GoraHazelcastTestDriver;
+import org.apache.gora.mapreduce.DataStoreMapReduceTestBase;
+import org.apache.gora.examples.generated.WebPage;
+import org.apache.gora.store.DataStore;
+import org.apache.gora.store.DataStoreFactory;
+import org.apache.hadoop.conf.Configuration;
+import org.junit.After;
+import org.junit.Before;
+
+import java.io.IOException;
+
+public class HazelcastStoreMapReduceTest extends DataStoreMapReduceTestBase {
+
+ private GoraHazelcastTestDriver driver;
+
+ public HazelcastStoreMapReduceTest() throws IOException {
+super();
+driver = new GoraHazelcastTestDriver();
+ }
+
+ @Override
+ @Before
+ public void setUp() throws Exception {
+driver.setUpClass();
+super.setUp();
+ }
+
+ @Override
+ @After
+ public void tearDown() throws Exception {
+super.tearDown();
+driver.tearDownClass();
+ }
+
+ @Override
+ protected DataStore createWebPageDataStore() throws
IOException {
+try {
+ return DataStoreFactory.getDataStore(String.class, WebPage.class, new
Configuration(), true);
+} catch (Exception e) {
+ throw new RuntimeException(e);
Review comment:
What is the purpose of catching the `Exception` and re-throwing it as
`RuntimeException`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Hazelcast IMap backed datastore
> ---
>
> Key: GORA-656
> URL: https://issues.apache.org/jira/browse/GORA-656
> Project: Apache Gora
> Issue Type: Improvement
>Reporter: Kevin Ratnasekera
>Priority: Major
> Labels: gsoc2020
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Current implementation of JCache datastore is written in a way that it will
> work with any JCache provider. Even though we have made explicitly available
> Hazelcast JCache provider to the classpath. This implementation should be
> based on the native interfaces of IMap.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GORA-656) Hazelcast IMap backed datastore
[
https://issues.apache.org/jira/browse/GORA-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344716#comment-17344716
]
ASF GitHub Bot commented on GORA-656:
-
kamaci commented on a change in pull request #222:
URL: https://github.com/apache/gora/pull/222#discussion_r632663594
##
File path:
gora-hazelcast/src/main/java/org/apache/gora/hazelcast/store/HazelcastCacheLoaderFactory.java
##
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.hazelcast.store;
+
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.store.DataStoreFactory;
+import org.apache.gora.util.GoraException;
+import org.apache.hadoop.conf.Configuration;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.cache.configuration.Factory;
+
+/**
+ * {@link HazelcastCacheLoaderFactory} is the primary class
+ * responsible for creating cache loader {@link
javax.cache.integration.CacheLoader} instances which itself
+ * loads data beans from persistency dataStore to in memory cache.
+ */
+public class HazelcastCacheLoaderFactory
+implements Factory> {
+
+ public static final long serialVersionUID = 201305101626L;
+ private static final Logger LOG =
LoggerFactory.getLogger(HazelcastCacheLoaderFactory.class);
+ private transient HazelcastCacheLoader instance;
+ private Class keyClass;
+ private Class persistentClass;
+
+ public HazelcastCacheLoaderFactory(HazelcastCacheLoader instance,
+ Class keyClass,
+ Class persistentClass) {
+this.keyClass = keyClass;
+this.persistentClass = persistentClass;
+LOG.info("JCache cache entry loader factory initialized successfully.");
+this.instance = instance;
+ }
+
+ public HazelcastCacheLoader create() {
+if (this.instance != null) {
+ return (HazelcastCacheLoader) this.instance;
+} else {
Review comment:
No need to write `else` after an `if` with a `return`.
##
File path:
gora-hazelcast/src/main/java/org/apache/gora/hazelcast/store/HazelcastCacheLoaderFactory.java
##
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.hazelcast.store;
+
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.store.DataStoreFactory;
+import org.apache.gora.util.GoraException;
+import org.apache.hadoop.conf.Configuration;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.cache.configuration.Factory;
+
+/**
+ * {@link HazelcastCacheLoaderFactory} is the primary class
+ * responsible for creating cache loader {@link
javax.cache.integration.CacheLoader} instances which itself
+ * loads data beans from persistency dataStore to in memory cache.
+ */
+public class HazelcastCacheLoaderFactory
+implements Factory> {
+
+ public static final long serialVersionUID = 201305101626L;
+ private static final Logger LOG =
LoggerFactory.getLogger(HazelcastCacheLoaderFactory.class);
+ private transient HazelcastCacheLoader instance;
+ private Class keyClass;
+ private Class persistentClass;
+
+ public HazelcastCacheLoaderFactory(HazelcastCacheLoader instance,
+ Class keyClass,
+ Class persistentClass) {
+this.keyClass = keyClass;
+
[jira] [Commented] (GORA-656) Hazelcast IMap backed datastore
[
https://issues.apache.org/jira/browse/GORA-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344712#comment-17344712
]
ASF GitHub Bot commented on GORA-656:
-
kamaci commented on a change in pull request #222:
URL: https://github.com/apache/gora/pull/222#discussion_r632661023
##
File path:
gora-hazelcast/src/main/java/org/apache/gora/hazelcast/store/HazelcastCacheEntryListenerFactory.java
##
@@ -0,0 +1,58 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.hazelcast.store;
+
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.cache.configuration.Factory;
+
+/**
+ * {@link HazelcastCacheEntryListenerFactory} is the primary class
+ * responsible for creating cache entry listeners which listens on {@link
javax.cache.event.CacheEntryEvent}
+ * cache entry events EG:- Creation, Removal, etc of keys on caches and
trigger actions as specified.
+ */
+public class HazelcastCacheEntryListenerFactory
+implements Factory> {
+
+ public static final long serialVersionUID = 201305101634L;
+ private static final Logger LOG =
LoggerFactory.getLogger(HazelcastCacheEntryListenerFactory.class);
+ private transient HazelcastCacheEntryListener instance;
+
+ public HazelcastCacheEntryListenerFactory(HazelcastCacheEntryListener
instance) {
+LOG.info("Hazelcast cache entry listener factory initialized
successfully.");
+this.instance = instance;
+ }
+
+ public HazelcastCacheEntryListener create() {
+return this.instance;
+ }
+
+ public boolean equals(Object other) {
+if (this == other) {
+ return true;
+} else if (other != null && this.getClass() == other.getClass()) {
Review comment:
No need for an else if you had a if with return.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Hazelcast IMap backed datastore
> ---
>
> Key: GORA-656
> URL: https://issues.apache.org/jira/browse/GORA-656
> Project: Apache Gora
> Issue Type: Improvement
>Reporter: Kevin Ratnasekera
>Priority: Major
> Labels: gsoc2020
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Current implementation of JCache datastore is written in a way that it will
> work with any JCache provider. Even though we have made explicitly available
> Hazelcast JCache provider to the classpath. This implementation should be
> based on the native interfaces of IMap.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GORA-656) Hazelcast IMap backed datastore
[
https://issues.apache.org/jira/browse/GORA-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344711#comment-17344711
]
ASF GitHub Bot commented on GORA-656:
-
kamaci commented on a change in pull request #222:
URL: https://github.com/apache/gora/pull/222#discussion_r632660595
##
File path:
gora-hazelcast/src/main/java/org/apache/gora/hazelcast/query/HazelcastResult.java
##
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.hazelcast.query;
+
+import java.io.IOException;
+import java.util.Iterator;
+import java.util.NavigableSet;
+
+import org.apache.gora.hazelcast.store.HazelcastStore;
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.query.Query;
+import org.apache.gora.query.impl.ResultBase;
+import org.apache.gora.store.DataStore;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * {@link HazelcastResult} is the primary class
+ * responsible for representing result set of a cache manipulation query
+ * {@link HazelcastQuery}
+ */
+public class HazelcastResult extends
ResultBase {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(HazelcastResult.class);
+ private NavigableSet cacheKeySet;
+ private Iterator iterator;
+ private int current;
+
+ public HazelcastResult(DataStore dataStore, Query query) {
+super(dataStore, query);
+ }
+
+ public HazelcastResult(DataStore dataStore, Query query,
NavigableSet cacheKeySet) {
+super(dataStore, query);
+this.cacheKeySet = cacheKeySet;
+this.iterator = cacheKeySet.iterator();
+this.current = 0;
+ }
+
+ public HazelcastStore getDataStore() {
+return (HazelcastStore) super.getDataStore();
+ }
+
+ @Override
+ public float getProgress() throws IOException {
+if (cacheKeySet.size() == 0) {
+ return 1;
+}
+float progress = ((float) current / (float) cacheKeySet.size());
Review comment:
You can inline variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Hazelcast IMap backed datastore
> ---
>
> Key: GORA-656
> URL: https://issues.apache.org/jira/browse/GORA-656
> Project: Apache Gora
> Issue Type: Improvement
>Reporter: Kevin Ratnasekera
>Priority: Major
> Labels: gsoc2020
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Current implementation of JCache datastore is written in a way that it will
> work with any JCache provider. Even though we have made explicitly available
> Hazelcast JCache provider to the classpath. This implementation should be
> based on the native interfaces of IMap.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GORA-562) Add a bin/gora command script for Windows
[ https://issues.apache.org/jira/browse/GORA-562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344709#comment-17344709 ] ASF GitHub Bot commented on GORA-562: - kamaci commented on pull request #225: URL: https://github.com/apache/gora/pull/225#issuecomment-841361918 @Titan-BT-7274 did you update your PR regarding to @jhnmora000's comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add a bin/gora command script for Windows > - > > Key: GORA-562 > URL: https://issues.apache.org/jira/browse/GORA-562 > Project: Apache Gora > Issue Type: Improvement >Affects Versions: 0.9 >Reporter: Alfonso Nishikawa >Assignee: Nilothpal Pillai >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > We would need a bin/gora.bat executable (or gora.cmd or alike) to compile > schemas under Windows. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-664) Add datastore for Elasticsearch
[ https://issues.apache.org/jira/browse/GORA-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344707#comment-17344707 ] ASF GitHub Bot commented on GORA-664: - kamaci commented on pull request #234: URL: https://github.com/apache/gora/pull/234#issuecomment-841358468 Congrats @podorvanova for the PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add datastore for Elasticsearch > --- > > Key: GORA-664 > URL: https://issues.apache.org/jira/browse/GORA-664 > Project: Apache Gora > Issue Type: New Feature >Reporter: Carlos Muñoz >Assignee: Mariia Podorvanova >Priority: Major > Labels: outreachy2020 > Time Spent: 10m > Remaining Estimate: 0h > > Elasticsearch is a Lucene-based search engine that primarily focuses on > distribution and availability. It could be a good alternative for the > gora-solr module. > > [https://www.elastic.co/guide/en/elasticsearch/reference/current/index.html] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GORA-664) Add datastore for Elasticsearch
[
https://issues.apache.org/jira/browse/GORA-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344706#comment-17344706
]
ASF GitHub Bot commented on GORA-664:
-
kamaci commented on a change in pull request #234:
URL: https://github.com/apache/gora/pull/234#discussion_r632653393
##
File path:
gora-elasticsearch/src/main/java/org/apache/gora/elasticsearch/store/ElasticsearchStoreMetadataAnalyzer.java
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gora.elasticsearch.store;
+
+import org.apache.gora.elasticsearch.utils.ElasticsearchParameters;
+import org.apache.gora.store.impl.DataStoreMetadataAnalyzer;
+import org.apache.gora.util.GoraException;
+import org.elasticsearch.client.RequestOptions;
+import org.elasticsearch.client.RestHighLevelClient;
+import org.elasticsearch.client.indices.GetIndexRequest;
+import org.elasticsearch.client.indices.GetIndexResponse;
+import org.elasticsearch.cluster.metadata.MappingMetadata;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Map;
+
+public class ElasticsearchStoreMetadataAnalyzer extends
DataStoreMetadataAnalyzer {
+
+private RestHighLevelClient elasticsearchClient;
+
+@Override
+public void initialize() throws GoraException {
+ElasticsearchParameters parameters =
ElasticsearchParameters.load(properties, getConf());
+elasticsearchClient = ElasticsearchStore.createClient(parameters);
+}
+
+@Override
+public String getType() {
+return "ELASTICSEARCH";
+}
+
+@Override
+public List getTablesNames() throws GoraException {
+GetIndexRequest request = new GetIndexRequest("*");
+GetIndexResponse response;
+try {
+response = elasticsearchClient.indices().get(request,
RequestOptions.DEFAULT);
+} catch (IOException ex) {
+throw new GoraException(ex);
+}
+assert response != null;
Review comment:
Consider logging and throwing an error without using assert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add datastore for Elasticsearch
> ---
>
> Key: GORA-664
> URL: https://issues.apache.org/jira/browse/GORA-664
> Project: Apache Gora
> Issue Type: New Feature
>Reporter: Carlos Muñoz
>Assignee: Mariia Podorvanova
>Priority: Major
> Labels: outreachy2020
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Elasticsearch is a Lucene-based search engine that primarily focuses on
> distribution and availability. It could be a good alternative for the
> gora-solr module.
>
> [https://www.elastic.co/guide/en/elasticsearch/reference/current/index.html]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GORA-664) Add datastore for Elasticsearch
[
https://issues.apache.org/jira/browse/GORA-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344704#comment-17344704
]
ASF GitHub Bot commented on GORA-664:
-
kamaci commented on a change in pull request #234:
URL: https://github.com/apache/gora/pull/234#discussion_r632650676
##
File path:
gora-elasticsearch/src/main/java/org/apache/gora/elasticsearch/query/ElasticsearchResult.java
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gora.elasticsearch.query;
+
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.query.Query;
+import org.apache.gora.query.impl.ResultBase;
+import org.apache.gora.store.DataStore;
+
+import java.util.List;
+
+/**
+ * ElasticsearchResult specific implementation of the
+ * {@link org.apache.gora.query.Result} interface.
+ */
+public class ElasticsearchResult extends
ResultBase {
+
+/**
+ * List of resulting persistent objects.
+ */
+private List persistentObjects;
+
+/**
+ * List of resulting objects keys.
+ */
+private List persistentKeys;
+
+public ElasticsearchResult(DataStore dataStore, Query query,
List persistentKeys, List persistentObjects) {
+super(dataStore, query);
+this.persistentKeys = persistentKeys;
+this.persistentObjects = persistentObjects;
+}
+
+@Override
+public float getProgress() {
+if (persistentObjects.size() == 0) {
+return 1;
+} else {
Review comment:
No need to write `else`. It can be:
```
if (persistentObjects.size() == 0) {
return 1;
}
return offset / (float) persistentObjects.size();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add datastore for Elasticsearch
> ---
>
> Key: GORA-664
> URL: https://issues.apache.org/jira/browse/GORA-664
> Project: Apache Gora
> Issue Type: New Feature
>Reporter: Carlos Muñoz
>Assignee: Mariia Podorvanova
>Priority: Major
> Labels: outreachy2020
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Elasticsearch is a Lucene-based search engine that primarily focuses on
> distribution and availability. It could be a good alternative for the
> gora-solr module.
>
> [https://www.elastic.co/guide/en/elasticsearch/reference/current/index.html]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
