[GitHub] [gora] dependabot[bot] opened a new pull request, #274: Bump hazelcast-jet from 3.1 to 4.5.4

[GitBox]

dependabot[bot] opened a new pull request, #274:
URL: https://github.com/apache/gora/pull/274

   Bumps hazelcast-jet from 3.1 to 4.5.4.
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.hazelcast.jet:hazelcast-jet=maven=3.1=4.5.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   - `@dependabot use these labels` will set the current labels as the default 
for future PRs for this repo and language
   - `@dependabot use these reviewers` will set the current reviewers as the 
default for future PRs for this repo and language
   - `@dependabot use these assignees` will set the current assignees as the 
default for future PRs for this repo and language
   - `@dependabot use this milestone` will set the current milestone as the 
default for future PRs for this repo and language
   
   You can disable automated security fix PRs for this repo from the [Security 
Alerts page](https://github.com/apache/gora/network/alerts).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] himanshuacharya95 commented on a diff in pull request #273: [IN-PROGRESS] GORA-698 Geode DataStore

[GitBox]

himanshuacharya95 commented on code in PR #273:
URL: https://github.com/apache/gora/pull/273#discussion_r973775993


##
gora-geode/src/main/java/org/apache/gora/geode/store/GeodeStore.java:
##
@@ -0,0 +1,187 @@
+package org.apache.gora.geode.store;
+
+import org.apache.geode.cache.*;

Review Comment:
   
   Replaced wildcard import statements with only required ones.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] kamaci commented on a diff in pull request #273: [IN-PROGRESS] GORA-698 Geode DataStore

[GitBox]

kamaci commented on code in PR #273:
URL: https://github.com/apache/gora/pull/273#discussion_r973769144


##
gora-geode/src/test/java/store/TestGeodeStore.java:
##
@@ -0,0 +1,161 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ * 
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package store;
+
+
+
+import org.apache.avro.util.Utf8;
+import org.apache.gora.examples.WebPageDataCreator;
+import org.apache.gora.examples.generated.WebPage;
+import org.apache.gora.geode.GeodeStartupLogWaitStrategy;
+import org.apache.gora.geode.GoraGeodeTestDriver;
+import org.apache.gora.geode.query.GeodeResult;
+import org.apache.gora.query.Query;
+import org.apache.gora.store.DataStoreTestBase;
+import org.apache.gora.util.GoraException;
+import org.junit.ClassRule;
+import org.junit.Ignore;
+import org.junit.Test;
+import org.testcontainers.containers.GenericContainer;
+
+
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.nio.charset.Charset;
+import java.time.Duration;
+
+import static org.junit.Assert.*;
+
+/**
+ * Tests extending {@link DataStoreTestBase}
+ * which run the base JUnit test suite for Gora.
+ */
+public class TestGeodeStore extends DataStoreTestBase {

Review Comment:
   Could you add more tests?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] kamaci commented on a diff in pull request #273: [IN-PROGRESS] GORA-698 Geode DataStore

[GitBox]

kamaci commented on code in PR #273:
URL: https://github.com/apache/gora/pull/273#discussion_r973768766


##
gora-geode/src/main/java/org/apache/gora/geode/store/GeodeStore.java:
##
@@ -0,0 +1,187 @@
+package org.apache.gora.geode.store;
+
+import org.apache.geode.cache.*;

Review Comment:
   Please not use wildcard imports



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] himanshuacharya95 commented on a diff in pull request #273: [IN-PROGRESS] GORA-698 Geode DataStore

[GitBox]

himanshuacharya95 commented on code in PR #273:
URL: https://github.com/apache/gora/pull/273#discussion_r963144285


##
gora-geode/src/main/java/org/apache/gora/geode/store/GeodeStore.java:
##
@@ -0,0 +1,190 @@
+package org.apache.gora.geode.store;
+
+import org.apache.geode.cache.*;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.client.ClientCacheFactory;
+import org.apache.gora.geode.query.GeodeQuery;
+import org.apache.gora.geode.query.GeodeResult;
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.query.PartitionQuery;
+import org.apache.gora.query.Query;
+import org.apache.gora.query.Result;
+import org.apache.gora.query.impl.PartitionQueryImpl;
+import org.apache.gora.store.impl.DataStoreBase;
+import org.apache.gora.util.GoraException;
+
+import java.io.IOException;
+import java.util.*;
+import java.util.concurrent.ConcurrentSkipListSet;
+
+import static org.apache.geode.cache.RegionShortcut.REPLICATE;
+import static org.apache.gora.geode.store.GeodeStoreParameters.*;
+
+
+public class GeodeStore extends DataStoreBase {
+
+private ClientCache clientCache;
+private Region region;
+private Properties geodeProperties;
+
+
+private CacheFactory cacheFactory;
+
+@Override
+public void initialize(Class keyClass, Class persistentClass, 
Properties properties) throws GoraException {
+super.initialize(keyClass, persistentClass, properties);
+String geodeHostName = (String) properties.get(GEODE_SERVER_HOST);
+int portNumber = Integer.parseInt((String) 
properties.get(GEODE_SERVER_PORT));
+clientCache = new ClientCacheFactory().addPoolLocator(geodeHostName, 
portNumber).create();
+String userName = properties.getProperty(GEODE_USERNAME);
+String password = properties.getProperty(GEODE_PASSWORD);
+geodeProperties = properties;
+
+Properties clientProperties = 
clientCache.getDistributedSystem().getProperties();
+if (userName != null) {
+clientProperties.setProperty("security-username", userName);
+clientProperties.setProperty("security-password", password);
+}
+cacheFactory = new CacheFactory(clientProperties);
+}
+
+@Override
+/*
+  Schema Name can be assigned via Property file using 
@PREFERRED_SCHEMA_NAME, or else PersistentClass name is used as the default 
schema name.
+ */
+public String getSchemaName() {
+String preferredSchemaName = 
properties.getProperty(PREFERRED_SCHEMA_NAME);
+if (preferredSchemaName == null) {
+return persistentClass.getSimpleName();
+}
+return preferredSchemaName;
+}
+
+@Override
+public void createSchema() throws GoraException {
+try {
+Cache cache = cacheFactory.create();
+String regionShortCut = 
geodeProperties.getProperty(GEODE_REGION_SHORTCUT);
+RegionFactory regionFactory;
+if (regionShortCut != null) {
+regionFactory = 
cache.createRegionFactory(RegionShortcut.valueOf(regionShortCut));
+} else {
+regionFactory = cache.createRegionFactory(REPLICATE);
+}
+region = regionFactory.create(getSchemaName());
+} catch (Exception e) {
+throw new GoraException(e);
+}
+}
+
+@Override
+public void deleteSchema() {
+region.destroyRegion();
+}
+
+@Override
+public boolean schemaExists() {
+Properties properties = 
clientCache.getDistributedSystem().getProperties();
+CacheFactory factory = new CacheFactory(properties);
+Cache cache = factory.create();
+Region rf = cache.getRegion(getSchemaName());
+return rf != null;
+}
+
+@Override
+public boolean exists(K key) {
+for (K existingKey : region.getInterestList()) {
+if (existingKey.equals(key)) {
+return true;
+}
+}
+return false;
+}
+
+@Override
+public T get(K key, String[] fields) {
+return region.get(key);
+}
+
+@Override
+public void put(K key, T obj) {
+region.put(key, obj);
+}
+
+@Override
+public boolean delete(K key) {
+region.destroy(key);
+return true;
+}
+
+@Override
+public long deleteByQuery(Query query) throws GoraException {
+try {
+long deletedRows = 0;
+Result result = query.execute();
+while (result.next()) {
+if (delete(result.getKey())) {
+deletedRows++;
+}
+}
+LOG.info("Geode datastore deleted {} rows from Persistent 
datastore.", deletedRows);
+return deletedRows;
+} catch (Exception e) {
+throw new GoraException(e);
+}
+}
+
+@Override
+public Result execute(Query query) {
+

Review 

[GitHub] [gora] himanshuacharya95 commented on a diff in pull request #273: [IN-PROGRESS] GORA-698 Geode DataStore

[GitBox]

himanshuacharya95 commented on code in PR #273:
URL: https://github.com/apache/gora/pull/273#discussion_r963144223


##
gora-geode/src/main/java/org/apache/gora/geode/store/GeodeStore.java:
##
@@ -0,0 +1,190 @@
+package org.apache.gora.geode.store;
+
+import org.apache.geode.cache.*;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.client.ClientCacheFactory;
+import org.apache.gora.geode.query.GeodeQuery;
+import org.apache.gora.geode.query.GeodeResult;
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.query.PartitionQuery;
+import org.apache.gora.query.Query;
+import org.apache.gora.query.Result;
+import org.apache.gora.query.impl.PartitionQueryImpl;
+import org.apache.gora.store.impl.DataStoreBase;
+import org.apache.gora.util.GoraException;
+
+import java.io.IOException;
+import java.util.*;
+import java.util.concurrent.ConcurrentSkipListSet;
+
+import static org.apache.geode.cache.RegionShortcut.REPLICATE;
+import static org.apache.gora.geode.store.GeodeStoreParameters.*;
+
+
+public class GeodeStore extends DataStoreBase {
+
+private ClientCache clientCache;
+private Region region;
+private Properties geodeProperties;
+
+
+private CacheFactory cacheFactory;
+
+@Override
+public void initialize(Class keyClass, Class persistentClass, 
Properties properties) throws GoraException {
+super.initialize(keyClass, persistentClass, properties);
+String geodeHostName = (String) properties.get(GEODE_SERVER_HOST);
+int portNumber = Integer.parseInt((String) 
properties.get(GEODE_SERVER_PORT));
+clientCache = new ClientCacheFactory().addPoolLocator(geodeHostName, 
portNumber).create();
+String userName = properties.getProperty(GEODE_USERNAME);
+String password = properties.getProperty(GEODE_PASSWORD);
+geodeProperties = properties;
+
+Properties clientProperties = 
clientCache.getDistributedSystem().getProperties();
+if (userName != null) {

Review Comment:
   Added some code to throw exception



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] himanshuacharya95 commented on a diff in pull request #273: [IN-PROGRESS] GORA-698 Geode DataStore

[GitBox]

himanshuacharya95 commented on code in PR #273:
URL: https://github.com/apache/gora/pull/273#discussion_r963143973


##
gora-geode/src/main/java/org/apache/gora/geode/store/GeodeStore.java:
##
@@ -0,0 +1,190 @@
+package org.apache.gora.geode.store;
+
+import org.apache.geode.cache.*;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.client.ClientCacheFactory;
+import org.apache.gora.geode.query.GeodeQuery;
+import org.apache.gora.geode.query.GeodeResult;
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.query.PartitionQuery;
+import org.apache.gora.query.Query;
+import org.apache.gora.query.Result;
+import org.apache.gora.query.impl.PartitionQueryImpl;
+import org.apache.gora.store.impl.DataStoreBase;
+import org.apache.gora.util.GoraException;
+
+import java.io.IOException;
+import java.util.*;
+import java.util.concurrent.ConcurrentSkipListSet;
+
+import static org.apache.geode.cache.RegionShortcut.REPLICATE;
+import static org.apache.gora.geode.store.GeodeStoreParameters.*;
+
+
+public class GeodeStore extends DataStoreBase {
+
+private ClientCache clientCache;
+private Region region;
+private Properties geodeProperties;
+
+

Review Comment:
   Extra spaces removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] kamaci commented on a diff in pull request #273: [IN-PROGRESS] GORA-698 Geode DataStore

[GitBox]

kamaci commented on code in PR #273:
URL: https://github.com/apache/gora/pull/273#discussion_r962204734


##
gora-geode/src/main/java/org/apache/gora/geode/store/GeodeStore.java:
##
@@ -0,0 +1,190 @@
+package org.apache.gora.geode.store;
+
+import org.apache.geode.cache.*;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.client.ClientCacheFactory;
+import org.apache.gora.geode.query.GeodeQuery;
+import org.apache.gora.geode.query.GeodeResult;
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.query.PartitionQuery;
+import org.apache.gora.query.Query;
+import org.apache.gora.query.Result;
+import org.apache.gora.query.impl.PartitionQueryImpl;
+import org.apache.gora.store.impl.DataStoreBase;
+import org.apache.gora.util.GoraException;
+
+import java.io.IOException;
+import java.util.*;
+import java.util.concurrent.ConcurrentSkipListSet;
+
+import static org.apache.geode.cache.RegionShortcut.REPLICATE;
+import static org.apache.gora.geode.store.GeodeStoreParameters.*;
+
+
+public class GeodeStore extends DataStoreBase {
+
+private ClientCache clientCache;
+private Region region;
+private Properties geodeProperties;
+
+
+private CacheFactory cacheFactory;
+
+@Override
+public void initialize(Class keyClass, Class persistentClass, 
Properties properties) throws GoraException {
+super.initialize(keyClass, persistentClass, properties);
+String geodeHostName = (String) properties.get(GEODE_SERVER_HOST);
+int portNumber = Integer.parseInt((String) 
properties.get(GEODE_SERVER_PORT));
+clientCache = new ClientCacheFactory().addPoolLocator(geodeHostName, 
portNumber).create();
+String userName = properties.getProperty(GEODE_USERNAME);
+String password = properties.getProperty(GEODE_PASSWORD);
+geodeProperties = properties;
+
+Properties clientProperties = 
clientCache.getDistributedSystem().getProperties();
+if (userName != null) {
+clientProperties.setProperty("security-username", userName);
+clientProperties.setProperty("security-password", password);
+}
+cacheFactory = new CacheFactory(clientProperties);
+}
+
+@Override
+/*
+  Schema Name can be assigned via Property file using 
@PREFERRED_SCHEMA_NAME, or else PersistentClass name is used as the default 
schema name.
+ */
+public String getSchemaName() {
+String preferredSchemaName = 
properties.getProperty(PREFERRED_SCHEMA_NAME);
+if (preferredSchemaName == null) {
+return persistentClass.getSimpleName();
+}
+return preferredSchemaName;
+}
+
+@Override
+public void createSchema() throws GoraException {
+try {
+Cache cache = cacheFactory.create();
+String regionShortCut = 
geodeProperties.getProperty(GEODE_REGION_SHORTCUT);
+RegionFactory regionFactory;
+if (regionShortCut != null) {
+regionFactory = 
cache.createRegionFactory(RegionShortcut.valueOf(regionShortCut));
+} else {
+regionFactory = cache.createRegionFactory(REPLICATE);
+}
+region = regionFactory.create(getSchemaName());
+} catch (Exception e) {
+throw new GoraException(e);
+}
+}
+
+@Override
+public void deleteSchema() {
+region.destroyRegion();
+}
+
+@Override
+public boolean schemaExists() {
+Properties properties = 
clientCache.getDistributedSystem().getProperties();
+CacheFactory factory = new CacheFactory(properties);
+Cache cache = factory.create();
+Region rf = cache.getRegion(getSchemaName());
+return rf != null;
+}
+
+@Override
+public boolean exists(K key) {
+for (K existingKey : region.getInterestList()) {
+if (existingKey.equals(key)) {
+return true;
+}
+}
+return false;
+}
+
+@Override
+public T get(K key, String[] fields) {
+return region.get(key);
+}
+
+@Override
+public void put(K key, T obj) {
+region.put(key, obj);
+}
+
+@Override
+public boolean delete(K key) {
+region.destroy(key);
+return true;
+}
+
+@Override
+public long deleteByQuery(Query query) throws GoraException {
+try {
+long deletedRows = 0;
+Result result = query.execute();
+while (result.next()) {
+if (delete(result.getKey())) {
+deletedRows++;
+}
+}
+LOG.info("Geode datastore deleted {} rows from Persistent 
datastore.", deletedRows);
+return deletedRows;
+} catch (Exception e) {
+throw new GoraException(e);
+}
+}
+
+@Override
+public Result execute(Query query) {
+

Review Comment:
  

[GitHub] [gora] kamaci commented on a diff in pull request #273: [IN-PROGRESS] GORA-698 Geode DataStore

[GitBox]

kamaci commented on code in PR #273:
URL: https://github.com/apache/gora/pull/273#discussion_r962204714


##
gora-geode/src/main/java/org/apache/gora/geode/store/GeodeStore.java:
##
@@ -0,0 +1,190 @@
+package org.apache.gora.geode.store;
+
+import org.apache.geode.cache.*;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.client.ClientCacheFactory;
+import org.apache.gora.geode.query.GeodeQuery;
+import org.apache.gora.geode.query.GeodeResult;
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.query.PartitionQuery;
+import org.apache.gora.query.Query;
+import org.apache.gora.query.Result;
+import org.apache.gora.query.impl.PartitionQueryImpl;
+import org.apache.gora.store.impl.DataStoreBase;
+import org.apache.gora.util.GoraException;
+
+import java.io.IOException;
+import java.util.*;
+import java.util.concurrent.ConcurrentSkipListSet;
+
+import static org.apache.geode.cache.RegionShortcut.REPLICATE;
+import static org.apache.gora.geode.store.GeodeStoreParameters.*;
+
+
+public class GeodeStore extends DataStoreBase {
+
+private ClientCache clientCache;
+private Region region;
+private Properties geodeProperties;
+
+
+private CacheFactory cacheFactory;
+
+@Override
+public void initialize(Class keyClass, Class persistentClass, 
Properties properties) throws GoraException {
+super.initialize(keyClass, persistentClass, properties);
+String geodeHostName = (String) properties.get(GEODE_SERVER_HOST);
+int portNumber = Integer.parseInt((String) 
properties.get(GEODE_SERVER_PORT));
+clientCache = new ClientCacheFactory().addPoolLocator(geodeHostName, 
portNumber).create();
+String userName = properties.getProperty(GEODE_USERNAME);
+String password = properties.getProperty(GEODE_PASSWORD);
+geodeProperties = properties;
+
+Properties clientProperties = 
clientCache.getDistributedSystem().getProperties();
+if (userName != null) {

Review Comment:
   What if username is null and password is not? How about throwing an 
exception in that case?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] kamaci commented on a diff in pull request #273: [IN-PROGRESS] GORA-698 Geode DataStore

[GitBox]

kamaci commented on code in PR #273:
URL: https://github.com/apache/gora/pull/273#discussion_r962204662


##
gora-geode/src/main/java/org/apache/gora/geode/store/GeodeStore.java:
##
@@ -0,0 +1,190 @@
+package org.apache.gora.geode.store;
+
+import org.apache.geode.cache.*;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.client.ClientCacheFactory;
+import org.apache.gora.geode.query.GeodeQuery;
+import org.apache.gora.geode.query.GeodeResult;
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.query.PartitionQuery;
+import org.apache.gora.query.Query;
+import org.apache.gora.query.Result;
+import org.apache.gora.query.impl.PartitionQueryImpl;
+import org.apache.gora.store.impl.DataStoreBase;
+import org.apache.gora.util.GoraException;
+
+import java.io.IOException;
+import java.util.*;
+import java.util.concurrent.ConcurrentSkipListSet;
+
+import static org.apache.geode.cache.RegionShortcut.REPLICATE;
+import static org.apache.gora.geode.store.GeodeStoreParameters.*;
+
+
+public class GeodeStore extends DataStoreBase {
+
+private ClientCache clientCache;
+private Region region;
+private Properties geodeProperties;
+
+

Review Comment:
   Please remove extra spaces



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] himanshuacharya95 opened a new pull request, #273: [IN-PROGRESS] GORA-698 Geode DataStore

[GitBox]

himanshuacharya95 opened a new pull request, #273:
URL: https://github.com/apache/gora/pull/273

   # Pending Items Test Cases


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] cunningt opened a new pull request, #272: Upgrade spark to 2.4.8

[GitBox]

cunningt opened a new pull request, #272:
URL: https://github.com/apache/gora/pull/272

   Upgrade spark to 2.4.8.Ran gora-core, gora-hbase tests with jdk8, 
passed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] dependabot[bot] opened a new pull request, #271: Bump commons-fileupload from 1.2.1 to 1.3.3

[GitBox]

dependabot[bot] opened a new pull request, #271:
URL: https://github.com/apache/gora/pull/271

   Bumps commons-fileupload from 1.2.1 to 1.3.3.
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=commons-fileupload:commons-fileupload=maven=1.2.1=1.3.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   - `@dependabot use these labels` will set the current labels as the default 
for future PRs for this repo and language
   - `@dependabot use these reviewers` will set the current reviewers as the 
default for future PRs for this repo and language
   - `@dependabot use these assignees` will set the current assignees as the 
default for future PRs for this repo and language
   - `@dependabot use this milestone` will set the current milestone as the 
default for future PRs for this repo and language
   
   You can disable automated security fix PRs for this repo from the [Security 
Alerts page](https://github.com/apache/gora/network/alerts).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] dependabot[bot] opened a new pull request, #270: Bump cxf-rt-frontend-jaxrs from 2.5.2 to 2.6.11

[GitBox]

dependabot[bot] opened a new pull request, #270:
URL: https://github.com/apache/gora/pull/270

   Bumps cxf-rt-frontend-jaxrs from 2.5.2 to 2.6.11.
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.cxf:cxf-rt-frontend-jaxrs=maven=2.5.2=2.6.11)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   - `@dependabot use these labels` will set the current labels as the default 
for future PRs for this repo and language
   - `@dependabot use these reviewers` will set the current reviewers as the 
default for future PRs for this repo and language
   - `@dependabot use these assignees` will set the current assignees as the 
default for future PRs for this repo and language
   - `@dependabot use this milestone` will set the current milestone as the 
default for future PRs for this repo and language
   
   You can disable automated security fix PRs for this repo from the [Security 
Alerts page](https://github.com/apache/gora/network/alerts).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] dependabot[bot] opened a new pull request, #269: Bump jetty-server from 9.4.14.v20181114 to 10.0.10

[GitBox]

dependabot[bot] opened a new pull request, #269:
URL: https://github.com/apache/gora/pull/269

   Bumps [jetty-server](https://github.com/eclipse/jetty.project) from 
9.4.14.v20181114 to 10.0.10.
   
   Release notes
   Sourced from https://github.com/eclipse/jetty.project/releases;>jetty-server's 
releases.
   
   10.0.10
   Special Thanks to the following Eclipse Jetty community members
   
   https://github.com/jianglai;>@​jianglai (Lai 
Jiang)
   https://github.com/markslater;>@​markslater 
(markslater)
   https://github.com/prenagha;>@​prenagha 
(Padraic Renaghan)
   
   Changelog
   
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8136;>#8136
 - Cherry-pick of Improvements to PathSpec for Jetty 10.0.x
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8134;>#8134
 - Improve cleanup of deflater/inflater pools for 
PerMessageDeflateExtension
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8088;>#8088
 - Add option to configure exitVm on ShutdownMonitor from System properties
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8067;>#8067
 - Wall time usage in DoSFilter RateTracker results in false positive alert
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8057;>#8057
 - Support Http Response 103 (Early Hints)
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8014;>#8014
 - Review HttpRequest URI construction
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8008;>#8008
 - Add compliance mode for LEGACY multipart parser in Jetty 10+
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7994;>#7994
 - Ability to construct a detached client Request
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7981;>#7981
 - Add TRANSFER_ENCODING violation for MultiPart RFC7578 parser. (https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7976;>#7976)
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7977;>#7977
 - UpgradeHttpServletRequest.setAttribute  
UpgradeHttpServletRequest.removeAttribute can throw NullPointerException
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7975;>#7975
 - ForwardedRequestCustomizer setters do not clear existing 
handlers
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7953;>#7953
 - Fix StatisticsHandler in the case a Handler throws exception.
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7935;>#7935
 - Review HTTP/2 error handling
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7929;>#7929
 - Correct requestlog formatString commented default (https://github.com/prenagha;>@​prenagha)
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7924;>#7924
 - Fix a typo in Javadoc (https://github.com/jianglai;>@​jianglai)
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7918;>#7918
 - PathMappings.asPathSpec does not allow root ServletPathSpec
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7891;>#7891
 - Better Servlet PathMappings for Regex
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7880;>#7880
 - DefaultServlet should not overwrite programmatically configured 
precompressed formats with defaults (https://github.com/markslater;>@​markslater)
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7863;>#7863
 - Default servlet drops first accept-encoding header if there is more than 
one. (https://github.com/markslater;>@​markslater)
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7858;>#7858
 - GZipHandler does not play nice with other handlers in HandlerCollection
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7818;>#7818
 - Modifying of HTTP headers in HttpChannel.Listener#onResponseBegin is no 
longer possible with Jetty 10
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7808;>#7808
 - Jetty 10.0.x 7801 duplicate set session cookie
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7802;>#7802
 - HTTP/3 QPACK - do not expect section ack for zero required insert count
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7754;>#7754
 - jetty.sh ignores JAVA_OPTIONS environment variable
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7748;>#7748
 - Allow overriding of url-pattern mapping in ServletContextHandler to allow 
for regex or uri-template matching
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7635;>#7635
 - QPACK decoder should fail connection if the encoder blocks more than 
SETTINGS_QPACK_BLOCKED_STREAMS
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/4414;>#4414
 - GZipHandler not excluding inflation for specified paths
   

[GitHub] [gora] dependabot[bot] opened a new pull request, #268: Bump jetty-http from 9.4.14.v20181114 to 9.4.48.v20220622

[GitBox]

dependabot[bot] opened a new pull request, #268:
URL: https://github.com/apache/gora/pull/268

   Bumps [jetty-http](https://github.com/eclipse/jetty.project) from 
9.4.14.v20181114 to 9.4.48.v20220622.
   
   Release notes
   Sourced from https://github.com/eclipse/jetty.project/releases;>jetty-http's 
releases.
   
   9.4.48.v20220622
   End of Life Notice
   
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7958;>eclipse/jetty.project#7958
 - Jetty 9.4.x is now at End of Community Support. (See issue for details)
   
   Critical Fix
   
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8184;>#8184
 - All suffix globs except first fail to match if path has . 
character in prefix section
   
   9.4.47.v20220610
   Important
   
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7958;>eclipse/jetty.project#7958
 - Jetty 9.4.x is now at End of Community Support. (See issue for details)
   
   Changelog
   
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8145;>#8145
 - RegexPathSpec backport of optional group name/info lookup if regex fails
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8088;>#8088
 - Add option to configure exitVm on ShutdownMonitor from System properties
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8067;>#8067
 - Wall time usage in DoSFilter RateTracker results in false positive alert
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8014;>#8014
 - Review HttpRequest URI construction
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7976;>#7976
 - Add TRANSFER_ENCODING violation for MultiPart RFC7578 parser.
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7947;>#7947
 - Improved PathSpec handling for servletName  pathInfo
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7935;>#7935
 - Review HTTP/2 error handling
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7918;>#7918
 - PathMappings.asPathSpec does not allow root ServletPathSpec
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7863;>#7863
 - Default servlet drops first accept-encoding header if there is more than 
one.
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7858;>#7858
 - GZipHandler does not play nice with other handlers in HandlerCollection
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7837;>#7837
 - Fix StatisticsHandler in the case a Handler throws exception.
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7809;>#7809
 - Jetty 9.4.x 7801 duplicate set session cookies
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7748;>#7748
 - Allow overriding of url-pattern mapping in ServletContextHandler to allow 
for regex or uri-template matching
   
   Dependencies
   
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8076;>#8076
 - Bump asciidoctorj-diagram to 2.2.3
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7840;>#7840
 - Bump asm.version to 9.3
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8143;>#8143
 - Bump biz.aQute.bndlib to 6.3.1
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8055;>#8055
 - Bump error_prone_annotations to 2.14.0
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8110;>#8110
 - Bump google-cloud-datastore to 2.7.0
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8098;>#8098
 - Bump grpc-core to 1.47.0
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7988;>#7988
 - Bump hawtio-default to 2.15.0
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7999;>#7999
 - Bump jackson-annotations to 2.13.3
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8000;>#8000
 - Bump jackson-core to 2.13.3
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8002;>#8002
 - Bump jackson-databind to 2.13.3
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7846;>#7846
 - Bump jacoco-maven-plugin to 0.8.8
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7816;>#7816
 - Bump jnr-ffi to 2.2.12
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7968;>#7968
 - Bump kerb-simplekdc to 2.0.2
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8060;>#8060
 - Bump mariadb-java-client to 3.0.5
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7909;>#7909
 - Bump maven-antrun-plugin to 3.1.0
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/7841;>#7841
 - Bump maven-clean-plugin to 3.2.0
   https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8078;>#8078
 - Bump maven-invoker-plugin to 3.3.0
   

[GitHub] [gora] dependabot[bot] opened a new pull request, #267: Bump uimaj-core from 2.3.1 to 2.10.2

[GitBox]

dependabot[bot] opened a new pull request, #267:
URL: https://github.com/apache/gora/pull/267

   Bumps uimaj-core from 2.3.1 to 2.10.2.
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.uima:uimaj-core=maven=2.3.1=2.10.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   - `@dependabot use these labels` will set the current labels as the default 
for future PRs for this repo and language
   - `@dependabot use these reviewers` will set the current reviewers as the 
default for future PRs for this repo and language
   - `@dependabot use these assignees` will set the current assignees as the 
default for future PRs for this repo and language
   - `@dependabot use this milestone` will set the current milestone as the 
default for future PRs for this repo and language
   
   You can disable automated security fix PRs for this repo from the [Security 
Alerts page](https://github.com/apache/gora/network/alerts).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] dependabot[bot] opened a new pull request, #266: Bump hadoop-client from 2.5.2 to 2.7.0

[GitBox]

dependabot[bot] opened a new pull request, #266:
URL: https://github.com/apache/gora/pull/266

   Bumps hadoop-client from 2.5.2 to 2.7.0.
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.hadoop:hadoop-client=maven=2.5.2=2.7.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   - `@dependabot use these labels` will set the current labels as the default 
for future PRs for this repo and language
   - `@dependabot use these reviewers` will set the current reviewers as the 
default for future PRs for this repo and language
   - `@dependabot use these assignees` will set the current assignees as the 
default for future PRs for this repo and language
   - `@dependabot use this milestone` will set the current milestone as the 
default for future PRs for this repo and language
   
   You can disable automated security fix PRs for this repo from the [Security 
Alerts page](https://github.com/apache/gora/network/alerts).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] dependabot[bot] opened a new pull request, #265: Bump zookeeper from 3.4.6 to 3.4.14

[GitBox]

dependabot[bot] opened a new pull request, #265:
URL: https://github.com/apache/gora/pull/265

   Bumps zookeeper from 3.4.6 to 3.4.14.
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.zookeeper:zookeeper=maven=3.4.6=3.4.14)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   - `@dependabot use these labels` will set the current labels as the default 
for future PRs for this repo and language
   - `@dependabot use these reviewers` will set the current reviewers as the 
default for future PRs for this repo and language
   - `@dependabot use these assignees` will set the current assignees as the 
default for future PRs for this repo and language
   - `@dependabot use this milestone` will set the current milestone as the 
default for future PRs for this repo and language
   
   You can disable automated security fix PRs for this repo from the [Security 
Alerts page](https://github.com/apache/gora/network/alerts).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] dependabot[bot] opened a new pull request, #264: Bump derby from 10.9.1.0 to 10.14.2.0

[GitBox]

dependabot[bot] opened a new pull request, #264:
URL: https://github.com/apache/gora/pull/264

   Bumps derby from 10.9.1.0 to 10.14.2.0.
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.derby:derby=maven=10.9.1.0=10.14.2.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   - `@dependabot use these labels` will set the current labels as the default 
for future PRs for this repo and language
   - `@dependabot use these reviewers` will set the current reviewers as the 
default for future PRs for this repo and language
   - `@dependabot use these assignees` will set the current assignees as the 
default for future PRs for this repo and language
   - `@dependabot use this milestone` will set the current milestone as the 
default for future PRs for this repo and language
   
   You can disable automated security fix PRs for this repo from the [Security 
Alerts page](https://github.com/apache/gora/network/alerts).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] madhawa-gunasekara merged pull request #253: GORA-691 Upgrade Lucene driver to latest

[GitBox]

madhawa-gunasekara merged PR #253:
URL: https://github.com/apache/gora/pull/253


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] dependabot[bot] opened a new pull request, #261: Bump netty-all from 4.1.36.Final to 4.1.42.Final in /gora-redis

[GitBox]

dependabot[bot] opened a new pull request, #261:
URL: https://github.com/apache/gora/pull/261

   Bumps [netty-all](https://github.com/netty/netty) from 4.1.36.Final to 
4.1.42.Final.
   
   Commits
   
   https://github.com/netty/netty/commit/bd907c3b3acf3d746ad1143270224aa0f784cd1b;>bd907c3
 [maven-release-plugin] prepare release netty-4.1.42.Final
   https://github.com/netty/netty/commit/2791f0fefac82663ca09dc8aa5dda024152c92f8;>2791f0f
 Avoid use of global AtomicLong for ScheduledFutureTask ids (https://github-redirect.dependabot.com/netty/netty/issues/9599;>#9599)
   https://github.com/netty/netty/commit/86ff76a4f77662fe1bf61deeec5f3e39e16d4020;>86ff76a
 Fix incorrect comment  (https://github-redirect.dependabot.com/netty/netty/issues/9598;>#9598)
   https://github.com/netty/netty/commit/5e69a13c21bcf89bf26dbf1421c5ec8188561a17;>5e69a13
 Cleanup JNI code to always correctly free memory when loading fails and also 
...
   https://github.com/netty/netty/commit/eb3c4bd926e697da3ea16079a5f4211adb375ea5;>eb3c4bd
 ChunkedNioFile can use absolute FileChannel::read to read chunks (https://github-redirect.dependabot.com/netty/netty/issues/9592;>#9592)
   https://github.com/netty/netty/commit/76592db0bde9d4908191c2d7e54af3466ffd4673;>76592db
 Close eventfd shutdown/wakeup race by closely tracking epoll edges (https://github-redirect.dependabot.com/netty/netty/issues/9586;>#9586)
   https://github.com/netty/netty/commit/0a2d85f1d32749eb278b27502ba7de20de958485;>0a2d85f
 Fix GraalVM native image build error (https://github-redirect.dependabot.com/netty/netty/issues/9593;>#9593)
   https://github.com/netty/netty/commit/dc4de7fbb4e17c606c92c542d5015042ada48e38;>dc4de7f
 We need to use NewGloblRef when caching jclass instances (https://github-redirect.dependabot.com/netty/netty/issues/9595;>#9595)
   https://github.com/netty/netty/commit/4499384135cdaca5ccdda85b0c9610d4ecd6c3cc;>4499384
 Update to netty-tcnative 2.0.26.Final (https://github-redirect.dependabot.com/netty/netty/issues/9589;>#9589)
   https://github.com/netty/netty/commit/8648171abc27497d87a8b47e509e8adabd622f5b;>8648171
 Fix *SslEngineTest to not throw ClassCastException and pass in all cases (https://github-redirect.dependabot.com/netty/netty/issues/9588;>#9588)
   Additional commits viewable in https://github.com/netty/netty/compare/netty-4.1.36.Final...netty-4.1.42.Final;>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=io.netty:netty-all=maven=4.1.36.Final=4.1.42.Final)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   - `@dependabot use these labels` will set the current labels as the default 
for future PRs for this repo and language
   - `@dependabot use these reviewers` will set the current reviewers as the 
default for future PRs for this repo and language
   - `@dependabot use these assignees` will set the current assignees as the 
default for future PRs for this repo and language
   - `@dependabot use this milestone` will set the current milestone as the 
default for future PRs for this repo and language
   
   You can disable automated security fix PRs for this repo from the [Security 
Alerts page](https://github.com/apache/gora/network/alerts).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on 

[GitHub] [gora] dependabot[bot] opened a new pull request, #263: Bump ant from 1.8.2 to 1.10.11

[GitBox]

dependabot[bot] opened a new pull request, #263:
URL: https://github.com/apache/gora/pull/263

   Bumps ant from 1.8.2 to 1.10.11.
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.ant:ant=maven=1.8.2=1.10.11)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   - `@dependabot use these labels` will set the current labels as the default 
for future PRs for this repo and language
   - `@dependabot use these reviewers` will set the current reviewers as the 
default for future PRs for this repo and language
   - `@dependabot use these assignees` will set the current assignees as the 
default for future PRs for this repo and language
   - `@dependabot use this milestone` will set the current milestone as the 
default for future PRs for this repo and language
   
   You can disable automated security fix PRs for this repo from the [Security 
Alerts page](https://github.com/apache/gora/network/alerts).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] dependabot[bot] opened a new pull request, #260: Bump accumulo-core from 1.7.1 to 1.10.1 in /gora-accumulo

[GitBox]

dependabot[bot] opened a new pull request, #260:
URL: https://github.com/apache/gora/pull/260

   Bumps [accumulo-core](https://github.com/apache/accumulo) from 1.7.1 to 
1.10.1.
   
   Commits
   
   https://github.com/apache/accumulo/commit/2ede18d4d00e48300e289666069aaa44ec341ff6;>2ede18d
 [maven-release-plugin] prepare release rel/1.10.1
   https://github.com/apache/accumulo/commit/0773baac791ab2055d949bd62948d2ba39cca1a3;>0773baa
 Fix https://github-redirect.dependabot.com/apache/accumulo/issues/1792;>#1792
 flaky/broken GcMetricsIT
   https://github.com/apache/accumulo/commit/8433b587a674343253626a7f498eb38b76b8556e;>8433b58
 Add additional permission checks (https://github-redirect.dependabot.com/apache/accumulo/issues/1832;>#1832)
   https://github.com/apache/accumulo/commit/d4fd27f32dc2611a23f67b1d3e8dafd8ee05a1cb;>d4fd27f
 Backport JUnit upgrade from https://github-redirect.dependabot.com/apache/accumulo/issues/1562;>#1562
 to 1.10.1
   https://github.com/apache/accumulo/commit/56142a89952533fef922fa86739a879c073e7c2a;>56142a8
 Throw sercurity exceptions when permissions checks fail. Backport to 1.10 (https://github-redirect.dependabot.com/apache/accumulo/issues/1;>#1...
   https://github.com/apache/accumulo/commit/b8fd34907155df4d69202b95183b3934ca660d95;>b8fd349
 Improve log message in Delete CleanUp FATE. (https://github-redirect.dependabot.com/apache/accumulo/issues/1829;>#1829)
   https://github.com/apache/accumulo/commit/7e2e09e0656d40adce178420be8e66cffee0a4f2;>7e2e09e
 Backport some GcMetricsIT test stability to 1.10
   https://github.com/apache/accumulo/commit/61840580b448b68d7af67bfb8440db00cedebd0e;>6184058
 Minor fixup of build
   https://github.com/apache/accumulo/commit/64e01c8d339dece29cc51c0630c5cc62e0ac9bda;>64e01c8
 Make skipQA profile more human-proof (https://github-redirect.dependabot.com/apache/accumulo/issues/1807;>#1807)
   https://github.com/apache/accumulo/commit/252897d7e59bd8da8dd351a42e1c822008f08d8e;>252897d
 Back port https://github-redirect.dependabot.com/apache/accumulo/issues/1754;>#1754
 to 1.10
   Additional commits viewable in https://github.com/apache/accumulo/compare/rel/1.7.1...rel/1.10.1;>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.accumulo:accumulo-core=maven=1.7.1=1.10.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   - `@dependabot use these labels` will set the current labels as the default 
for future PRs for this repo and language
   - `@dependabot use these reviewers` will set the current reviewers as the 
default for future PRs for this repo and language
   - `@dependabot use these assignees` will set the current assignees as the 
default for future PRs for this repo and language
   - `@dependabot use this milestone` will set the current milestone as the 
default for future PRs for this repo and language
   
   You can disable automated security fix PRs for this repo from the [Security 
Alerts page](https://github.com/apache/gora/network/alerts).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:

[GitHub] [gora] dependabot[bot] opened a new pull request, #259: Bump accumulo-core from 1.6.4 to 1.10.1 in /gora-goraci

[GitBox]

dependabot[bot] opened a new pull request, #259:
URL: https://github.com/apache/gora/pull/259

   Bumps [accumulo-core](https://github.com/apache/accumulo) from 1.6.4 to 
1.10.1.
   
   Commits
   
   https://github.com/apache/accumulo/commit/2ede18d4d00e48300e289666069aaa44ec341ff6;>2ede18d
 [maven-release-plugin] prepare release rel/1.10.1
   https://github.com/apache/accumulo/commit/0773baac791ab2055d949bd62948d2ba39cca1a3;>0773baa
 Fix https://github-redirect.dependabot.com/apache/accumulo/issues/1792;>#1792
 flaky/broken GcMetricsIT
   https://github.com/apache/accumulo/commit/8433b587a674343253626a7f498eb38b76b8556e;>8433b58
 Add additional permission checks (https://github-redirect.dependabot.com/apache/accumulo/issues/1832;>#1832)
   https://github.com/apache/accumulo/commit/d4fd27f32dc2611a23f67b1d3e8dafd8ee05a1cb;>d4fd27f
 Backport JUnit upgrade from https://github-redirect.dependabot.com/apache/accumulo/issues/1562;>#1562
 to 1.10.1
   https://github.com/apache/accumulo/commit/56142a89952533fef922fa86739a879c073e7c2a;>56142a8
 Throw sercurity exceptions when permissions checks fail. Backport to 1.10 (https://github-redirect.dependabot.com/apache/accumulo/issues/1;>#1...
   https://github.com/apache/accumulo/commit/b8fd34907155df4d69202b95183b3934ca660d95;>b8fd349
 Improve log message in Delete CleanUp FATE. (https://github-redirect.dependabot.com/apache/accumulo/issues/1829;>#1829)
   https://github.com/apache/accumulo/commit/7e2e09e0656d40adce178420be8e66cffee0a4f2;>7e2e09e
 Backport some GcMetricsIT test stability to 1.10
   https://github.com/apache/accumulo/commit/61840580b448b68d7af67bfb8440db00cedebd0e;>6184058
 Minor fixup of build
   https://github.com/apache/accumulo/commit/64e01c8d339dece29cc51c0630c5cc62e0ac9bda;>64e01c8
 Make skipQA profile more human-proof (https://github-redirect.dependabot.com/apache/accumulo/issues/1807;>#1807)
   https://github.com/apache/accumulo/commit/252897d7e59bd8da8dd351a42e1c822008f08d8e;>252897d
 Back port https://github-redirect.dependabot.com/apache/accumulo/issues/1754;>#1754
 to 1.10
   Additional commits viewable in https://github.com/apache/accumulo/compare/1.6.4...rel/1.10.1;>compare 
view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.accumulo:accumulo-core=maven=1.6.4=1.10.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   - `@dependabot use these labels` will set the current labels as the default 
for future PRs for this repo and language
   - `@dependabot use these reviewers` will set the current reviewers as the 
default for future PRs for this repo and language
   - `@dependabot use these assignees` will set the current assignees as the 
default for future PRs for this repo and language
   - `@dependabot use this milestone` will set the current milestone as the 
default for future PRs for this repo and language
   
   You can disable automated security fix PRs for this repo from the [Security 
Alerts page](https://github.com/apache/gora/network/alerts).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:

[GitHub] [gora] dependabot[bot] opened a new pull request, #262: Bump cassandra-all from 3.11.0 to 3.11.12

[GitBox]

dependabot[bot] opened a new pull request, #262:
URL: https://github.com/apache/gora/pull/262

   Bumps cassandra-all from 3.11.0 to 3.11.12.
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.cassandra:cassandra-all=maven=3.11.0=3.11.12)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   - `@dependabot use these labels` will set the current labels as the default 
for future PRs for this repo and language
   - `@dependabot use these reviewers` will set the current reviewers as the 
default for future PRs for this repo and language
   - `@dependabot use these assignees` will set the current assignees as the 
default for future PRs for this repo and language
   - `@dependabot use this milestone` will set the current milestone as the 
default for future PRs for this repo and language
   
   You can disable automated security fix PRs for this repo from the [Security 
Alerts page](https://github.com/apache/gora/network/alerts).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] madhawa-gunasekara merged pull request #254: GORA-692 Upgrade MongoDB java driver

[GitBox]

madhawa-gunasekara merged PR #254:
URL: https://github.com/apache/gora/pull/254


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] madhawa-gunasekara merged pull request #258: Upgrade Cassandra driver version

[GitBox]

madhawa-gunasekara merged PR #258:
URL: https://github.com/apache/gora/pull/258


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] dependabot[bot] opened a new pull request, #257: Bump hadoop-common from 2.5.2 to 3.2.3 in /gora-jet

[GitBox]

dependabot[bot] opened a new pull request, #257:
URL: https://github.com/apache/gora/pull/257

   Bumps hadoop-common from 2.5.2 to 3.2.3.
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.hadoop:hadoop-common=maven=2.5.2=3.2.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   - `@dependabot use these labels` will set the current labels as the default 
for future PRs for this repo and language
   - `@dependabot use these reviewers` will set the current reviewers as the 
default for future PRs for this repo and language
   - `@dependabot use these assignees` will set the current assignees as the 
default for future PRs for this repo and language
   - `@dependabot use this milestone` will set the current milestone as the 
default for future PRs for this repo and language
   
   You can disable automated security fix PRs for this repo from the [Security 
Alerts page](https://github.com/apache/gora/network/alerts).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] nbrendah edited a comment on pull request #249: GORA-651: Upgrade OrientDB to the latest version 3

[GitBox]

nbrendah edited a comment on pull request #249:
URL: https://github.com/apache/gora/pull/249#issuecomment-963811996


   Hello @djkevincr @lewismc 
   May you please kindly take a look at this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] nbrendah commented on pull request #249: GORA-651: Upgrade OrientDB to the latest version 3

[GitBox]

nbrendah commented on pull request #249:
URL: https://github.com/apache/gora/pull/249#issuecomment-963811996


   Hello @djkevincr @lewismc 
   May your please take a look at this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] nbrendah commented on pull request #251: GORA-276: Refactor and organize o.a.g.mapreduce package naming

[GitBox]

nbrendah commented on pull request #251:
URL: https://github.com/apache/gora/pull/251#issuecomment-963728763


   I had to send an empty commit to re-run the build.
   I guess it passes and we continue with our discussion


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] nbrendah commented on pull request #248: GORA-537: Upgrade to Hadoop 3.X

[GitBox]

nbrendah commented on pull request #248:
URL: https://github.com/apache/gora/pull/248#issuecomment-963721790


   @lewismc @djkevincr 
   Based on the dependence requirements at 
https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-common/dependency-analysis.html,
 I thought it would be important to upgrade org.eclipse.jetty to 
`9.4.40.v20210413`
   
   My local instance is still having errors on building with maven.  I have 
reset it to `upstream/master` and pulled the latest changes but keep on getting 
errors.
   
   As far as I know, if it passes on upstream, it must pass locally unless 
there is some initial developers' setup task I haven't finished yet.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] nbrendah commented on pull request #251: GORA-276: Refactor and organize o.a.g.mapreduce package naming

[GitBox]

nbrendah commented on pull request #251:
URL: https://github.com/apache/gora/pull/251#issuecomment-963651500


   Sorry @lewismc for taking long without replying to this.  I was finishing my 
outreachy application 
   
   
   
   >  This patch introduces a major API break... so we need to think about how 
clients will address that.
   
   @lewismc @djkevincr Should we create documentation to show this change or I 
close this because negative results outweigh the positive?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] lewismc commented on pull request #251: GORA-276: Refactor and organize o.a.g.mapreduce package naming

[GitBox]

lewismc commented on pull request #251:
URL: https://github.com/apache/gora/pull/251#issuecomment-960458329


   This is a real blast from the past @nbrendah 
   This patch introduces a major API break... so we need to think about how 
clients will address that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] nbrendah commented on pull request #248: GORA-537: Upgrade to Hadoop 3.X

[GitBox]

nbrendah commented on pull request #248:
URL: https://github.com/apache/gora/pull/248#issuecomment-958180480


   Its so nice to here form you @djkevincr
   I will add tests for this in 8 hours time
   Thank you so much.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] djkevincr commented on pull request #248: GORA-537: Upgrade to Hadoop 3.X

[GitBox]

djkevincr commented on pull request #248:
URL: https://github.com/apache/gora/pull/248#issuecomment-958088664


   @nbrendah Thank you for the PR. There s already PR raised for the issue in 
https://github.com/apache/gora/pull/220 Basically this is basically a major 
version upgrade, probably there can API changes, please check all the test 
cases passes with the version upgrade.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] djkevincr commented on pull request #250: GORA-630 Move hadoop-common dependencies from gora-hive pom to gora parent pom

[GitBox]

djkevincr commented on pull request #250:
URL: https://github.com/apache/gora/pull/250#issuecomment-958079050


   @khadijm Thank you for the PR. we basically had transitive dependency issue 
where the same jar exists multiple versions in class path that made a build 
failure. Please do full build using mvn clean install and see whether there s 
build failure when running tests. And see how can avoid this particular 
dependency conflict.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] djkevincr commented on pull request #249: GORA-651: Upgrade OrientDB to the latest version 3

[GitBox]

djkevincr commented on pull request #249:
URL: https://github.com/apache/gora/pull/249#issuecomment-958083777


   @nbrendah Thank you for the PR. This is main version upgrade and you will 
probably have compilation errors due to API changes. Please execute tests using 
mvn clean install and see how you can upgrade API to new version and the same 
time check whether all tests pass for orientdb store.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] djkevincr commented on pull request #248: GORA-537: Upgrade to Hadoop 3.X

[GitBox]

djkevincr commented on pull request #248:
URL: https://github.com/apache/gora/pull/248#issuecomment-958088664


   @nbrendah Thank you for the PR. There s already PR raised for the issue in 
https://github.com/apache/gora/pull/220 Basically this is basically a major 
version upgrade, probably there can API changes, please check all the test 
cases passes with the version upgrade.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] djkevincr commented on pull request #249: GORA-651: Upgrade OrientDB to the latest version 3

[GitBox]

djkevincr commented on pull request #249:
URL: https://github.com/apache/gora/pull/249#issuecomment-958083777


   @nbrendah Thank you for the PR. This is main version upgrade and you will 
probably have compilation errors due to API changes. Please execute tests using 
mvn clean install and see how you can upgrade API to new version and the same 
time check whether all tests pass for orientdb store.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] djkevincr commented on pull request #250: GORA-630 Move hadoop-common dependencies from gora-hive pom to gora parent pom

[GitBox]

djkevincr commented on pull request #250:
URL: https://github.com/apache/gora/pull/250#issuecomment-958079050


   @khadijm Thank you for the PR. we basically had transitive dependency issue 
where the same jar exists multiple versions in class path that made a build 
failure. Please do full build using mvn clean install and see whether there s 
build failure when running tests. And see how can avoid this particular 
dependency conflict.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] nbrendah edited a comment on pull request #251: GORA-276: Refactor and organize o.a.g.mapreduce package naming

[GitBox]

nbrendah edited a comment on pull request #251:
URL: https://github.com/apache/gora/pull/251#issuecomment-954303920


   > Yeah I saw that and I tried to fix it.
   
   @lewismc I saw your current commit 
https://github.com/apache/gora/commit/44ecabb241201c37f94ade36806b2070eca0144c 
.  It was passing build, though failing with sonar scanners.
   However, most of these builds pass locally. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] nbrendah commented on pull request #251: GORA-276: Refactor and organize o.a.g.mapreduce package naming

[GitBox]

nbrendah commented on pull request #251:
URL: https://github.com/apache/gora/pull/251#issuecomment-954303920


   > Yeah I saw that and I tried to fix it.
   
   @lewismc I saw your current build.  It was passing build, though failing 
with sonar scanners.
   However, most of these builds pass locally. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] lewismc commented on pull request #251: GORA-276: Refactor and organize o.a.g.mapreduce package naming

[GitBox]

lewismc commented on pull request #251:
URL: https://github.com/apache/gora/pull/251#issuecomment-954302442


   Yeah I saw that and I tried to fix it.
   @djkevincr do you know when the Github Actions build started failing?
   I did see 
https://github.com/actions/first-interaction/issues/10#issuecomment-910605074


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] nbrendah edited a comment on pull request #251: GORA-276: Refactor and organize o.a.g.mapreduce package naming

[GitBox]

nbrendah edited a comment on pull request #251:
URL: https://github.com/apache/gora/pull/251#issuecomment-954249750


   My PR is failing. @lewismc, what is the cause of
   ```
   Going to parse results form **/*-reports/TEST-*.xml
   Result: 1352 tests run, 29 skipped, 0 failed.
   Posting status 'completed' with conclusion 'success' to 
https://github.com/apache/gora/pull/251 (sha: 
07293dc17249838fb781c01ca624318f4b29917e)
   Error: Resource not accessible by integration
   ```
   ![Screenshot from 2021-10-29 
00-49-19](https://user-images.githubusercontent.com/92251087/139341318-8ba93db7-34c2-430f-b5e7-62bb006d7cd9.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] nbrendah commented on pull request #251: GORA-276: Refactor and organize o.a.g.mapreduce package naming

[GitBox]

nbrendah commented on pull request #251:
URL: https://github.com/apache/gora/pull/251#issuecomment-954249750


   My PR is failing.  What is the meaning of 
   ```
Going to parse results form **/*-reports/TEST-*.xml
   Result: 1352 tests run, 29 skipped, 0 failed.
   Posting status 'completed' with conclusion 'success' to 
https://github.com/apache/gora/pull/251 (sha: 
07293dc17249838fb781c01ca624318f4b29917e)
   Error: Resource not accessible by integration
   ```
   ![Screenshot from 2021-10-29 
00-49-19](https://user-images.githubusercontent.com/92251087/139341318-8ba93db7-34c2-430f-b5e7-62bb006d7cd9.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] nbrendah opened a new pull request #251: GORA-276: Refactor and organize o.a.g.mapreduce package naming

[GitBox]

nbrendah opened a new pull request #251:
URL: https://github.com/apache/gora/pull/251


   Issue Link:  https://issues.apache.org/jira/browse/GORA-276
   
   Migrated classes in package  `org.apache.gora.mapreduce` to 
org.apache.gora.io.serializer
   
   cc @djkevincr


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] khadijm commented on pull request #250: GORA-630 Move hadoop-common dependencies from gora-hive pom to gora parent pom

[GitBox]

khadijm commented on pull request #250:
URL: https://github.com/apache/gora/pull/250#issuecomment-950010559


   this is the first step after that i will be able to move to junit test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] khadijm opened a new pull request #250: GORA-630 Move hadoop-common dependencies from gora-hive pom to gora parent pom

[GitBox]

khadijm opened a new pull request #250:
URL: https://github.com/apache/gora/pull/250


   
   as describe here https://issues.apache.org/jira/browse/GORA-630 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] nbrendah opened a new pull request #249: GORA-651: Upgrade OrientDB to the latest version 3

[GitBox]

nbrendah opened a new pull request #249:
URL: https://github.com/apache/gora/pull/249


   **Issue Link:**  https://issues.apache.org/jira/browse/GORA-651
   
   I have updated upgraded the version of OrientDB to 3.2.2
   All tests are passing locally.  Maybe it could on the upstream.
   
   cc @djkevincr 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] nbrendah opened a new pull request #248: GORA-537: Upgrade to Hadoop 3.X

[GitBox]

nbrendah opened a new pull request #248:
URL: https://github.com/apache/gora/pull/248


   This PR is raised in reaction to issue 
https://issues.apache.org/jira/browse/GORA-537
   Some tests are still failing though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] 100202x edited a comment on pull request #246: Add SQL store on JOOQ

[GitBox]

100202x edited a comment on pull request #246:
URL: https://github.com/apache/gora/pull/246#issuecomment-903323925


   Update : There are 44 test cases in GoraTestBase and 19 test cases are 
getting through without a problem in this PR. But most essentials one where 
persisting objects is happening while searching and deleting support is being 
added via JOOQ library for mysql database. Most test cases are failing because 
that test cases contains complex data structures such as RECORD, MAP & ARRAY 
where those are persisted in the database but the conversion of these db fields 
to Avro beans isn't implemented yet apart from the Union shema type. Adding 
support to complex data structures alone will pass most of the test cases which 
are failing. WebPage table uses lot of these complex datatypes to store its 
data where my current datastore doesn't provide the support to these schema 
types is what causing the failure of test cases.
   
   But if you run this datastore with simple data types such as string and 
integers the datastore works without a problem. Regardless of the out come of 
the Gsoc Project I am planning to contribute to the project and finish this 
datastore. There are few more code tweaks to support all relational database 
such as connection string such as that and to specify. Added that this project 
will be complete. There is one more main method from the datastore which i 
didn't implement is delete by query. Which i will be doing in the future as 
well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] 100202x commented on pull request #246: Add SQL store on JOOQ

[GitBox]

100202x commented on pull request #246:
URL: https://github.com/apache/gora/pull/246#issuecomment-903323925


   Update : There are 44 test cases in GoraTestBase and 19 test cases are 
getting through without a problem in this PR. But most essentials one where 
persisting objects is happening while searching and deleting support is being 
added via JOOQ library for mysql database. Most test cases are failing because 
that test cases contains complex data structures such as RECORD, MAP & ARRAY 
where those are persisted in the database but the conversion of these db fields 
to Avro beans isn't implemented yet apart from the Union shema type. 
   
   But if you run this datastore with simple data types such as string and 
integers the datastore works without a problem. Regardless of the out come of 
the Gsoc Project I am planning to contribute to the project and finish this 
datastore. There are few more code tweaks to support all relational database 
such as connection string such as that and to specify. Added that this project 
will be complete. There is one more main method from the datastore which i 
didn't implement is delete by query. Which i will be doing in the future as 
well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] madhawa-gunasekara merged pull request #245: Update mongodb driver version to 3.12.8

[GitBox]

madhawa-gunasekara merged pull request #245:
URL: https://github.com/apache/gora/pull/245


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] madhawa-gunasekara merged pull request #238: GORA-677 Upgrade Ignite version 2.10.0

[GitBox]

madhawa-gunasekara merged pull request #238:
URL: https://github.com/apache/gora/pull/238


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] djkevincr commented on pull request #240: GORA-678 Upgrade to JDK11

[GitBox]

djkevincr commented on pull request #240:
URL: https://github.com/apache/gora/pull/240#issuecomment-897133583


   @lewismc Initial work looks great. Any update on this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] djkevincr commented on pull request #244: GORA-680 Upgrade Avro from 1.8.2 --> 1.10.2

[GitBox]

djkevincr commented on pull request #244:
URL: https://github.com/apache/gora/pull/244#issuecomment-897132355


   @lewismc Initial work looks great. Any update on this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] djkevincr merged pull request #247: GORA-664 Fix build issue with testcases / formatting

[GitBox]

djkevincr merged pull request #247:
URL: https://github.com/apache/gora/pull/247


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] djkevincr merged pull request #234: GORA-664 Add datastore for Elasticsearch

[GitBox]

djkevincr merged pull request #234:
URL: https://github.com/apache/gora/pull/234


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] 100202x opened a new pull request #246: Add SQL store on JOOQ

[GitBox]

100202x opened a new pull request #246:
URL: https://github.com/apache/gora/pull/246


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gora.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] lewismc commented on pull request #245: Update mongodb driver version to 3.12.8

[GitBox]

lewismc commented on pull request #245:
URL: https://github.com/apache/gora/pull/245#issuecomment-856112487


   Build error is 
   ```
   Error:  Failed to execute goal on project gora-hive: Could not resolve 
dependencies for project org.apache.gora:gora-hive:bundle:1.0-SNAPSHOT: Failed 
to collect dependencies at org.apache.hive:hive-service:jar:2.3.8 -> 
org.apache.hive:hive-exec:jar:2.3.8 -> 
org.pentaho:pentaho-aggdesigner-algorithm:jar:5.1.5-jhyde: Failed to read 
artifact descriptor for 
org.pentaho:pentaho-aggdesigner-algorithm:jar:5.1.5-jhyde: Could not transfer 
artifact org.pentaho:pentaho-aggdesigner-algorithm:pom:5.1.5-jhyde from/to 
maven-default-http-blocker (http://0.0.0.0/): Blocked mirror for repositories: 
[conjars (http://conjars.org/repo, default, releases+snapshots), 
apache.snapshots (http://repository.apache.org/snapshots, default, snapshots)] 
-> [Help 1]
   ```
   ... however I cannot reproduce this locally. Can anyone else?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] madhawa-gunasekara commented on pull request #238: GORA-677 Upgrade Ignite version 2.10.0

[GitBox]

madhawa-gunasekara commented on pull request #238:
URL: https://github.com/apache/gora/pull/238#issuecomment-855409797


   Thanks,  @100202x for the pull request


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] madhawa-gunasekara merged pull request #237: GORA-676 Upgrade Aerospike 5.0.6

[GitBox]

madhawa-gunasekara merged pull request #237:
URL: https://github.com/apache/gora/pull/237


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] madhawa-gunasekara commented on pull request #237: GORA-676 Upgrade Aerospike 5.0.6

[GitBox]

madhawa-gunasekara commented on pull request #237:
URL: https://github.com/apache/gora/pull/237#issuecomment-855409178


   Thanks, @100202x for the contribution. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] 100202x opened a new pull request #245: Update mongodb driver version to 3.12.8

[GitBox]

100202x opened a new pull request #245:
URL: https://github.com/apache/gora/pull/245


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] lewismc merged pull request #242: GORA-679 Fix CI build issue

[GitBox]

lewismc merged pull request #242:
URL: https://github.com/apache/gora/pull/242


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] podorvanova commented on pull request #234: GORA-664 Add datastore for Elasticsearch

[GitBox]

podorvanova commented on pull request #234:
URL: https://github.com/apache/gora/pull/234#issuecomment-843754824


   Thanks @kamaci for your feedback! I have updated the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] balashashanka commented on pull request #220: GORA-537: [WIP] Upgrade to Hadoop 3.X

[GitBox]

balashashanka commented on pull request #220:
URL: https://github.com/apache/gora/pull/220#issuecomment-841627206


   Hi @kamaci, will take a look at it now. There were few internal dependencies 
which we might need to upgrade will push new changes in some time. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] kamaci commented on a change in pull request #189: GORA-464 Get gora-dynamodb back up and running and available as part of the examples

[GitBox]

kamaci commented on a change in pull request #189:
URL: https://github.com/apache/gora/pull/189#discussion_r632682377



##
File path: gora-dynamodb/howto_upgrade.md
##
@@ -0,0 +1,19 @@
+# Howto upgrade aaws-java-sdk version

Review comment:
   Typo, aaws-java-sdk version -> aws-java-sdk version




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] kamaci commented on a change in pull request #210: GORA-651 upgrade Orient DB driver to version 3

[GitBox]

kamaci commented on a change in pull request #210:
URL: https://github.com/apache/gora/pull/210#discussion_r632680001



##
File path: 
gora-orientdb/src/main/java/org/apache/gora/orientdb/store/OrientDBStore.java
##
@@ -103,20 +109,36 @@ public void initialize(Class keyClass, Class 
persistentClass, Properties p
   ROOT_URL = 
"remote:".concat(orientDbStoreParams.getServerHost()).concat(":")
   .concat(orientDbStoreParams.getServerPort());
   ROOT_DATABASE_URL = 
ROOT_URL.concat("/").concat(orientDbStoreParams.getDatabaseName());
-  remoteServerAdmin = new 
OServerAdmin(ROOT_URL).connect(orientDbStoreParams.getUserName(),
-  orientDbStoreParams.getUserPassword());
-  if 
(!remoteServerAdmin.existsDatabase(orientDbStoreParams.getDatabaseName(), 
"memory")) {
-
remoteServerAdmin.createDatabase(orientDbStoreParams.getDatabaseName(), 
"document", "memory");
-  }
-
-  if (orientDbStoreParams.getConnectionPoolSize() != null) {
-int connPoolSize = 
Integer.valueOf(orientDbStoreParams.getConnectionPoolSize());
-connectionPool = new OPartitionedDatabasePoolFactory(connPoolSize)
-.get(ROOT_DATABASE_URL, orientDbStoreParams.getUserName(),
-orientDbStoreParams.getUserPassword());
+  remoteServerAdmin = new OrientDB(ROOT_URL, 
orientDbStoreParams.getUserName(),
+  orientDbStoreParams.getUserPassword(), 
OrientDBConfig.defaultConfig());
+  if (!remoteServerAdmin.exists(orientDbStoreParams.getDatabaseName())) {
+remoteServerAdmin.create(orientDbStoreParams.getDatabaseName(),
+
ODatabaseType.valueOf(orientDbStoreParams.getStorageType().toUpperCase()));

Review comment:
   Please pass `Locale.ENGLISH` to `toUpperCase`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] kamaci commented on pull request #218: [GORA-650] [WIP] Add initial ArangoDB datastore

[GitBox]

kamaci commented on pull request #218:
URL: https://github.com/apache/gora/pull/218#issuecomment-841386840


   Thanks @dinuka-perera!
   
   Please review my comments and resolve the conflict.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] kamaci commented on a change in pull request #218: [GORA-650] [WIP] Add initial ArangoDB datastore

[GitBox]

kamaci commented on a change in pull request #218:
URL: https://github.com/apache/gora/pull/218#discussion_r632677448



##
File path: 
gora-arangodb/src/test/java/org/apache/gora/arangodb/ArangoDBTestDriver.java
##
@@ -0,0 +1,85 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.arangodb;
+
+import org.apache.gora.GoraTestDriver;
+import org.apache.gora.arangodb.store.ArangoDBStore;
+import org.apache.gora.arangodb.store.ArangoDBStoreParameters;
+import org.apache.gora.persistency.Persistent;
+import org.apache.gora.store.DataStore;
+import org.apache.gora.store.DataStoreFactory;
+import org.apache.gora.util.GoraException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.testcontainers.containers.GenericContainer;
+
+/**
+ * Driver to set up an embedded ArangoDB database instance for Gora
+ * dataStore specific integration tests.
+ */
+public class ArangoDBTestDriver extends GoraTestDriver {
+
+  private static Logger log = 
LoggerFactory.getLogger(ArangoDBTestDriver.class);
+
+  private GenericContainer arangodbContainer;
+
+  public ArangoDBTestDriver(GenericContainer arangodbContainer) {
+super(ArangoDBStore.class);
+this.arangodbContainer = arangodbContainer;
+  }
+
+
+  public ArangoDBTestDriver() {
+super(ArangoDBStore.class);
+  }
+
+  /**
+   * Initialize embedded ArangoDB server instance as per the 
gora-arangodb-mapping.xml
+   * server configuration file.
+   */
+  @Override
+  public void setUpClass() throws Exception {
+log.info("Setting up ArangoDB test driver");
+conf.set(ArangoDBStoreParameters.ARANGO_DB_SERVER_HOST, "localhost");
+conf.set(ArangoDBStoreParameters.ARANGO_DB_SERVER_PORT,
+arangodbContainer.getMappedPort(8529).toString());
+log.info("ArangoDB Embedded Server started successfully.");
+  }
+
+  /**
+   * Terminate embedded ArangoDB server.
+   */
+  @Override
+  public void tearDownClass() throws Exception {
+log.info("ArangoDB Embedded server instance terminated successfully.");
+  }
+
+  @Override
+  public  DataStore createDataStore(Class 
keyClass,
+   Class 
persistentClass) throws GoraException {
+

Review comment:
   Remove extra space




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] kamaci commented on a change in pull request #218: [GORA-650] [WIP] Add initial ArangoDB datastore

[GitBox]

kamaci commented on a change in pull request #218:
URL: https://github.com/apache/gora/pull/218#discussion_r632677158



##
File path: 
gora-arangodb/src/main/java/org/apache/gora/arangodb/store/ArangoDBStore.java
##
@@ -0,0 +1,690 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.arangodb.store;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.Base64;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Properties;
+import java.util.List;
+import java.util.ArrayList;
+
+import com.arangodb.ArangoDB;
+import com.arangodb.entity.BaseDocument;
+import org.apache.avro.Schema;
+import org.apache.avro.util.Utf8;
+import org.apache.gora.arangodb.query.ArangoDBQuery;
+import org.apache.gora.persistency.impl.BeanFactoryImpl;
+import org.apache.gora.persistency.impl.DirtyListWrapper;
+import org.apache.gora.persistency.impl.DirtyMapWrapper;
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.query.PartitionQuery;
+import org.apache.gora.query.Query;
+import org.apache.gora.query.Result;
+import org.apache.gora.query.impl.PartitionQueryImpl;
+import org.apache.gora.store.impl.DataStoreBase;
+import org.apache.gora.util.AvroUtils;
+import org.apache.gora.util.ClassLoadingUtils;
+import org.apache.gora.util.GoraException;
+
+
+/**
+ * {@inheritDoc}
+ * {@link org.apache.gora.arangodb.store.ArangoDBStore} is the primary class
+ * responsible for facilitating GORA CRUD operations on ArangoDB documents.
+ */
+public class ArangoDBStore extends 
DataStoreBase {
+
+  public static final String DEFAULT_MAPPING_FILE = 
"/gora-arangodb-mapping.xml";
+  private ArangoDBStoreParameters arangoDbStoreParams;
+  private ArangoDBMapping arangoDBMapping;
+  private ArangoDB arangoDB;
+
+  /**
+   * {@inheritDoc}
+   * Initialize the ArangoDB dataStore by {@link Properties} parameters.
+   *
+   * @param keyClasskey class type for dataStore.
+   * @param persistentClass persistent class type for dataStore.
+   * @param properties  ArangoDB dataStore properties EG:- ArangoDB client 
credentials.
+   */
+  @Override
+  public void initialize(Class keyClass, Class persistentClass, 
Properties properties) throws GoraException {
+super.initialize(keyClass, persistentClass, properties);
+try {
+  arangoDbStoreParams = ArangoDBStoreParameters.load(properties);
+  arangoDB = new ArangoDB.Builder()
+  .host(arangoDbStoreParams.getServerHost(),
+  Integer.valueOf(arangoDbStoreParams.getServerPort()))
+  .user(arangoDbStoreParams.getUserName())
+  .password(arangoDbStoreParams.getUserPassword())
+  
.maxConnections(Integer.valueOf(arangoDbStoreParams.getConnectionPoolSize()))
+  .build();
+  if (!arangoDB.db(arangoDbStoreParams.getDatabaseName()).exists())
+arangoDB.createDatabase(arangoDbStoreParams.getDatabaseName());
+
+  ArangoDBMappingBuilder builder = new 
ArangoDBMappingBuilder<>(this);
+  arangoDBMapping = 
builder.fromFile(arangoDbStoreParams.getMappingFile()).build();
+  if (!schemaExists()) {
+createSchema();
+  }
+} catch (Exception e) {
+  LOG.error("Error while initializing ArangoDB dataStore: {}",
+  new Object[]{e.getMessage()});
+  throw new RuntimeException(e);
+}
+  }
+
+  /**
+   * {@inheritDoc}
+   */
+  @Override
+  public String getSchemaName(final String mappingSchemaName,
+  final Class persistentClass) {
+return super.getSchemaName(mappingSchemaName, persistentClass);
+  }
+
+  /**
+   * {@inheritDoc}
+   */
+  @Override
+  public String getSchemaName() {
+return arangoDBMapping.getDocumentClass();
+  }
+
+  /**
+   * {@inheritDoc}
+   * Create a new class of ArangoDB documents if necessary. Enforce specified 
schema over the document class.
+   */
+  @Override
+  public void createSchema() throws GoraException {
+if (schemaExists()) {
+  return;
+}
+try {
+  arangoDB.db(arangoDbStoreParams.getDatabaseName())
+  .createCollection(arangoDBMapping.getDocumentClass());
+
+} 

[GitHub] [gora] kamaci commented on a change in pull request #218: [GORA-650] [WIP] Add initial ArangoDB datastore

[GitBox]

kamaci commented on a change in pull request #218:
URL: https://github.com/apache/gora/pull/218#discussion_r632676903



##
File path: 
gora-arangodb/src/main/java/org/apache/gora/arangodb/store/ArangoDBStore.java
##
@@ -0,0 +1,690 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.arangodb.store;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.Base64;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Properties;
+import java.util.List;
+import java.util.ArrayList;
+
+import com.arangodb.ArangoDB;
+import com.arangodb.entity.BaseDocument;
+import org.apache.avro.Schema;
+import org.apache.avro.util.Utf8;
+import org.apache.gora.arangodb.query.ArangoDBQuery;
+import org.apache.gora.persistency.impl.BeanFactoryImpl;
+import org.apache.gora.persistency.impl.DirtyListWrapper;
+import org.apache.gora.persistency.impl.DirtyMapWrapper;
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.query.PartitionQuery;
+import org.apache.gora.query.Query;
+import org.apache.gora.query.Result;
+import org.apache.gora.query.impl.PartitionQueryImpl;
+import org.apache.gora.store.impl.DataStoreBase;
+import org.apache.gora.util.AvroUtils;
+import org.apache.gora.util.ClassLoadingUtils;
+import org.apache.gora.util.GoraException;
+
+
+/**
+ * {@inheritDoc}
+ * {@link org.apache.gora.arangodb.store.ArangoDBStore} is the primary class
+ * responsible for facilitating GORA CRUD operations on ArangoDB documents.
+ */
+public class ArangoDBStore extends 
DataStoreBase {
+
+  public static final String DEFAULT_MAPPING_FILE = 
"/gora-arangodb-mapping.xml";
+  private ArangoDBStoreParameters arangoDbStoreParams;
+  private ArangoDBMapping arangoDBMapping;
+  private ArangoDB arangoDB;
+
+  /**
+   * {@inheritDoc}
+   * Initialize the ArangoDB dataStore by {@link Properties} parameters.
+   *
+   * @param keyClasskey class type for dataStore.
+   * @param persistentClass persistent class type for dataStore.
+   * @param properties  ArangoDB dataStore properties EG:- ArangoDB client 
credentials.
+   */
+  @Override
+  public void initialize(Class keyClass, Class persistentClass, 
Properties properties) throws GoraException {
+super.initialize(keyClass, persistentClass, properties);
+try {
+  arangoDbStoreParams = ArangoDBStoreParameters.load(properties);
+  arangoDB = new ArangoDB.Builder()
+  .host(arangoDbStoreParams.getServerHost(),
+  Integer.valueOf(arangoDbStoreParams.getServerPort()))
+  .user(arangoDbStoreParams.getUserName())
+  .password(arangoDbStoreParams.getUserPassword())
+  
.maxConnections(Integer.valueOf(arangoDbStoreParams.getConnectionPoolSize()))
+  .build();
+  if (!arangoDB.db(arangoDbStoreParams.getDatabaseName()).exists())
+arangoDB.createDatabase(arangoDbStoreParams.getDatabaseName());
+
+  ArangoDBMappingBuilder builder = new 
ArangoDBMappingBuilder<>(this);
+  arangoDBMapping = 
builder.fromFile(arangoDbStoreParams.getMappingFile()).build();
+  if (!schemaExists()) {
+createSchema();
+  }
+} catch (Exception e) {
+  LOG.error("Error while initializing ArangoDB dataStore: {}",
+  new Object[]{e.getMessage()});
+  throw new RuntimeException(e);
+}
+  }
+
+  /**
+   * {@inheritDoc}
+   */
+  @Override
+  public String getSchemaName(final String mappingSchemaName,
+  final Class persistentClass) {
+return super.getSchemaName(mappingSchemaName, persistentClass);
+  }
+
+  /**
+   * {@inheritDoc}
+   */
+  @Override
+  public String getSchemaName() {
+return arangoDBMapping.getDocumentClass();
+  }
+
+  /**
+   * {@inheritDoc}
+   * Create a new class of ArangoDB documents if necessary. Enforce specified 
schema over the document class.
+   */
+  @Override
+  public void createSchema() throws GoraException {
+if (schemaExists()) {
+  return;
+}
+try {
+  arangoDB.db(arangoDbStoreParams.getDatabaseName())
+  .createCollection(arangoDBMapping.getDocumentClass());
+
+} 

[GitHub] [gora] kamaci commented on a change in pull request #218: [GORA-650] [WIP] Add initial ArangoDB datastore

[GitBox]

kamaci commented on a change in pull request #218:
URL: https://github.com/apache/gora/pull/218#discussion_r632676232



##
File path: 
gora-arangodb/src/main/java/org/apache/gora/arangodb/store/ArangoDBStore.java
##
@@ -0,0 +1,690 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.arangodb.store;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.Base64;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Properties;
+import java.util.List;
+import java.util.ArrayList;
+
+import com.arangodb.ArangoDB;
+import com.arangodb.entity.BaseDocument;
+import org.apache.avro.Schema;
+import org.apache.avro.util.Utf8;
+import org.apache.gora.arangodb.query.ArangoDBQuery;
+import org.apache.gora.persistency.impl.BeanFactoryImpl;
+import org.apache.gora.persistency.impl.DirtyListWrapper;
+import org.apache.gora.persistency.impl.DirtyMapWrapper;
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.query.PartitionQuery;
+import org.apache.gora.query.Query;
+import org.apache.gora.query.Result;
+import org.apache.gora.query.impl.PartitionQueryImpl;
+import org.apache.gora.store.impl.DataStoreBase;
+import org.apache.gora.util.AvroUtils;
+import org.apache.gora.util.ClassLoadingUtils;
+import org.apache.gora.util.GoraException;
+
+
+/**
+ * {@inheritDoc}
+ * {@link org.apache.gora.arangodb.store.ArangoDBStore} is the primary class
+ * responsible for facilitating GORA CRUD operations on ArangoDB documents.
+ */
+public class ArangoDBStore extends 
DataStoreBase {
+
+  public static final String DEFAULT_MAPPING_FILE = 
"/gora-arangodb-mapping.xml";
+  private ArangoDBStoreParameters arangoDbStoreParams;
+  private ArangoDBMapping arangoDBMapping;
+  private ArangoDB arangoDB;
+
+  /**
+   * {@inheritDoc}
+   * Initialize the ArangoDB dataStore by {@link Properties} parameters.
+   *
+   * @param keyClasskey class type for dataStore.
+   * @param persistentClass persistent class type for dataStore.
+   * @param properties  ArangoDB dataStore properties EG:- ArangoDB client 
credentials.
+   */
+  @Override
+  public void initialize(Class keyClass, Class persistentClass, 
Properties properties) throws GoraException {
+super.initialize(keyClass, persistentClass, properties);
+try {
+  arangoDbStoreParams = ArangoDBStoreParameters.load(properties);
+  arangoDB = new ArangoDB.Builder()
+  .host(arangoDbStoreParams.getServerHost(),
+  Integer.valueOf(arangoDbStoreParams.getServerPort()))
+  .user(arangoDbStoreParams.getUserName())
+  .password(arangoDbStoreParams.getUserPassword())
+  
.maxConnections(Integer.valueOf(arangoDbStoreParams.getConnectionPoolSize()))
+  .build();
+  if (!arangoDB.db(arangoDbStoreParams.getDatabaseName()).exists())
+arangoDB.createDatabase(arangoDbStoreParams.getDatabaseName());
+
+  ArangoDBMappingBuilder builder = new 
ArangoDBMappingBuilder<>(this);
+  arangoDBMapping = 
builder.fromFile(arangoDbStoreParams.getMappingFile()).build();
+  if (!schemaExists()) {
+createSchema();
+  }
+} catch (Exception e) {
+  LOG.error("Error while initializing ArangoDB dataStore: {}",
+  new Object[]{e.getMessage()});
+  throw new RuntimeException(e);
+}
+  }
+
+  /**
+   * {@inheritDoc}
+   */
+  @Override
+  public String getSchemaName(final String mappingSchemaName,
+  final Class persistentClass) {
+return super.getSchemaName(mappingSchemaName, persistentClass);
+  }
+
+  /**
+   * {@inheritDoc}
+   */
+  @Override
+  public String getSchemaName() {
+return arangoDBMapping.getDocumentClass();
+  }
+
+  /**
+   * {@inheritDoc}
+   * Create a new class of ArangoDB documents if necessary. Enforce specified 
schema over the document class.
+   */
+  @Override
+  public void createSchema() throws GoraException {
+if (schemaExists()) {
+  return;
+}
+try {
+  arangoDB.db(arangoDbStoreParams.getDatabaseName())
+  .createCollection(arangoDBMapping.getDocumentClass());
+
+} 

[GitHub] [gora] kamaci commented on a change in pull request #218: [GORA-650] [WIP] Add initial ArangoDB datastore

[GitBox]

kamaci commented on a change in pull request #218:
URL: https://github.com/apache/gora/pull/218#discussion_r632675878



##
File path: 
gora-arangodb/src/main/java/org/apache/gora/arangodb/store/ArangoDBStore.java
##
@@ -0,0 +1,690 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.arangodb.store;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.Base64;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Properties;
+import java.util.List;
+import java.util.ArrayList;
+
+import com.arangodb.ArangoDB;
+import com.arangodb.entity.BaseDocument;
+import org.apache.avro.Schema;
+import org.apache.avro.util.Utf8;
+import org.apache.gora.arangodb.query.ArangoDBQuery;
+import org.apache.gora.persistency.impl.BeanFactoryImpl;
+import org.apache.gora.persistency.impl.DirtyListWrapper;
+import org.apache.gora.persistency.impl.DirtyMapWrapper;
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.query.PartitionQuery;
+import org.apache.gora.query.Query;
+import org.apache.gora.query.Result;
+import org.apache.gora.query.impl.PartitionQueryImpl;
+import org.apache.gora.store.impl.DataStoreBase;
+import org.apache.gora.util.AvroUtils;
+import org.apache.gora.util.ClassLoadingUtils;
+import org.apache.gora.util.GoraException;
+
+
+/**
+ * {@inheritDoc}
+ * {@link org.apache.gora.arangodb.store.ArangoDBStore} is the primary class
+ * responsible for facilitating GORA CRUD operations on ArangoDB documents.
+ */
+public class ArangoDBStore extends 
DataStoreBase {
+
+  public static final String DEFAULT_MAPPING_FILE = 
"/gora-arangodb-mapping.xml";
+  private ArangoDBStoreParameters arangoDbStoreParams;
+  private ArangoDBMapping arangoDBMapping;
+  private ArangoDB arangoDB;
+
+  /**
+   * {@inheritDoc}
+   * Initialize the ArangoDB dataStore by {@link Properties} parameters.
+   *
+   * @param keyClasskey class type for dataStore.
+   * @param persistentClass persistent class type for dataStore.
+   * @param properties  ArangoDB dataStore properties EG:- ArangoDB client 
credentials.
+   */
+  @Override
+  public void initialize(Class keyClass, Class persistentClass, 
Properties properties) throws GoraException {
+super.initialize(keyClass, persistentClass, properties);
+try {
+  arangoDbStoreParams = ArangoDBStoreParameters.load(properties);
+  arangoDB = new ArangoDB.Builder()
+  .host(arangoDbStoreParams.getServerHost(),
+  Integer.valueOf(arangoDbStoreParams.getServerPort()))
+  .user(arangoDbStoreParams.getUserName())
+  .password(arangoDbStoreParams.getUserPassword())
+  
.maxConnections(Integer.valueOf(arangoDbStoreParams.getConnectionPoolSize()))
+  .build();
+  if (!arangoDB.db(arangoDbStoreParams.getDatabaseName()).exists())
+arangoDB.createDatabase(arangoDbStoreParams.getDatabaseName());
+
+  ArangoDBMappingBuilder builder = new 
ArangoDBMappingBuilder<>(this);
+  arangoDBMapping = 
builder.fromFile(arangoDbStoreParams.getMappingFile()).build();
+  if (!schemaExists()) {
+createSchema();
+  }
+} catch (Exception e) {
+  LOG.error("Error while initializing ArangoDB dataStore: {}",
+  new Object[]{e.getMessage()});
+  throw new RuntimeException(e);
+}
+  }
+
+  /**
+   * {@inheritDoc}
+   */
+  @Override
+  public String getSchemaName(final String mappingSchemaName,
+  final Class persistentClass) {
+return super.getSchemaName(mappingSchemaName, persistentClass);
+  }
+
+  /**
+   * {@inheritDoc}
+   */
+  @Override
+  public String getSchemaName() {
+return arangoDBMapping.getDocumentClass();
+  }
+
+  /**
+   * {@inheritDoc}
+   * Create a new class of ArangoDB documents if necessary. Enforce specified 
schema over the document class.
+   */
+  @Override
+  public void createSchema() throws GoraException {
+if (schemaExists()) {
+  return;
+}
+try {
+  arangoDB.db(arangoDbStoreParams.getDatabaseName())
+  .createCollection(arangoDBMapping.getDocumentClass());
+
+} 

[GitHub] [gora] kamaci commented on a change in pull request #218: [GORA-650] [WIP] Add initial ArangoDB datastore

[GitBox]

kamaci commented on a change in pull request #218:
URL: https://github.com/apache/gora/pull/218#discussion_r632675729



##
File path: 
gora-arangodb/src/main/java/org/apache/gora/arangodb/store/ArangoDBStore.java
##
@@ -0,0 +1,690 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.arangodb.store;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.Base64;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Properties;
+import java.util.List;
+import java.util.ArrayList;
+
+import com.arangodb.ArangoDB;
+import com.arangodb.entity.BaseDocument;
+import org.apache.avro.Schema;
+import org.apache.avro.util.Utf8;
+import org.apache.gora.arangodb.query.ArangoDBQuery;
+import org.apache.gora.persistency.impl.BeanFactoryImpl;
+import org.apache.gora.persistency.impl.DirtyListWrapper;
+import org.apache.gora.persistency.impl.DirtyMapWrapper;
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.query.PartitionQuery;
+import org.apache.gora.query.Query;
+import org.apache.gora.query.Result;
+import org.apache.gora.query.impl.PartitionQueryImpl;
+import org.apache.gora.store.impl.DataStoreBase;
+import org.apache.gora.util.AvroUtils;
+import org.apache.gora.util.ClassLoadingUtils;
+import org.apache.gora.util.GoraException;
+
+
+/**
+ * {@inheritDoc}
+ * {@link org.apache.gora.arangodb.store.ArangoDBStore} is the primary class
+ * responsible for facilitating GORA CRUD operations on ArangoDB documents.
+ */
+public class ArangoDBStore extends 
DataStoreBase {
+
+  public static final String DEFAULT_MAPPING_FILE = 
"/gora-arangodb-mapping.xml";
+  private ArangoDBStoreParameters arangoDbStoreParams;
+  private ArangoDBMapping arangoDBMapping;
+  private ArangoDB arangoDB;
+
+  /**
+   * {@inheritDoc}
+   * Initialize the ArangoDB dataStore by {@link Properties} parameters.
+   *
+   * @param keyClasskey class type for dataStore.
+   * @param persistentClass persistent class type for dataStore.
+   * @param properties  ArangoDB dataStore properties EG:- ArangoDB client 
credentials.
+   */
+  @Override
+  public void initialize(Class keyClass, Class persistentClass, 
Properties properties) throws GoraException {
+super.initialize(keyClass, persistentClass, properties);
+try {
+  arangoDbStoreParams = ArangoDBStoreParameters.load(properties);
+  arangoDB = new ArangoDB.Builder()
+  .host(arangoDbStoreParams.getServerHost(),
+  Integer.valueOf(arangoDbStoreParams.getServerPort()))
+  .user(arangoDbStoreParams.getUserName())
+  .password(arangoDbStoreParams.getUserPassword())
+  
.maxConnections(Integer.valueOf(arangoDbStoreParams.getConnectionPoolSize()))
+  .build();
+  if (!arangoDB.db(arangoDbStoreParams.getDatabaseName()).exists())
+arangoDB.createDatabase(arangoDbStoreParams.getDatabaseName());
+
+  ArangoDBMappingBuilder builder = new 
ArangoDBMappingBuilder<>(this);
+  arangoDBMapping = 
builder.fromFile(arangoDbStoreParams.getMappingFile()).build();
+  if (!schemaExists()) {
+createSchema();
+  }
+} catch (Exception e) {
+  LOG.error("Error while initializing ArangoDB dataStore: {}",
+  new Object[]{e.getMessage()});
+  throw new RuntimeException(e);
+}
+  }
+
+  /**
+   * {@inheritDoc}
+   */
+  @Override
+  public String getSchemaName(final String mappingSchemaName,
+  final Class persistentClass) {
+return super.getSchemaName(mappingSchemaName, persistentClass);
+  }
+
+  /**
+   * {@inheritDoc}
+   */
+  @Override
+  public String getSchemaName() {
+return arangoDBMapping.getDocumentClass();
+  }
+
+  /**
+   * {@inheritDoc}
+   * Create a new class of ArangoDB documents if necessary. Enforce specified 
schema over the document class.
+   */
+  @Override
+  public void createSchema() throws GoraException {
+if (schemaExists()) {
+  return;
+}
+try {
+  arangoDB.db(arangoDbStoreParams.getDatabaseName())
+  .createCollection(arangoDBMapping.getDocumentClass());
+
+} 

[GitHub] [gora] kamaci commented on a change in pull request #218: [GORA-650] [WIP] Add initial ArangoDB datastore

[GitBox]

kamaci commented on a change in pull request #218:
URL: https://github.com/apache/gora/pull/218#discussion_r632675364



##
File path: 
gora-arangodb/src/main/java/org/apache/gora/arangodb/store/ArangoDBMappingBuilder.java
##
@@ -0,0 +1,119 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.arangodb.store;
+
+import org.apache.gora.persistency.impl.PersistentBase;
+
+import java.io.FileInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.List;
+
+import org.jdom.Document;
+import org.jdom.Element;
+import org.jdom.input.SAXBuilder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Utility builder for create ArangoDB mapping from gora-arango-mapping.xml.
+ */
+public class ArangoDBMappingBuilder {
+
+  public static final String ATT_NAME = "name";
+  public static final String ATT_TYPE = "type";
+  public static final String TAG_CLASS = "class";
+  public static final String ATT_KEYCLASS = "keyClass";
+  public static final String ATT_DOCUMENT = "document";
+  public static final String TAG_FIELD = "field";
+  public static final String ATT_FIELD = "docfield";
+  public static final Logger log = 
LoggerFactory.getLogger(ArangoDBMappingBuilder.class);
+
+  private final ArangoDBStore dataStore;
+
+  private ArangoDBMapping mapping;
+
+  public ArangoDBMappingBuilder(final ArangoDBStore store) {
+this.dataStore = store;
+this.mapping = new ArangoDBMapping();
+  }
+
+  public ArangoDBMapping build() {
+if (mapping.getDocumentClass() == null)
+  throw new IllegalStateException("Document Class is not specified.");
+return mapping;
+  }
+
+  protected ArangoDBMappingBuilder fromFile(String uri) throws IOException {
+try {
+  SAXBuilder saxBuilder = new SAXBuilder();
+  InputStream is = getClass().getResourceAsStream(uri);
+  if (is == null) {
+String msg = "Unable to load the mapping from classpath resource '" + 
uri
++ "' Re-trying local from local file system location.";
+log.warn(msg);
+is = new FileInputStream(uri);
+  }
+  Document doc = saxBuilder.build(is);
+  Element root = doc.getRootElement();
+  List classElements = root.getChildren(TAG_CLASS);
+  for (Element classElement : classElements) {
+final Class persistentClass = dataStore.getPersistentClass();
+final Class keyClass = dataStore.getKeyClass();
+if (matchesKeyClassWithMapping(keyClass, classElement)
+&& matchesPersistentClassWithMapping(persistentClass, 
classElement)) {
+  loadPersistentClass(classElement, persistentClass);
+  break;
+}
+  }
+} catch (IOException ex) {
+  throw ex;
+} catch (Exception ex) {

Review comment:
   Instead of this catch `Exception` and throw `IOException`.
   
   On the other hand, what is the reason to wrap `Exception` as `IOException`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] kamaci commented on pull request #220: GORA-537: [WIP] Upgrade to Hadoop 3.X

[GitBox]

kamaci commented on pull request #220:
URL: https://github.com/apache/gora/pull/220#issuecomment-841381866


   Thanks @balashashanka!
   
   Did you have a time to check the comment of @lewismc?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] kamaci edited a comment on pull request #221: Add ScyllaDB Store

[GitBox]

kamaci edited a comment on pull request #221:
URL: https://github.com/apache/gora/pull/221#issuecomment-841378487


   Thanks for your effort @arnenissen! 
   
   Could you explain what is the difference using Cassandra client of Gora 
instead of this since ScyllaDB is designed to be compatible with Cassandra? 
   
   Can anybody use current Cassandra client to interact with ScyllaDB or not?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] kamaci commented on pull request #221: Add ScyllaDB Store

[GitBox]

kamaci commented on pull request #221:
URL: https://github.com/apache/gora/pull/221#issuecomment-841378487


   Thanks for your effort @arnenissen? Could you explain what is the difference 
using Cassandra client of Gora instead of this since ScyllaDB is designed to be 
compatible with Cassandra? 
   
   Can anybody use current Cassandra client to interact with ScyllaDB or not?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] kamaci commented on a change in pull request #221: Add ScyllaDB Store

[GitBox]

kamaci commented on a change in pull request #221:
URL: https://github.com/apache/gora/pull/221#discussion_r632669675



##
File path: 
gora-scylladb/src/examples/java/org/apache/gora/scylladb/example/generated/AvroSerialization/ScyllaDBRecord.java
##
@@ -0,0 +1,1299 @@
+/**
+ *Licensed to the Apache Software Foundation (ASF) under one
+ *or more contributor license agreements.  See the NOTICE file
+ *distributed with this work for additional information
+ *regarding copyright ownership.  The ASF licenses this file
+ *to you under the Apache License, Version 2.0 (the"
+ *License"); you may not use this file except in compliance
+ *with the License.  You may obtain a copy of the License at
+ *
+  * http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ *Unless required by applicable law or agreed to in writing, software
+ *distributed under the License is distributed on an "AS IS" BASIS,
+ *WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *See the License for the specific language governing permissions and
+ *limitations under the License.
+ */
+package org.apache.gora.scylladb.example.generated.AvroSerialization;  
+
+/** This object created to used as Persistent Object to test cassandra data 
store */
+public class ScyllaDBRecord extends 
org.apache.gora.persistency.impl.PersistentBase implements 
org.apache.avro.specific.SpecificRecord, org.apache.gora.persistency.Persistent 
{
+  public static final org.apache.avro.Schema SCHEMA$ = new 
org.apache.avro.Schema.Parser().parse("{\"type\":\"record\",\"name\":\"ScyllaDBRecord\",\"namespace\":\"org.apache.gora.scylladb.example.generated.AvroSerialization\",\"doc\":\"This
 object created to used as Persistent Object to test cassandra data 
store\",\"fields\":[{\"name\":\"dataString\",\"type\":\"string\",\"default\":\"\"},{\"name\":\"dataInt\",\"type\":\"int\",\"default\":0},{\"name\":\"dataLong\",\"type\":[\"null\",\"long\"],\"default\":null},{\"name\":\"dataDouble\",\"type\":[\"null\",\"double\"],\"default\":null},{\"name\":\"dataBytes\",\"type\":[\"null\",\"bytes\"],\"default\":null},{\"name\":\"arrayInt\",\"type\":{\"type\":\"array\",\"items\":\"int\"},\"default\":null},{\"name\":\"arrayString\",\"type\":{\"type\":\"array\",\"items\":\"string\"},\"default\":null},{\"name\":\"arrayLong\",\"type\":{\"type\":\"array\",\"items\":\"long\"},\"default\":null},{\"name\":\"arrayDouble\",\"type\":{\"type\":\"array\",\"item
 
s\":\"double\"},\"default\":null},{\"name\":\"mapInt\",\"type\":{\"type\":\"map\",\"values\":\"int\"},\"default\":{}},{\"name\":\"mapString\",\"type\":{\"type\":\"map\",\"values\":\"string\"},\"default\":{}},{\"name\":\"mapLong\",\"type\":{\"type\":\"map\",\"values\":\"long\"},\"default\":{}},{\"name\":\"mapDouble\",\"type\":{\"type\":\"map\",\"values\":\"double\"},\"default\":{}}],\"default\":null}");
+  private static final long serialVersionUID = -5423182670341604358L;
+  /** Enum containing all data bean's fields. */
+  public static enum Field {
+DATA_STRING(0, "dataString"),
+DATA_INT(1, "dataInt"),
+DATA_LONG(2, "dataLong"),
+DATA_DOUBLE(3, "dataDouble"),
+DATA_BYTES(4, "dataBytes"),
+ARRAY_INT(5, "arrayInt"),
+ARRAY_STRING(6, "arrayString"),
+ARRAY_LONG(7, "arrayLong"),
+ARRAY_DOUBLE(8, "arrayDouble"),
+MAP_INT(9, "mapInt"),
+MAP_STRING(10, "mapString"),
+MAP_LONG(11, "mapLong"),
+MAP_DOUBLE(12, "mapDouble"),
+;
+/**
+ * Field's index.
+ */
+private int index;
+
+/**
+ * Field's name.
+ */
+private String name;
+
+/**
+ * Field's constructor
+ * @param index field's index.
+ * @param name field's name.
+ */
+Field(int index, String name) {this.index=index;this.name=name;}
+
+/**
+ * Gets field's index.
+ * @return int field's index.
+ */
+public int getIndex() {return index;}
+
+/**
+ * Gets field's name.
+ * @return String field's name.
+ */
+public String getName() {return name;}
+
+/**
+ * Gets field's attributes to string.
+ * @return String field's attributes to string.
+ */
+public String toString() {return name;}
+  };
+
+  public static final String[] _ALL_FIELDS = {
+  "dataString",
+  "dataInt",
+  "dataLong",
+  "dataDouble",
+  "dataBytes",
+  "arrayInt",
+  "arrayString",
+  "arrayLong",
+  "arrayDouble",
+  "mapInt",
+  "mapString",
+  "mapLong",
+  "mapDouble",
+  };
+
+  /**
+   * Gets the total field count.
+   * @return int field count
+   */
+  public int getFieldsCount() {
+return ScyllaDBRecord._ALL_FIELDS.length;
+  }
+
+  private java.lang.CharSequence dataString;
+  private int dataInt;
+  private java.lang.Long dataLong;
+  private java.lang.Double dataDouble;
+  private java.nio.ByteBuffer dataBytes;
+  private java.util.List arrayInt;
+  private java.util.List arrayString;
+  private java.util.List arrayLong;
+  private java.util.List arrayDouble;
+  private java.util.Map mapInt;
+  private 

[GitHub] [gora] kamaci commented on a change in pull request #221: Add ScyllaDB Store

[GitBox]

kamaci commented on a change in pull request #221:
URL: https://github.com/apache/gora/pull/221#discussion_r632669501



##
File path: 
gora-scylladb/src/examples/java/org/apache/gora/scylladb/example/generated/AvroSerialization/ScyllaDBRecord.java
##
@@ -0,0 +1,1299 @@
+/**
+ *Licensed to the Apache Software Foundation (ASF) under one
+ *or more contributor license agreements.  See the NOTICE file
+ *distributed with this work for additional information
+ *regarding copyright ownership.  The ASF licenses this file
+ *to you under the Apache License, Version 2.0 (the"
+ *License"); you may not use this file except in compliance
+ *with the License.  You may obtain a copy of the License at
+ *
+  * http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ *Unless required by applicable law or agreed to in writing, software
+ *distributed under the License is distributed on an "AS IS" BASIS,
+ *WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *See the License for the specific language governing permissions and
+ *limitations under the License.
+ */
+package org.apache.gora.scylladb.example.generated.AvroSerialization;  
+
+/** This object created to used as Persistent Object to test cassandra data 
store */
+public class ScyllaDBRecord extends 
org.apache.gora.persistency.impl.PersistentBase implements 
org.apache.avro.specific.SpecificRecord, org.apache.gora.persistency.Persistent 
{
+  public static final org.apache.avro.Schema SCHEMA$ = new 
org.apache.avro.Schema.Parser().parse("{\"type\":\"record\",\"name\":\"ScyllaDBRecord\",\"namespace\":\"org.apache.gora.scylladb.example.generated.AvroSerialization\",\"doc\":\"This
 object created to used as Persistent Object to test cassandra data 
store\",\"fields\":[{\"name\":\"dataString\",\"type\":\"string\",\"default\":\"\"},{\"name\":\"dataInt\",\"type\":\"int\",\"default\":0},{\"name\":\"dataLong\",\"type\":[\"null\",\"long\"],\"default\":null},{\"name\":\"dataDouble\",\"type\":[\"null\",\"double\"],\"default\":null},{\"name\":\"dataBytes\",\"type\":[\"null\",\"bytes\"],\"default\":null},{\"name\":\"arrayInt\",\"type\":{\"type\":\"array\",\"items\":\"int\"},\"default\":null},{\"name\":\"arrayString\",\"type\":{\"type\":\"array\",\"items\":\"string\"},\"default\":null},{\"name\":\"arrayLong\",\"type\":{\"type\":\"array\",\"items\":\"long\"},\"default\":null},{\"name\":\"arrayDouble\",\"type\":{\"type\":\"array\",\"item
 
s\":\"double\"},\"default\":null},{\"name\":\"mapInt\",\"type\":{\"type\":\"map\",\"values\":\"int\"},\"default\":{}},{\"name\":\"mapString\",\"type\":{\"type\":\"map\",\"values\":\"string\"},\"default\":{}},{\"name\":\"mapLong\",\"type\":{\"type\":\"map\",\"values\":\"long\"},\"default\":{}},{\"name\":\"mapDouble\",\"type\":{\"type\":\"map\",\"values\":\"double\"},\"default\":{}}],\"default\":null}");
+  private static final long serialVersionUID = -5423182670341604358L;
+  /** Enum containing all data bean's fields. */
+  public static enum Field {
+DATA_STRING(0, "dataString"),
+DATA_INT(1, "dataInt"),
+DATA_LONG(2, "dataLong"),
+DATA_DOUBLE(3, "dataDouble"),
+DATA_BYTES(4, "dataBytes"),
+ARRAY_INT(5, "arrayInt"),
+ARRAY_STRING(6, "arrayString"),
+ARRAY_LONG(7, "arrayLong"),
+ARRAY_DOUBLE(8, "arrayDouble"),
+MAP_INT(9, "mapInt"),
+MAP_STRING(10, "mapString"),
+MAP_LONG(11, "mapLong"),
+MAP_DOUBLE(12, "mapDouble"),
+;
+/**
+ * Field's index.
+ */
+private int index;
+
+/**
+ * Field's name.
+ */
+private String name;
+
+/**
+ * Field's constructor
+ * @param index field's index.
+ * @param name field's name.
+ */
+Field(int index, String name) {this.index=index;this.name=name;}
+
+/**
+ * Gets field's index.
+ * @return int field's index.
+ */
+public int getIndex() {return index;}
+
+/**
+ * Gets field's name.
+ * @return String field's name.
+ */
+public String getName() {return name;}
+
+/**
+ * Gets field's attributes to string.
+ * @return String field's attributes to string.
+ */
+public String toString() {return name;}
+  };
+
+  public static final String[] _ALL_FIELDS = {
+  "dataString",
+  "dataInt",
+  "dataLong",
+  "dataDouble",
+  "dataBytes",
+  "arrayInt",
+  "arrayString",
+  "arrayLong",
+  "arrayDouble",
+  "mapInt",
+  "mapString",
+  "mapLong",
+  "mapDouble",
+  };
+
+  /**
+   * Gets the total field count.
+   * @return int field count
+   */
+  public int getFieldsCount() {
+return ScyllaDBRecord._ALL_FIELDS.length;
+  }
+
+  private java.lang.CharSequence dataString;

Review comment:
   java.lang is imported as default




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] kamaci commented on a change in pull request #221: Add ScyllaDB Store

[GitBox]

kamaci commented on a change in pull request #221:
URL: https://github.com/apache/gora/pull/221#discussion_r632668707



##
File path: 
gora-scylladb/src/examples/java/org/apache/gora/scylladb/example/generated/AvroSerialization/ScyllaDBRecord.java
##
@@ -0,0 +1,1299 @@
+/**
+ *Licensed to the Apache Software Foundation (ASF) under one
+ *or more contributor license agreements.  See the NOTICE file
+ *distributed with this work for additional information
+ *regarding copyright ownership.  The ASF licenses this file
+ *to you under the Apache License, Version 2.0 (the"
+ *License"); you may not use this file except in compliance
+ *with the License.  You may obtain a copy of the License at
+ *
+  * http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ *Unless required by applicable law or agreed to in writing, software
+ *distributed under the License is distributed on an "AS IS" BASIS,
+ *WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *See the License for the specific language governing permissions and
+ *limitations under the License.
+ */
+package org.apache.gora.scylladb.example.generated.AvroSerialization;  
+
+/** This object created to used as Persistent Object to test cassandra data 
store */
+public class ScyllaDBRecord extends 
org.apache.gora.persistency.impl.PersistentBase implements 
org.apache.avro.specific.SpecificRecord, org.apache.gora.persistency.Persistent 
{
+  public static final org.apache.avro.Schema SCHEMA$ = new 
org.apache.avro.Schema.Parser().parse("{\"type\":\"record\",\"name\":\"ScyllaDBRecord\",\"namespace\":\"org.apache.gora.scylladb.example.generated.AvroSerialization\",\"doc\":\"This
 object created to used as Persistent Object to test cassandra data 
store\",\"fields\":[{\"name\":\"dataString\",\"type\":\"string\",\"default\":\"\"},{\"name\":\"dataInt\",\"type\":\"int\",\"default\":0},{\"name\":\"dataLong\",\"type\":[\"null\",\"long\"],\"default\":null},{\"name\":\"dataDouble\",\"type\":[\"null\",\"double\"],\"default\":null},{\"name\":\"dataBytes\",\"type\":[\"null\",\"bytes\"],\"default\":null},{\"name\":\"arrayInt\",\"type\":{\"type\":\"array\",\"items\":\"int\"},\"default\":null},{\"name\":\"arrayString\",\"type\":{\"type\":\"array\",\"items\":\"string\"},\"default\":null},{\"name\":\"arrayLong\",\"type\":{\"type\":\"array\",\"items\":\"long\"},\"default\":null},{\"name\":\"arrayDouble\",\"type\":{\"type\":\"array\",\"item
 
s\":\"double\"},\"default\":null},{\"name\":\"mapInt\",\"type\":{\"type\":\"map\",\"values\":\"int\"},\"default\":{}},{\"name\":\"mapString\",\"type\":{\"type\":\"map\",\"values\":\"string\"},\"default\":{}},{\"name\":\"mapLong\",\"type\":{\"type\":\"map\",\"values\":\"long\"},\"default\":{}},{\"name\":\"mapDouble\",\"type\":{\"type\":\"map\",\"values\":\"double\"},\"default\":{}}],\"default\":null}");
+  private static final long serialVersionUID = -5423182670341604358L;
+  /** Enum containing all data bean's fields. */
+  public static enum Field {
+DATA_STRING(0, "dataString"),
+DATA_INT(1, "dataInt"),
+DATA_LONG(2, "dataLong"),
+DATA_DOUBLE(3, "dataDouble"),
+DATA_BYTES(4, "dataBytes"),
+ARRAY_INT(5, "arrayInt"),
+ARRAY_STRING(6, "arrayString"),
+ARRAY_LONG(7, "arrayLong"),
+ARRAY_DOUBLE(8, "arrayDouble"),
+MAP_INT(9, "mapInt"),
+MAP_STRING(10, "mapString"),
+MAP_LONG(11, "mapLong"),
+MAP_DOUBLE(12, "mapDouble"),
+;
+/**
+ * Field's index.
+ */
+private int index;
+
+/**
+ * Field's name.
+ */
+private String name;
+
+/**
+ * Field's constructor
+ * @param index field's index.
+ * @param name field's name.
+ */
+Field(int index, String name) {this.index=index;this.name=name;}
+
+/**
+ * Gets field's index.
+ * @return int field's index.
+ */
+public int getIndex() {return index;}
+
+/**
+ * Gets field's name.
+ * @return String field's name.
+ */
+public String getName() {return name;}
+
+/**
+ * Gets field's attributes to string.
+ * @return String field's attributes to string.
+ */
+public String toString() {return name;}
+  };
+
+  public static final String[] _ALL_FIELDS = {
+  "dataString",

Review comment:
   Check the indentation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] kamaci commented on a change in pull request #221: Add ScyllaDB Store

[GitBox]

kamaci commented on a change in pull request #221:
URL: https://github.com/apache/gora/pull/221#discussion_r632668517



##
File path: 
gora-scylladb/src/examples/java/org/apache/gora/scylladb/example/generated/AvroSerialization/ScyllaDBRecord.java
##
@@ -0,0 +1,1299 @@
+/**
+ *Licensed to the Apache Software Foundation (ASF) under one
+ *or more contributor license agreements.  See the NOTICE file
+ *distributed with this work for additional information
+ *regarding copyright ownership.  The ASF licenses this file
+ *to you under the Apache License, Version 2.0 (the"
+ *License"); you may not use this file except in compliance
+ *with the License.  You may obtain a copy of the License at
+ *
+  * http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ *Unless required by applicable law or agreed to in writing, software
+ *distributed under the License is distributed on an "AS IS" BASIS,
+ *WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *See the License for the specific language governing permissions and
+ *limitations under the License.
+ */
+package org.apache.gora.scylladb.example.generated.AvroSerialization;  
+
+/** This object created to used as Persistent Object to test cassandra data 
store */
+public class ScyllaDBRecord extends 
org.apache.gora.persistency.impl.PersistentBase implements 
org.apache.avro.specific.SpecificRecord, org.apache.gora.persistency.Persistent 
{
+  public static final org.apache.avro.Schema SCHEMA$ = new 
org.apache.avro.Schema.Parser().parse("{\"type\":\"record\",\"name\":\"ScyllaDBRecord\",\"namespace\":\"org.apache.gora.scylladb.example.generated.AvroSerialization\",\"doc\":\"This
 object created to used as Persistent Object to test cassandra data 
store\",\"fields\":[{\"name\":\"dataString\",\"type\":\"string\",\"default\":\"\"},{\"name\":\"dataInt\",\"type\":\"int\",\"default\":0},{\"name\":\"dataLong\",\"type\":[\"null\",\"long\"],\"default\":null},{\"name\":\"dataDouble\",\"type\":[\"null\",\"double\"],\"default\":null},{\"name\":\"dataBytes\",\"type\":[\"null\",\"bytes\"],\"default\":null},{\"name\":\"arrayInt\",\"type\":{\"type\":\"array\",\"items\":\"int\"},\"default\":null},{\"name\":\"arrayString\",\"type\":{\"type\":\"array\",\"items\":\"string\"},\"default\":null},{\"name\":\"arrayLong\",\"type\":{\"type\":\"array\",\"items\":\"long\"},\"default\":null},{\"name\":\"arrayDouble\",\"type\":{\"type\":\"array\",\"item
 
s\":\"double\"},\"default\":null},{\"name\":\"mapInt\",\"type\":{\"type\":\"map\",\"values\":\"int\"},\"default\":{}},{\"name\":\"mapString\",\"type\":{\"type\":\"map\",\"values\":\"string\"},\"default\":{}},{\"name\":\"mapLong\",\"type\":{\"type\":\"map\",\"values\":\"long\"},\"default\":{}},{\"name\":\"mapDouble\",\"type\":{\"type\":\"map\",\"values\":\"double\"},\"default\":{}}],\"default\":null}");
+  private static final long serialVersionUID = -5423182670341604358L;
+  /** Enum containing all data bean's fields. */
+  public static enum Field {
+DATA_STRING(0, "dataString"),
+DATA_INT(1, "dataInt"),
+DATA_LONG(2, "dataLong"),
+DATA_DOUBLE(3, "dataDouble"),
+DATA_BYTES(4, "dataBytes"),
+ARRAY_INT(5, "arrayInt"),
+ARRAY_STRING(6, "arrayString"),
+ARRAY_LONG(7, "arrayLong"),
+ARRAY_DOUBLE(8, "arrayDouble"),
+MAP_INT(9, "mapInt"),
+MAP_STRING(10, "mapString"),
+MAP_LONG(11, "mapLong"),
+MAP_DOUBLE(12, "mapDouble"),
+;
+/**
+ * Field's index.
+ */
+private int index;
+
+/**
+ * Field's name.
+ */
+private String name;
+
+/**
+ * Field's constructor
+ * @param index field's index.
+ * @param name field's name.
+ */
+Field(int index, String name) {this.index=index;this.name=name;}

Review comment:
   Start the method body with a new line.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] kamaci commented on a change in pull request #221: Add ScyllaDB Store

[GitBox]

kamaci commented on a change in pull request #221:
URL: https://github.com/apache/gora/pull/221#discussion_r632668274



##
File path: 
gora-scylladb/src/examples/java/org/apache/gora/scylladb/example/generated/AvroSerialization/ScyllaDBRecord.java
##
@@ -0,0 +1,1299 @@
+/**
+ *Licensed to the Apache Software Foundation (ASF) under one
+ *or more contributor license agreements.  See the NOTICE file
+ *distributed with this work for additional information
+ *regarding copyright ownership.  The ASF licenses this file
+ *to you under the Apache License, Version 2.0 (the"
+ *License"); you may not use this file except in compliance
+ *with the License.  You may obtain a copy of the License at
+ *
+  * http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ *Unless required by applicable law or agreed to in writing, software
+ *distributed under the License is distributed on an "AS IS" BASIS,
+ *WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *See the License for the specific language governing permissions and
+ *limitations under the License.
+ */
+package org.apache.gora.scylladb.example.generated.AvroSerialization;  
+
+/** This object created to used as Persistent Object to test cassandra data 
store */
+public class ScyllaDBRecord extends 
org.apache.gora.persistency.impl.PersistentBase implements 
org.apache.avro.specific.SpecificRecord, org.apache.gora.persistency.Persistent 
{
+  public static final org.apache.avro.Schema SCHEMA$ = new 
org.apache.avro.Schema.Parser().parse("{\"type\":\"record\",\"name\":\"ScyllaDBRecord\",\"namespace\":\"org.apache.gora.scylladb.example.generated.AvroSerialization\",\"doc\":\"This
 object created to used as Persistent Object to test cassandra data 
store\",\"fields\":[{\"name\":\"dataString\",\"type\":\"string\",\"default\":\"\"},{\"name\":\"dataInt\",\"type\":\"int\",\"default\":0},{\"name\":\"dataLong\",\"type\":[\"null\",\"long\"],\"default\":null},{\"name\":\"dataDouble\",\"type\":[\"null\",\"double\"],\"default\":null},{\"name\":\"dataBytes\",\"type\":[\"null\",\"bytes\"],\"default\":null},{\"name\":\"arrayInt\",\"type\":{\"type\":\"array\",\"items\":\"int\"},\"default\":null},{\"name\":\"arrayString\",\"type\":{\"type\":\"array\",\"items\":\"string\"},\"default\":null},{\"name\":\"arrayLong\",\"type\":{\"type\":\"array\",\"items\":\"long\"},\"default\":null},{\"name\":\"arrayDouble\",\"type\":{\"type\":\"array\",\"item
 
s\":\"double\"},\"default\":null},{\"name\":\"mapInt\",\"type\":{\"type\":\"map\",\"values\":\"int\"},\"default\":{}},{\"name\":\"mapString\",\"type\":{\"type\":\"map\",\"values\":\"string\"},\"default\":{}},{\"name\":\"mapLong\",\"type\":{\"type\":\"map\",\"values\":\"long\"},\"default\":{}},{\"name\":\"mapDouble\",\"type\":{\"type\":\"map\",\"values\":\"double\"},\"default\":{}}],\"default\":null}");
+  private static final long serialVersionUID = -5423182670341604358L;
+  /** Enum containing all data bean's fields. */
+  public static enum Field {
+DATA_STRING(0, "dataString"),
+DATA_INT(1, "dataInt"),
+DATA_LONG(2, "dataLong"),
+DATA_DOUBLE(3, "dataDouble"),
+DATA_BYTES(4, "dataBytes"),
+ARRAY_INT(5, "arrayInt"),
+ARRAY_STRING(6, "arrayString"),
+ARRAY_LONG(7, "arrayLong"),
+ARRAY_DOUBLE(8, "arrayDouble"),
+MAP_INT(9, "mapInt"),
+MAP_STRING(10, "mapString"),
+MAP_LONG(11, "mapLong"),
+MAP_DOUBLE(12, "mapDouble"),

Review comment:
   No need a comma before a semicolon.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] kamaci commented on a change in pull request #221: Add ScyllaDB Store

[GitBox]

kamaci commented on a change in pull request #221:
URL: https://github.com/apache/gora/pull/221#discussion_r632667516



##
File path: 
gora-scylladb/src/examples/java/org/apache/gora/scylladb/example/generated/AvroSerialization/ScyllaDBKey.java
##
@@ -0,0 +1,386 @@
+/**
+ *Licensed to the Apache Software Foundation (ASF) under one
+ *or more contributor license agreements.  See the NOTICE file
+ *distributed with this work for additional information
+ *regarding copyright ownership.  The ASF licenses this file
+ *to you under the Apache License, Version 2.0 (the"
+ *License"); you may not use this file except in compliance
+ *with the License.  You may obtain a copy of the License at
+ *
+  * http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ *Unless required by applicable law or agreed to in writing, software
+ *distributed under the License is distributed on an "AS IS" BASIS,
+ *WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *See the License for the specific language governing permissions and
+ *limitations under the License.
+ */
+package org.apache.gora.scylladb.example.generated.AvroSerialization;  
+
+/** This Object is created to used as Cassandra Key to test cassandra data 
store, Cassandra Key can be used to define partition keys, clustering keys. */
+public class ScyllaDBKey extends 
org.apache.gora.persistency.impl.PersistentBase implements 
org.apache.avro.specific.SpecificRecord, org.apache.gora.persistency.Persistent 
{
+  public static final org.apache.avro.Schema SCHEMA$ = new 
org.apache.avro.Schema.Parser().parse("{\"type\":\"record\",\"name\":\"ScyllaDBKey\",\"namespace\":\"org.apache.gora.scylladb.example.generated.AvroSerialization\",\"doc\":\"This
 Object is created to used as Cassandra Key to test cassandra data store, 
Cassandra Key can be used to define partition keys, clustering 
keys.\",\"fields\":[{\"name\":\"url\",\"type\":[\"null\",\"string\"],\"default\":null},{\"name\":\"timestamp\",\"type\":\"long\",\"default\":0}],\"default\":null}");
+  private static final long serialVersionUID = 232044203208115437L;
+  /** Enum containing all data bean's fields. */
+  public static enum Field {
+URL(0, "url"),
+TIMESTAMP(1, "timestamp"),
+;
+/**
+ * Field's index.
+ */
+private int index;
+
+/**
+ * Field's name.
+ */
+private String name;
+
+/**
+ * Field's constructor
+ * @param index field's index.
+ * @param name field's name.
+ */
+Field(int index, String name) {this.index=index;this.name=name;}
+
+/**
+ * Gets field's index.
+ * @return int field's index.
+ */
+public int getIndex() {return index;}
+
+/**
+ * Gets field's name.
+ * @return String field's name.
+ */
+public String getName() {return name;}
+
+/**
+ * Gets field's attributes to string.
+ * @return String field's attributes to string.
+ */
+public String toString() {return name;}
+  };
+
+  public static final String[] _ALL_FIELDS = {
+  "url",
+  "timestamp",
+  };
+
+  /**
+   * Gets the total field count.
+   * @return int field count
+   */
+  public int getFieldsCount() {
+return ScyllaDBKey._ALL_FIELDS.length;
+  }
+
+  private java.lang.CharSequence url;
+  private long timestamp;
+  public org.apache.avro.Schema getSchema() { return SCHEMA$; }
+  // Used by DatumWriter.  Applications should not call. 
+  public java.lang.Object get(int field$) {
+switch (field$) {
+case 0: return this.url;
+case 1: return this.timestamp;
+default: throw new org.apache.avro.AvroRuntimeException("Bad index");
+}
+  }
+  
+  // Used by DatumReader.  Applications should not call. 
+  @SuppressWarnings(value="unchecked")
+  public void put(int field$, java.lang.Object value) {
+switch (field$) {
+case 0: this.url = (java.lang.CharSequence)(value); break;
+case 1: this.timestamp = (java.lang.Long)(value); break;
+default: throw new org.apache.avro.AvroRuntimeException("Bad index");
+}
+  }
+
+  /**
+   * Gets the value of the 'url' field.
+   */
+  public java.lang.CharSequence getUrl() {
+return url;
+  }
+
+  /**
+   * Sets the value of the 'url' field.
+   * @param value the value to set.
+   */
+  public void setUrl(java.lang.CharSequence value) {
+this.url = value;
+setDirty(0);
+  }
+  
+  /**
+   * Checks the dirty status of the 'url' field. A field is dirty if it 
represents a change that has not yet been written to the database.
+   * @param value the value to set.
+   */
+  public boolean isUrlDirty() {
+return isDirty(0);
+  }
+
+  /**
+   * Gets the value of the 'timestamp' field.
+   */
+  public java.lang.Long getTimestamp() {
+return timestamp;
+  }
+
+  /**
+   * Sets the value of the 'timestamp' field.
+   * @param value the value to set.
+   */
+  public void setTimestamp(java.lang.Long value) {
+this.timestamp = value;
+setDirty(1);
+  }
+  
+  /**
+   * Checks the dirty 

[GitHub] [gora] kamaci commented on a change in pull request #221: Add ScyllaDB Store

[GitBox]

kamaci commented on a change in pull request #221:
URL: https://github.com/apache/gora/pull/221#discussion_r632667177



##
File path: 
gora-scylladb/src/examples/java/org/apache/gora/scylladb/example/generated/AvroSerialization/ScyllaDBKey.java
##
@@ -0,0 +1,386 @@
+/**
+ *Licensed to the Apache Software Foundation (ASF) under one
+ *or more contributor license agreements.  See the NOTICE file
+ *distributed with this work for additional information
+ *regarding copyright ownership.  The ASF licenses this file
+ *to you under the Apache License, Version 2.0 (the"
+ *License"); you may not use this file except in compliance
+ *with the License.  You may obtain a copy of the License at
+ *
+  * http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ *Unless required by applicable law or agreed to in writing, software
+ *distributed under the License is distributed on an "AS IS" BASIS,
+ *WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *See the License for the specific language governing permissions and
+ *limitations under the License.
+ */
+package org.apache.gora.scylladb.example.generated.AvroSerialization;  
+
+/** This Object is created to used as Cassandra Key to test cassandra data 
store, Cassandra Key can be used to define partition keys, clustering keys. */
+public class ScyllaDBKey extends 
org.apache.gora.persistency.impl.PersistentBase implements 
org.apache.avro.specific.SpecificRecord, org.apache.gora.persistency.Persistent 
{
+  public static final org.apache.avro.Schema SCHEMA$ = new 
org.apache.avro.Schema.Parser().parse("{\"type\":\"record\",\"name\":\"ScyllaDBKey\",\"namespace\":\"org.apache.gora.scylladb.example.generated.AvroSerialization\",\"doc\":\"This
 Object is created to used as Cassandra Key to test cassandra data store, 
Cassandra Key can be used to define partition keys, clustering 
keys.\",\"fields\":[{\"name\":\"url\",\"type\":[\"null\",\"string\"],\"default\":null},{\"name\":\"timestamp\",\"type\":\"long\",\"default\":0}],\"default\":null}");
+  private static final long serialVersionUID = 232044203208115437L;
+  /** Enum containing all data bean's fields. */
+  public static enum Field {
+URL(0, "url"),
+TIMESTAMP(1, "timestamp"),
+;
+/**
+ * Field's index.
+ */
+private int index;
+
+/**
+ * Field's name.
+ */
+private String name;
+
+/**
+ * Field's constructor
+ * @param index field's index.
+ * @param name field's name.
+ */
+Field(int index, String name) {this.index=index;this.name=name;}
+
+/**
+ * Gets field's index.
+ * @return int field's index.
+ */
+public int getIndex() {return index;}
+
+/**
+ * Gets field's name.
+ * @return String field's name.
+ */
+public String getName() {return name;}
+
+/**
+ * Gets field's attributes to string.
+ * @return String field's attributes to string.
+ */
+public String toString() {return name;}
+  };
+
+  public static final String[] _ALL_FIELDS = {
+  "url",
+  "timestamp",
+  };
+
+  /**
+   * Gets the total field count.
+   * @return int field count
+   */
+  public int getFieldsCount() {
+return ScyllaDBKey._ALL_FIELDS.length;
+  }
+
+  private java.lang.CharSequence url;
+  private long timestamp;
+  public org.apache.avro.Schema getSchema() { return SCHEMA$; }
+  // Used by DatumWriter.  Applications should not call. 
+  public java.lang.Object get(int field$) {
+switch (field$) {
+case 0: return this.url;
+case 1: return this.timestamp;
+default: throw new org.apache.avro.AvroRuntimeException("Bad index");
+}
+  }
+  
+  // Used by DatumReader.  Applications should not call. 
+  @SuppressWarnings(value="unchecked")
+  public void put(int field$, java.lang.Object value) {
+switch (field$) {
+case 0: this.url = (java.lang.CharSequence)(value); break;
+case 1: this.timestamp = (java.lang.Long)(value); break;
+default: throw new org.apache.avro.AvroRuntimeException("Bad index");
+}
+  }
+
+  /**
+   * Gets the value of the 'url' field.
+   */
+  public java.lang.CharSequence getUrl() {
+return url;
+  }
+
+  /**
+   * Sets the value of the 'url' field.
+   * @param value the value to set.
+   */
+  public void setUrl(java.lang.CharSequence value) {
+this.url = value;
+setDirty(0);
+  }
+  
+  /**
+   * Checks the dirty status of the 'url' field. A field is dirty if it 
represents a change that has not yet been written to the database.
+   * @param value the value to set.
+   */
+  public boolean isUrlDirty() {
+return isDirty(0);
+  }
+
+  /**
+   * Gets the value of the 'timestamp' field.
+   */
+  public java.lang.Long getTimestamp() {
+return timestamp;
+  }
+
+  /**
+   * Sets the value of the 'timestamp' field.
+   * @param value the value to set.
+   */
+  public void setTimestamp(java.lang.Long value) {
+this.timestamp = value;
+setDirty(1);
+  }
+  
+  /**
+   * Checks the dirty 

[GitHub] [gora] kamaci commented on a change in pull request #221: Add ScyllaDB Store

[GitBox]

kamaci commented on a change in pull request #221:
URL: https://github.com/apache/gora/pull/221#discussion_r63201



##
File path: gora-scylladb/src/examples/avro/scyllaDBKey.json
##
@@ -0,0 +1,22 @@
+{
+  "type": "record",
+  "name": "ScyllaDBKey",
+  "default": null,
+  "namespace": "org.apache.gora.scylladb.example.generated.AvroSerialization",
+  "doc": "This Object is created to used as Cassandra Key to test cassandra 
data store, Cassandra Key can be used to define partition keys, clustering 
keys.",

Review comment:
   Cassandra?

##
File path: gora-scylladb/src/examples/avro/scyllaDBRecord.json
##
@@ -0,0 +1,107 @@
+{
+  "type": "record",
+  "name": "ScyllaDBRecord",
+  "default": null,
+  "namespace": "org.apache.gora.scylladb.example.generated.AvroSerialization",
+  "doc": "This object created to used as Persistent Object to test cassandra 
data store",

Review comment:
   Cassandra?

##
File path: 
gora-scylladb/src/examples/java/org/apache/gora/scylladb/example/generated/AvroSerialization/ScyllaDBKey.java
##
@@ -0,0 +1,386 @@
+/**
+ *Licensed to the Apache Software Foundation (ASF) under one
+ *or more contributor license agreements.  See the NOTICE file
+ *distributed with this work for additional information
+ *regarding copyright ownership.  The ASF licenses this file
+ *to you under the Apache License, Version 2.0 (the"
+ *License"); you may not use this file except in compliance
+ *with the License.  You may obtain a copy of the License at
+ *
+  * http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ *Unless required by applicable law or agreed to in writing, software
+ *distributed under the License is distributed on an "AS IS" BASIS,
+ *WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *See the License for the specific language governing permissions and
+ *limitations under the License.
+ */
+package org.apache.gora.scylladb.example.generated.AvroSerialization;  
+
+/** This Object is created to used as Cassandra Key to test cassandra data 
store, Cassandra Key can be used to define partition keys, clustering keys. */

Review comment:
   Cassandra?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] kamaci commented on a change in pull request #221: Add ScyllaDB Store

[GitBox]

kamaci commented on a change in pull request #221:
URL: https://github.com/apache/gora/pull/221#discussion_r632666067



##
File path: gora-scylladb/pom.xml
##
@@ -0,0 +1,199 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+gora
+org.apache.gora
+1.0-SNAPSHOT
+
+4.0.0
+
+gora-scylladb
+bundle
+
+
+
+Apache Gora :: ScyllaDB
+http://gora.apache.org
+The Apache Gora open source framework provides an in-memory 
data model and
+persistence for big data. Gora supports persisting to column stores, 
key value stores,
+document stores and RDBMSs, and analyzing the data with extensive 
Apache Hadoop MapReduce
+support.
+
+2010
+
+The Apache Software Foundation
+http://www.apache.org/
+
+
+JIRA
+https://issues.apache.org/jira/browse/GORA
+
+
+Jenkins
+https://builds.apache.org/job/Gora-trunk/
+
+
+
+18.0
+*
+
org.apache.gora.cassandra*;version="${project.version}";-noimport:=true
+
+
+
+target
+target/classes
+${project.artifactId}-${project.version}
+target/test-classes
+src/test/java
+src/main/java
+
+
+${project.basedir}/src/test/conf
+
+**/*
+
+

+
+
+
+
+org.codehaus.mojo
+build-helper-maven-plugin
+${build-helper-maven-plugin.version}
+
+
+generate-test-sources
+
+add-test-source
+
+
+
+src/examples/java
+
+
+
+
+
+
+org.apache.maven.plugins
+maven-surefire-plugin
+
+
+org.apache.maven.surefire
+surefire-junit47
+2.20

Review comment:
   It is already defined at parent pom.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] kamaci commented on a change in pull request #222: GORA-656 Add Hazelcast Imap backed datastore

[GitBox]

kamaci commented on a change in pull request #222:
URL: https://github.com/apache/gora/pull/222#discussion_r632664707



##
File path: 
gora-hazelcast/src/test/java/org/apache/gora/hazelcast/mapreduce/HazelcastStoreMapReduceTest.java
##
@@ -0,0 +1,63 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.hazelcast.mapreduce;
+
+import org.apache.gora.hazelcast.GoraHazelcastTestDriver;
+import org.apache.gora.mapreduce.DataStoreMapReduceTestBase;
+import org.apache.gora.examples.generated.WebPage;
+import org.apache.gora.store.DataStore;
+import org.apache.gora.store.DataStoreFactory;
+import org.apache.hadoop.conf.Configuration;
+import org.junit.After;
+import org.junit.Before;
+
+import java.io.IOException;
+
+public class HazelcastStoreMapReduceTest extends DataStoreMapReduceTestBase {
+
+  private GoraHazelcastTestDriver driver;
+
+  public HazelcastStoreMapReduceTest() throws IOException {
+super();
+driver = new GoraHazelcastTestDriver();
+  }
+
+  @Override
+  @Before
+  public void setUp() throws Exception {
+driver.setUpClass();
+super.setUp();
+  }
+
+  @Override
+  @After
+  public void tearDown() throws Exception {
+super.tearDown();
+driver.tearDownClass();
+  }
+
+  @Override
+  protected DataStore createWebPageDataStore() throws 
IOException {
+try {
+  return DataStoreFactory.getDataStore(String.class, WebPage.class, new 
Configuration(), true);
+} catch (Exception e) {
+  throw new RuntimeException(e);

Review comment:
   What is the purpose of catching the `Exception` and re-throwing it as 
`RuntimeException`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] kamaci commented on a change in pull request #222: GORA-656 Add Hazelcast Imap backed datastore

[GitBox]

kamaci commented on a change in pull request #222:
URL: https://github.com/apache/gora/pull/222#discussion_r632663594



##
File path: 
gora-hazelcast/src/main/java/org/apache/gora/hazelcast/store/HazelcastCacheLoaderFactory.java
##
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.hazelcast.store;
+
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.store.DataStoreFactory;
+import org.apache.gora.util.GoraException;
+import org.apache.hadoop.conf.Configuration;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.cache.configuration.Factory;
+
+/**
+ * {@link HazelcastCacheLoaderFactory} is the primary class
+ * responsible for creating cache loader {@link 
javax.cache.integration.CacheLoader} instances which itself
+ * loads data beans from persistency dataStore to in memory cache.
+ */
+public class HazelcastCacheLoaderFactory
+implements Factory> {
+
+  public static final long serialVersionUID = 201305101626L;
+  private static final Logger LOG = 
LoggerFactory.getLogger(HazelcastCacheLoaderFactory.class);
+  private transient HazelcastCacheLoader instance;
+  private Class keyClass;
+  private Class persistentClass;
+
+  public HazelcastCacheLoaderFactory(HazelcastCacheLoader instance,
+ Class keyClass,
+ Class persistentClass) {
+this.keyClass = keyClass;
+this.persistentClass = persistentClass;
+LOG.info("JCache cache entry loader factory initialized successfully.");
+this.instance = instance;
+  }
+
+  public HazelcastCacheLoader create() {
+if (this.instance != null) {
+  return (HazelcastCacheLoader) this.instance;
+} else {

Review comment:
   No need to write `else` after an `if` with a `return`.

##
File path: 
gora-hazelcast/src/main/java/org/apache/gora/hazelcast/store/HazelcastCacheLoaderFactory.java
##
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.hazelcast.store;
+
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.store.DataStoreFactory;
+import org.apache.gora.util.GoraException;
+import org.apache.hadoop.conf.Configuration;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.cache.configuration.Factory;
+
+/**
+ * {@link HazelcastCacheLoaderFactory} is the primary class
+ * responsible for creating cache loader {@link 
javax.cache.integration.CacheLoader} instances which itself
+ * loads data beans from persistency dataStore to in memory cache.
+ */
+public class HazelcastCacheLoaderFactory
+implements Factory> {
+
+  public static final long serialVersionUID = 201305101626L;
+  private static final Logger LOG = 
LoggerFactory.getLogger(HazelcastCacheLoaderFactory.class);
+  private transient HazelcastCacheLoader instance;
+  private Class keyClass;
+  private Class persistentClass;
+
+  public HazelcastCacheLoaderFactory(HazelcastCacheLoader instance,
+ Class keyClass,
+ Class persistentClass) {
+this.keyClass = keyClass;
+this.persistentClass = persistentClass;
+LOG.info("JCache cache entry loader factory initialized successfully.");
+this.instance = instance;
+  }
+
+  public HazelcastCacheLoader create() {
+if (this.instance != null) {
+ 

[GitHub] [gora] kamaci commented on a change in pull request #222: GORA-656 Add Hazelcast Imap backed datastore

[GitBox]

kamaci commented on a change in pull request #222:
URL: https://github.com/apache/gora/pull/222#discussion_r632661023



##
File path: 
gora-hazelcast/src/main/java/org/apache/gora/hazelcast/store/HazelcastCacheEntryListenerFactory.java
##
@@ -0,0 +1,58 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.hazelcast.store;
+
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.cache.configuration.Factory;
+
+/**
+ * {@link HazelcastCacheEntryListenerFactory} is the primary class
+ * responsible for creating cache entry listeners which listens on {@link 
javax.cache.event.CacheEntryEvent}
+ * cache entry events EG:- Creation, Removal, etc of keys on caches and 
trigger actions as specified.
+ */
+public class HazelcastCacheEntryListenerFactory
+implements Factory> {
+
+  public static final long serialVersionUID = 201305101634L;
+  private static final Logger LOG = 
LoggerFactory.getLogger(HazelcastCacheEntryListenerFactory.class);
+  private transient HazelcastCacheEntryListener instance;
+
+  public HazelcastCacheEntryListenerFactory(HazelcastCacheEntryListener 
instance) {
+LOG.info("Hazelcast cache entry listener factory initialized 
successfully.");
+this.instance = instance;
+  }
+
+  public HazelcastCacheEntryListener create() {
+return this.instance;
+  }
+
+  public boolean equals(Object other) {
+if (this == other) {
+  return true;
+} else if (other != null && this.getClass() == other.getClass()) {

Review comment:
   No need for an else if you had a if with return.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] kamaci commented on a change in pull request #222: GORA-656 Add Hazelcast Imap backed datastore

[GitBox]

kamaci commented on a change in pull request #222:
URL: https://github.com/apache/gora/pull/222#discussion_r632660595



##
File path: 
gora-hazelcast/src/main/java/org/apache/gora/hazelcast/query/HazelcastResult.java
##
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.hazelcast.query;
+
+import java.io.IOException;
+import java.util.Iterator;
+import java.util.NavigableSet;
+
+import org.apache.gora.hazelcast.store.HazelcastStore;
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.query.Query;
+import org.apache.gora.query.impl.ResultBase;
+import org.apache.gora.store.DataStore;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * {@link HazelcastResult} is the primary class
+ * responsible for representing result set of a cache manipulation query
+ * {@link HazelcastQuery}
+ */
+public class HazelcastResult extends 
ResultBase {
+
+  private static final Logger LOG = 
LoggerFactory.getLogger(HazelcastResult.class);
+  private NavigableSet cacheKeySet;
+  private Iterator iterator;
+  private int current;
+
+  public HazelcastResult(DataStore dataStore, Query query) {
+super(dataStore, query);
+  }
+
+  public HazelcastResult(DataStore dataStore, Query query, 
NavigableSet cacheKeySet) {
+super(dataStore, query);
+this.cacheKeySet = cacheKeySet;
+this.iterator = cacheKeySet.iterator();
+this.current = 0;
+  }
+
+  public HazelcastStore getDataStore() {
+return (HazelcastStore) super.getDataStore();
+  }
+
+  @Override
+  public float getProgress() throws IOException {
+if (cacheKeySet.size() == 0) {
+  return 1;
+}
+float progress = ((float) current / (float) cacheKeySet.size());

Review comment:
   You can inline variable.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] kamaci commented on pull request #225: GORA-562 Add bin batchscript

[GitBox]

kamaci commented on pull request #225:
URL: https://github.com/apache/gora/pull/225#issuecomment-841361918


   @Titan-BT-7274 did you update your PR regarding to @jhnmora000's comments?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] kamaci commented on pull request #234: GORA-664 Add datastore for Elasticsearch

[GitBox]

kamaci commented on pull request #234:
URL: https://github.com/apache/gora/pull/234#issuecomment-841358468


   Congrats @podorvanova for the PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] kamaci commented on a change in pull request #234: GORA-664 Add datastore for Elasticsearch

[GitBox]

kamaci commented on a change in pull request #234:
URL: https://github.com/apache/gora/pull/234#discussion_r632653393



##
File path: 
gora-elasticsearch/src/main/java/org/apache/gora/elasticsearch/store/ElasticsearchStoreMetadataAnalyzer.java
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gora.elasticsearch.store;
+
+import org.apache.gora.elasticsearch.utils.ElasticsearchParameters;
+import org.apache.gora.store.impl.DataStoreMetadataAnalyzer;
+import org.apache.gora.util.GoraException;
+import org.elasticsearch.client.RequestOptions;
+import org.elasticsearch.client.RestHighLevelClient;
+import org.elasticsearch.client.indices.GetIndexRequest;
+import org.elasticsearch.client.indices.GetIndexResponse;
+import org.elasticsearch.cluster.metadata.MappingMetadata;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Map;
+
+public class ElasticsearchStoreMetadataAnalyzer extends 
DataStoreMetadataAnalyzer {
+
+private RestHighLevelClient elasticsearchClient;
+
+@Override
+public void initialize() throws GoraException {
+ElasticsearchParameters parameters = 
ElasticsearchParameters.load(properties, getConf());
+elasticsearchClient = ElasticsearchStore.createClient(parameters);
+}
+
+@Override
+public String getType() {
+return "ELASTICSEARCH";
+}
+
+@Override
+public List getTablesNames() throws GoraException {
+GetIndexRequest request = new GetIndexRequest("*");
+GetIndexResponse response;
+try {
+response = elasticsearchClient.indices().get(request, 
RequestOptions.DEFAULT);
+} catch (IOException ex) {
+throw new GoraException(ex);
+}
+assert response != null;

Review comment:
   Consider logging and throwing an error without using assert.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] kamaci commented on a change in pull request #234: GORA-664 Add datastore for Elasticsearch

[GitBox]

kamaci commented on a change in pull request #234:
URL: https://github.com/apache/gora/pull/234#discussion_r632650676



##
File path: 
gora-elasticsearch/src/main/java/org/apache/gora/elasticsearch/query/ElasticsearchResult.java
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gora.elasticsearch.query;
+
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.query.Query;
+import org.apache.gora.query.impl.ResultBase;
+import org.apache.gora.store.DataStore;
+
+import java.util.List;
+
+/**
+ * ElasticsearchResult specific implementation of the
+ * {@link org.apache.gora.query.Result} interface.
+ */
+public class ElasticsearchResult extends 
ResultBase {
+
+/**
+ * List of resulting persistent objects.
+ */
+private List persistentObjects;
+
+/**
+ * List of resulting objects keys.
+ */
+private List persistentKeys;
+
+public ElasticsearchResult(DataStore dataStore, Query query, 
List persistentKeys, List persistentObjects) {
+super(dataStore, query);
+this.persistentKeys = persistentKeys;
+this.persistentObjects = persistentObjects;
+}
+
+@Override
+public float getProgress() {
+if (persistentObjects.size() == 0) {
+return 1;
+} else {

Review comment:
   No need to write `else`. It can be:
   
   ```
   if (persistentObjects.size() == 0) {
   return 1;
   }
   
   return offset / (float) persistentObjects.size();
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [gora] kamaci commented on a change in pull request #234: GORA-664 Add datastore for Elasticsearch

[GitBox]

kamaci commented on a change in pull request #234:
URL: https://github.com/apache/gora/pull/234#discussion_r632649046



##
File path: 
gora-elasticsearch/src/main/java/org/apache/gora/elasticsearch/mapping/ElasticsearchMappingBuilder.java
##
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gora.elasticsearch.mapping;
+
+import com.google.inject.ConfigurationException;
+import org.apache.commons.io.IOUtils;
+import org.apache.gora.elasticsearch.store.ElasticsearchStore;
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.util.GoraException;
+import org.jdom.Document;
+import org.jdom.Element;
+import org.jdom.JDOMException;
+import org.jdom.input.SAXBuilder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.xml.sax.SAXException;
+
+import javax.xml.XMLConstants;
+import javax.xml.transform.Source;
+import javax.xml.transform.stream.StreamSource;
+import javax.xml.validation.Schema;
+import javax.xml.validation.SchemaFactory;
+import java.io.IOException;
+import java.io.InputStream;
+import java.nio.charset.Charset;
+import java.util.List;
+import java.util.Locale;
+
+/**
+ * Builder for Mapping definitions of Elasticsearch.
+ */
+public class ElasticsearchMappingBuilder {
+
+private static final Logger LOG = 
LoggerFactory.getLogger(ElasticsearchMappingBuilder.class);
+
+/**
+ * XSD validation file for the XML mapping.
+ */
+private static final String XSD_MAPPING_FILE = "gora-elasticsearch.xsd";
+
+// Index description
+static final String ATT_NAME = "name";
+
+static final String ATT_TYPE = "type";
+
+// Class description
+static final String TAG_CLASS = "class";
+
+static final String ATT_KEYCLASS = "keyClass";
+
+static final String ATT_INDEX = "index";
+
+static final String TAG_FIELD = "field";
+
+static final String ATT_DOCFIELD = "docfield";
+
+static final String ATT_SCALINGFACTOR = "scalingFactor";
+
+/**
+ * Mapping instance being built.
+ */
+private ElasticsearchMapping elasticsearchMapping;
+
+private final ElasticsearchStore dataStore;
+
+/**
+ * Constructor for ElasticsearchMappingBuilder.
+ *
+ * @param store ElasticsearchStore instance
+ */
+public ElasticsearchMappingBuilder(final ElasticsearchStore store) {
+this.elasticsearchMapping = new ElasticsearchMapping();
+this.dataStore = store;
+}
+
+/**
+ * Returns the Elasticsearch Mapping being built.
+ *
+ * @return Elasticsearch Mapping instance
+ */
+public ElasticsearchMapping getElasticsearchMapping() {
+return elasticsearchMapping;
+}
+
+/**
+ * Sets the Elasticsearch Mapping.
+ *
+ * @param elasticsearchMapping Elasticsearch Mapping instance
+ */
+public void setElasticsearchMapping(ElasticsearchMapping 
elasticsearchMapping) {
+this.elasticsearchMapping = elasticsearchMapping;
+}
+
+/**
+ * Reads Elasticsearch mappings from file.
+ *
+ * @param inputStream   Mapping input stream
+ * @param xsdValidation Parameter for enabling XSD validation
+ */
+public void readMappingFile(InputStream inputStream, boolean 
xsdValidation) {
+try {
+SAXBuilder saxBuilder = new SAXBuilder();
+if (inputStream == null) {
+LOG.error("The mapping input stream is null!");
+throw new GoraException("The mapping input stream is null!");
+}
+
+// Convert input stream to a string to use it a few times
+String mappingStream = IOUtils.toString(inputStream, 
Charset.defaultCharset());
+
+// XSD validation for XML file
+if (xsdValidation) {
+Source xmlSource = new 
StreamSource(IOUtils.toInputStream(mappingStream, Charset.defaultCharset()));
+Schema schema = 
SchemaFactory.newInstance(XMLConstants.W3C_XML_SCHEMA_NS_URI)
+.newSchema(new 
StreamSource(getClass().getClassLoader().getResourceAsStream(XSD_MAPPING_FILE)));
+schema.newValidator().validate(xmlSource);
+LOG.info("Mapping