[GitHub] [gora] cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-06 Thread GitBox
cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480512928 @djkevincr done! This is an automated message from

[GitHub] [gora] cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-05 Thread GitBox
cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480476838 I implemented the test. I also notice that in some places some keys are converted to `String` by default. I solved

[GitHub] [gora] cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-05 Thread GitBox
cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480299253 Yes, I reviewed the `DataStoreTestBase`, but it creates a `employeeStore` and a `webPageStore` which both have String

[GitHub] [gora] cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-04 Thread GitBox
cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480081077 I was trying to add that but it creates two examples, employees and website, which have string keys. How can I extend