[GitHub] [gora] lewismc commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-05 Thread GitBox
lewismc commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480384094 So why don't you just create individual tests such as

[GitHub] [gora] lewismc commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-05 Thread GitBox
lewismc commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480168630 @cuent you can easily implement individual tests for the module and use the `@Override` convention to implement the

[GitHub] [gora] lewismc commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-04 Thread GitBox
lewismc commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480010966 This looks good @cuent thank you for taking the issue on. Please augment your pull request with Unit tests. Thank you