[GitHub] [gora] cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480512928 @djkevincr done! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480476838 I implemented the test. I also notice that in some places some keys are converted to `String` by default. I solved another issue by inferring the type while creating the document. It is working and passing all the tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480299253 Yes, I reviewed the `DataStoreTestBase`, but it creates a `employeeStore` and a `webPageStore` which both have String kes. So even if I override the method, Query will ask for a String. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480081077 I was trying to add that but it creates two examples, employees and website, which have string keys. How can I extend that for creating a key with a numerical type? I was looking for that but I didn't found. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
