djkevincr commented on issue #135: Goraexplorer needed changes
URL: https://github.com/apache/gora/pull/135#issuecomment-474604466
@alfonsonishikawa Lets create a new ticket and address separately :)
This is an automated
djkevincr commented on issue #135: Goraexplorer needed changes
URL: https://github.com/apache/gora/pull/135#issuecomment-474603912
@alfonsonishikawa I have merged you PR, thank you very much for your hard
work on this :) I went through your design documents and all looked very
impressive.
djkevincr commented on issue #135: Goraexplorer needed changes
URL: https://github.com/apache/gora/pull/135#issuecomment-474034153
@alfonsonishikawa One concern I do have is, I noticed record.vm velocity
template changes, hopefully I think you have regenerated all the AVRO databean
djkevincr commented on issue #135: Goraexplorer needed changes
URL: https://github.com/apache/gora/pull/135#issuecomment-474029378
Locally tested the PR, build passes without any test failures.
[INFO]
djkevincr commented on issue #135: Goraexplorer needed changes
URL: https://github.com/apache/gora/pull/135#issuecomment-472522370
@alfonsonishikawa Are you done with updating PR as per the reviews? Is there
anything else that we should address or do you need further time on this? Its
5 matches
Mail list logo
