[GitHub] [gora] djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-06 Thread GitBox
djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480527044 @lewismc Please raise if you do have any concerns. Otherwise will proceed to merge.

[GitHub] [gora] djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-06 Thread GitBox
djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480526888 I have approved the PR, will locally test and merge to the master.

[GitHub] [gora] djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-06 Thread GitBox
djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480521014 @cuent Thank you for addressing my comments. Were you able add the EmployeeInt.json AVRO schema? This should be added

[GitHub] [gora] djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-06 Thread GitBox
djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480482576 @cuent Thanks for considering my suggestions over the discussion we had on ticket. Noticed you have added changes

[GitHub] [gora] djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-04 Thread GitBox
djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480031983 +1 @cuent This look certainly great. @lewismc mentioned you may add Lucene store specific tests. ( in