[GitHub] [gora] djkevincr commented on issue #161: GORA-565: Enable Spark in Unit Tests

djkevincr commented on issue #161: GORA-565: Enable Spark in Unit Tests URL: https://github.com/apache/gora/pull/161#issuecomment-488335336 I will merge this PR as it is and send a new PR to fix the failing tests. This is an a

[GitHub] [gora] djkevincr commented on issue #161: GORA-565: Enable Spark in Unit Tests

djkevincr commented on issue #161: GORA-565: Enable Spark in Unit Tests URL: https://github.com/apache/gora/pull/161#issuecomment-487840780 ``` public Configuration generateOutputConf(DataStore dataStore) throws IOException { Configuration hadoopConf = ((Configura

[GitHub] [gora] djkevincr commented on issue #161: GORA-565: Enable Spark in Unit Tests

djkevincr commented on issue #161: GORA-565: Enable Spark in Unit Tests URL: https://github.com/apache/gora/pull/161#issuecomment-487832799 @sneceesay77 I have locally tested your PR and ran into some issues. ``` # Don't override properties coming from Hadoop configuration for test

[GitHub] [gora] djkevincr commented on issue #161: GORA-565: Enable Spark in Unit Tests

djkevincr commented on issue #161: GORA-565: Enable Spark in Unit Tests URL: https://github.com/apache/gora/pull/161#issuecomment-484770502 @sneceesay77 This looks great, thank you for the contribution. I ll keep this PR for a while, so that others can have a look.