[GitHub] [gora] lewismc commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
lewismc commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480384094 So why don't you just create individual tests such as https://github.com/apache/gora/blob/master/gora-accumulo/src/test/java/org/apache/gora/accumulo/store/PartitionTest.java This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] lewismc commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
lewismc commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480168630 @cuent you can easily implement individual tests for the module and use the `@Override` convention to implement the specific keys you need. See [TestHBaseStore.java](https://github.com/apache/gora/blob/master/gora-hbase/src/test/java/org/apache/gora/hbase/store/TestHBaseStore.java) for more details. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] lewismc commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
lewismc commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480010966 This looks good @cuent thank you for taking the issue on. Please augment your pull request with Unit tests. Thank you This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
