[GitHub] gora issue #132: Gora-444 : Add #size() to Result API

Github user djkevincr commented on the issue: https://github.com/apache/gora/pull/132 Awesome work Carlos :+1: One minor thing to point out, it s good if you can be consistent with commit messages. Have look at this post. [1] https://chris.beams.io/posts/git-commit/ ---

[GitHub] gora issue #132: Gora-444 : Add #size() to Result API

Github user djkevincr commented on the issue: https://github.com/apache/gora/pull/132 If any one have concerns please raise, otherwise I will proceed merging this PR to master. ---

[GitHub] gora issue #132: Gora-444 : Add #size() to Result API

Github user carlosrmng commented on the issue: https://github.com/apache/gora/pull/132 Is this okay for merge? ---

[GitHub] gora issue #132: Gora-444 : Add #size() to Result API

Github user lewismc commented on the issue: https://github.com/apache/gora/pull/132 +1 ---

[GitHub] gora issue #132: Gora-444 : Add #size() to Result API

Github user cguzel commented on the issue: https://github.com/apache/gora/pull/132 +1 ---

[GitHub] gora issue #132: Gora-444 : Add #size() to Result API

Github user nishadi commented on the issue: https://github.com/apache/gora/pull/132 Hi Carlos, This is great. One thing to note is when sending PRs please make sure code is well formatted, all required Java docs is added for public methods. These improvements will show case a good

[GitHub] gora issue #132: Gora-444 : Add #size() to Result API

Github user carlosrmng commented on the issue: https://github.com/apache/gora/pull/132 Thanks for your support, I will start working in some tests and documentation. ---

[GitHub] gora issue #132: Gora-444 : Add #size() to Result API

Github user djkevincr commented on the issue: https://github.com/apache/gora/pull/132 +1 ---

[GitHub] gora issue #132: Gora-444 : Add #size() to Result API

Github user lewismc commented on the issue: https://github.com/apache/gora/pull/132 Yep tests would be great. IMHO, as this is something we want to test for every Datastore, I suggest it be implemented within

[GitHub] gora issue #132: Gora-444 : Add #size() to Result API

Github user nishadi commented on the issue: https://github.com/apache/gora/pull/132 This is great work...!!! As Lewis mentioned, shall we add tests for this? As well we will need to document all the public APIs as well. ---

[GitHub] gora issue #132: Gora-444 : Add #size() to Result API

Github user lewismc commented on the issue: https://github.com/apache/gora/pull/132 I am +1 for committing this. @carlosrmng it would be great if we could add tests to

[GitHub] gora issue #132: Gora-444 : Add #size() to Result API

Github user lewismc commented on the issue: https://github.com/apache/gora/pull/132 @carlosrmng great 👍 Can you please format 2 space indents the same as the other source code? Thanks ---