[
https://issues.apache.org/jira/browse/GOSSIP-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932083#comment-15932083
]
ASF GitHub Bot commented on GOSSIP-74:
--------------------------------------
Github user makrusak closed the pull request at:
https://github.com/apache/incubator-gossip/pull/43
> FailureDetector is calculating phi improperly
> ---------------------------------------------
>
> Key: GOSSIP-74
> URL: https://issues.apache.org/jira/browse/GOSSIP-74
> Project: Gossip
> Issue Type: Bug
> Reporter: Maxim Rusak
> Assignee: Maxim Rusak
> Fix For: 0.1.3
>
>
> Now FailureDetector have (at least) 2 bugs (in comparation to original paper):
> 1. latestHeartbeatMs don't update on each HeartBeat. So we have
> descriptiveStatistics consisted not from deltas between heartbeats but from
> time periods from first heartbeats.
> 2. when we create normalDistribution we pass variation, not standard
> deviation.
> They make FailureDetector totally indifferent due to extremely high deviation.
> Example: http://pastebin.com/xaeF52PP
> Here we send 100 heartbeats, one per second(for example), then we check the
> state after 2000 seconds, and comparing to threshold it's still alive.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
