[jira] [Commented] (GOSSIP-29) Typo in GossipCore method name

2016-10-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GOSSIP-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582399#comment-15582399
 ] 

ASF GitHub Bot commented on GOSSIP-29:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-gossip/pull/16


> Typo in GossipCore method name
> --
>
> Key: GOSSIP-29
> URL: https://issues.apache.org/jira/browse/GOSSIP-29
> Project: Gossip
>  Issue Type: Bug
>Reporter: Rishabh Patel
>Assignee: Rishabh Patel
>Priority: Trivial
>
> The GossipCore class has a "recieve" method. We should correct this typo to 
> avoid propagating it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (GOSSIP-29) Typo in GossipCore method name

2016-10-17 Thread Edward Capriolo (JIRA) 

 [ 
https://issues.apache.org/jira/browse/GOSSIP-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Edward Capriolo resolved GOSSIP-29.
---
Resolution: Fixed

Merged. Thank you!

> Typo in GossipCore method name
> --
>
> Key: GOSSIP-29
> URL: https://issues.apache.org/jira/browse/GOSSIP-29
> Project: Gossip
>  Issue Type: Bug
>Reporter: Rishabh Patel
>Assignee: Rishabh Patel
>Priority: Trivial
>
> The GossipCore class has a "recieve" method. We should correct this typo to 
> avoid propagating it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (GOSSIP-30) Use getDeadMembers instead of getDeadList

2016-10-17 Thread Rishabh Patel (JIRA) 
Rishabh Patel created GOSSIP-30:
---

 Summary: Use getDeadMembers instead of getDeadList
 Key: GOSSIP-30
 URL: https://issues.apache.org/jira/browse/GOSSIP-30
 Project: Gossip
  Issue Type: Improvement
Reporter: Rishabh Patel
Assignee: Rishabh Patel


The getDeadList method is a duplicate of getDeadMembers

{code:title=GossipManager.java}
public List getDeadMembers() {
List down = new ArrayList<>();
for (Entry entry : members.entrySet()) {
  if (GossipState.DOWN.equals(entry.getValue())) {
down.add(entry.getKey());
  }
}
return Collections.unmodifiableList(down);
  }
public List getDeadList() {
List up = new ArrayList<>();
for (Entry entry : members.entrySet()) {
  if (GossipState.DOWN.equals(entry.getValue())) {
up.add(entry.getKey());
  }
}
return Collections.unmodifiableList(up);
  }
{code}

I recommend removing getDeadList, as now we can use the pair of similarly named 
methods getLiveMembers and getDeadMembers



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work started] (GOSSIP-30) Use getDeadMembers instead of getDeadList

2016-10-17 Thread Rishabh Patel (JIRA) 

 [ 
https://issues.apache.org/jira/browse/GOSSIP-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on GOSSIP-30 started by Rishabh Patel.
---
> Use getDeadMembers instead of getDeadList
> -
>
> Key: GOSSIP-30
> URL: https://issues.apache.org/jira/browse/GOSSIP-30
> Project: Gossip
>  Issue Type: Improvement
>Reporter: Rishabh Patel
>Assignee: Rishabh Patel
>
> The getDeadList method is a duplicate of getDeadMembers
> {code:title=GossipManager.java}
> public List getDeadMembers() {
> List down = new ArrayList<>();
> for (Entry entry : members.entrySet()) {
>   if (GossipState.DOWN.equals(entry.getValue())) {
> down.add(entry.getKey());
>   }
> }
> return Collections.unmodifiableList(down);
>   }
> public List getDeadList() {
> List up = new ArrayList<>();
> for (Entry entry : members.entrySet()) {
>   if (GossipState.DOWN.equals(entry.getValue())) {
> up.add(entry.getKey());
>   }
> }
> return Collections.unmodifiableList(up);
>   }
> {code}
> I recommend removing getDeadList, as now we can use the pair of similarly 
> named methods getLiveMembers and getDeadMembers



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GOSSIP-30) Use getDeadMembers instead of getDeadList

2016-10-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GOSSIP-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15583511#comment-15583511
 ] 

ASF GitHub Bot commented on GOSSIP-30:
--

GitHub user patelrishabh opened a pull request:

https://github.com/apache/incubator-gossip/pull/17

GOSSIP-30 Use getDeadMembers instead of getDeadList



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/patelrishabh/incubator-gossip GOSSIP-30

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-gossip/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #17


commit 3d0ccf52e516eabbb07bea5cc8a52aefb0f1ce67
Author: Rishabh Patel 
Date:   2016-10-17T20:04:43Z

GOSSIP-30 Use getDeadMembers instead of getDeadList




> Use getDeadMembers instead of getDeadList
> -
>
> Key: GOSSIP-30
> URL: https://issues.apache.org/jira/browse/GOSSIP-30
> Project: Gossip
>  Issue Type: Improvement
>Reporter: Rishabh Patel
>Assignee: Rishabh Patel
>
> The getDeadList method is a duplicate of getDeadMembers
> {code:title=GossipManager.java}
> public List getDeadMembers() {
> List down = new ArrayList<>();
> for (Entry entry : members.entrySet()) {
>   if (GossipState.DOWN.equals(entry.getValue())) {
> down.add(entry.getKey());
>   }
> }
> return Collections.unmodifiableList(down);
>   }
> public List getDeadList() {
> List up = new ArrayList<>();
> for (Entry entry : members.entrySet()) {
>   if (GossipState.DOWN.equals(entry.getValue())) {
> up.add(entry.getKey());
>   }
> }
> return Collections.unmodifiableList(up);
>   }
> {code}
> I recommend removing getDeadList, as now we can use the pair of similarly 
> named methods getLiveMembers and getDeadMembers



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)