Re: [VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating (RC2)

[P . Taylor Goetz]

+1

I checked:

- DISCLAIMER exists
- NOTICE looks good.
- LICENSE looks good
- License headers present
- Can build from source (though I had to skip tests. I got the same failures as 
Josh).
- Signatures/hashes check out.

Nice work on the quick turnaround.

-Taylor

> On Jan 3, 2017, at 3:47 PM, Edward Capriolo  wrote:
> 
> I am pleased to be calling this vote for the source release of Apache Gossip
> 
> Ancillary artifacts such as poms, jars, wars, ect. can be found here:
> https://repository.apache.org/content/repositories/orgapachegossip-1002/
> 
> The Git commit ID is:
> 6720f35beb8718ae39018211f33bbff2ac782fb6
> https://github.com/apache/incubator-gossip/commit/6720f35beb8718ae39018211f33bbff2ac782fb6
> 
> The tag is:
> https://github.com/apache/incubator-gossip/tree/gossip-0.1.1-incubating-rc2
> 
> Checksums of:
> https://repository.apache.org/content/repositories/orgapachegossip-1002/org/apache/gossip/gossip/0.1.1-incubating/gossip-0.1.1-incubating-source-release.zip
> https://repository.apache.org/content/repositories/orgapachegossip-1002/org/apache/gossip/gossip/0.1.1-incubating/gossip-0.1.1-incubating-source-release.zip.md5
> https://repository.apache.org/content/repositories/orgapachegossip-1002/org/apache/gossip/gossip/0.1.1-incubating/gossip-0.1.1-incubating-source-release.zip.sha1
> SHA1: 66dfe09a925fe2650fd3d85c97fdc10b049a9776
> MD5: 2695f11e714edb1364a4105b970039b8
> 
> Are confirmed:
> [edward@jackintosh tmp]$ wget
> https://repository.apache.org/content/repositories/orgapachegossip-1002/org/apache/gossip/gossip/0.1.1-incubating/gossip-0.1.1-incubating-source-release.zip
> [edward@jackintosh tmp]$ md5sum gossip-0.1.1-incubating-source-release.zip
> 2695f11e714edb1364a4105b970039b8  gossip-0.1.1-incubating-source-release.zip
> [edward@jackintosh tmp]$ sha1sum gossip-0.1.1-incubating-source-release.zip
> 66dfe09a925fe2650fd3d85c97fdc10b049a9776
> gossip-0.1.1-incubating-source-release.zip
> 
> Release artifacts are signed with the following key:
> http://people.apache.org/~ecapriolo/
> http://people.apache.org/~ecapriolo/ecapriolo_asf.asc
> 
> KEYS file available here:
> https://dist.apache.org/repos/dist/release/incubator/gossip/KEYS
> 
> Please download the release candidate and evaluate the necessary items
> including checking hashes, signatures, build from source, and test.
> 
> Note: The end-to-end tests (ShutdownDeadtimeTest) tend to be flakey.
> https://issues.apache.org/jira/browse/GOSSIP-22 will address this feature
> in next release.
> 
> Release this package?
> [ ] +1 yes
> [ ] +0 no opinion
> [ ] -1 Do not release this package because because...

Re: [VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating (RC2)

[Edward Capriolo]

+1.

Many emails today. I wanted to make sure this one did not get lost in the
shuffle.

On Tue, Jan 3, 2017 at 3:47 PM, Edward Capriolo 
wrote:

> I am pleased to be calling this vote for the source release of Apache
> Gossip
>
> Ancillary artifacts such as poms, jars, wars, ect. can be found here:
> https://repository.apache.org/content/repositories/orgapachegossip-1002/
>
> The Git commit ID is:
> 6720f35beb8718ae39018211f33bbff2ac782fb6
> https://github.com/apache/incubator-gossip/commit/
> 6720f35beb8718ae39018211f33bbff2ac782fb6
> The tag is:
> https://github.com/apache/incubator-gossip/tree/gossip-
> 0.1.1-incubating-rc2
>
> Checksums of:
> https://repository.apache.org/content/repositories/
> orgapachegossip-1002/org/apache/gossip/gossip/0.1.1-
> incubating/gossip-0.1.1-incubating-source-release.zip
> https://repository.apache.org/content/repositories/
> orgapachegossip-1002/org/apache/gossip/gossip/0.1.1-
> incubating/gossip-0.1.1-incubating-source-release.zip.md5
> https://repository.apache.org/content/repositories/
> orgapachegossip-1002/org/apache/gossip/gossip/0.1.1-
> incubating/gossip-0.1.1-incubating-source-release.zip.sha1
> SHA1: 66dfe09a925fe2650fd3d85c97fdc10b049a9776
> MD5: 2695f11e714edb1364a4105b970039b8
>
> Are confirmed:
> [edward@jackintosh tmp]$ wget https://repository.apache.org/
> content/repositories/orgapachegossip-1002/org/apache/gossip/gossip/0.1.1-
> incubating/gossip-0.1.1-incubating-source-release.zip
> [edward@jackintosh tmp]$ md5sum gossip-0.1.1-incubating-
> source-release.zip
> 2695f11e714edb1364a4105b970039b8  gossip-0.1.1-incubating-
> source-release.zip
> [edward@jackintosh tmp]$ sha1sum gossip-0.1.1-incubating-
> source-release.zip
> 66dfe09a925fe2650fd3d85c97fdc10b049a9776  gossip-0.1.1-incubating-
> source-release.zip
>
> Release artifacts are signed with the following key:
> http://people.apache.org/~ecapriolo/
> http://people.apache.org/~ecapriolo/ecapriolo_asf.asc
>
> KEYS file available here: https://dist.apache.org/repos/
> dist/release/incubator/gossip/KEYS
>
> Please download the release candidate and evaluate the necessary items
> including checking hashes, signatures, build from source, and test.
>
> Note: The end-to-end tests (ShutdownDeadtimeTest) tend to be flakey.
> https://issues.apache.org/jira/browse/GOSSIP-22 will address this feature
> in next release.
>
> Release this package?
> [ ] +1 yes
> [ ] +0 no opinion
> [ ] -1 Do not release this package because because...
>

Re: [VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating

[P. Taylor Goetz]

Josh is correct that there is some wiggle room on this specific issue (json.org 
license). The wiggle room is that existing projects have a grace period for 
removing the json.org dependency, with the deadline I think being June 2017.

Since Gossip has yet to make a release, I would lean toward removing it. It 
would be a good demonstration to the IPMC of the podling taking efforts to 
comply with license policy.

> On Jan 3, 2017, at 4:54 PM, Gary Dusbabek  wrote:
> 
> On Tue, Jan 3, 2017 at 10:45 AM, Josh Elser  wrote:
> 
>> -1 due to a dependency on a project with a category-X license [1].
>> 
> 
> Wait. So you're saying that a transitive category-X licensed dependency is
> verboten even when we do not include the binary or the source?
> 

The litmus test I use is “Can the software be used without the category-X 
licensed dependency?”

If the answer is “no” then it is verboten. 

-Taylor

[VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating (RC2)

[Edward Capriolo]

I am pleased to be calling this vote for the source release of Apache Gossip

Ancillary artifacts such as poms, jars, wars, ect. can be found here:
https://repository.apache.org/content/repositories/orgapachegossip-1002/

The Git commit ID is:
6720f35beb8718ae39018211f33bbff2ac782fb6
https://github.com/apache/incubator-gossip/commit/6720f35beb8718ae39018211f33bbff2ac782fb6

The tag is:
https://github.com/apache/incubator-gossip/tree/gossip-0.1.1-incubating-rc2

Checksums of:
https://repository.apache.org/content/repositories/orgapachegossip-1002/org/apache/gossip/gossip/0.1.1-incubating/gossip-0.1.1-incubating-source-release.zip
https://repository.apache.org/content/repositories/orgapachegossip-1002/org/apache/gossip/gossip/0.1.1-incubating/gossip-0.1.1-incubating-source-release.zip.md5
https://repository.apache.org/content/repositories/orgapachegossip-1002/org/apache/gossip/gossip/0.1.1-incubating/gossip-0.1.1-incubating-source-release.zip.sha1
SHA1: 66dfe09a925fe2650fd3d85c97fdc10b049a9776
MD5: 2695f11e714edb1364a4105b970039b8

Are confirmed:
[edward@jackintosh tmp]$ wget
https://repository.apache.org/content/repositories/orgapachegossip-1002/org/apache/gossip/gossip/0.1.1-incubating/gossip-0.1.1-incubating-source-release.zip
[edward@jackintosh tmp]$ md5sum gossip-0.1.1-incubating-source-release.zip
2695f11e714edb1364a4105b970039b8  gossip-0.1.1-incubating-source-release.zip
[edward@jackintosh tmp]$ sha1sum gossip-0.1.1-incubating-source-release.zip
66dfe09a925fe2650fd3d85c97fdc10b049a9776
 gossip-0.1.1-incubating-source-release.zip

Release artifacts are signed with the following key:
http://people.apache.org/~ecapriolo/
http://people.apache.org/~ecapriolo/ecapriolo_asf.asc

KEYS file available here:
https://dist.apache.org/repos/dist/release/incubator/gossip/KEYS

Please download the release candidate and evaluate the necessary items
including checking hashes, signatures, build from source, and test.

Note: The end-to-end tests (ShutdownDeadtimeTest) tend to be flakey.
https://issues.apache.org/jira/browse/GOSSIP-22 will address this feature
in next release.

Release this package?
[ ] +1 yes
[ ] +0 no opinion
[ ] -1 Do not release this package because because...

Re: [VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating

[Edward Capriolo]

No worries I will tackle it today. I did not like the ugly class names hurt
my eyes.

import org.json.JSONObject;

STOP YELLING AT ME JSON!

On Tue, Jan 3, 2017 at 1:26 PM, Drew Farris  wrote:

> I may be incorrect here, I need to do some research; The license issue may
> be a barrier to graduation but may not prevent releases while incubating.
> Josh, do you recall offhand?
>
> Drew
>
> On Tue, Jan 3, 2017 at 11:45 AM Josh Elser  wrote:
>
> > -1 due to a dependency on a project with a category-X license [1].
> >
> > Gossip is transitively depending on org.json:json via
> > jackson-datatype-json-org.
> >
> > ```
> > [INFO] org.apache.gossip:gossip:jar:0.1.1-incubating
> > [INFO] +- com.fasterxml.jackson:jackson-datatype-json-org:jar:1.8.0:
> compile
> > [INFO] |  +- org.codehaus.jackson:jackson-mapper-asl:jar:1.8.6:compile
> > [INFO] |  |  \- org.codehaus.jackson:jackson-core-asl:jar:1.8.6:compile
> > [INFO] |  \- org.json:json:jar:20090211:compile
> > ```
> >
> > org.json:json is licensed with the JSON license which the ASF has
> > recently moved to category-X [2]. Debian has a list of some
> > alternatives[3] which can be used instead. This would need to be
> > resolved before your release.
> >
> > I know in Calcite we use jackson-databind for JSON serialization of
> > POJOs and that doesn't have the dependency on org.json:json. Perhaps
> > this can be easily resolved switching the jackson dependencies and maybe
> > some API calls.
> >
> > Good:
> >
> > * xsums/sigs match (for source-release.zip)
> > * KEYS looks good
> > * Can build from source
> > * DISCLAIMER is present
> >
> > I see that the rc1 tag was pushed, and will assume that the next VOTE
> > message will get that right too. Re-stating this one as I can't verify
> > that presently.
> >
> > Nit:
> >
> > * Wrong header in the src/**/log4j.properties files. Update it to match
> > the header in the rest of the java files. Fix for next release.
> > * Year in NOTICE is now out of date. Fix for next release.
> > * Use "Apache Gossip" for the first mention of "Gossip" in the
> > README.md. Fix for next release.
> > * Add the license text to the README and eclipse template as it's
> > trivial to do so for both (xml and md both support "comments"). Fix for
> > next release.
> > * Tests failed for me (on a `mvn package`). Not a release issue, just a
> > quality issue. I would expect that all of the tests would pass, and just
> > wanted to mention it.
> >
> > ```
> > Failed tests:
> >ShutdownDeadtimeTest.DeadNodesDoNotComeAliveAgain:103
> > ComparisonFailure expected:<[16]> but was:<[8]>
> >StartupSettingsTest.testUsingSettingsFile:69 » Runtime
> > java.net.BindException:...
> >TenNodeThreeSeedTest.test:44->abc:78 » Runtime
> > java.net.BindException: Address...
> >TenNodeThreeSeedTest.testAgain:49->abc:78 » Runtime
> > java.net.BindException: Ad...
> > ```
> >
> > - Josh
> >
> > [1] https://www.apache.org/legal/resolved#category-x
> > [2] https://www.apache.org/legal/resolved#json
> > [3] https://wiki.debian.org/qa.debian.org/jsonevil
> >
> > Edward Capriolo wrote:
> > > I am pleased to be calling this vote for the source release of Apache
> > Gossip
> > >
> > > Ancillary artifacts such as poms, jars, wars, ect. can be found here:
> > > https://repository.apache.org/content/repositories/
> orgapachegossip-1001
> > >
> > > The Git commit ID is:
> > >
> > https://github.com/edwardcapriolo/incubator-gossip/commit/
> 74133870410fec45bd6cac39351fcbbe0950de18
> > >
> > > Which will be tagged as gossip-0.1.1-incubating
> > >
> > >
> > https://git-wip-us.apache.org/repos/asf?p=incubator-rya.git;a=commit;h=
> 66d8b7f060bddeeb7c50cb0918f98ce3b265c564
> > >
> > >
> > > Checksums of
> > >
> > https://repository.apache.org/content/repositories/
> orgapachegossip-1001/org/apache/gossip/gossip/0.1.1-
> incubating/gossip-0.1.1-incubating-source-release.zip.asc
> > > :
> > > SHA1: 53ca6498d0f704fe7931ec23ca81a638a1fd666c
> > > MD5: c27067c47bdeb6133660beda908f679c
> > >
> > > Release artifacts are signed with the following key:
> > > http://people.apache.org/~ecapriolo/
> > > http://people.apache.org/~ecapriolo/ecapriolo_asf.asc
> > >
> > > KEYS file available here:
> > > https://dist.apache.org/repos/dist/release/incubator/rya/KEYS
> > >
> > > The vote will be open for 72 hours. Please download the release
> candidate
> > > and evaluate the necessary items including checking hashes, signatures,
> > > build from source, and test.
> > >
> > >
> > > Release this package?
> > > [ ] +1 yes
> > > [ ] +0 no opinion
> > > [ ] -1 Do not release this package because because...
> > >
> >
>

Re: [VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating

[Drew Farris]

I may be incorrect here, I need to do some research; The license issue may
be a barrier to graduation but may not prevent releases while incubating.
Josh, do you recall offhand?

Drew

On Tue, Jan 3, 2017 at 11:45 AM Josh Elser  wrote:

> -1 due to a dependency on a project with a category-X license [1].
>
> Gossip is transitively depending on org.json:json via
> jackson-datatype-json-org.
>
> ```
> [INFO] org.apache.gossip:gossip:jar:0.1.1-incubating
> [INFO] +- com.fasterxml.jackson:jackson-datatype-json-org:jar:1.8.0:compile
> [INFO] |  +- org.codehaus.jackson:jackson-mapper-asl:jar:1.8.6:compile
> [INFO] |  |  \- org.codehaus.jackson:jackson-core-asl:jar:1.8.6:compile
> [INFO] |  \- org.json:json:jar:20090211:compile
> ```
>
> org.json:json is licensed with the JSON license which the ASF has
> recently moved to category-X [2]. Debian has a list of some
> alternatives[3] which can be used instead. This would need to be
> resolved before your release.
>
> I know in Calcite we use jackson-databind for JSON serialization of
> POJOs and that doesn't have the dependency on org.json:json. Perhaps
> this can be easily resolved switching the jackson dependencies and maybe
> some API calls.
>
> Good:
>
> * xsums/sigs match (for source-release.zip)
> * KEYS looks good
> * Can build from source
> * DISCLAIMER is present
>
> I see that the rc1 tag was pushed, and will assume that the next VOTE
> message will get that right too. Re-stating this one as I can't verify
> that presently.
>
> Nit:
>
> * Wrong header in the src/**/log4j.properties files. Update it to match
> the header in the rest of the java files. Fix for next release.
> * Year in NOTICE is now out of date. Fix for next release.
> * Use "Apache Gossip" for the first mention of "Gossip" in the
> README.md. Fix for next release.
> * Add the license text to the README and eclipse template as it's
> trivial to do so for both (xml and md both support "comments"). Fix for
> next release.
> * Tests failed for me (on a `mvn package`). Not a release issue, just a
> quality issue. I would expect that all of the tests would pass, and just
> wanted to mention it.
>
> ```
> Failed tests:
>ShutdownDeadtimeTest.DeadNodesDoNotComeAliveAgain:103
> ComparisonFailure expected:<[16]> but was:<[8]>
>StartupSettingsTest.testUsingSettingsFile:69 » Runtime
> java.net.BindException:...
>TenNodeThreeSeedTest.test:44->abc:78 » Runtime
> java.net.BindException: Address...
>TenNodeThreeSeedTest.testAgain:49->abc:78 » Runtime
> java.net.BindException: Ad...
> ```
>
> - Josh
>
> [1] https://www.apache.org/legal/resolved#category-x
> [2] https://www.apache.org/legal/resolved#json
> [3] https://wiki.debian.org/qa.debian.org/jsonevil
>
> Edward Capriolo wrote:
> > I am pleased to be calling this vote for the source release of Apache
> Gossip
> >
> > Ancillary artifacts such as poms, jars, wars, ect. can be found here:
> > https://repository.apache.org/content/repositories/orgapachegossip-1001
> >
> > The Git commit ID is:
> >
> https://github.com/edwardcapriolo/incubator-gossip/commit/74133870410fec45bd6cac39351fcbbe0950de18
> >
> > Which will be tagged as gossip-0.1.1-incubating
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-rya.git;a=commit;h=66d8b7f060bddeeb7c50cb0918f98ce3b265c564
> >
> >
> > Checksums of
> >
> https://repository.apache.org/content/repositories/orgapachegossip-1001/org/apache/gossip/gossip/0.1.1-incubating/gossip-0.1.1-incubating-source-release.zip.asc
> > :
> > SHA1: 53ca6498d0f704fe7931ec23ca81a638a1fd666c
> > MD5: c27067c47bdeb6133660beda908f679c
> >
> > Release artifacts are signed with the following key:
> > http://people.apache.org/~ecapriolo/
> > http://people.apache.org/~ecapriolo/ecapriolo_asf.asc
> >
> > KEYS file available here:
> > https://dist.apache.org/repos/dist/release/incubator/rya/KEYS
> >
> > The vote will be open for 72 hours. Please download the release candidate
> > and evaluate the necessary items including checking hashes, signatures,
> > build from source, and test.
> >
> >
> > Release this package?
> > [ ] +1 yes
> > [ ] +0 no opinion
> > [ ] -1 Do not release this package because because...
> >
>

Re: [VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating

[Josh Elser]

Edward Capriolo wrote:

On Tue, Jan 3, 2017 at 11:45 AM, Josh Elser  wrote:


-1 due to a dependency on a project with a category-X license [1].

Gossip is transitively depending on org.json:json via
jackson-datatype-json-org.

```
[INFO] org.apache.gossip:gossip:jar:0.1.1-incubating
[INFO] +- com.fasterxml.jackson:jackson-datatype-json-org:jar:1.8.0:co
mpile
[INFO] |  +- org.codehaus.jackson:jackson-mapper-asl:jar:1.8.6:compile
[INFO] |  |  \- org.codehaus.jackson:jackson-core-asl:jar:1.8.6:compile
[INFO] |  \- org.json:json:jar:20090211:compile
```

org.json:json is licensed with the JSON license which the ASF has recently
moved to category-X [2]. Debian has a list of some alternatives[3] which
can be used instead. This would need to be resolved before your release.

I know in Calcite we use jackson-databind for JSON serialization of POJOs
and that doesn't have the dependency on org.json:json. Perhaps this can be
easily resolved switching the jackson dependencies and maybe some API calls.

Good:

* xsums/sigs match (for source-release.zip)
* KEYS looks good
* Can build from source
* DISCLAIMER is present

I see that the rc1 tag was pushed, and will assume that the next VOTE
message will get that right too. Re-stating this one as I can't verify that
presently.

Nit:

* Wrong header in the src/**/log4j.properties files. Update it to match
the header in the rest of the java files. Fix for next release.
* Year in NOTICE is now out of date. Fix for next release.
* Use "Apache Gossip" for the first mention of "Gossip" in the README.md.
Fix for next release.
* Add the license text to the README and eclipse template as it's trivial
to do so for both (xml and md both support "comments"). Fix for next
release.
* Tests failed for me (on a `mvn package`). Not a release issue, just a
quality issue. I would expect that all of the tests would pass, and just
wanted to mention it.

```
Failed tests:
   ShutdownDeadtimeTest.DeadNodesDoNotComeAliveAgain:103 ComparisonFailure
expected:<[16]>  but was:<[8]>
   StartupSettingsTest.testUsingSettingsFile:69 » Runtime
java.net.BindException:...
   TenNodeThreeSeedTest.test:44->abc:78 » Runtime java.net.BindException:
Address...
   TenNodeThreeSeedTest.testAgain:49->abc:78 » Runtime
java.net.BindException: Ad...
```

- Josh

[1] https://www.apache.org/legal/resolved#category-x
[2] https://www.apache.org/legal/resolved#json
[3] https://wiki.debian.org/qa.debian.org/jsonevil

Edward Capriolo wrote:


I am pleased to be calling this vote for the source release of Apache
Gossip

Ancillary artifacts such as poms, jars, wars, ect. can be found here:
https://repository.apache.org/content/repositories/orgapachegossip-1001

The Git commit ID is:
https://github.com/edwardcapriolo/incubator-gossip/commit/74
133870410fec45bd6cac39351fcbbe0950de18

Which will be tagged as gossip-0.1.1-incubating

https://git-wip-us.apache.org/repos/asf?p=incubator-rya.git;
a=commit;h=66d8b7f060bddeeb7c50cb0918f98ce3b265c564


Checksums of
https://repository.apache.org/content/repositories/orgapache
gossip-1001/org/apache/gossip/gossip/0.1.1-incubating/
gossip-0.1.1-incubating-source-release.zip.asc
:
SHA1: 53ca6498d0f704fe7931ec23ca81a638a1fd666c
MD5: c27067c47bdeb6133660beda908f679c

Release artifacts are signed with the following key:
http://people.apache.org/~ecapriolo/
http://people.apache.org/~ecapriolo/ecapriolo_asf.asc

KEYS file available here:
https://dist.apache.org/repos/dist/release/incubator/rya/KEYS

The vote will be open for 72 hours. Please download the release candidate
and evaluate the necessary items including checking hashes, signatures,
build from source, and test.


Release this package?
[ ] +1 yes
[ ] +0 no opinion
[ ] -1 Do not release this package because because...



I have changed the dependency to this:
https://mvnrepository.com/artifact/com.fasterxml.jackson.datatype/jackson-datatype-json-org/2.8.5



 com.fasterxml.jackson.datatype
 jackson-datatype-json-org
 2.8.5


Which produces this:

mvn dependency:tree
[INFO] --- maven-dependency-plugin:2.10:tree (default-cli) @ gossip ---
[INFO] org.apache.gossip:gossip:jar:0.1.2-incubating-SNAPSHOT
[INFO] +-
com.fasterxml.jackson.datatype:jackson-datatype-json-org:jar:2.8.5:compile
[INFO] |  +- com.fasterxml.jackson.core:jackson-core:jar:2.8.5:compile
[INFO] |  +- com.fasterxml.jackson.core:jackson-databind:jar:2.8.5:compile
[INFO] |  |  \-
com.fasterxml.jackson.core:jackson-annotations:jar:2.8.0:compile
[INFO] |  \- org.apache.geronimo.bundles:json:jar:20090211_1:compile
[INFO] +- org.junit.jupiter:junit-jupiter-api:jar:5.0.0-M2:test
[INFO] |  +- org.opentest4j:opentest4j:jar:1.0.0-M1:test
[INFO] |  \- org.junit.platform:junit-platform-commons:jar:1.0.0-M2:test
[INFO] +- org.junit.jupiter:junit-jupiter-engine:jar:5.0.0-M2:test
[INFO] |  \- org.junit.platform:junit-platform-engine:jar:1.0.0-M2:test
[INFO] +- org.junit.vintage:junit-vintage-engine:jar:4.12.0-M2:test
[INFO] |  \- junit:junit:jar:4.12:test

Re: [VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating

[Edward Capriolo]

  * The git commit ID is good to see (not just the tag), but linking to
your personal github acct is a little out-of-the-normal to me.

Yes. I plan on pushing that commit to apache git as the tag once the vote
is complete. Normally the maven release WOULD push the tag but we are
voting on the tag so I did not want to push it until it is +1ed.

I have pushed the tag as
https://github.com/apache/incubator-gossip/tree/gossip-0.1.1-incubating-rc1when
the vote is complete I will re-tag as
https://github.com/apache/incubator-gossip/tree/gossip-0.1.1-incubating

*The manifest at the start of the KEYS file doesn't list you key although
the it present at the end of the file.

My manifest is after Taylors key (towards the middle of the file)

* For the checksums, I'm guessing you copied the wrong filename.
I assume you meant those are the checksums for
gossip-0.1.1-incubating-source-release.zip as a gpg signature doesn't
require
a checksum to ensure it was not tampered with

The maven process signed every artifact here:
https://repository.apache.org/content/repositories/orgapachegossip-1001/org/apache/gossip/gossip/0.1.1-incubating/
I have verified these locally.

The correct URL to the keys file is here:
https://dist.apache.org/repos/dist/release/incubator/gossip/KEYS

On Mon, Jan 2, 2017 at 9:37 AM, Drew Farris  wrote:

> Edward,
>
> Thanks for the release. Generally things looks pretty good. Aside from the
> concerns with the vote e-mail Josh already shared, I can't seem to find the
> commit referenced by commit id 7413387041 anywhere other than the
> edwardcapriolo fork on GitHub. That's the only other showstopper I have
> found.
>
> Here's what I checked:
>
> I found the correct KEYS file at:
> https://dist.apache.org/repos/dist/release/incubator/gossip/KEYS
>
> - Name on release artifacts includes incubating.
> - Verified GPG signatures, MD5's and SHA hashes look good.
> - No unintentional binary artifacts in the source release zip.
> - NOTICE, LICENSE, DISCLAIMER files all look good.
> - All source files have the Apache license header.
> - Can build from the source release.
>
> Some nits:
>
> You may consider GPG signing with an apache.org e-mail address instead of
> a
> personal address.
>
> The manifest at the start of the KEYS file doesn't list you key although
> the it present at the end of the file.
>
> I think it is probably worth calling a second vote with a corrected e-mail
> once Josh has weighed in and the commit is present on Apache's git repo.
>
> Drew
>
> On Mon, Jan 2, 2017 at 12:21 AM Josh Elser  wrote:
>
> I'm just getting back from a little vacation. If you can hold off on
> calling the vote strictly after 72hrs, I'll do my best to look at this
> tmrw before it makes its way to the IPMC for a vote.
>
> A couple of remarks on the VOTE email's content:
>* The git commit ID is good to see (not just the tag), but linking to
> your personal github acct is a little out-of-the-normal to me.
>* The URL to the KEYS file and the git-wip-us URL are both wrong.
>* For the checksums, I'm guessing you copied the wrong filename. I
> assume you meant those are the checksums for
> gossip-0.1.1-incubating-source-release.zip as a gpg signature doesn't
> require a checksum to ensure it was not tampered with.
>
> Edward Capriolo wrote:
> > I am pleased to be calling this vote for the source release of Apache
> Gossip
> >
> > Ancillary artifacts such as poms, jars, wars, ect. can be found here:
> > https://repository.apache.org/content/repositories/orgapachegossip-1001
> >
> > The Git commit ID is:
> >
> https://github.com/edwardcapriolo/incubator-gossip/commit/
> 74133870410fec45bd6cac39351fcbbe0950de18
> >
> > Which will be tagged as gossip-0.1.1-incubating
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-rya.git;a=commit;h=
> 66d8b7f060bddeeb7c50cb0918f98ce3b265c564
> >
> >
> > Checksums of
> >
> https://repository.apache.org/content/repositories/
> orgapachegossip-1001/org/apache/gossip/gossip/0.1.1-
> incubating/gossip-0.1.1-incubating-source-release.zip.asc
> > :
> > SHA1: 53ca6498d0f704fe7931ec23ca81a638a1fd666c
> > MD5: c27067c47bdeb6133660beda908f679c
> >
> > Release artifacts are signed with the following key:
> > http://people.apache.org/~ecapriolo/
> > http://people.apache.org/~ecapriolo/ecapriolo_asf.asc
> >
> > KEYS file available here:
> > https://dist.apache.org/repos/dist/release/incubator/rya/KEYS
> >
> > The vote will be open for 72 hours. Please download the release candidate
> > and evaluate the necessary items including checking hashes, signatures,
> > build from source, and test.
> >
> >
> > Release this package?
> > [ ] +1 yes
> > [ ] +0 no opinion
> > [ ] -1 Do not release this package because because...
> >
>

Re: [VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating

[Drew Farris]

Edward,

Thanks for the release. Generally things looks pretty good. Aside from the
concerns with the vote e-mail Josh already shared, I can't seem to find the
commit referenced by commit id 7413387041 anywhere other than the
edwardcapriolo fork on GitHub. That's the only other showstopper I have
found.

Here's what I checked:

I found the correct KEYS file at:
https://dist.apache.org/repos/dist/release/incubator/gossip/KEYS

- Name on release artifacts includes incubating.
- Verified GPG signatures, MD5's and SHA hashes look good.
- No unintentional binary artifacts in the source release zip.
- NOTICE, LICENSE, DISCLAIMER files all look good.
- All source files have the Apache license header.
- Can build from the source release.

Some nits:

You may consider GPG signing with an apache.org e-mail address instead of a
personal address.

The manifest at the start of the KEYS file doesn't list you key although
the it present at the end of the file.

I think it is probably worth calling a second vote with a corrected e-mail
once Josh has weighed in and the commit is present on Apache's git repo.

Drew

On Mon, Jan 2, 2017 at 12:21 AM Josh Elser  wrote:

I'm just getting back from a little vacation. If you can hold off on
calling the vote strictly after 72hrs, I'll do my best to look at this
tmrw before it makes its way to the IPMC for a vote.

A couple of remarks on the VOTE email's content:
   * The git commit ID is good to see (not just the tag), but linking to
your personal github acct is a little out-of-the-normal to me.
   * The URL to the KEYS file and the git-wip-us URL are both wrong.
   * For the checksums, I'm guessing you copied the wrong filename. I
assume you meant those are the checksums for
gossip-0.1.1-incubating-source-release.zip as a gpg signature doesn't
require a checksum to ensure it was not tampered with.

Edward Capriolo wrote:
> I am pleased to be calling this vote for the source release of Apache
Gossip
>
> Ancillary artifacts such as poms, jars, wars, ect. can be found here:
> https://repository.apache.org/content/repositories/orgapachegossip-1001
>
> The Git commit ID is:
>
https://github.com/edwardcapriolo/incubator-gossip/commit/74133870410fec45bd6cac39351fcbbe0950de18
>
> Which will be tagged as gossip-0.1.1-incubating
>
>
https://git-wip-us.apache.org/repos/asf?p=incubator-rya.git;a=commit;h=66d8b7f060bddeeb7c50cb0918f98ce3b265c564
>
>
> Checksums of
>
https://repository.apache.org/content/repositories/orgapachegossip-1001/org/apache/gossip/gossip/0.1.1-incubating/gossip-0.1.1-incubating-source-release.zip.asc
> :
> SHA1: 53ca6498d0f704fe7931ec23ca81a638a1fd666c
> MD5: c27067c47bdeb6133660beda908f679c
>
> Release artifacts are signed with the following key:
> http://people.apache.org/~ecapriolo/
> http://people.apache.org/~ecapriolo/ecapriolo_asf.asc
>
> KEYS file available here:
> https://dist.apache.org/repos/dist/release/incubator/rya/KEYS
>
> The vote will be open for 72 hours. Please download the release candidate
> and evaluate the necessary items including checking hashes, signatures,
> build from source, and test.
>
>
> Release this package?
> [ ] +1 yes
> [ ] +0 no opinion
> [ ] -1 Do not release this package because because...
>

Re: [VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating

[Josh Elser]

I'm just getting back from a little vacation. If you can hold off on 
calling the vote strictly after 72hrs, I'll do my best to look at this 
tmrw before it makes its way to the IPMC for a vote.


A couple of remarks on the VOTE email's content:
  * The git commit ID is good to see (not just the tag), but linking to 
your personal github acct is a little out-of-the-normal to me.

  * The URL to the KEYS file and the git-wip-us URL are both wrong.
  * For the checksums, I'm guessing you copied the wrong filename. I 
assume you meant those are the checksums for 
gossip-0.1.1-incubating-source-release.zip as a gpg signature doesn't 
require a checksum to ensure it was not tampered with.


Edward Capriolo wrote:

I am pleased to be calling this vote for the source release of Apache Gossip

Ancillary artifacts such as poms, jars, wars, ect. can be found here:
https://repository.apache.org/content/repositories/orgapachegossip-1001

The Git commit ID is:
https://github.com/edwardcapriolo/incubator-gossip/commit/74133870410fec45bd6cac39351fcbbe0950de18

Which will be tagged as gossip-0.1.1-incubating

https://git-wip-us.apache.org/repos/asf?p=incubator-rya.git;a=commit;h=66d8b7f060bddeeb7c50cb0918f98ce3b265c564


Checksums of
https://repository.apache.org/content/repositories/orgapachegossip-1001/org/apache/gossip/gossip/0.1.1-incubating/gossip-0.1.1-incubating-source-release.zip.asc
:
SHA1: 53ca6498d0f704fe7931ec23ca81a638a1fd666c
MD5: c27067c47bdeb6133660beda908f679c

Release artifacts are signed with the following key:
http://people.apache.org/~ecapriolo/
http://people.apache.org/~ecapriolo/ecapriolo_asf.asc

KEYS file available here:
https://dist.apache.org/repos/dist/release/incubator/rya/KEYS

The vote will be open for 72 hours. Please download the release candidate
and evaluate the necessary items including checking hashes, signatures,
build from source, and test.


Release this package?
[ ] +1 yes
[ ] +0 no opinion
[ ] -1 Do not release this package because because...

Re: [VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating

[Gary Dusbabek]

+1

On Fri, Dec 30, 2016 at 11:31 AM, Edward Capriolo 
wrote:

> I am pleased to be calling this vote for the source release of Apache
> Gossip
>
> Ancillary artifacts such as poms, jars, wars, ect. can be found here:
> https://repository.apache.org/content/repositories/orgapachegossip-1001
>
> The Git commit ID is:
> https://github.com/edwardcapriolo/incubator-gossip/commit/
> 74133870410fec45bd6cac39351fcbbe0950de18
>
> Which will be tagged as gossip-0.1.1-incubating
>
> https://git-wip-us.apache.org/repos/asf?p=incubator-rya.git;a=commit;h=
> 66d8b7f060bddeeb7c50cb0918f98ce3b265c564
>
>
> Checksums of
> https://repository.apache.org/content/repositories/
> orgapachegossip-1001/org/apache/gossip/gossip/0.1.1-
> incubating/gossip-0.1.1-incubating-source-release.zip.asc
> :
> SHA1: 53ca6498d0f704fe7931ec23ca81a638a1fd666c
> MD5: c27067c47bdeb6133660beda908f679c
>
> Release artifacts are signed with the following key:
> http://people.apache.org/~ecapriolo/
> http://people.apache.org/~ecapriolo/ecapriolo_asf.asc
>
> KEYS file available here:
> https://dist.apache.org/repos/dist/release/incubator/rya/KEYS
>
> The vote will be open for 72 hours. Please download the release candidate
> and evaluate the necessary items including checking hashes, signatures,
> build from source, and test.
>
>
> Release this package?
> [ ] +1 yes
> [ ] +0 no opinion
> [ ] -1 Do not release this package because because...
>

[VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating

[Edward Capriolo]

I am pleased to be calling this vote for the source release of Apache Gossip

Ancillary artifacts such as poms, jars, wars, ect. can be found here:
https://repository.apache.org/content/repositories/orgapachegossip-1001

The Git commit ID is:
https://github.com/edwardcapriolo/incubator-gossip/commit/74133870410fec45bd6cac39351fcbbe0950de18

Which will be tagged as gossip-0.1.1-incubating

https://git-wip-us.apache.org/repos/asf?p=incubator-rya.git;a=commit;h=66d8b7f060bddeeb7c50cb0918f98ce3b265c564


Checksums of
https://repository.apache.org/content/repositories/orgapachegossip-1001/org/apache/gossip/gossip/0.1.1-incubating/gossip-0.1.1-incubating-source-release.zip.asc
:
SHA1: 53ca6498d0f704fe7931ec23ca81a638a1fd666c
MD5: c27067c47bdeb6133660beda908f679c

Release artifacts are signed with the following key:
http://people.apache.org/~ecapriolo/
http://people.apache.org/~ecapriolo/ecapriolo_asf.asc

KEYS file available here:
https://dist.apache.org/repos/dist/release/incubator/rya/KEYS

The vote will be open for 72 hours. Please download the release candidate
and evaluate the necessary items including checking hashes, signatures,
build from source, and test.


Release this package?
[ ] +1 yes
[ ] +0 no opinion
[ ] -1 Do not release this package because because...