Re: [gradle-dev] PluginContainer.withId

2014-03-13 Thread Szczepan Faber
> > You mean withId(String id, Action action)? Sounds fine to me. > > yes I think it should be based on something about the plugin (it has this id) > rather than based on how the plugin was applied. > +1 Cheers! -- Szczepan Faber Principal engineer@gradle; Founder@mockito

Re: [gradle-dev] PluginContainer.withId

2014-03-13 Thread Adam Murdoch
On 14 Mar 2014, at 8:14 am, Luke Daley wrote: > > > On 14 March 2014 at 6:38:45 am, Adam Murdoch (adam.murd...@gradleware.com) > wrote: > >> Hey guys, >> >> Are there any objections to adding PluginContainer.withId(String id) method? >> >> You mean withId(String id, Action action)? Sounds

Re: [gradle-dev] PluginContainer.withId

2014-03-13 Thread Luke Daley
On 14 March 2014 at 6:38:45 am, Adam Murdoch (adam.murd...@gradleware.com) wrote: Hey guys, Are there any objections to adding PluginContainer.withId(String id) method? You mean withId(String id, Action action)? Sounds fine to me. +1 Will this be all plugins applied? Or only plugins applied

Re: [gradle-dev] PluginContainer.withId

2014-03-13 Thread Adam Murdoch
On 14 Mar 2014, at 1:15 am, Szczepan Faber wrote: > Hey guys, > > Are there any objections to adding PluginContainer.withId(String id) method? You mean withId(String id, Action action)? Sounds fine to me. -- Adam Murdoch Gradle Co-founder http://www.gradle.org VP of Engineering, Gradleware

Re: [gradle-dev] PluginContainer.withId

2014-03-13 Thread Szczepan Faber
Hey, - using withType requires me to know the fully qualified name of the class. - using withType requires me to import the class (extra statement in the build script) or refer via fqn, both don't look good. It's not painful for built-in Gradle classes (because they are implicitly imported) but ma

Re: [gradle-dev] PluginContainer.withId

2014-03-13 Thread Rene Groeschke
Can you explain a bit the usecase? why is PluginContainer.withType not enough? cheers, René Szczepan Faber 13 Mar 2014 15:15 Hey guys,Are there any objections to adding PluginContainer.withId(String id) method?Cheers!-- Szczepan Faber Principal engineer@gradle; Founder