[GitHub] [griffin] qwang6 commented on issue #506: add hive metadata jdbc retrieval

2019-07-04 Thread GitBox
qwang6 commented on issue #506: add hive metadata jdbc retrieval URL: https://github.com/apache/griffin/pull/506#issuecomment-508624644 1. Have done the code style check 2. Added Unit tests 3. Added Apache License header

[GitHub] [griffin] guoyuepeng commented on a change in pull request #506: add hive metadata jdbc retrieval

2019-07-04 Thread GitBox
guoyuepeng commented on a change in pull request #506: add hive metadata jdbc retrieval URL: https://github.com/apache/griffin/pull/506#discussion_r300513498 ## File path: service/pom.xml ## @@ -167,6 +167,19 @@ under the License. + +

[GitHub] [griffin] guoyuepeng commented on issue #506: add hive metadata jdbc retrieval

2019-07-04 Thread GitBox
guoyuepeng commented on issue #506: add hive metadata jdbc retrieval URL: https://github.com/apache/griffin/pull/506#issuecomment-508595267 Thanks for your PR. please add test case first also follow our apache coding standard such as add apache header. https://github.com/apach

[GitHub] [griffin] guoyuepeng commented on a change in pull request #506: add hive metadata jdbc retrieval

2019-07-04 Thread GitBox
guoyuepeng commented on a change in pull request #506: add hive metadata jdbc retrieval URL: https://github.com/apache/griffin/pull/506#discussion_r300512914 ## File path: service/src/main/java/org/apache/griffin/core/metastore/hive/HiveMetaStoreServiceJDBCImpl.java ## @@

[GitHub] [griffin] guoyuepeng edited a comment on issue #506: add hive metadata jdbc retrieval

2019-07-04 Thread GitBox
guoyuepeng edited a comment on issue #506: add hive metadata jdbc retrieval URL: https://github.com/apache/griffin/pull/506#issuecomment-508594490 it seems cannot init cache beans because of Caused by: java.lang.ClassNotFoundException: com.google.common.cache.CacheBuilderSpec cou

[GitHub] [griffin] guoyuepeng commented on issue #506: add hive metadata jdbc retrieval

2019-07-04 Thread GitBox
guoyuepeng commented on issue #506: add hive metadata jdbc retrieval URL: https://github.com/apache/griffin/pull/506#issuecomment-508594490 it seems cannot init cache beans because of Caused by: java.lang.ClassNotFoundException: com.google.common.cache.CacheBuilderSpec could you

[GitHub] [griffin] qwang6 commented on issue #506: add hive metadata jdbc retrieval

2019-07-04 Thread GitBox
qwang6 commented on issue #506: add hive metadata jdbc retrieval URL: https://github.com/apache/griffin/pull/506#issuecomment-508592839 I have changed get connection code, and now using JDBC to retrieve Hive metadata is working on my local machine. -

[GitHub] [griffin] qwang6 commented on issue #506: add hive metadata jdbc retrieval

2019-07-04 Thread GitBox
qwang6 commented on issue #506: add hive metadata jdbc retrieval URL: https://github.com/apache/griffin/pull/506#issuecomment-508536637 What I have changed: 1. add one implementation of HiveMetaStoreService 2. add hive-jdbc dependency in service/pom.xml 3. changed postgre to mysql

[GitHub] [griffin] qwang6 opened a new pull request #506: add hive metadata jdbc retrieval

2019-07-04 Thread GitBox
qwang6 opened a new pull request #506: add hive metadata jdbc retrieval URL: https://github.com/apache/griffin/pull/506 Hi, I used the all default configurations except that changed the database from postgre to mysql. When ever I added the hive-jdbc dependency in service/pom.xml, I ca

[GitHub] [griffin] wankunde edited a comment on issue #504: build and run transform steps with multiple threads

2019-07-04 Thread GitBox
wankunde edited a comment on issue #504: build and run transform steps with multiple threads URL: https://github.com/apache/griffin/pull/504#issuecomment-508527889 @bhlx3lyx7 Thank you for your advice. Yes, may systems have two or more execution engine inside ,and users can change

[GitHub] [griffin] wankunde commented on issue #504: build and run transform steps with multiple threads

2019-07-04 Thread GitBox
wankunde commented on issue #504: build and run transform steps with multiple threads URL: https://github.com/apache/griffin/pull/504#issuecomment-508527889 @bhlx3lyx7 Thank you for your advice. Yes, may systems have two or more execution engine inside ,and users can change the eng

[GitHub] [griffin] wankunde commented on issue #504: build and run transform steps with multiple threads

2019-07-04 Thread GitBox
wankunde commented on issue #504: build and run transform steps with multiple threads URL: https://github.com/apache/griffin/pull/504#issuecomment-508523910 @guoyuepeng Thanks for your code review. I'm on vacation. And I'll finish this work next week. -

[GitHub] [griffin] guoyuepeng commented on a change in pull request #504: build and run transform steps with multiple threads

2019-07-04 Thread GitBox
guoyuepeng commented on a change in pull request #504: build and run transform steps with multiple threads URL: https://github.com/apache/griffin/pull/504#discussion_r299349972 ## File path: measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/AccuracyExpr2D

[GitHub] [griffin] guoyuepeng commented on a change in pull request #504: build and run transform steps with multiple threads

2019-07-04 Thread GitBox
guoyuepeng commented on a change in pull request #504: build and run transform steps with multiple threads URL: https://github.com/apache/griffin/pull/504#discussion_r299360212 ## File path: measure/src/main/scala/org/apache/griffin/measure/utils/ThreadUtils.scala ## @@ -

[GitHub] [griffin] guoyuepeng commented on a change in pull request #504: build and run transform steps with multiple threads

2019-07-04 Thread GitBox
guoyuepeng commented on a change in pull request #504: build and run transform steps with multiple threads URL: https://github.com/apache/griffin/pull/504#discussion_r299350383 ## File path: measure/src/main/scala/org/apache/griffin/measure/step/transform/TransformStep.scala #

[jira] [Commented] (GRIFFIN-253) How to implement the HA in apache griffin?

2019-07-04 Thread Jay Wong (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16878409#comment-16878409 ] Jay Wong commented on GRIFFIN-253: -- But as showed in my question, I have to set the pro

[jira] [Commented] (GRIFFIN-253) How to implement the HA in apache griffin?

2019-07-04 Thread Liao, Xiaoge (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16878401#comment-16878401 ] Liao, Xiaoge commented on GRIFFIN-253: -- You shouldn't have to do anything because t

[GitHub] [griffin] guoyuepeng commented on issue #505: GRIFFIN-256 Add JDBC retrieve Hive Metadata

2019-07-04 Thread GitBox
guoyuepeng commented on issue #505: GRIFFIN-256 Add JDBC retrieve Hive Metadata URL: https://github.com/apache/griffin/pull/505#issuecomment-508367046 BTW, I didn't see Qualifier has changed to jdbc impl. it is still using hive_metastore in your case. @Autowired @Quali

[jira] [Work logged] (GRIFFIN-256) Alternatives way to access hive metadata

2019-07-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-256?focusedWorklogId=272020&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-272020 ] ASF GitHub Bot logged work on GRIFFIN-256: -- Author: ASF GitHub Bot