guoyuepeng edited a comment on issue #535: [GRIFFIN-291]Relocate HttpClient 
code in measure jar using shade plugin
URL: https://github.com/apache/griffin/pull/535#issuecomment-531430930
 
 
   LGTM. 
   Maven shade plugin is good for resolving version conflict issue.
   
   BTW,
   Can we add main-class into manifest this time?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to