[
https://issues.apache.org/jira/browse/GRIFFIN-281?focusedWorklogId=297661&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297661
]
ASF GitHub Bot logged work on GRIFFIN-281:
------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Aug/19 07:40
Start Date: 20/Aug/19 07:40
Worklog Time Spent: 10m
Work Description: wankunde commented on pull request #524: [GRIFFIN-281]
Add custom sink test
URL: https://github.com/apache/griffin/pull/524
Add custom sink test.
I also have two question:
1. In `ConsoleSink`,`ElasticSearchSink`,`MongoSink` , the `sinkRecords`
method doesn't really sink records ?
2. Why should we have four metrics output types ?
```
* flatten: Aggregation method used before sending data frame result into the
sink:
- default: use "array" if data frame returned multiple records,
otherwise use "entries"
- entries: sends first row of data frame as metric results, like like
`{"agg_col": "value"}`
- array: wraps all metrics into a map, like `{"my_out_name":
[{"agg_col": "value"}]}`
- map: wraps first row of data frame into a map, like `{"my_out_name":
{"agg_col": "value"}}`
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 297661)
Remaining Estimate: 0h
Time Spent: 10m
> Add custom sink test
> --------------------
>
> Key: GRIFFIN-281
> URL: https://issues.apache.org/jira/browse/GRIFFIN-281
> Project: Griffin
> Issue Type: Task
> Reporter: wan kun
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Add some test case for custom sink.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
