[jira] [Work logged] (GRIFFIN-244) [Service, Metric]Implement possibility to get metrics for certain Job Instance Id
[ https://issues.apache.org/jira/browse/GRIFFIN-244?focusedWorklogId=221612=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-221612 ] ASF GitHub Bot logged work on GRIFFIN-244: -- Author: ASF GitHub Bot Created on: 02/Apr/19 05:41 Start Date: 02/Apr/19 05:41 Worklog Time Spent: 10m Work Description: RodionGork commented on issue #491: GRIFFIN-244 Get metrics by instance URL: https://github.com/apache/griffin/pull/491#issuecomment-478852679 @chemikadze rebase leads to conflicts resolving... Thus I'd better have all this stuff squashed and pushed as @dershovGD (we probably have no practical sense in intermediate commits too), if no one's minds. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 221612) Time Spent: 1h 20m (was: 1h 10m) > [Service, Metric]Implement possibility to get metrics for certain Job > Instance Id > - > > Key: GRIFFIN-244 > URL: https://issues.apache.org/jira/browse/GRIFFIN-244 > Project: Griffin (Incubating) > Issue Type: New Feature >Reporter: Dmitry Ershov >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > In addition to functionality described in tasks > https://issues.apache.org/jira/browse/GRIFFIN-240, > https://issues.apache.org/jira/browse/GRIFFIN-233 and > https://issues.apache.org/jira/browse/GRIFFIN-234 it will be very convenient > to have a possibility to obtain the metrics for given Job Instance Id. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (GRIFFIN-244) [Service, Metric]Implement possibility to get metrics for certain Job Instance Id
[ https://issues.apache.org/jira/browse/GRIFFIN-244?focusedWorklogId=221605=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-221605 ] ASF GitHub Bot logged work on GRIFFIN-244: -- Author: ASF GitHub Bot Created on: 02/Apr/19 04:16 Start Date: 02/Apr/19 04:16 Worklog Time Spent: 10m Work Description: chemikadze commented on issue #491: GRIFFIN-244 Get metrics by instance URL: https://github.com/apache/griffin/pull/491#issuecomment-478838049 @RodionGork these merge commits have no practical sense, please rebase ontop of fresh master This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 221605) Time Spent: 1h (was: 50m) > [Service, Metric]Implement possibility to get metrics for certain Job > Instance Id > - > > Key: GRIFFIN-244 > URL: https://issues.apache.org/jira/browse/GRIFFIN-244 > Project: Griffin (Incubating) > Issue Type: New Feature >Reporter: Dmitry Ershov >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > In addition to functionality described in tasks > https://issues.apache.org/jira/browse/GRIFFIN-240, > https://issues.apache.org/jira/browse/GRIFFIN-233 and > https://issues.apache.org/jira/browse/GRIFFIN-234 it will be very convenient > to have a possibility to obtain the metrics for given Job Instance Id. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [griffin] chemikadze commented on issue #491: GRIFFIN-244 Get metrics by instance
chemikadze commented on issue #491: GRIFFIN-244 Get metrics by instance URL: https://github.com/apache/griffin/pull/491#issuecomment-478838049 @RodionGork these merge commits have no practical sense, please rebase ontop of fresh master This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [griffin] aborgatin commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id
aborgatin commented on a change in pull request #489: GRIFFIN-240 Return
JobInstanceBean in response to a call Trigger job by id
URL: https://github.com/apache/griffin/pull/489#discussion_r270774300
##
File path:
service/src/main/java/org/apache/griffin/core/job/JobServiceImpl.java
##
@@ -666,9 +668,31 @@ public void triggerJobById(Long id) throws
SchedulerException {
.forJob(jobKey)
.startNow()
.build();
-scheduler.scheduleJob(trigger);
+TriggerKey key = trigger.getKey();
+CountDownLatch latch = new CountDownLatch(1);
+String listenerName = "listenerJob_" + jobKey.toString();
+try {
+scheduler.getListenerManager().addTriggerListener(
+new CountDownTriggerListener(latch, listenerName)
+, key::equals);
+
+scheduler.scheduleJob(trigger);
+
+try {
+latch.await(0, TimeUnit.MILLISECONDS);
Review comment:
Timeout don't used here by mistake, I fixed it
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Work logged] (GRIFFIN-240) [Service] Return JobInstance in response to a call Trigger job by id
[
https://issues.apache.org/jira/browse/GRIFFIN-240?focusedWorklogId=221167=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-221167
]
ASF GitHub Bot logged work on GRIFFIN-240:
--
Author: ASF GitHub Bot
Created on: 01/Apr/19 09:03
Start Date: 01/Apr/19 09:03
Worklog Time Spent: 10m
Work Description: aborgatin commented on pull request #489: GRIFFIN-240
Return JobInstanceBean in response to a call Trigger job by id
URL: https://github.com/apache/griffin/pull/489#discussion_r270773676
##
File path:
service/src/main/java/org/apache/griffin/core/job/JobServiceImpl.java
##
@@ -666,9 +669,28 @@ public void triggerJobById(Long id) throws
SchedulerException {
.forJob(jobKey)
.startNow()
.build();
+TriggerKey key = trigger.getKey();
+CountDownLatch latch = new CountDownLatch(1);
+scheduler.getListenerManager().addTriggerListener(
+new CountDownTriggerListener(latch, "listenerJob_" +
jobKey.toString())
+, key::equals);
+
scheduler.scheduleJob(trigger);
+
+try {
+latch.await(timeout, TimeUnit.MILLISECONDS);
+} catch (InterruptedException e) {
+LOGGER.warn("CountDownLatch awaiting is interrupted");
+}
+List instanceBeans =
instanceRepo.findByTriggerName(key.toString());
Review comment:
Yes, it is a full scan
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 221167)
Time Spent: 3h 50m (was: 3h 40m)
> [Service] Return JobInstance in response to a call Trigger job by id
> -
>
> Key: GRIFFIN-240
> URL: https://issues.apache.org/jira/browse/GRIFFIN-240
> Project: Griffin (Incubating)
> Issue Type: Improvement
>Reporter: Aleksandr Borgatin
>Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> The proposal is following: in response of method "/jobs/trigger/\{id}" to
> return JobInstance
> {code:java}
> @RequestMapping(value = "/jobs/trigger/{id}", method = RequestMethod.POST)
> @ResponseStatus(HttpStatus.OK)
> public JobInstanceBean triggerJob(@PathVariable("id") Long id) throws
> SchedulerException
> { return jobService.triggerJobById(id); }{code}
> Now this method looks like this
> {code:java}
> @RequestMapping(value = "/jobs/trigger/{id}", method = RequestMethod.POST)
> @ResponseStatus(HttpStatus.NO_CONTENT)
> public void triggerJob(@PathVariable("id") Long id) throws
> SchedulerException {
> jobService.triggerJobById(id);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [griffin] aborgatin commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id
aborgatin commented on a change in pull request #489: GRIFFIN-240 Return
JobInstanceBean in response to a call Trigger job by id
URL: https://github.com/apache/griffin/pull/489#discussion_r270773676
##
File path:
service/src/main/java/org/apache/griffin/core/job/JobServiceImpl.java
##
@@ -666,9 +669,28 @@ public void triggerJobById(Long id) throws
SchedulerException {
.forJob(jobKey)
.startNow()
.build();
+TriggerKey key = trigger.getKey();
+CountDownLatch latch = new CountDownLatch(1);
+scheduler.getListenerManager().addTriggerListener(
+new CountDownTriggerListener(latch, "listenerJob_" +
jobKey.toString())
+, key::equals);
+
scheduler.scheduleJob(trigger);
+
+try {
+latch.await(timeout, TimeUnit.MILLISECONDS);
+} catch (InterruptedException e) {
+LOGGER.warn("CountDownLatch awaiting is interrupted");
+}
+List instanceBeans =
instanceRepo.findByTriggerName(key.toString());
Review comment:
Yes, it is a full scan
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
Re: Data Quality Tool Trial
Hi Mauricio Welcome to Apache Griffin Community! I think you can get the first glance from https://github.com/apache/griffin, concerning what the Griffin can do. The community would like to share usage experience with you, if it's needed we can have a session to share something. Could you give more details about data quality requirements in your application? Thx From: Mauricio Calleja Vargas Sent: Friday, March 29, 2019 2:24 AM To: dev@griffin.apache.org Subject: Data Quality Tool Trial Good afternoon, Just reviewed your webpage and I’m interested in knowing the functionality of your tool regarding data quality. We’re a Mexican company focused on water treatment and just recently started Data Governance Model among the company, and we’re evaluating different options that fulfill our requirement. Is there any chance that we can have a session to see the benefits/functionality of your tool and talk about our needs? Best regards [Firma Correo] La información y documentos contenidos en este correo electrónico son confidenciales y están legalmente protegidos. Este correo electrónico está dirigido únicamente a la dirección de correo señalada. El acceso a este correo electrónico por cualquier otra persona no está autorizado. Si usted no es la persona a la cual el presente correo electrónico estaba originalmente dirigido, cualquier difusión, copia o distribución está prohibida y puede ser ilegal. Si lo ha recibido por error, por favor notifique al emisor e inmediatamente bórrelo de forma permanente y destruya cualquier copia impresa. As informações e documentos contidos neste e-mail são confidenciais e legalmente protegidos. Este e-mail é destinado exclusivamente para o endereço de e-mail designado. O acesso a este e-mail por qualquer outra pessoa não é autorizado. Se você não é a pessoa a quem este e-mail estava previsto inicialmente, qualquer divulgação, cópia ou distribuição é proibida e pode ser ilegal. Se você recebeu esta mensagem por engano, por favor notifique o remetente e apague imediatamente de forma permanente e destrua qualquer cópia impressa. The information and documents in this e-mail are confidential and may be legally privileged. It is intended solely for the addressee(s), and any access to this e-mail by anyone else is unauthorized. If you are not the intended recipient of this e-mail, any disclosure, copying, or distribution of it is prohibited and may be unlawful. If you have received this e-mail by mistake, please notify the sender and immediately and permanently delete it and destroy any printed copies.
[jira] [Work logged] (GRIFFIN-240) [Service] Return JobInstance in response to a call Trigger job by id
[
https://issues.apache.org/jira/browse/GRIFFIN-240?focusedWorklogId=221139=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-221139
]
ASF GitHub Bot logged work on GRIFFIN-240:
--
Author: ASF GitHub Bot
Created on: 01/Apr/19 07:37
Start Date: 01/Apr/19 07:37
Worklog Time Spent: 10m
Work Description: RodionGork commented on pull request #489: GRIFFIN-240
Return JobInstanceBean in response to a call Trigger job by id
URL: https://github.com/apache/griffin/pull/489#discussion_r270744266
##
File path:
service/src/main/java/org/apache/griffin/core/job/JobServiceImpl.java
##
@@ -666,9 +668,31 @@ public void triggerJobById(Long id) throws
SchedulerException {
.forJob(jobKey)
.startNow()
.build();
-scheduler.scheduleJob(trigger);
+TriggerKey key = trigger.getKey();
+CountDownLatch latch = new CountDownLatch(1);
+String listenerName = "listenerJob_" + jobKey.toString();
+try {
+scheduler.getListenerManager().addTriggerListener(
+new CountDownTriggerListener(latch, listenerName)
+, key::equals);
+
+scheduler.scheduleJob(trigger);
+
+try {
+latch.await(0, TimeUnit.MILLISECONDS);
+} catch (InterruptedException e) {
+LOGGER.warn("CountDownLatch awaiting is interrupted");
+}
+List instanceBeans =
instanceRepo.findByTriggerKey(key.toString());
Review comment:
We probably can slightly change this API to become properly asynchronous -
we can return triggerKey from the `/trigger` request and then client can send
further requests with this key to find the instance as in this line.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 221139)
Time Spent: 3h 40m (was: 3.5h)
> [Service] Return JobInstance in response to a call Trigger job by id
> -
>
> Key: GRIFFIN-240
> URL: https://issues.apache.org/jira/browse/GRIFFIN-240
> Project: Griffin (Incubating)
> Issue Type: Improvement
>Reporter: Aleksandr Borgatin
>Priority: Major
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> The proposal is following: in response of method "/jobs/trigger/\{id}" to
> return JobInstance
> {code:java}
> @RequestMapping(value = "/jobs/trigger/{id}", method = RequestMethod.POST)
> @ResponseStatus(HttpStatus.OK)
> public JobInstanceBean triggerJob(@PathVariable("id") Long id) throws
> SchedulerException
> { return jobService.triggerJobById(id); }{code}
> Now this method looks like this
> {code:java}
> @RequestMapping(value = "/jobs/trigger/{id}", method = RequestMethod.POST)
> @ResponseStatus(HttpStatus.NO_CONTENT)
> public void triggerJob(@PathVariable("id") Long id) throws
> SchedulerException {
> jobService.triggerJobById(id);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (GRIFFIN-244) [Service, Metric]Implement possibility to get metrics for certain Job Instance Id
[
https://issues.apache.org/jira/browse/GRIFFIN-244?focusedWorklogId=221123=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-221123
]
ASF GitHub Bot logged work on GRIFFIN-244:
--
Author: ASF GitHub Bot
Created on: 01/Apr/19 06:52
Start Date: 01/Apr/19 06:52
Worklog Time Spent: 10m
Work Description: RodionGork commented on pull request #491: GRIFFIN-244
Get metrics by instance
URL: https://github.com/apache/griffin/pull/491#discussion_r270732965
##
File path:
service/src/main/java/org/apache/griffin/core/metric/MetricStoreImpl.java
##
@@ -206,4 +208,14 @@ private static String buildBasicAuthString(String user,
String password) {
return String.format("Basic %s", Base64.getEncoder().encodeToString(
auth.getBytes()));
}
+
+@Override
+public MetricValue getMetric(String applicationId) throws IOException {
+Map map =new HashMap<>();
+map.put("q", "applicationId:"+applicationId);
Review comment:
`Collections.singletonMap()` probably can be used
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 221123)
Time Spent: 50m (was: 40m)
> [Service, Metric]Implement possibility to get metrics for certain Job
> Instance Id
> -
>
> Key: GRIFFIN-244
> URL: https://issues.apache.org/jira/browse/GRIFFIN-244
> Project: Griffin (Incubating)
> Issue Type: New Feature
>Reporter: Dmitry Ershov
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> In addition to functionality described in tasks
> https://issues.apache.org/jira/browse/GRIFFIN-240,
> https://issues.apache.org/jira/browse/GRIFFIN-233 and
> https://issues.apache.org/jira/browse/GRIFFIN-234 it will be very convenient
> to have a possibility to obtain the metrics for given Job Instance Id.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [griffin] RodionGork commented on a change in pull request #491: GRIFFIN-244 Get metrics by instance
RodionGork commented on a change in pull request #491: GRIFFIN-244 Get metrics
by instance
URL: https://github.com/apache/griffin/pull/491#discussion_r270732965
##
File path:
service/src/main/java/org/apache/griffin/core/metric/MetricStoreImpl.java
##
@@ -206,4 +208,14 @@ private static String buildBasicAuthString(String user,
String password) {
return String.format("Basic %s", Base64.getEncoder().encodeToString(
auth.getBytes()));
}
+
+@Override
+public MetricValue getMetric(String applicationId) throws IOException {
+Map map =new HashMap<>();
+map.put("q", "applicationId:"+applicationId);
Review comment:
`Collections.singletonMap()` probably can be used
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
