[jira] [Created] (GRIFFIN-296) Update .travis.yml to specify Maven Memory
Johnnie created GRIFFIN-296: --- Summary: Update .travis.yml to specify Maven Memory Key: GRIFFIN-296 URL: https://issues.apache.org/jira/browse/GRIFFIN-296 Project: Griffin Issue Type: Bug Reporter: Johnnie Recently, most of the PR failed due to memory issue. Need to fix the issue by specifying the Maven memory option in travis.yml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (GRIFFIN-296) Update .travis.yml to specify Maven Memory
[ https://issues.apache.org/jira/browse/GRIFFIN-296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johnnie closed GRIFFIN-296. --- Resolution: Duplicate > Update .travis.yml to specify Maven Memory > -- > > Key: GRIFFIN-296 > URL: https://issues.apache.org/jira/browse/GRIFFIN-296 > Project: Griffin > Issue Type: Bug >Reporter: Johnnie >Priority: Major > > Recently, most of the PR failed due to memory issue. > Need to fix the issue by specifying the Maven memory option in travis.yml > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GRIFFIN-280) Issues with travis-ci build config
[
https://issues.apache.org/jira/browse/GRIFFIN-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915037#comment-16915037
]
Johnnie commented on GRIFFIN-280:
-
[https://travis-ci.org/apache/griffin/builds/576008161?utm_source=github_status&utm_medium=notification]
build under apache/griffin
> Issues with travis-ci build config
> --
>
> Key: GRIFFIN-280
> URL: https://issues.apache.org/jira/browse/GRIFFIN-280
> Project: Griffin
> Issue Type: Bug
>Reporter: Johnnie
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Actually, some of the test cases are failed without external dependencies
> such as hive.
> Below is the travis-cli and we can find some exceptions
> [https://travis-ci.org/apache/griffin]
>
> 2019-08-15 08:40:25.987 ERROR 5041 --- [ main] o.a.g.c.m.h.HiveMetaStoreProxy
> [70] : Failed to connect hive metastore. {}
> 568
> 569org.apache.hadoop.hive.metastore.api.MetaException: Could not connect to
> meta store using any of the URIs provided. Most recent failure:
> org.apache.thrift.transport.TTransportException: java.net.ConnectException:
> Connection refused (Connection refused)
> 570 at org.apache.thrift.transport.TSocket.open(TSocket.java:226)
> 571 at
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.open(HiveMetaStoreClient.java:478)
> 572 at
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.(HiveMetaStoreClient.java:286)
> 573 at
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.(HiveMetaStoreClient.java:211)
> 574 at
> org.apache.griffin.core.metastore.hive.HiveMetaStoreProxy.initHiveMetastoreClient(HiveMetaStoreProxy.java:68)
> 575 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 576 at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 577 at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 578 at java.lang.reflect.Method.invoke(Method.java:498)
> 579 at
>
> I think we might need to change travis config to execute docker-compose -f to
> start up the dockers before we run the CI test.
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (GRIFFIN-280) Issues with travis-ci build config
[
https://issues.apache.org/jira/browse/GRIFFIN-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913858#comment-16913858
]
Johnnie commented on GRIFFIN-280:
-
Below is the travis build but failed after starting docker container
[https://travis-ci.org/joohnnie/griffin/builds/575600885]
[~guoyp] do you have similar issue before?
thanks
> Issues with travis-ci build config
> --
>
> Key: GRIFFIN-280
> URL: https://issues.apache.org/jira/browse/GRIFFIN-280
> Project: Griffin
> Issue Type: Bug
>Reporter: Johnnie
>Priority: Major
>
> Actually, some of the test cases are failed without external dependencies
> such as hive.
> Below is the travis-cli and we can find some exceptions
> [https://travis-ci.org/apache/griffin]
>
> 2019-08-15 08:40:25.987 ERROR 5041 --- [ main] o.a.g.c.m.h.HiveMetaStoreProxy
> [70] : Failed to connect hive metastore. {}
> 568
> 569org.apache.hadoop.hive.metastore.api.MetaException: Could not connect to
> meta store using any of the URIs provided. Most recent failure:
> org.apache.thrift.transport.TTransportException: java.net.ConnectException:
> Connection refused (Connection refused)
> 570 at org.apache.thrift.transport.TSocket.open(TSocket.java:226)
> 571 at
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.open(HiveMetaStoreClient.java:478)
> 572 at
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.(HiveMetaStoreClient.java:286)
> 573 at
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.(HiveMetaStoreClient.java:211)
> 574 at
> org.apache.griffin.core.metastore.hive.HiveMetaStoreProxy.initHiveMetastoreClient(HiveMetaStoreProxy.java:68)
> 575 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 576 at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 577 at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 578 at java.lang.reflect.Method.invoke(Method.java:498)
> 579 at
>
> I think we might need to change travis config to execute docker-compose -f to
> start up the dockers before we run the CI test.
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (GRIFFIN-280) Issues with travis-ci build config
[
https://issues.apache.org/jira/browse/GRIFFIN-280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Johnnie updated GRIFFIN-280:
Summary: Issues with travis-ci build config (was: Issues with travis-ci
build )
> Issues with travis-ci build config
> --
>
> Key: GRIFFIN-280
> URL: https://issues.apache.org/jira/browse/GRIFFIN-280
> Project: Griffin
> Issue Type: Bug
>Reporter: Johnnie
>Priority: Major
>
> Actually, some of the test cases are failed without external dependencies
> such as hive.
> Below is the travis-cli and we can find some exceptions
> [https://travis-ci.org/apache/griffin]
>
> 2019-08-15 08:40:25.987 ERROR 5041 --- [ main] o.a.g.c.m.h.HiveMetaStoreProxy
> [70] : Failed to connect hive metastore. {}
> 568
> 569org.apache.hadoop.hive.metastore.api.MetaException: Could not connect to
> meta store using any of the URIs provided. Most recent failure:
> org.apache.thrift.transport.TTransportException: java.net.ConnectException:
> Connection refused (Connection refused)
> 570 at org.apache.thrift.transport.TSocket.open(TSocket.java:226)
> 571 at
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.open(HiveMetaStoreClient.java:478)
> 572 at
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.(HiveMetaStoreClient.java:286)
> 573 at
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.(HiveMetaStoreClient.java:211)
> 574 at
> org.apache.griffin.core.metastore.hive.HiveMetaStoreProxy.initHiveMetastoreClient(HiveMetaStoreProxy.java:68)
> 575 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 576 at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 577 at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 578 at java.lang.reflect.Method.invoke(Method.java:498)
> 579 at
>
> I think we might need to change travis config to execute docker-compose -f to
> start up the dockers before we run the CI test.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Created] (GRIFFIN-280) Issues with travis-ci build
Johnnie created GRIFFIN-280:
---
Summary: Issues with travis-ci build
Key: GRIFFIN-280
URL: https://issues.apache.org/jira/browse/GRIFFIN-280
Project: Griffin
Issue Type: Bug
Reporter: Johnnie
Actually, some of the test cases are failed without external dependencies such
as hive.
Below is the travis-cli and we can find some exceptions
[https://travis-ci.org/apache/griffin]
2019-08-15 08:40:25.987 ERROR 5041 --- [ main] o.a.g.c.m.h.HiveMetaStoreProxy
[70] : Failed to connect hive metastore. {}
568
569org.apache.hadoop.hive.metastore.api.MetaException: Could not connect to
meta store using any of the URIs provided. Most recent failure:
org.apache.thrift.transport.TTransportException: java.net.ConnectException:
Connection refused (Connection refused)
570 at org.apache.thrift.transport.TSocket.open(TSocket.java:226)
571 at
org.apache.hadoop.hive.metastore.HiveMetaStoreClient.open(HiveMetaStoreClient.java:478)
572 at
org.apache.hadoop.hive.metastore.HiveMetaStoreClient.(HiveMetaStoreClient.java:286)
573 at
org.apache.hadoop.hive.metastore.HiveMetaStoreClient.(HiveMetaStoreClient.java:211)
574 at
org.apache.griffin.core.metastore.hive.HiveMetaStoreProxy.initHiveMetastoreClient(HiveMetaStoreProxy.java:68)
575 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
576 at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
577 at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
578 at java.lang.reflect.Method.invoke(Method.java:498)
579 at
I think we might need to change travis config to execute docker-compose -f to
start up the dockers before we run the CI test.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (GRIFFIN-279) Upgrade Spring boot to 2.1.7.RELEASE
[ https://issues.apache.org/jira/browse/GRIFFIN-279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johnnie updated GRIFFIN-279: Summary: Upgrade Spring boot to 2.1.7.RELEASE (was: Upgrade Spring boot to 2.1.x as Spring Boot 1.x EOL Aug 1st 2019) > Upgrade Spring boot to 2.1.7.RELEASE > > > Key: GRIFFIN-279 > URL: https://issues.apache.org/jira/browse/GRIFFIN-279 > Project: Griffin > Issue Type: Improvement >Reporter: Johnnie >Priority: Major > > As spring boot 1.x is end of life Aug 1st 2019, it would be great to migrate > to 2.1.x. > Below is the announcement > [https://spring.io/blog/2018/07/30/spring-boot-1-x-eol-aug-1st-2019] > Migrate Guide is > [https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.0-Migration-Guide] > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (GRIFFIN-279) Upgrade Spring boot to 2.1.x as Spring Boot 1.x EOL Aug 1st 2019
Johnnie created GRIFFIN-279: --- Summary: Upgrade Spring boot to 2.1.x as Spring Boot 1.x EOL Aug 1st 2019 Key: GRIFFIN-279 URL: https://issues.apache.org/jira/browse/GRIFFIN-279 Project: Griffin Issue Type: Improvement Reporter: Johnnie As spring boot 1.x is end of life Aug 1st 2019, it would be great to migrate to 2.1.x. Below is the announcement [https://spring.io/blog/2018/07/30/spring-boot-1-x-eol-aug-1st-2019] Migrate Guide is [https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.0-Migration-Guide] -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (GRIFFIN-278) AvroBatchDataConnector handle input is directory
[ https://issues.apache.org/jira/browse/GRIFFIN-278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johnnie updated GRIFFIN-278: Description: Griffin data connector designed to compare the dataset's accuracy between source and target. However, in big data eco-system, most of the source is huge and will have hundreds of files in one folder. I think it would be great if griffin can handle the source by folder instead of a file by default. In addition, in spark normally it reads data from a folder. in this case we don't need to union all the files in one folder was: Griffin data connector designed to compare the dataset's accuracy between source and target. However, in big data eco-system, most of the source is huge and will have hundreds of files in one folder. I think it would be great if griffin can handle the source by folder instead of a file. > AvroBatchDataConnector handle input is directory > > > Key: GRIFFIN-278 > URL: https://issues.apache.org/jira/browse/GRIFFIN-278 > Project: Griffin > Issue Type: Improvement >Reporter: Johnnie >Priority: Major > > Griffin data connector designed to compare the dataset's accuracy between > source and target. > However, in big data eco-system, most of the source is huge and will have > hundreds of files in one folder. I think it would be great if griffin can > handle the source by folder instead of a file by default. > In addition, in spark normally it reads data from a folder. in this case we > don't need to union all the files in one folder -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (GRIFFIN-278) AvroBatchDataConnector handle input is directory
Johnnie created GRIFFIN-278: --- Summary: AvroBatchDataConnector handle input is directory Key: GRIFFIN-278 URL: https://issues.apache.org/jira/browse/GRIFFIN-278 Project: Griffin Issue Type: Improvement Reporter: Johnnie Griffin data connector designed to compare the dataset's accuracy between source and target. However, in big data eco-system, most of the source is huge and will have hundreds of files in one folder. I think it would be great if griffin can handle the source by folder instead of a file. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (GRIFFIN-275) [Measure] Post data to ElasticSearch failed
[ https://issues.apache.org/jira/browse/GRIFFIN-275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johnnie updated GRIFFIN-275: Summary: [Measure] Post data to ElasticSearch failed (was: [Mersure] Post data to ElasticSaerch failed) > [Measure] Post data to ElasticSearch failed > --- > > Key: GRIFFIN-275 > URL: https://issues.apache.org/jira/browse/GRIFFIN-275 > Project: Griffin > Issue Type: Bug >Reporter: Johnnie >Priority: Major > Attachments: image-2019-08-07-18-03-34-672.png > > > Griffin uses apache httpclient 4.5.2 to post data to Elastic Search. > Had the following exception > > java.lang.NoClassDefFoundError: org/apache/http/ssl/SSLContexts > at > org.apache.http.impl.client.HttpClientBuilder.build(HttpClientBuilder.java:966) > at > org.apache.griffin.measure.utils.HttpUtil$.doHttpRequest(HttpUtil.scala:48) > at > org.apache.griffin.measure.sink.ElasticSearchSink$$anonfun$org$apache$griffin$measure$sink$ElasticSearchSink$$func$1$1.apply$mcZ$sp(ElasticSearchSink.scala:69) > at > org.apache.griffin.measure.sink.ElasticSearchSink$$anonfun$org$apache$griffin$measure$sink$ElasticSearchSink$$func$1$1.apply(ElasticSearchSink.scala:69) > at > org.apache.griffin.measure.sink.ElasticSearchSink$$anonfun$org$apache$griffin$measure$sink$ElasticSearchSink$$func$1$1.apply(ElasticSearchSink.scala:69) > at > scala.concurrent.impl.Future$PromiseCompletingRunnable.liftedTree1$1(Future.scala:24) > at > scala.concurrent.impl.Future$PromiseCompletingRunnable.run(Future.scala:24) > at > scala.concurrent.impl.ExecutionContextImpl$AdaptedForkJoinTask.exec(ExecutionContextImpl.scala:121) > at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260) > at > scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339) > at scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979) > at > scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107) > Caused by: java.lang.ClassNotFoundException: org.apache.http.ssl.SSLContexts > at java.net.URLClassLoader.findClass(URLClassLoader.java:382) > at java.lang.ClassLoader.loadClass(ClassLoader.java:424) > at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349) > at java.lang.ClassLoader.loadClass(ClassLoader.java:357) > ... 12 more > > The root cause is spark-hive has 3 httpclient versions and the scope of > spark-hive is provided. > > !image-2019-08-07-18-03-34-672.png! -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (GRIFFIN-275) [Mersure] Post data to ElasticSaerch failed
Johnnie created GRIFFIN-275: --- Summary: [Mersure] Post data to ElasticSaerch failed Key: GRIFFIN-275 URL: https://issues.apache.org/jira/browse/GRIFFIN-275 Project: Griffin Issue Type: Bug Reporter: Johnnie Attachments: image-2019-08-07-18-03-34-672.png Griffin uses apache httpclient 4.5.2 to post data to Elastic Search. Had the following exception java.lang.NoClassDefFoundError: org/apache/http/ssl/SSLContexts at org.apache.http.impl.client.HttpClientBuilder.build(HttpClientBuilder.java:966) at org.apache.griffin.measure.utils.HttpUtil$.doHttpRequest(HttpUtil.scala:48) at org.apache.griffin.measure.sink.ElasticSearchSink$$anonfun$org$apache$griffin$measure$sink$ElasticSearchSink$$func$1$1.apply$mcZ$sp(ElasticSearchSink.scala:69) at org.apache.griffin.measure.sink.ElasticSearchSink$$anonfun$org$apache$griffin$measure$sink$ElasticSearchSink$$func$1$1.apply(ElasticSearchSink.scala:69) at org.apache.griffin.measure.sink.ElasticSearchSink$$anonfun$org$apache$griffin$measure$sink$ElasticSearchSink$$func$1$1.apply(ElasticSearchSink.scala:69) at scala.concurrent.impl.Future$PromiseCompletingRunnable.liftedTree1$1(Future.scala:24) at scala.concurrent.impl.Future$PromiseCompletingRunnable.run(Future.scala:24) at scala.concurrent.impl.ExecutionContextImpl$AdaptedForkJoinTask.exec(ExecutionContextImpl.scala:121) at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260) at scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339) at scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979) at scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107) Caused by: java.lang.ClassNotFoundException: org.apache.http.ssl.SSLContexts at java.net.URLClassLoader.findClass(URLClassLoader.java:382) at java.lang.ClassLoader.loadClass(ClassLoader.java:424) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ... 12 more The root cause is spark-hive has 3 httpclient versions and the scope of spark-hive is provided. !image-2019-08-07-18-03-34-672.png! -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (GRIFFIN-273) Griffin Service user-defined log4j2 configuration
[ https://issues.apache.org/jira/browse/GRIFFIN-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johnnie updated GRIFFIN-273: Summary: Griffin Service user-defined log4j2 configuration (was: Griffin Service log4j2) > Griffin Service user-defined log4j2 configuration > - > > Key: GRIFFIN-273 > URL: https://issues.apache.org/jira/browse/GRIFFIN-273 > Project: Griffin > Issue Type: Improvement >Reporter: Johnnie >Priority: Major > > Currently, the Griffin service module use spring-boot default log4j2 > configuration. > This approach is not easy to change the config for debugging and add new > appender such as > RollingFile. > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (GRIFFIN-273) Griffin Service with user-defined log4j2 configuration
[ https://issues.apache.org/jira/browse/GRIFFIN-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johnnie updated GRIFFIN-273: Summary: Griffin Service with user-defined log4j2 configuration (was: Griffin Service user-defined log4j2 configuration) > Griffin Service with user-defined log4j2 configuration > -- > > Key: GRIFFIN-273 > URL: https://issues.apache.org/jira/browse/GRIFFIN-273 > Project: Griffin > Issue Type: Improvement >Reporter: Johnnie >Priority: Major > > Currently, the Griffin service module use spring-boot default log4j2 > configuration. > This approach is not easy to change the config for debugging and add new > appender such as > RollingFile. > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (GRIFFIN-273) Griffin Service log4j2
Johnnie created GRIFFIN-273: --- Summary: Griffin Service log4j2 Key: GRIFFIN-273 URL: https://issues.apache.org/jira/browse/GRIFFIN-273 Project: Griffin Issue Type: Improvement Reporter: Johnnie Currently, the Griffin service module use spring-boot default log4j2 configuration. This approach is not easy to change the config for debugging and add new appender such as RollingFile. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (GRIFFIN-267) Loggable trait use Scala call by name for lazy evaluation
[ https://issues.apache.org/jira/browse/GRIFFIN-267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johnnie updated GRIFFIN-267: Description: For trait Loggable, it would be great to evaluate the msg if really needed. otherwise, it might have a potential issue. For example, if msg is 1/0, it will cause Exception even we don't call the log method. was: For trait Loggable, it would be great to evaluate the msg if really needed. otherwise, it might have a potential issue. For example, is msg is 1/0, it will cause Exception even we don't call the log method. > Loggable trait use Scala call by name for lazy evaluation > -- > > Key: GRIFFIN-267 > URL: https://issues.apache.org/jira/browse/GRIFFIN-267 > Project: Griffin > Issue Type: Improvement >Reporter: Johnnie >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > For trait Loggable, it would be great to evaluate the msg if really needed. > otherwise, it might have a potential issue. > For example, if msg is 1/0, it will cause Exception even we don't call the > log method. > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (GRIFFIN-267) Loggable trait use Scala call by name for lazy evaluation
Johnnie created GRIFFIN-267: --- Summary: Loggable trait use Scala call by name for lazy evaluation Key: GRIFFIN-267 URL: https://issues.apache.org/jira/browse/GRIFFIN-267 Project: Griffin Issue Type: Improvement Reporter: Johnnie For trait Loggable, it would be great to evaluate the msg if really needed. otherwise, it might have a potential issue. For example, is msg is 1/0, it will cause Exception even we don't call the log method. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (GRIFFIN-264) Clean up maven dependencies in pom.xml
[ https://issues.apache.org/jira/browse/GRIFFIN-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johnnie updated GRIFFIN-264: External issue URL: https://github.com/apache/griffin/pull/508 > Clean up maven dependencies in pom.xml > -- > > Key: GRIFFIN-264 > URL: https://issues.apache.org/jira/browse/GRIFFIN-264 > Project: Griffin > Issue Type: Improvement >Reporter: Johnnie >Priority: Minor > > Clean up maven dependencies in pom.xml for all the modules -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GRIFFIN-264) Clean up maven dependencies in pom.xml
Johnnie created GRIFFIN-264: --- Summary: Clean up maven dependencies in pom.xml Key: GRIFFIN-264 URL: https://issues.apache.org/jira/browse/GRIFFIN-264 Project: Griffin Issue Type: Improvement Reporter: Johnnie Clean up maven dependencies in pom.xml for all the modules -- This message was sent by Atlassian JIRA (v7.6.3#76005)
