[jira] [Comment Edited] (GRIFFIN-173) [Measure] Support JDBC connection as data source

[ https://issues.apache.org/jira/browse/GRIFFIN-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533261#comment-16533261 ] Maciej Bryński edited comment on GRIFFIN-173 at 7/5/18 5:12 AM:

[GitHub] incubator-griffin pull request #332: fix a bad practice

Github user toyboxman closed the pull request at: https://github.com/apache/incubator-griffin/pull/332 ---

[GitHub] incubator-griffin issue #332: fix a bad practice

Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/332 Hi, @whhe @guoyuepeng I submit a new patch to revise, please review again https://github.com/apache/incubator-griffin/pull/335 ---

[GitHub] incubator-griffin pull request #335: fix a bad practice

GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/335 fix a bad practice 1.Format string should use %n rather than \n In format strings, it is generally preferable better to use %n, which will produce the platform-specific line

[jira] [Commented] (GRIFFIN-173) [Measure] Support JDBC connection as data source

[ https://issues.apache.org/jira/browse/GRIFFIN-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533135#comment-16533135 ] William Guo commented on GRIFFIN-173: - hi Maciej Bryński , Let's figure out how to make it,

[jira] [Assigned] (GRIFFIN-173) [Measure] Support JDBC connection as data source

[ https://issues.apache.org/jira/browse/GRIFFIN-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] William Guo reassigned GRIFFIN-173: --- Assignee: William Guo (was: Lionel Liu) > [Measure] Support JDBC connection as data

[jira] [Updated] (GRIFFIN-173) [Measure] Support JDBC connection as data source

[ https://issues.apache.org/jira/browse/GRIFFIN-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maciej Bryński updated GRIFFIN-173: --- Labels: (was: SP_6) > [Measure] Support JDBC connection as data source >

[jira] [Updated] (GRIFFIN-173) [Measure] Support JDBC connection as data source

[ https://issues.apache.org/jira/browse/GRIFFIN-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maciej Bryński updated GRIFFIN-173: --- Description: DoD:  Support JDBC connection as data source. was: DoD:  Support google 

[jira] [Created] (GRIFFIN-173) [Measure] Support JDBC connection as data source

Maciej Bryński created GRIFFIN-173: -- Summary: [Measure] Support JDBC connection as data source Key: GRIFFIN-173 URL: https://issues.apache.org/jira/browse/GRIFFIN-173 Project: Griffin (Incubating)

[GitHub] incubator-griffin issue #332: fix a bad practice

Github user guoyuepeng commented on the issue: https://github.com/apache/incubator-griffin/pull/332 hi @toyboxman Yes, we might need to new patch for all '\n' Thanks, William ---

[GitHub] incubator-griffin issue #332: fix a bad practice

Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/332 let me check how many times '\n' was used in codes and make a new patch ---