[GitHub] incubator-griffin issue #457: merge_pr.py python 3 support

2018-11-18 Thread ludongfang
Github user ludongfang commented on the issue: https://github.com/apache/incubator-griffin/pull/457 LGTM ---

[GitHub] incubator-griffin pull request #457: merge_pr.py python 3 support

2018-11-18 Thread IAmFQQ
GitHub user IAmFQQ opened a pull request: https://github.com/apache/incubator-griffin/pull/457 merge_pr.py python 3 support 1. Import Request/urlopen/HTTPError from urllib.request to support python 3 2. The print statement has been replaced with a print() function You can

Re: [RESULT][VOTE] Graduate Apache Griffin (incubating) as a TLP

2018-11-18 Thread William Guo
Hi Justin, Could you have a look whether Apache Griffin miss anything in the agenda before board meeting? Henry should have updated the resolution part for apache griffin graduation. Please tell us if we miss anything, so we can update it accordingly before the meeting. Thanks, William On

[jira] [Commented] (GRIFFIN-210) [Measure] need to integrate with upstream/downstream nodes when bad records are founded

2018-11-18 Thread Eugene (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691165#comment-16691165 ] Eugene commented on GRIFFIN-210: I think we should allow to define DQ rules/threshold/remedy action from

[jira] [Commented] (GRIFFIN-213) Support pluggable datasource connectors

2018-11-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691153#comment-16691153 ] ASF GitHub Bot commented on GRIFFIN-213: Github user toyboxman commented on a diff in the pull

[GitHub] incubator-griffin pull request #456: [GRIFFIN-213] Custom connector support

2018-11-18 Thread toyboxman
Github user toyboxman commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/456#discussion_r234475362 --- Diff: griffin-doc/measure/measure-configuration-guide.md --- @@ -188,7 +188,7 @@ Above lists DQ job configure parameters. - **sinks**:

[jira] [Commented] (GRIFFIN-213) Support pluggable datasource connectors

2018-11-18 Thread Eugene (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691151#comment-16691151 ] Eugene commented on GRIFFIN-213: two comments: 1.customization connector allows users to connect any