[GitHub] incubator-griffin issue #435: [GRIFFIN-206] fix job timezone when creating f...

2018-10-14 Thread guoyuepeng
Github user guoyuepeng commented on the issue: https://github.com/apache/incubator-griffin/pull/435 data partition timezone is come from data connector.

[GitHub] incubator-griffin issue #435: [GRIFFIN-206] fix job timezone when creating f...

2018-10-14 Thread guoyuepeng
Github user guoyuepeng commented on the issue: https://github.com/apache/incubator-griffin/pull/435 let me check ---

[GitHub] incubator-griffin issue #435: [GRIFFIN-206] fix job timezone when creating f...

2018-10-14 Thread chemikadze
Github user chemikadze commented on the issue: https://github.com/apache/incubator-griffin/pull/435 @guoyuepeng @ahutsunshine is there anything left preventing the merge? ---

[GitHub] incubator-griffin issue #435: [GRIFFIN-206] fix job timezone when creating f...

2018-10-14 Thread ahutsunshine
Github user ahutsunshine commented on the issue: https://github.com/apache/incubator-griffin/pull/435 > cron.time.zone you are right. ---

[GitHub] incubator-griffin issue #435: [GRIFFIN-206] fix job timezone when creating f...

2018-10-14 Thread chemikadze
Github user chemikadze commented on the issue: https://github.com/apache/incubator-griffin/pull/435 @ahutsunshine I've found only usage of cron.time.zone is only during schedule creation:

[GitHub] incubator-griffin issue #435: [GRIFFIN-206] fix job timezone when creating f...

2018-10-14 Thread ahutsunshine
Github user ahutsunshine commented on the issue: https://github.com/apache/incubator-griffin/pull/435 > Added time zone information to batch UI: > https://user-images.githubusercontent.com/867294/46914000-4c567a00-cf4c-11e8-85cb-be6428e91895.png;> > Added time

[GitHub] incubator-griffin issue #435: [GRIFFIN-206] fix job timezone when creating f...

2018-10-14 Thread chemikadze
Github user chemikadze commented on the issue: https://github.com/apache/incubator-griffin/pull/435 Added time zone information to batch UI: https://user-images.githubusercontent.com/867294/46914000-4c567a00-cf4c-11e8-85cb-be6428e91895.png;> ---

[GitHub] incubator-griffin issue #435: [GRIFFIN-206] fix job timezone when creating f...

2018-10-12 Thread chemikadze
Github user chemikadze commented on the issue: https://github.com/apache/incubator-griffin/pull/435 @ahutsunshine I was thinking on handling UTCxxx format on backend to fix existing jobs, but from other hand, this feels like unnecessary breaking change. I've provided UI fix for now.

[GitHub] incubator-griffin issue #435: [GRIFFIN-206] fix job timezone when creating f...

2018-10-12 Thread ahutsunshine
Github user ahutsunshine commented on the issue: https://github.com/apache/incubator-griffin/pull/435 @chemikadze You are right. In backend, the method of getTimeZone always returns GMT timezone for UTC-1 or UTC+01:00 or other similar formats, as the given timezone ID cannot be

[GitHub] incubator-griffin issue #435: [GRIFFIN-206] fix job timezone when creating f...

2018-10-11 Thread chemikadze
Github user chemikadze commented on the issue: https://github.com/apache/incubator-griffin/pull/435 Went with UI route for a time being, to avoid introducing any incompatible behavior from backend side. ---

[GitHub] incubator-griffin issue #435: [GRIFFIN-206] fix job timezone when creating f...

2018-10-10 Thread chemikadze
Github user chemikadze commented on the issue: https://github.com/apache/incubator-griffin/pull/435 Looks like positive time zones without signs are not parsed properly, so this is not a complete fix. ---