[GitHub] incubator-griffin issue #444: Define griffin plain-vanilla hook.

Github user chemikadze commented on the issue: https://github.com/apache/incubator-griffin/pull/444 Regardig naming -- do you think we should really tie it to Jobs? Handling Measure events could be useful as well. ---

[GitHub] incubator-griffin issue #444: Define griffin plain-vanilla hook.

Github user chemikadze commented on the issue: https://github.com/apache/incubator-griffin/pull/444 @toyboxman leaving minor comments aside, looks really nice! ---

[GitHub] incubator-griffin pull request #444: Define griffin plain-vanilla hook.

Github user chemikadze commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/444#discussion_r230578497 --- Diff: service/src/test/java/org/apache/griffin/core/job/EventServiceTest.java --- @@ -0,0 +1,69 @@ +package

[GitHub] incubator-griffin pull request #444: Define griffin plain-vanilla hook.

Github user chemikadze commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/444#discussion_r230578447 --- Diff: service/src/main/resources/application.properties --- @@ -62,3 +62,5 @@ elasticsearch.scheme=http

[GitHub] incubator-griffin pull request #444: Define griffin plain-vanilla hook.

Github user chemikadze commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/444#discussion_r230578657 --- Diff: service/src/main/java/org/apache/griffin/core/integration/JobEventHook.java --- @@ -0,0 +1,11 @@ +package

[GitHub] incubator-griffin pull request #444: Define griffin plain-vanilla hook.

Github user chemikadze commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/444#discussion_r230578522 --- Diff: service/src/main/java/org/apache/griffin/core/job/JobServiceImpl.java --- @@ -158,17 +162,22 @@ public JobServiceImpl() {

[GitHub] incubator-griffin issue #444: Define griffin plain-vanilla hook.

Github user guoyuepeng commented on the issue: https://github.com/apache/incubator-griffin/pull/444 @chemikadze right, we cannot tie events to jobs related. @toyboxman ---

[GitHub] incubator-griffin issue #444: Define griffin plain-vanilla hook.

Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/444 summary of comments 1.considering general usage, I do not use 'GriffinJobEventManager' but actually name it 'GriffinEventManager' 2.I keep empty implementation for

[GitHub] incubator-griffin pull request #444: Define griffin plain-vanilla hook.

Github user toyboxman commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/444#discussion_r230622132 --- Diff: service/src/main/java/org/apache/griffin/core/job/JobServiceImpl.java --- @@ -158,17 +162,22 @@ public JobServiceImpl() {

[GitHub] incubator-griffin pull request #444: Define griffin plain-vanilla hook.

Github user toyboxman commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/444#discussion_r230622329 --- Diff: service/src/main/resources/application.properties --- @@ -62,3 +62,5 @@ elasticsearch.scheme=http

[RESULT][VOTE] Graduate Apache Griffin (incubating) as a TLP

Hi all, With 13 +1 non-binding votes, 5 +1 binding votes and no -1 or +/-0 votes, This vote PASSES. Thanks to everyone who voted. The vote tally is attached. Non-binding: 邵亮 Jenny Li ShaoFeng Shi Eugene Liu Sheng Wu Alex Lv Yin Wan John Liu Kevin Yao Matt Sicker Xin Wang Li De He Wang

[GitHub] incubator-griffin pull request #451: Griffin amit dev

Github user amitEnquero closed the pull request at: https://github.com/apache/incubator-griffin/pull/451 ---