Re: [jira] [Commented] (GRIFFIN-179) Deploy questions

2018-07-13 Thread William Guo
hi Dennis,

Thanks for reminding, we do need to update our document right now.

Thanks,
William

On Fri, Jul 13, 2018 at 6:29 PM, Kwang-in (Dennis) JUNG (JIRA) <
j...@apache.org> wrote:

>
> [ https://issues.apache.org/jira/browse/GRIFFIN-179?page=
> com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel=16542850#comment-16542850 ]
>
> Kwang-in (Dennis) JUNG commented on GRIFFIN-179:
> 
>
> [~Kevin Yao] seems working well. Thanks!
>
> Maybe these parts needs to be updated in document. It is difficult to
> findout only with deploy guide.
>
> Thanks.
>
> > Deploy questions
> > 
> >
> > Key: GRIFFIN-179
> > URL: https://issues.apache.org/jira/browse/GRIFFIN-179
> > Project: Griffin (Incubating)
> >  Issue Type: Test
> >Affects Versions: 0.2.0-incubating
> >Reporter: Kwang-in (Dennis) JUNG
> >Priority: Minor
> >
> > Hello,
> > I'm starter of this project, and have some question of setting up.
> > This is my application.properties...
> > ```
> > spring.datasource.url = jdbc:mysql://localhost:3306/
> quartz?autoReconnect=true=false
> > spring.datasource.username = griffin
> > spring.datasource.password = 123456
> > spring.jpa.generate-ddl=true
> > spring.datasource.driver-class-name = com.mysql.jdbc.Driver
> > ...
> > ```
> > ...and it shows problem...
> >
> > ```
> > ...
> > 2018-07-13 14:33:52.190 ERROR 6603 --- [ main] o.s.b.SpringApplication :
> Application startup failed
> > org.springframework.beans.factory.UnsatisfiedDependencyException: Error
> creating bean with name 'eclipseLinkJpaConfig' defined in URL
> [jar:file:/Users/jung/workspace/etc/incubator-griffin/service/target/
> service-0.2.0-incubating-SNAPSHOT.jar!/BOOT-INF/
> classes!/org/apache/griffin/core/config/EclipseLinkJpaConfig.class]:
> Unsatisfied dependency expressed through constructor parameter 0; nested
> exception is org.springframework.beans.factory.BeanCreationException:
> Error creating bean with name 'dataSource' defined in class path resource
> [org/springframework/boot/autoconfigure/jdbc/DataSourceConfiguration$Tomcat.class]:
> Bean instantiation via factory method failed; nested exception is
> org.springframework.beans.BeanInstantiationException: Failed to
> instantiate [org.apache.tomcat.jdbc.pool.DataSource]: Factory method
> 'dataSource' threw exception; nested exception is 
> java.lang.IllegalStateException:
> Cannot load driver class: com.mysql.jdbc.Driver
> >  at org.springframework.beans.factory.support.ConstructorResolver.
> createArgumentArray(ConstructorResolver.java:749)
> ~[spring-beans-4.3.6.RELEASE.jar!/:4.3.6.RELEASE]
> >  at org.springframework.beans.factory.support.ConstructorResolver.
> autowireConstructor(ConstructorResolver.java:189)
> ~[spring-beans-4.3.6.RELEASE.jar!/:4.3.6.RELEASE]
> > ...
> > ```
> >
> > As you see, I'm trying to work on with mysql.
> > Could you give me some help?
> >
> > Thanks.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v7.6.3#76005)
>


[jira] [Commented] (GRIFFIN-180) [UI] add validation for creating profiling and accuracy measure

2018-07-13 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/GRIFFIN-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543353#comment-16543353
 ] 

ASF GitHub Bot commented on GRIFFIN-180:


GitHub user icesmartjuan opened a pull request:

https://github.com/apache/incubator-griffin/pull/352

GRIFFIN-180-add validation for creating profiling and accuracy measure

GRIFFIN-180-add validation for creating profiling and accuracy measure
when creating profiling or accuracy measures: skip all other steps jump to 
the last step, add measure name , data source/target is empty, you could submit 
from the frontend, which is not expected.

and in the subsequent pop-up  window, empty field(source/target) with just 
"." is not expected

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/icesmartjuan/incubator-griffin formvalidation

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-griffin/pull/352.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #352


commit e6e5429fdc628d5dcb0e0e8682b8f06f3549d71d
Author: Li, Juan 
Date:   2018-07-13T15:36:06Z

fix bug




> [UI] add validation for creating profiling and accuracy measure
> ---
>
> Key: GRIFFIN-180
> URL: https://issues.apache.org/jira/browse/GRIFFIN-180
> Project: Griffin (Incubating)
>  Issue Type: Bug
>Reporter: Juan Li
>Priority: Major
> Attachments: 180.png
>
>
> when creating profiling or accuracy measures: skip all other steps jump to 
> the last step, add measure name , data source/target is empty, you could 
> submit from the frontend, which is not expected.
> and in the subsequent pop-up  window, empty field(source/target) with just 
> "." is not expected
>  
> attached the issue snapshot.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] incubator-griffin pull request #352: GRIFFIN-180-add validation for creating...

2018-07-13 Thread icesmartjuan
GitHub user icesmartjuan opened a pull request:

https://github.com/apache/incubator-griffin/pull/352

GRIFFIN-180-add validation for creating profiling and accuracy measure

GRIFFIN-180-add validation for creating profiling and accuracy measure
when creating profiling or accuracy measures: skip all other steps jump to 
the last step, add measure name , data source/target is empty, you could submit 
from the frontend, which is not expected.

and in the subsequent pop-up  window, empty field(source/target) with just 
"." is not expected

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/icesmartjuan/incubator-griffin formvalidation

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-griffin/pull/352.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #352


commit e6e5429fdc628d5dcb0e0e8682b8f06f3549d71d
Author: Li, Juan 
Date:   2018-07-13T15:36:06Z

fix bug




---


[jira] [Updated] (GRIFFIN-180) [UI] add validation for creating profiling and accuracy measure

2018-07-13 Thread Juan Li (JIRA)


 [ 
https://issues.apache.org/jira/browse/GRIFFIN-180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Juan Li updated GRIFFIN-180:

Description: 
when creating profiling or accuracy measures: skip all other steps jump to the 
last step, add measure name , data source/target is empty, you could submit 
from the frontend, which is not expected.

and in the subsequent pop-up  window, empty field(source/target) with just "." 
is not expected

 

attached the issue snapshot.

> [UI] add validation for creating profiling and accuracy measure
> ---
>
> Key: GRIFFIN-180
> URL: https://issues.apache.org/jira/browse/GRIFFIN-180
> Project: Griffin (Incubating)
>  Issue Type: Bug
>Reporter: Juan Li
>Priority: Major
> Attachments: 180.png
>
>
> when creating profiling or accuracy measures: skip all other steps jump to 
> the last step, add measure name , data source/target is empty, you could 
> submit from the frontend, which is not expected.
> and in the subsequent pop-up  window, empty field(source/target) with just 
> "." is not expected
>  
> attached the issue snapshot.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GRIFFIN-180) [UI] add validation for creating profiling and accuracy measure

2018-07-13 Thread Juan Li (JIRA)


 [ 
https://issues.apache.org/jira/browse/GRIFFIN-180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Juan Li updated GRIFFIN-180:

Attachment: 180.png

> [UI] add validation for creating profiling and accuracy measure
> ---
>
> Key: GRIFFIN-180
> URL: https://issues.apache.org/jira/browse/GRIFFIN-180
> Project: Griffin (Incubating)
>  Issue Type: Bug
>Reporter: Juan Li
>Priority: Major
> Attachments: 180.png
>
>
> when creating profiling or accuracy measures: skip all other steps jump to 
> the last step, add measure name , data source/target is empty, you could 
> submit from the frontend, which is not expected.
> and in the subsequent pop-up  window, empty field(source/target) with just 
> "." is not expected
>  
> attached the issue snapshot.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GRIFFIN-180) [UI] add validation for creating profiling and accuracy measure

2018-07-13 Thread Juan Li (JIRA)
Juan Li created GRIFFIN-180:
---

 Summary: [UI] add validation for creating profiling and accuracy 
measure
 Key: GRIFFIN-180
 URL: https://issues.apache.org/jira/browse/GRIFFIN-180
 Project: Griffin (Incubating)
  Issue Type: Bug
Reporter: Juan Li






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GRIFFIN-179) Deploy questions

2018-07-13 Thread Kwang-in (Dennis) JUNG (JIRA)


[ 
https://issues.apache.org/jira/browse/GRIFFIN-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542850#comment-16542850
 ] 

Kwang-in (Dennis) JUNG commented on GRIFFIN-179:


[~Kevin Yao] seems working well. Thanks!

Maybe these parts needs to be updated in document. It is difficult to findout 
only with deploy guide.

Thanks.

> Deploy questions
> 
>
> Key: GRIFFIN-179
> URL: https://issues.apache.org/jira/browse/GRIFFIN-179
> Project: Griffin (Incubating)
>  Issue Type: Test
>Affects Versions: 0.2.0-incubating
>Reporter: Kwang-in (Dennis) JUNG
>Priority: Minor
>
> Hello,
> I'm starter of this project, and have some question of setting up.
> This is my application.properties...
> ```
> spring.datasource.url = 
> jdbc:mysql://localhost:3306/quartz?autoReconnect=true=false
> spring.datasource.username = griffin
> spring.datasource.password = 123456
> spring.jpa.generate-ddl=true
> spring.datasource.driver-class-name = com.mysql.jdbc.Driver
> ...
> ```
> ...and it shows problem...
>  
> ```
> ...
> 2018-07-13 14:33:52.190 ERROR 6603 --- [ main] o.s.b.SpringApplication : 
> Application startup failed
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error 
> creating bean with name 'eclipseLinkJpaConfig' defined in URL 
> [jar:file:/Users/jung/workspace/etc/incubator-griffin/service/target/service-0.2.0-incubating-SNAPSHOT.jar!/BOOT-INF/classes!/org/apache/griffin/core/config/EclipseLinkJpaConfig.class]:
>  Unsatisfied dependency expressed through constructor parameter 0; nested 
> exception is org.springframework.beans.factory.BeanCreationException: Error 
> creating bean with name 'dataSource' defined in class path resource 
> [org/springframework/boot/autoconfigure/jdbc/DataSourceConfiguration$Tomcat.class]:
>  Bean instantiation via factory method failed; nested exception is 
> org.springframework.beans.BeanInstantiationException: Failed to instantiate 
> [org.apache.tomcat.jdbc.pool.DataSource]: Factory method 'dataSource' threw 
> exception; nested exception is java.lang.IllegalStateException: Cannot load 
> driver class: com.mysql.jdbc.Driver
>  at 
> org.springframework.beans.factory.support.ConstructorResolver.createArgumentArray(ConstructorResolver.java:749)
>  ~[spring-beans-4.3.6.RELEASE.jar!/:4.3.6.RELEASE]
>  at 
> org.springframework.beans.factory.support.ConstructorResolver.autowireConstructor(ConstructorResolver.java:189)
>  ~[spring-beans-4.3.6.RELEASE.jar!/:4.3.6.RELEASE]
> ...
> ```
>  
> As you see, I'm trying to work on with mysql.
> Could you give me some help?
>  
> Thanks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GRIFFIN-179) Deploy questions

2018-07-13 Thread Kevin Yao (JIRA)


[ 
https://issues.apache.org/jira/browse/GRIFFIN-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542704#comment-16542704
 ] 

Kevin Yao commented on GRIFFIN-179:
---

Btw, if you use mysql as your database, you also need to configure 
quartz.properties.
{code:java}
org.quartz.jobStore.driverDelegateClass=org.quartz.impl.jdbcjobstore.StdJDBCDelegate
{code}
You can refer to this 
document:https://github.com/apache/incubator-griffin/blob/master/griffin-doc/service/mysql_postgresql_switch.md


> Deploy questions
> 
>
> Key: GRIFFIN-179
> URL: https://issues.apache.org/jira/browse/GRIFFIN-179
> Project: Griffin (Incubating)
>  Issue Type: Test
>Affects Versions: 0.2.0-incubating
>Reporter: Kwang-in (Dennis) JUNG
>Priority: Minor
>
> Hello,
> I'm starter of this project, and have some question of setting up.
> This is my application.properties...
> ```
> spring.datasource.url = 
> jdbc:mysql://localhost:3306/quartz?autoReconnect=true=false
> spring.datasource.username = griffin
> spring.datasource.password = 123456
> spring.jpa.generate-ddl=true
> spring.datasource.driver-class-name = com.mysql.jdbc.Driver
> ...
> ```
> ...and it shows problem...
>  
> ```
> ...
> 2018-07-13 14:33:52.190 ERROR 6603 --- [ main] o.s.b.SpringApplication : 
> Application startup failed
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error 
> creating bean with name 'eclipseLinkJpaConfig' defined in URL 
> [jar:file:/Users/jung/workspace/etc/incubator-griffin/service/target/service-0.2.0-incubating-SNAPSHOT.jar!/BOOT-INF/classes!/org/apache/griffin/core/config/EclipseLinkJpaConfig.class]:
>  Unsatisfied dependency expressed through constructor parameter 0; nested 
> exception is org.springframework.beans.factory.BeanCreationException: Error 
> creating bean with name 'dataSource' defined in class path resource 
> [org/springframework/boot/autoconfigure/jdbc/DataSourceConfiguration$Tomcat.class]:
>  Bean instantiation via factory method failed; nested exception is 
> org.springframework.beans.BeanInstantiationException: Failed to instantiate 
> [org.apache.tomcat.jdbc.pool.DataSource]: Factory method 'dataSource' threw 
> exception; nested exception is java.lang.IllegalStateException: Cannot load 
> driver class: com.mysql.jdbc.Driver
>  at 
> org.springframework.beans.factory.support.ConstructorResolver.createArgumentArray(ConstructorResolver.java:749)
>  ~[spring-beans-4.3.6.RELEASE.jar!/:4.3.6.RELEASE]
>  at 
> org.springframework.beans.factory.support.ConstructorResolver.autowireConstructor(ConstructorResolver.java:189)
>  ~[spring-beans-4.3.6.RELEASE.jar!/:4.3.6.RELEASE]
> ...
> ```
>  
> As you see, I'm trying to work on with mysql.
> Could you give me some help?
>  
> Thanks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GRIFFIN-179) Deploy questions

2018-07-13 Thread Kevin Yao (JIRA)


[ 
https://issues.apache.org/jira/browse/GRIFFIN-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542636#comment-16542636
 ] 

Kevin Yao commented on GRIFFIN-179:
---

Hi Dennis,
I guess you just edit application.properties without modifying pom.xml. Add the 
following dependency to your pom.xml. 
{code:java}

   mysql
   mysql-connector-java
 
{code}
It may work.

Thanks,
Kevin Yao

> Deploy questions
> 
>
> Key: GRIFFIN-179
> URL: https://issues.apache.org/jira/browse/GRIFFIN-179
> Project: Griffin (Incubating)
>  Issue Type: Test
>Affects Versions: 0.2.0-incubating
>Reporter: Kwang-in (Dennis) JUNG
>Priority: Minor
>
> Hello,
> I'm starter of this project, and have some question of setting up.
> This is my application.properties...
> ```
> spring.datasource.url = 
> jdbc:mysql://localhost:3306/quartz?autoReconnect=true=false
> spring.datasource.username = griffin
> spring.datasource.password = 123456
> spring.jpa.generate-ddl=true
> spring.datasource.driver-class-name = com.mysql.jdbc.Driver
> ...
> ```
> ...and it shows problem...
>  
> ```
> ...
> 2018-07-13 14:33:52.190 ERROR 6603 --- [ main] o.s.b.SpringApplication : 
> Application startup failed
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error 
> creating bean with name 'eclipseLinkJpaConfig' defined in URL 
> [jar:file:/Users/jung/workspace/etc/incubator-griffin/service/target/service-0.2.0-incubating-SNAPSHOT.jar!/BOOT-INF/classes!/org/apache/griffin/core/config/EclipseLinkJpaConfig.class]:
>  Unsatisfied dependency expressed through constructor parameter 0; nested 
> exception is org.springframework.beans.factory.BeanCreationException: Error 
> creating bean with name 'dataSource' defined in class path resource 
> [org/springframework/boot/autoconfigure/jdbc/DataSourceConfiguration$Tomcat.class]:
>  Bean instantiation via factory method failed; nested exception is 
> org.springframework.beans.BeanInstantiationException: Failed to instantiate 
> [org.apache.tomcat.jdbc.pool.DataSource]: Factory method 'dataSource' threw 
> exception; nested exception is java.lang.IllegalStateException: Cannot load 
> driver class: com.mysql.jdbc.Driver
>  at 
> org.springframework.beans.factory.support.ConstructorResolver.createArgumentArray(ConstructorResolver.java:749)
>  ~[spring-beans-4.3.6.RELEASE.jar!/:4.3.6.RELEASE]
>  at 
> org.springframework.beans.factory.support.ConstructorResolver.autowireConstructor(ConstructorResolver.java:189)
>  ~[spring-beans-4.3.6.RELEASE.jar!/:4.3.6.RELEASE]
> ...
> ```
>  
> As you see, I'm trying to work on with mysql.
> Could you give me some help?
>  
> Thanks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: [jira] [Created] (GRIFFIN-179) Deploy questions

2018-07-13 Thread William Guo
hi Dennis,

>From the error log,
Factory method 'dataSource' threw exception; nested exception is
java.lang.IllegalStateException:
Cannot load driver class: com.mysql.jdbc.Driver

It seems you are using mysql as storage , could you show your code base so
we can reproduce your issue?


Thanks,
William

On Fri, Jul 13, 2018 at 1:40 PM, Kwang-in (Dennis) JUNG (JIRA) <
j...@apache.org> wrote:

> Kwang-in (Dennis) JUNG created GRIFFIN-179:
> --
>
>  Summary: Deploy questions
>  Key: GRIFFIN-179
>  URL: https://issues.apache.org/jira/browse/GRIFFIN-179
>  Project: Griffin (Incubating)
>   Issue Type: Test
> Affects Versions: 0.2.0-incubating
> Reporter: Kwang-in (Dennis) JUNG
>
>
> Hello,
>
> I'm starter of this project, and have some question of setting up.
>
> This is my application.properties...
>
> ```
>
> spring.datasource.url = jdbc:mysql://localhost:3306/
> quartz?autoReconnect=true=false
> spring.datasource.username = griffin
> spring.datasource.password = 123456
> spring.jpa.generate-ddl=true
>
> spring.datasource.driver-class-name = com.mysql.jdbc.Driver
>
> ...
>
> ```
>
> ...and it shows problem...
>
>
>
> ```
>
> ...
>
> 2018-07-13 14:33:52.190 ERROR 6603 --- [ main] o.s.b.SpringApplication :
> Application startup failed
>
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error
> creating bean with name 'eclipseLinkJpaConfig' defined in URL
> [jar:file:/Users/jung/workspace/etc/incubator-griffin/service/target/
> service-0.2.0-incubating-SNAPSHOT.jar!/BOOT-INF/
> classes!/org/apache/griffin/core/config/EclipseLinkJpaConfig.class]:
> Unsatisfied dependency expressed through constructor parameter 0; nested
> exception is org.springframework.beans.factory.BeanCreationException:
> Error creating bean with name 'dataSource' defined in class path resource
> [org/springframework/boot/autoconfigure/jdbc/DataSourceConfiguration$Tomcat.class]:
> Bean instantiation via factory method failed; nested exception is
> org.springframework.beans.BeanInstantiationException: Failed to
> instantiate [org.apache.tomcat.jdbc.pool.DataSource]: Factory method
> 'dataSource' threw exception; nested exception is 
> java.lang.IllegalStateException:
> Cannot load driver class: com.mysql.jdbc.Driver
>  at org.springframework.beans.factory.support.ConstructorResolver.
> createArgumentArray(ConstructorResolver.java:749)
> ~[spring-beans-4.3.6.RELEASE.jar!/:4.3.6.RELEASE]
>  at org.springframework.beans.factory.support.ConstructorResolver.
> autowireConstructor(ConstructorResolver.java:189)
> ~[spring-beans-4.3.6.RELEASE.jar!/:4.3.6.RELEASE]
>
> ...
>
> ```
>
>
>
> As you see, I'm trying to work on with mysql.
>
> Could you give me some help?
>
>
>
> Thanks.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v7.6.3#76005)
>


[GitHub] incubator-griffin pull request #351: Pr/testcase

2018-07-13 Thread toyboxman
GitHub user toyboxman opened a pull request:

https://github.com/apache/incubator-griffin/pull/351

Pr/testcase

Refactor codes and fix unit test bug

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/toyboxman/incubator-griffin pr/testcase

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-griffin/pull/351.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #351


commit 95cf208eef353a9cbd2531d571d7ce41d89956d5
Author: Eugene 
Date:   2018-07-10T05:57:20Z

Fix unit case bug

JobInstanceRepoTest always fails to run due to code bug, fix it here

commit 05ae2677945c3a34d02fd9981a525a90df066782
Author: Eugene 
Date:   2018-07-12T03:04:04Z

Merge branch 'master' of https://github.com/apache/incubator-griffin

commit ce6e073ba38cbc82ad3da8845748913005b015be
Author: Eugene 
Date:   2018-07-13T03:12:07Z

Merge branch 'master' of https://github.com/apache/incubator-griffin

commit c3db596009b556aa8c3f403aef4f6373ba87f33a
Author: Eugene 
Date:   2018-07-13T06:02:17Z

Refactor

fix unit test bug in service




---