[GitHub] incubator-griffin-site pull request #13: Fix layout issue when on mobile
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin-site/pull/13 Fix layout issue when on mobile You can merge this pull request into a Git repository by running: $ git pull https://github.com/icesmartjuan/incubator-griffin-site fix/partner_logo_display Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin-site/pull/13.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #13 commit e97871049bc17092bf321a8971b95a16f43bf353 Author: Li, Juan Date: 2018-11-01T10:55:30Z Fix layout issue when on mobile ---
[GitHub] incubator-griffin issue #446: [GRIFFIN-203] "Plaintext mode" for measure cre...
Github user icesmartjuan commented on the issue: https://github.com/apache/incubator-griffin/pull/446 Great work, it works fine ---
[GitHub] incubator-griffin issue #446: [GRIFFIN-203] "Plaintext mode" for measure cre...
Github user icesmartjuan commented on the issue: https://github.com/apache/incubator-griffin/pull/446 Awesome feature! There seems an issue when zoom up the page, the textare is outside and the ```submit``` button can't be clicked/triggered.  ---
[GitHub] incubator-griffin pull request #423: Adjust error msg when failing to create...
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin/pull/423 Adjust error msg when failing to create job You can merge this pull request into a Git repository by running: $ git pull https://github.com/icesmartjuan/incubator-griffin ui_createJobFailure_msg Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/423.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #423 commit 9a7d37366789e9e3960e9cd9013fc59d22cd4c36 Author: Li, Juan Date: 2018-09-27T07:15:07Z Adjust error msg when failing to create job ---
[GitHub] incubator-griffin pull request #410: Fix download table bug
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin/pull/410 Fix download table bug You can merge this pull request into a Git repository by running: $ git pull https://github.com/icesmartjuan/incubator-griffin fix_ui_bug_2018905 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/410.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #410 commit 811b5838d7e274f356c985a2be9a5cb349f75944 Author: Li, Juan Date: 2018-09-05T07:58:47Z Fix download table bug ---
[GitHub] incubator-griffin pull request #406: fix download disable items issue
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin/pull/406 fix download disable items issue fix the issue that one column is not disabled while in downloading You can merge this pull request into a Git repository by running: $ git pull https://github.com/icesmartjuan/incubator-griffin fix_ui_bug Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/406.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #406 commit fd0ca49191c106312d8340984dc8aa9636994059 Author: Li, Juan Date: 2018-08-30T11:06:55Z fix download disable items issue ---
[GitHub] incubator-griffin pull request #401: Fix UI bugs
GitHub user icesmartjuan opened a pull request:
https://github.com/apache/incubator-griffin/pull/401
Fix UI bugs
1. In profiling, when selecting rule on UI, for "Enum detection Top5
count", it generates rule like:
{
"rule": "source.desc, desc, count(*) AS count GROUP BY source.desc
ORDER BY count DESC LIMIT 5",
"dsl.type": "griffin-dsl",
"dq.type": "PROFILING"
}
Actually, we need it to be like:
{
"rule": "source.desc AS desc, count(*) AS count GROUP BY
source.desc ORDER BY count DESC LIMIT 5",
"dsl.type": "griffin-dsl",
"dq.type": "PROFILING",
"out": [
{
"type": "metric",
"name": "desc_group",
"flatten": "array"
}
]
}
To flatten the group by metric as an array, and naming it as "${the group
column name}_group". Then the metric will be like:
{"name":"prof_job","tmst":153476850,"value":{"desc_group":[{"desc":
"aaa", "count": 3}, {"desc": "bbb", "count": 5}]}}
Please notice that there're 2 mistakes in current enum rule, one is the
"rule" content, the other one is the lack of "out" field.
2. There's a bug in Dashboard page, when refreshing, it works good, and a
metric chart is painted. But after select the measure drop-down box, the chart
size is collapsed into a line, which is terrible.
3. In "partition configuration" pages of creating accuracy measure, the
item "Time Zone" is blank by default, but in the same page of creating
profiling measure, the item "Time Zone" has a default value, which should act
the same as the accuracy measure creation page.
4. In "Select Models" page of creating profiling measure, when you select
"Regular Expression Detection Count" as a rule for a string column, there will
be a text box below, for regular expression. I think the UI is not bad so far.
However, it doesn't work in a right way. The rule it generates is like:
{
"rule": "count(source.desc RLIKE '^[0-9]{4}$') AS
`desc_regexcount`",
"dsl.type": "griffin-dsl",
"dq.type": "PROFILING"
}
After test, it returns total count of the column, which means the statement
"RLIKE" doesn't work. We need to change it like this:
{
"rule": "count(source.desc) AS `desc_regexcount` WHERE source.desc
RLIKE '^[0-9]{4}$'",
"dsl.type": "griffin-dsl",
"dq.type": "PROFILING"
}
I've tested the latter, it works.
5. For "Download Miss Sample" page, the item list seems a litte strange, it
would be better to list them in a table and hover with a hand pointer rather
than a text cursor. Besides, sometimes it's slow for the downloading, I think
it's better to tell user to wait after a click.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/icesmartjuan/incubator-griffin fix_ui_bugs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-griffin/pull/401.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #401
commit f9d54f6b451d79a122e9473c80853362bd1e2827
Author: Li, Juan
Date: 2018-08-22T07:57:25Z
Fix UI bugs:
1. In profiling, when selecting rule on UI, for "Enum detection Top5
count", it generates rule like:
{
"rule": "source.desc, desc, count(*) AS count GROUP BY source.desc
ORDER BY count DESC LIMIT 5",
"dsl.type": "griffin-dsl",
"dq.type": "PROFILING"
}
Actually, we need it to be like:
{
"rule": "source.desc AS desc, count(*) AS count GROUP BY
source.desc ORDER BY count DESC LIMIT 5",
"dsl.type": "griffin-dsl",
"dq.type": "PROFILING",
"out": [
{
"type": "metric",
"name": "desc_group",
"flatten": "array"
}
]
}
To flatten the group by metric as an array, a
[GitHub] incubator-griffin pull request #391: merge pr382 and pr389
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin/pull/391 merge pr382 and pr389 add out.dataframe.name in accuracy and profiling measure You can merge this pull request into a Git repository by running: $ git pull https://github.com/icesmartjuan/incubator-griffin mergepr389382 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/391.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #391 commit 5591cad8913e415a0b007f3f46142483ab7d5976 Author: Li, Juan Date: 2018-08-10T10:16:03Z add out.dataframe.name in accuracy and profiling measure ---
[GitHub] incubator-griffin pull request #390: merged with pr389 and pr382
Github user icesmartjuan closed the pull request at: https://github.com/apache/incubator-griffin/pull/390 ---
[GitHub] incubator-griffin pull request #390: merged with pr389 and pr382
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin/pull/390 merged with pr389 and pr382 You can merge this pull request into a Git repository by running: $ git pull https://github.com/icesmartjuan/incubator-griffin pr389 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/390.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #390 commit a1c4d2d9efecd79f1c0207d2787d99960ac6a7f3 Author: ahutsunshine Date: 2018-08-09T19:09:37Z update measure field and ut commit 9e6348f5ebc9dee60dd1d6d39f4a1c658368bfd3 Author: ahutsunshine Date: 2018-08-10T04:00:47Z update field name commit 54d4aa7adc35ea9d5fca4309d2457ecfb03ddc39 Author: Li, Juan Date: 2018-08-10T10:09:15Z Add out.dataframe.name in accuracy and profiling measure ---
[GitHub] incubator-griffin issue #381: GRIFFIN-164 GRIFFIN-186 GRIFFIN-187: Profiling...
Github user icesmartjuan commented on the issue: https://github.com/apache/incubator-griffin/pull/381 tested with newly commit, create Profiling measure successfully, create jobs with the Profiling measure sucessfully ---
[GitHub] incubator-griffin issue #381: GRIFFIN-164 GRIFFIN-186 GRIFFIN-187: Profiling...
Github user icesmartjuan commented on the issue:
https://github.com/apache/incubator-griffin/pull/381
Test from UI based on your current measure and service :
1. create Accuracy and Publish measure successfully
2. fail to create Data Profiling measure
pr.component.ts: line 390 fails the Profiling and Publish measure creation,
as this.step3.size is undefined type
3. failed to create job with above created Accuracy measure
{"timestamp":1533207681903,"status":400,"error":"Bad
Request","code":"40011","message":"We don't support such measure
type.","path":"/api/v1/jobs"}
```this.newJob
{job.name: "job1", job.type: "batch", measure.id: 1, cron.expression: "0
0/4 * * * ?", cron.time.zone: "GMT-8:00", â¦}cron.expression: "0 0/4 * * *
?"cron.time.zone: "GMT-8:00"data.segments: Array(2)0: as.baseline:
truedata.connector.name: "source1533207565052"segment.range: begin:
"-1day"length: "1day"__proto__: Object__proto__: Objectconstructor: Æ
Object()hasOwnProperty: Æ hasOwnProperty()isPrototypeOf: Æ
isPrototypeOf()propertyIsEnumerable: Æ propertyIsEnumerable()toLocaleString:
Æ toLocaleString()toString: Æ ()valueOf: Æ valueOf()__defineGetter__: Æ
__defineGetter__()__defineSetter__: Æ __defineSetter__()__lookupGetter__: Æ
__lookupGetter__()__lookupSetter__: Æ __lookupSetter__()get __proto__: Æ
__proto__()set __proto__: Æ __proto__()1: data.connector.name:
"target1533207568926"segment.range: begin: "-1day"length: "1day"__proto__:
Object__proto__: Objectlength: 2__proto__: Array(0)job.name: "job1"job.type:
"batch"measure.id: 1__proto__: Object```
---
[GitHub] incubator-griffin pull request #366: GRIFFIN-185 - Feature/download ui
Github user icesmartjuan commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/366#discussion_r204635343
--- Diff: service/src/main/java/org/apache/griffin/core/util/FSUtil.java ---
@@ -177,4 +177,23 @@ private static void checkHDFSConf() {
}
}
+public static String getFirstMissRecordPath(String hdfsDir) throws
Exception{
+List fileList = listFileStatus(hdfsDir);
+for(int i=0; i
[GitHub] incubator-griffin pull request #366: GRIFFIN-185 - Feature/download ui
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin/pull/366 GRIFFIN-185 - Feature/download ui GRIFFIN-185 - Feature/download ui You can merge this pull request into a Git repository by running: $ git pull https://github.com/icesmartjuan/incubator-griffin feature/download_ui Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/366.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #366 commit 5b9f07980f21fab7c40033a0a76682fa0bbf82d0 Author: Li, Juan Date: 2018-07-17T13:31:23Z add home page link under user setting commit 0cc51bc300b74957f51fb48e6a4b0a2702a29638 Author: Li, Juan Date: 2018-07-20T15:47:13Z [Service] download missRecord service part commit f1da2d557eb1ba34d316b3680df28db1f07872e5 Author: Li, Juan Date: 2018-07-22T04:16:57Z Refine service commit 6e1ace4bfa2afbc09f73f815ca44238e7efeffc2 Author: Li, Juan Date: 2018-07-22T04:23:44Z UI part for feature of downloading miss record sample ---
[GitHub] incubator-griffin pull request #365: GRIFFIN-184 - service for download miss...
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin/pull/365 GRIFFIN-184 - service for download miss records GRIFFIN-184 - service for download miss records You can merge this pull request into a Git repository by running: $ git pull https://github.com/icesmartjuan/incubator-griffin feature/download Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/365.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #365 commit 5b9f07980f21fab7c40033a0a76682fa0bbf82d0 Author: Li, Juan Date: 2018-07-17T13:31:23Z add home page link under user setting commit 0cc51bc300b74957f51fb48e6a4b0a2702a29638 Author: Li, Juan Date: 2018-07-20T15:47:13Z [Service] download missRecord service part ---
[GitHub] incubator-griffin pull request #356: GRIFFIN-183 - add home page link under ...
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin/pull/356 GRIFFIN-183 - add home page link under user setting GRIFFIN-183 - add home page link under user setting You can merge this pull request into a Git repository by running: $ git pull https://github.com/icesmartjuan/incubator-griffin addhomepageunderusersetting Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/356.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #356 commit 5b9f07980f21fab7c40033a0a76682fa0bbf82d0 Author: Li, Juan Date: 2018-07-17T13:31:23Z add home page link under user setting ---
[GitHub] incubator-griffin issue #354: GRIFFIN-182 - fix blank flash when routing fro...
Github user icesmartjuan commented on the issue: https://github.com/apache/incubator-griffin/pull/354 other user reported ngx-echarts navigation issue: https://github.com/xieziyu/ngx-echarts/issues/18 ---
[GitHub] incubator-griffin pull request #352: GRIFFIN-180-add validation for creating...
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin/pull/352 GRIFFIN-180-add validation for creating profiling and accuracy measure GRIFFIN-180-add validation for creating profiling and accuracy measure when creating profiling or accuracy measures: skip all other steps jump to the last step, add measure name , data source/target is empty, you could submit from the frontend, which is not expected. and in the subsequent pop-up window, empty field(source/target) with just "." is not expected You can merge this pull request into a Git repository by running: $ git pull https://github.com/icesmartjuan/incubator-griffin formvalidation Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/352.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #352 commit e6e5429fdc628d5dcb0e0e8682b8f06f3549d71d Author: Li, Juan Date: 2018-07-13T15:36:06Z fix bug ---
[GitHub] incubator-griffin issue #346: GRIFFIN-178 - job state not update after perfo...
Github user icesmartjuan commented on the issue: https://github.com/apache/incubator-griffin/pull/346 Issue: job state is not updated properly after performing start/stop job action, still previous state ---
[GitHub] incubator-griffin issue #343: GRIFFIN-175 - fix es 411 issue
Github user icesmartjuan commented on the issue: https://github.com/apache/incubator-griffin/pull/343 when call get BASE_PATH/api/v1/metrics or get BASE_PATH/api/v1/metrics/values?metricName=jobName=5=0, service returns 500. after debugging, found that elasticsearch returns 411 Length required response ---
[GitHub] incubator-griffin issue #344: GRIFFIN-177 - fix measure page display issue
Github user icesmartjuan commented on the issue: https://github.com/apache/incubator-griffin/pull/344 issue: found UI page wrongly displayed if measure["dq.type"] is not set, root cause: row["dq.type"].toLowerCase() in measure.component.html causing infinite loading if row["dq.type"] is null ---
[GitHub] incubator-griffin pull request #346: GRIFFIN-178 - job state not update afte...
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin/pull/346 GRIFFIN-178 - job state not update after performing start/stop actions on job page GRIFFIN-178 - job state not update after performing start/stop actions on job page You can merge this pull request into a Git repository by running: $ git pull https://github.com/icesmartjuan/incubator-griffin bug/job_state_auto_refresh Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/346.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #346 commit bdfca096317edcfb5ec448bf36ddbc30286518f3 Author: Li, Juan Date: 2018-07-11T09:41:15Z fix job state incorrect commit 76ed1379223b832eb4a24031724e95905068e3be Author: Li, Juan Date: 2018-07-11T14:27:36Z fix job state display abnormal issue ---
[GitHub] incubator-griffin pull request #344: GRIFFIN-177 - fix measure page display ...
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin/pull/344 GRIFFIN-177 - fix measure page display issue GRIFFIN-177 - fix measure page display issue You can merge this pull request into a Git repository by running: $ git pull https://github.com/icesmartjuan/incubator-griffin bug/measure_display Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/344.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #344 commit c56cab5f139c28094d5c09718989ef6104aaedf1 Author: Li, Juan Date: 2018-07-11T08:36:43Z fix measure page display issue ---
[GitHub] incubator-griffin-site pull request #2: griffin site - GRIFFIN-130 - GRIFFIN...
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin-site/pull/2 griffin site - GRIFFIN-130 - GRIFFIN-126 change items font-size, and⦠griffin site - GRIFFIN-130 - GRIFFIN-126 change items font-size, and add security link You can merge this pull request into a Git repository by running: $ git pull https://github.com/icesmartjuan/incubator-griffin-site juanli/sitechange Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin-site/pull/2.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2 commit 4b395b2259c375f5721fc4b4ae5abedf8731aca4 Author: jenny <juanli1@...> Date: 2018-04-19T02:35:41Z griffin site - GRIFFIN-130 - GRIFFIN-126 change items font-size, and add security links ---
[GitHub] incubator-griffin pull request #251: UI-GRIFFIN-111-add progress indicator i...
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin/pull/251 UI-GRIFFIN-111-add progress indicator in every http request You can merge this pull request into a Git repository by running: $ git pull https://github.com/icesmartjuan/incubator-griffin juanli_ui_improvement Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/251.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #251 commit 2c2c48ca345561065bb50de2d37425709678e2db Author: jenny <sunshinejuanl@...> Date: 2018-04-08T09:32:33Z global loading spinner commit 3bab345e0fe7577088e6ea9db820a45a9716cff1 Author: jenny <sunshinejuanl@...> Date: 2018-04-08T14:37:06Z modify commit 784a5f71a48308a0c2cedfd81fb004fbfc6ca90a Author: jenny <sunshinejuanl@...> Date: 2018-04-09T05:46:04Z UI-GRIFFIN-111-add progress indicator in every http request Final version ---
[GitHub] incubator-griffin pull request #246: UI-JIRA-GRIFFIN-121 Add publish measure...
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin/pull/246 UI-JIRA-GRIFFIN-121 Add publish measure create process on UI UI-JIRA-GRIFFIN-121 Add publish measure create process on UI You can merge this pull request into a Git repository by running: $ git pull https://github.com/icesmartjuan/incubator-griffin ui_addpublish Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/246.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #246 commit 53814e4b0037c6cd4117354631d0bb803cc5 Author: jenny <sunshinejuanl@...> Date: 2018-04-01T14:04:42Z UI-JIRA-GRIFFIN-121 Add publish measure create process on UI commit 7b5d90678408578bb2677809a62740429c5ae8cd Author: jenny <sunshinejuanl@...> Date: 2018-04-01T14:13:12Z Add description ---
[GitHub] incubator-griffin pull request #242: JIRA-GRIFFIN-107-UI-add hdfs data...
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin/pull/242 JIRA-GRIFFIN-107-UI-add hdfs data asset UI part-add hdfs or kafka data asset corresponding services need to be added later, following in GRIFFIN-109 and GRIFFIN-110 You can merge this pull request into a Git repository by running: $ git pull https://github.com/icesmartjuan/incubator-griffin juanli Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/242.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #242 commit 288f9e7526fdce15ffee65f82919cb0c14b61394 Author: jenny <juanli1@...> Date: 2018-03-29T01:56:58Z JIRA-GRIFFIN-107-UI-add hdfs data asset ---
