[GitHub] incubator-griffin-site pull request #13: Fix layout issue when on mobile

2018-11-01 Thread icesmartjuan
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin-site/pull/13 Fix layout issue when on mobile You can merge this pull request into a Git repository by running: $ git pull https://github.com/icesmartjuan/incubator-griffin-site fix

[GitHub] incubator-griffin issue #446: [GRIFFIN-203] "Plaintext mode" for measure cre...

2018-10-28 Thread icesmartjuan
Github user icesmartjuan commented on the issue: https://github.com/apache/incubator-griffin/pull/446 Great work, it works fine ---

[GitHub] incubator-griffin issue #446: [GRIFFIN-203] "Plaintext mode" for measure cre...

2018-10-25 Thread icesmartjuan
Github user icesmartjuan commented on the issue: https://github.com/apache/incubator-griffin/pull/446 Awesome feature! There seems an issue when zoom up the page, the textare is outside and the ```submit``` button can't be clicked/triggered. ![image](https://user

[GitHub] incubator-griffin pull request #423: Adjust error msg when failing to create...

2018-09-27 Thread icesmartjuan
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin/pull/423 Adjust error msg when failing to create job You can merge this pull request into a Git repository by running: $ git pull https://github.com/icesmartjuan/incubator-griffin

[GitHub] incubator-griffin pull request #410: Fix download table bug

2018-09-05 Thread icesmartjuan
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin/pull/410 Fix download table bug You can merge this pull request into a Git repository by running: $ git pull https://github.com/icesmartjuan/incubator-griffin fix_ui_bug_2018905

[GitHub] incubator-griffin pull request #406: fix download disable items issue

2018-08-30 Thread icesmartjuan
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin/pull/406 fix download disable items issue fix the issue that one column is not disabled while in downloading You can merge this pull request into a Git repository by running: $ git

[GitHub] incubator-griffin pull request #401: Fix UI bugs

2018-08-22 Thread icesmartjuan
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin/pull/401 Fix UI bugs 1. In profiling, when selecting rule on UI, for "Enum detection Top5 count", it generates rule like: { "rule": "source.desc

[GitHub] incubator-griffin pull request #391: merge pr382 and pr389

2018-08-10 Thread icesmartjuan
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin/pull/391 merge pr382 and pr389 add out.dataframe.name in accuracy and profiling measure You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-griffin pull request #390: merged with pr389 and pr382

2018-08-10 Thread icesmartjuan
Github user icesmartjuan closed the pull request at: https://github.com/apache/incubator-griffin/pull/390 ---

[GitHub] incubator-griffin pull request #390: merged with pr389 and pr382

2018-08-10 Thread icesmartjuan
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin/pull/390 merged with pr389 and pr382 You can merge this pull request into a Git repository by running: $ git pull https://github.com/icesmartjuan/incubator-griffin pr389 Alternatively

[GitHub] incubator-griffin issue #381: GRIFFIN-164 GRIFFIN-186 GRIFFIN-187: Profiling...

2018-08-03 Thread icesmartjuan
Github user icesmartjuan commented on the issue: https://github.com/apache/incubator-griffin/pull/381 tested with newly commit, create Profiling measure successfully, create jobs with the Profiling measure sucessfully ---

[GitHub] incubator-griffin issue #381: GRIFFIN-164 GRIFFIN-186 GRIFFIN-187: Profiling...

2018-08-02 Thread icesmartjuan
Github user icesmartjuan commented on the issue: https://github.com/apache/incubator-griffin/pull/381 Test from UI based on your current measure and service : 1. create Accuracy and Publish measure successfully 2. fail to create Data Profiling measure pr.component.ts: line

[GitHub] incubator-griffin pull request #366: GRIFFIN-185 - Feature/download ui

2018-07-24 Thread icesmartjuan
Github user icesmartjuan commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/366#discussion_r204635343 --- Diff: service/src/main/java/org/apache/griffin/core/util/FSUtil.java --- @@ -177,4 +177,23 @@ private static void checkHDFSConf

[GitHub] incubator-griffin pull request #366: GRIFFIN-185 - Feature/download ui

2018-07-21 Thread icesmartjuan
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin/pull/366 GRIFFIN-185 - Feature/download ui GRIFFIN-185 - Feature/download ui You can merge this pull request into a Git repository by running: $ git pull https://github.com/icesmartjuan

[GitHub] incubator-griffin pull request #365: GRIFFIN-184 - service for download miss...

2018-07-20 Thread icesmartjuan
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin/pull/365 GRIFFIN-184 - service for download miss records GRIFFIN-184 - service for download miss records You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-griffin pull request #356: GRIFFIN-183 - add home page link under ...

2018-07-17 Thread icesmartjuan
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin/pull/356 GRIFFIN-183 - add home page link under user setting GRIFFIN-183 - add home page link under user setting You can merge this pull request into a Git repository by running: $ git

[GitHub] incubator-griffin issue #354: GRIFFIN-182 - fix blank flash when routing fro...

2018-07-16 Thread icesmartjuan
Github user icesmartjuan commented on the issue: https://github.com/apache/incubator-griffin/pull/354 other user reported ngx-echarts navigation issue: https://github.com/xieziyu/ngx-echarts/issues/18 ---

[GitHub] incubator-griffin pull request #352: GRIFFIN-180-add validation for creating...

2018-07-13 Thread icesmartjuan
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin/pull/352 GRIFFIN-180-add validation for creating profiling and accuracy measure GRIFFIN-180-add validation for creating profiling and accuracy measure when creating profiling or accuracy

[GitHub] incubator-griffin issue #346: GRIFFIN-178 - job state not update after perfo...

2018-07-12 Thread icesmartjuan
Github user icesmartjuan commented on the issue: https://github.com/apache/incubator-griffin/pull/346 Issue: job state is not updated properly after performing start/stop job action, still previous state ---

[GitHub] incubator-griffin issue #343: GRIFFIN-175 - fix es 411 issue

2018-07-12 Thread icesmartjuan
Github user icesmartjuan commented on the issue: https://github.com/apache/incubator-griffin/pull/343 when call get BASE_PATH/api/v1/metrics or get BASE_PATH/api/v1/metrics/values?metricName=jobName=5=0, service returns 500. after debugging, found that elasticsearch returns

[GitHub] incubator-griffin issue #344: GRIFFIN-177 - fix measure page display issue

2018-07-12 Thread icesmartjuan
Github user icesmartjuan commented on the issue: https://github.com/apache/incubator-griffin/pull/344 issue: found UI page wrongly displayed if measure["dq.type"] is not set, root cause: row["dq.type"].toLowerCase() in measure.component.html caus

[GitHub] incubator-griffin pull request #346: GRIFFIN-178 - job state not update afte...

2018-07-11 Thread icesmartjuan
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin/pull/346 GRIFFIN-178 - job state not update after performing start/stop actions on job page GRIFFIN-178 - job state not update after performing start/stop actions on job page You can merge

[GitHub] incubator-griffin pull request #344: GRIFFIN-177 - fix measure page display ...

2018-07-11 Thread icesmartjuan
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin/pull/344 GRIFFIN-177 - fix measure page display issue GRIFFIN-177 - fix measure page display issue You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-griffin-site pull request #2: griffin site - GRIFFIN-130 - GRIFFIN...

2018-04-18 Thread icesmartjuan
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin-site/pull/2 griffin site - GRIFFIN-130 - GRIFFIN-126 change items font-size, and… griffin site - GRIFFIN-130 - GRIFFIN-126 change items font-size, and add security link You can merge

[GitHub] incubator-griffin pull request #251: UI-GRIFFIN-111-add progress indicator i...

2018-04-08 Thread icesmartjuan
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin/pull/251 UI-GRIFFIN-111-add progress indicator in every http request You can merge this pull request into a Git repository by running: $ git pull https://github.com/icesmartjuan

[GitHub] incubator-griffin pull request #246: UI-JIRA-GRIFFIN-121 Add publish measure...

2018-04-01 Thread icesmartjuan
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin/pull/246 UI-JIRA-GRIFFIN-121 Add publish measure create process on UI UI-JIRA-GRIFFIN-121 Add publish measure create process on UI You can merge this pull request into a Git repository

[GitHub] incubator-griffin pull request #242: JIRA-GRIFFIN-107-UI-add hdfs data...

2018-03-28 Thread icesmartjuan
GitHub user icesmartjuan opened a pull request: https://github.com/apache/incubator-griffin/pull/242 JIRA-GRIFFIN-107-UI-add hdfs data asset UI part-add hdfs or kafka data asset corresponding services need to be added later, following in GRIFFIN-109 and GRIFFIN-110 You can