Re: Failing joint build

2019-05-19 Thread Paul King
Possibly this in 2.5.7? https://issues.apache.org/jira/browse/GROOVY-7954 Virus-free. www.avast.com

Re: Failing joint build

2019-05-19 Thread Paolo Di Tommaso
Just to confirm the build fixed, though some tests failing due to changes in the snapshot version. Is there any change related to identity and Comparable interface coming in Groovy 2.5.8? Cheers, Paolo On Sun, May 19, 2019 at 10:19 AM Paolo Di Tommaso wrote: > Damn! you are right. The deps o

Re: groovy project's src/main/* folders

2019-05-19 Thread Paul King
Okay, the bootstrap compiler doesn't need src/main/groovy anymore, so that is gone too. On Mon, May 20, 2019 at 6:32 AM Paul King wrote: > > On Mon, May 20, 2019 at 4:46 AM Jochen Theodorou > wrote: > >> and how did the build times change? Do we still have incremental builds >> for the java par

Re: groovy project's src/main/* folders

2019-05-19 Thread Paul King
On Mon, May 20, 2019 at 4:46 AM Jochen Theodorou wrote: > and how did the build times change? Do we still have incremental builds > for the java parts? Because as I understood Cedric this is not the case > anymore now. > I am unsure what you are asking. I haven't done any performance testing of

Re: groovy project's src/main/* folders

2019-05-19 Thread Jochen Theodorou
On 19.05.19 14:26, Paul King wrote: True. But "good" separation of concerns is to some degree in the eye of the beholder. Separating by language of implementation caters for one concern, i.e. language of implementation. Another way would be to group all source related to one bit of functionality

Re: Indy-only support for Groovy 4 not 3?

2019-05-19 Thread Guillaume Laforge
Let's get 3 out sooner than later. So Indy shouldn't push 3 further. Le dim. 19 mai 2019 à 16:36, Daniel Sun a écrit : > Agreed. > > Moreover, we should implement PIC before enabling indy by default. > > Cheers, > Daniel.Sun > > > > > -- > Sent from: http://groovy.329449.n5.nabble.com/Groovy-De

Re: Indy-only support for Groovy 4 not 3?

2019-05-19 Thread Daniel Sun
Agreed. Moreover, we should implement PIC before enabling indy by default. Cheers, Daniel.Sun -- Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html

Indy-only support for Groovy 4 not 3?

2019-05-19 Thread Paul King
We have spoken previously about combining the classic and indy jars for Groovy 3 (using a bit of simplification around the word "combining"). To date, we haven't done anything but some incomplete spikes for this task. I am suggesting we now target this work for Groovy 4. Adding further module suppo

Split packaging changes for Groovy 3

2019-05-19 Thread Paul King
We planned (originally about a year ago) to have split packaging sorted for 3.0. I didn't have time to get that ready for beta-1. I have it ready now for beta-2. At the time, there were a few options we planned to consider over and above the necessary changes to become compliant with JPMS package n

Re: groovy project's src/main/* folders

2019-05-19 Thread Paul King
True. But "good" separation of concerns is to some degree in the eye of the beholder. Separating by language of implementation caters for one concern, i.e. language of implementation. Another way would be to group all source related to one bit of functionality together and hide away a potentially u

Re: groovy project's src/main/* folders

2019-05-19 Thread Cédric Champeau
This is not just about Gradle, and not related to the build cache. There are different things: mixing Java and Groovy sources in a single source tree **only** makes sense for sources which are _joint compiled_. Otherwise you're just slowing down your build arbitrarily, because Groovy has to generat

Re: Failing joint build

2019-05-19 Thread Paolo Di Tommaso
Damn! you are right. The deps overriding should have gone in `allprojects` block. Thanks for having spotted that and updated the building environment. Cheers, Paolo On Sun, May 19, 2019 at 2:42 AM Paul King wrote: > It seems repeatable locally. > > On Sun, May 19, 2019 at 10:17 AM Paul King