Re: [GitHub] groovy pull request #:

2017-12-19 Thread Cédric Champeau
Don't forget that there's the build cache now. Look at the build scans to check what was avoided. Le 19 déc. 2017 6:29 PM, "paulk-asert" a écrit : > Github user paulk-asert commented on the pull request: > > https://github.com/apache/groovy/commit/047c8f29b1f7a1a98b2b003e4d09c1 > cef05feb0e#

Re: [GitHub] groovy pull request: Link to MrHaki's blog in TupleConstructor jav...

2016-03-01 Thread Paco Zarate
Is it possible to include blog links or samples as: "External References:" ? I think that someone that wants to help with the documentation can have a very good starting point with the external references on hand, and it is very clear that is not the "Official documentation" On Mon, Feb 29, 2016

Re: [GitHub] groovy pull request: Link to MrHaki's blog in TupleConstructor jav...

2016-02-29 Thread Konstantin Boudnik
On Mon, Feb 29, 2016 at 06:40PM, Cédric Champeau wrote: > 2016-02-29 18:37 GMT+01:00 Konstantin Boudnik : > > > Sorry for a delay in the answer... > > > > On Mon, Feb 29, 2016 at 12:01PM, Jochen Theodorou wrote: > > > > > > On 27.02.2016 05:26, Aseem Bansal wrote: > > > >Hi Konstantin Boudnik > >

Re: [GitHub] groovy pull request: Link to MrHaki's blog in TupleConstructor jav...

2016-02-29 Thread Cédric Champeau
2016-02-29 18:37 GMT+01:00 Konstantin Boudnik : > Sorry for a delay in the answer... > > On Mon, Feb 29, 2016 at 12:01PM, Jochen Theodorou wrote: > > > > On 27.02.2016 05:26, Aseem Bansal wrote: > > >Hi Konstantin Boudnik > > > > > >Are the things on groovy-lang not considered originating from Apa

Re: [GitHub] groovy pull request: Link to MrHaki's blog in TupleConstructor jav...

2016-02-29 Thread Konstantin Boudnik
Sorry for a delay in the answer... On Mon, Feb 29, 2016 at 12:01PM, Jochen Theodorou wrote: > > On 27.02.2016 05:26, Aseem Bansal wrote: > >Hi Konstantin Boudnik > > > >Are the things on groovy-lang not considered originating from Apache > >premises? Where the code for groovy-lang is hosted? Tha

Re: [GitHub] groovy pull request: Link to MrHaki's blog in TupleConstructor jav...

2016-02-29 Thread Jochen Theodorou
On 27.02.2016 05:26, Aseem Bansal wrote: Hi Konstantin Boudnik Are the things on groovy-lang not considered originating from Apache premises? If we link to Mr Hakis blog, and that is seen as Docs, then we have external Docs, which do not originate from the ASF. In my opinion no problem, si

Re: [GitHub] groovy pull request: Link to MrHaki's blog in TupleConstructor jav...

2016-02-27 Thread Peter Ledbrook
> > I agree with Cédric. > It'd be better to integrate the actual tips in the JavaDocs per se. > Furthermore, the Groovy's GroovyDoc can also contain code samples that are > actually tested, with assertions. > So not only would that improve the documentation itself, without going > through another

Re: [GitHub] groovy pull request: Link to MrHaki's blog in TupleConstructor jav...

2016-02-27 Thread jim northrop
included in the GroovyDoc, which makes at least sure the code works. > > In the nearby future I certainly want to contribute to adding snippets to > the existing Groovydoc sources. > > Hubert Klein Ikkink > @mrhaki > www.mrhaki.com > > > > > -- > View this mess

Re: [GitHub] groovy pull request: Link to MrHaki's blog in TupleConstructor jav...

2016-02-27 Thread mrhaki
vydoc sources. Hubert Klein Ikkink @mrhaki www.mrhaki.com -- View this message in context: http://groovy.329449.n5.nabble.com/Re-GitHub-groovy-pull-request-Link-to-MrHaki-s-blog-in-TupleConstructor-jav-tp5731382p5731443.html Sent from the Groovy Dev mailing list archive at Nabble.com.

Re: [GitHub] groovy pull request: Link to MrHaki's blog in TupleConstructor jav...

2016-02-26 Thread Aseem Bansal
Hi Konstantin Boudnik Are the things on groovy-lang not considered originating from Apache premises? The repository for the same is licensed to Apache and is in Apache's git repository. Am I missing something here? On Fri, Feb 26, 2016 at 9:20 PM, Konstantin Boudnik wrote: > There's another con

Re: [GitHub] groovy pull request: Link to MrHaki's blog in TupleConstructor jav...

2016-02-26 Thread Suderman Keith
I side with Cédric here. The Java/Groovy docs should only link to other parts of the official documentation, or at least to endpoints the Groovy team controls. I don’t have to go online to read the docs or root around in my ~/.m2 repo to find them, they are displayed automagically by my IDE an

Re: [GitHub] groovy pull request: Link to MrHaki's blog in TupleConstructor jav...

2016-02-26 Thread Pascal Schumacher
Well it's not really hidden, as the groovy/javadoc is published on the web and quite high in the google search results (at least for me). Also you can configure e.g. Eclipse to automatically download sources and javadocs for all dependencies, so it's directly visible in the IDE. Cheers, Pasca

Re: [GitHub] groovy pull request: Link to MrHaki's blog in TupleConstructor jav...

2016-02-26 Thread Konstantin Boudnik
There's another concern: docs of an Apache project has to originate, as the source code, from Apache premises (Infra, etc.) While linking doesn't exactly violates this, it is still looks like "Ok, here's our documentation, but for this little piece you'd need to go and check somewhere else". There'

Re: [GitHub] groovy pull request: Link to MrHaki's blog in TupleConstructor jav...

2016-02-26 Thread Aseem Bansal
rg Glasius > > Hedevej 1, Gl. Rye, 8680 Ry, Denmark > Mobile: +45 40 44 91 88, Skype: sbglasius > --- Press ESC once to quit - twice to save the changes. > > From: Guillaume Laforge > Reply: dev@groovy.apache.org > > Date: February 26, 2016 at 10:53:07 > To: dev@groovy.

Re: [GitHub] groovy pull request: Link to MrHaki's blog in TupleConstructor jav...

2016-02-26 Thread Søren Berg Glasius
44 91 88, Skype: sbglasius --- Press ESC once to quit - twice to save the changes. From: Guillaume Laforge Reply: dev@groovy.apache.org Date: February 26, 2016 at 10:53:07 To: dev@groovy.apache.org Subject:  Re: [GitHub] groovy pull request: Link to MrHaki's blog in TupleConstructor ja

Re: [GitHub] groovy pull request: Link to MrHaki's blog in TupleConstructor jav...

2016-02-26 Thread Guillaume Laforge
I agree with Cédric. It'd be better to integrate the actual tips in the JavaDocs per se. Furthermore, the Groovy's GroovyDoc can also contain code samples that are actually tested, with assertions. So not only would that improve the documentation itself, without going through another hoop to visit

Re: [GitHub] groovy pull request: Link to MrHaki's blog in TupleConstructor jav...

2016-02-26 Thread Cédric Champeau
If you're ready to introduce a link to an external resource in a Javadoc, I think you should instead make an effort to improve this particular Javadoc. I'm strongly against promoting blogs, tutorials, ... that are by nature individual rather than community driven. That, independently of the quality

Re: [GitHub] groovy pull request: Link to MrHaki's blog in TupleConstructor jav...

2016-02-26 Thread Jesper Steen Møller
Also, people these days would usually consult documentation online sources than bother with locating any local javadoc/groovydoc documentation sources, hidden away in some local m2 repo cache (or is that just me?). That’d make a stale link somewhat less likely, outweighed by the goodness of Groovy

Re: [GitHub] groovy pull request: Link to MrHaki's blog in TupleConstructor jav...

2016-02-25 Thread Peter Ledbrook
On Wed, 24 Feb 2016 at 16:30 Cédric Champeau wrote: > I don't think linking to external resources like this is a good idea. We > don't own the end link, it can be dead very easily, especially in the > future. I would rather improve the documentation. > While I understand the concern, I think thi

Re: [GitHub] groovy pull request: Link to MrHaki's blog in TupleConstructor jav...

2016-02-24 Thread Cédric Champeau
I don't think linking to external resources like this is a good idea. We don't own the end link, it can be dead very easily, especially in the future. I would rather improve the documentation. 2016-02-24 17:25 GMT+01:00 pledbrook : > GitHub user pledbrook opened a pull request: > > https://gi