Re: Add a marker interface to bypass Collections and Maps formatting

2018-02-26 Thread Paolo Di Tommaso
I want to report an update on the status of this issue. In the conversation in the GitHub pull request I was requested to perform a benchmark to evaluate the impact of this change. The results are showed below: Benchmark(size)

Re: Add a marker interface to bypass Collections and Maps formatting

2018-01-26 Thread Paolo Di Tommaso
I agree. The name @GroovyOverride sounds a good option. Cheers, Paolo On Thu, Jan 25, 2018 at 11:53 PM, MG wrote: > This looks like something that might be useful in certain scenarios. A > "perfect fix" would always be better, but since that might be some time off > (2019 being optimistic -

Re: Add a marker interface to bypass Collections and Maps formatting

2018-01-25 Thread MG
This looks like something that might be useful in certain scenarios. A "perfect fix" would always be better, but since that might be some time off (2019 being optimistic - some of the things I want Groovy to improve in date back to at least 2006)... My only question would be, if it would perha

Re: Add a marker interface to bypass Collections and Maps formatting

2018-01-23 Thread Paolo Di Tommaso
Hi all, I want to take the opportunity to renew my proposal and PR to add an annotation that allows the override of the Groovy default formatting for certain classes. https://github.com/apache/groovy/pull/566 To quickly remind you what the problem is, Groovy provides a nice default formatting f

Re: Add a marker interface to bypass Collections and Maps formatting

2017-06-25 Thread Paolo Di Tommaso
Dear all, Groovy still does not provide a mechanism to override the `toString` and `equals` methods for custom Collection and Map objects. This is a serious limitation in some use cases. I'm proposing with the following pull request to introduce a marker annotation that allows a custom object to

Re: Add a marker interface to bypass Collections and Maps formatting

2016-06-03 Thread Paolo Di Tommaso
Hi, Thanks for your reply. I see your points and I really hope you can manage to find a better solution to handle this issue. In any case I will try to submit a PR at my earliest convenience at least to have it as remainder in the tracking system. Cheers, Paolo On Thu, Jun 2, 2016 at 1:38 AM,

Re: Add a marker interface to bypass Collections and Maps formatting

2016-06-01 Thread Paul King
I am +1 on improving how we handle formatting for lists and maps. My default position would be -1 on an implementation that smells like it might be "yet another hack" that we have to maintain long term. The main reason being that we are trying to streamline method selection for our revised MOP (I k

Re: Add a marker interface to bypass Collections and Maps formatting

2016-05-31 Thread Paolo Di Tommaso
Hello guys, No feedback on this? Would you take in consideration a PR for this proposal? Thanks, Paolo On Sat, May 28, 2016 at 6:26 PM, Paolo Di Tommaso wrote: > Hi all, > > Groovy implements a built-in formatting strategy for collection and map > objects that is surely nicer and more useful

Add a marker interface to bypass Collections and Maps formatting

2016-05-28 Thread Paolo Di Tommaso
Hi all, Groovy implements a built-in formatting strategy for collection and map objects that is surely nicer and more useful than the one provided by the default Java implementation for these classes. However there are use cases in which custom collection or map classes need to implement their ow