Re: ModuleNode and CompuleUnit

2018-08-13 Thread mg
Alias + deprecate in 2.5.3, delete in 2.5.4 - we need to get up to JDK speed here, guys (& gals)... ;-) Ursprüngliche Nachricht Von: Paul King Datum: 13.08.18 10:56 (GMT+00:00) An: [email protected] Betreff: Re: ModuleNode and CompuleUnit We could provide an ali

Re: ModuleNode and CompuleUnit

2018-08-13 Thread Paul King
We could provide an alias I guess. On Mon, Aug 13, 2018 at 6:09 PM Jochen Theodorou wrote: > > > Am 13.08.2018 um 10:08 schrieb Jochen Theodorou: > > > > > > Am 12.08.2018 um 15:34 schrieb Paul King: > >> > >> Anyone think of a reason we shouldn't allow the CompileUnit to be > >> accessed from M

Re: ModuleNode and CompuleUnit

2018-08-13 Thread Jochen Theodorou
Am 13.08.2018 um 10:08 schrieb Jochen Theodorou: Am 12.08.2018 um 15:34 schrieb Paul King: Anyone think of a reason we shouldn't allow the CompileUnit to be accessed from ModuleNode? We already let it be accessed from ClassNode. I was only thinking read access. I was contemplating addi

Re: ModuleNode and CompuleUnit

2018-08-13 Thread Jochen Theodorou
Am 12.08.2018 um 15:34 schrieb Paul King: Anyone think of a reason we shouldn't allow the CompileUnit to be accessed from ModuleNode? We already let it be accessed from ClassNode. I was only thinking read access. I was contemplating adding NodeMetaDataHandler capability to CompileUnit fo

Re: ModuleNode and CompuleUnit

2018-08-12 Thread Paul King
False alarm. We already allow compile unit to be accessed, it's just called getUnit in ModuleNode and getCompileUnit in ClassNode. On Sun, Aug 12, 2018 at 11:34 PM Paul King wrote: > > Anyone think of a reason we shouldn't allow the CompileUnit to be accessed > from ModuleNode? We already let it

ModuleNode and CompuleUnit

2018-08-12 Thread Paul King
Anyone think of a reason we shouldn't allow the CompileUnit to be accessed from ModuleNode? We already let it be accessed from ClassNode. I was only thinking read access. I was contemplating adding NodeMetaDataHandler capability to CompileUnit for "global" metadata shared across transforms. Though