Re: Antlr4-based Groovy parser status update

2016-03-12 Thread daniel_sun
Hi Jesper, I'm very glad to know the antlr4 works on Groovy re-launched. A few days ago, I gave it a try and found it did not support optional parentheses of invoking method, so I managed to fix it and new a pull request on the github, pls verify it. The dev environment settin

Re: Antlr4-based Groovy parser status update

2016-02-25 Thread Paul King
Ah yes, I'd forgotten about that line of thinking. I still believe we should be able to set things up so that prod code isn't affected by Spock but I don't have time to investigate further right now so being extra cautious as per Cédric's comment is the way to go. Cheers, Paul. On Wed, Feb 24, 20

Re: Antlr4-based Groovy parser status update

2016-02-24 Thread Jesper Steen Møller
Ah, good to know. While merging in the master changes since the antlr4 fork, I noticed that Spock was indeed in use already, so I haven’t ditched it — yet. For now, it’s only used for simple things like where-blocks, which can be done only slightly more clumsily with JUnit. -Jesper > On 24. f

Re: Antlr4-based Groovy parser status update

2016-02-24 Thread Cédric Champeau
It is a show stopper for groovy-core. We must *not* introduce a dependency on Spock, because it would conflict with the version of Groovy that we are using, and apply global xforms on Groovy core. While it might be ok, we want to minimize the risks. 2016-02-24 12:35 GMT+01:00 Paul King : > Spock

Re: Antlr4-based Groovy parser status update

2016-02-24 Thread Paul King
Spock for testing is by no means a show stopper! On Wed, Feb 24, 2016 at 6:46 PM, Jesper Steen Møller wrote: > > On 24. feb. 2016, at 01.21, Guillaume Laforge wrote: > > Sounds cool, Jesper, great to hear about your progress on the Antlr4 > grammar! > Is there a way we can help you? How can we t

Re: Antlr4-based Groovy parser status update

2016-02-24 Thread Jesper Steen Møller
> On 24. feb. 2016, at 01.21, Guillaume Laforge wrote: > > Sounds cool, Jesper, great to hear about your progress on the Antlr4 grammar! > Is there a way we can help you? How can we test drive this? Is the build > working? The build works in that the antlr4 branch can be build and tested with

Re: Antlr4-based Groovy parser status update

2016-02-23 Thread Guillaume Laforge
Sounds cool, Jesper, great to hear about your progress on the Antlr4 grammar! Is there a way we can help you? How can we test drive this? Is the build working? Guillaume On Wed, Feb 24, 2016 at 1:14 AM, Jesper Steen Møller wrote: > Hi Groovy-dev > > I’ve found some time to work on the Antlr4 pa