FastStringUtils change

2018-05-15 Thread Paul King
Hi everyone, I just noticed that for GROOVY-8379 (getting rid of Unsafe usage) I made this change in master and 2_6_X only. I was planning to push this into 2_5_X. If anyone has objections, let me know. Details: FastStringUtils implementations are picked up using the service provider mechanism

Re: [VOTE] Support Java-like array

2018-05-15 Thread mg
What I meant to say yesterday at 1am was: "On the other hand I do not get why only 2 PMC members have been voting +1 on this proposal..." This is not against voting +0, but about why so few PMC members vote at all... (?) Ursprüngliche Nachricht Von: MG

Re: [VOTE] Support Java-like array

2018-05-15 Thread Remko Popma
Cédric, Should the voting period be extended for this vote? Remko > On May 15, 2018, at 15:07, Cédric Champeau wrote: > > I can say why I didn't vote: I didn't have time to review the proposal and > its consequences, so I don't want to give a blind +1 or -1. >

About raw string and enhanced try-with-resource

2018-05-15 Thread Daniel.Sun
Hi all, Java11 will introduce raw string[1], there is no similar thing in Groovy. In order to improve the compatibility with Java, I plan to add raw string to Groovy too. Since Groovy has supported try-with-resource introduced by Java7, I plan to support the enhanced version[2].

Re: Java object conversion using ConfigSlurper

2018-05-15 Thread adithyank
Ok. Thanks Daniel. I will proceed in the below way. Pls advice 1. I will write new class `ConfigCustomObjectBuilder` in `ConfigSlurper.groovy` to convert given ConfigObject to custom class instance 2. I will add below new method in ConfigObject T getAs(Class dataStructure) {

Re: Java object conversion using ConfigSlurper

2018-05-15 Thread Daniel.Sun
I think it is nice for me :-) Cheers, Daniel.Sun -- Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html

Re: FastStringUtils change

2018-05-15 Thread John Wagenleitner
Definitely in favor of removing from 2_5_X, think it's a good idea. I doubt (though haven't benchmarked) that it really offers that much in terms of performance and memory savings and with JDK9 compat strings it doesn't work in it's currently form. Would it be worth considering leaving deprecated

Re: About raw string and enhanced try-with-resource

2018-05-15 Thread Paolo Di Tommaso
No. There's an important difference: raw strings do not escape any special character ie. backlashes, dollars, back-ticks, etc. This is very useful for DSLs when it's required to embed a piece of foreign code (think for example Bash) into a string. With groovy multi-line string you still need to

Re: About raw string and enhanced try-with-resource

2018-05-15 Thread Jesper Steen Møller
On 15 May 2018, at 12.31, Paolo Di Tommaso wrote: > > No. There's an important difference: raw strings do not escape any special > character ie. backlashes, dollars, back-ticks, etc. > Ah, I didn't actually realize that Groovy's current '''multiline''' style

Re: About raw string and enhanced try-with-resource

2018-05-15 Thread Cédric Champeau
+1 for both. In particular I like that you can choose your own delimiter in Java 11 raw strings. 2018-05-15 12:48 GMT+02:00 Jesper Steen Møller : > On 15 May 2018, at 12.31, Paolo Di Tommaso > wrote: > > > No. There's an important difference: raw

Re: CompilierConfiguration#CURRENT_JVM_VERSION

2018-05-15 Thread Remko Popma
+1 On Tue, May 15, 2018 at 7:01 PM, Paul King wrote: > > Hi all, > > In CompilerConfiguration we have a public constant CURRENT_JVM_VERSION > which actually represents the minimum JDK version supported by a particular > version of Groovy (potentially on a particular VM

Groovy 2.5 CliBuilder article (request for feedback)

2018-05-15 Thread Remko Popma
Hi everyone, I finished a first draft of an article on Groovy 2.5 CliBuilder (https://github.com/remkop/picocli/wiki/Groovy-2.5-CliBuilder-Renewal). I plan to publish this on DZone and Java Code Geeks when complete. I'd appreciate your feedback and suggestions for improvement! Remko

Re: CompilierConfiguration#CURRENT_JVM_VERSION

2018-05-15 Thread John Wagenleitner
+1 for deprecating the current constant and new name (see note below). If the new constant wont be used internally then I might suggest no new constant is created. Else if it's created in order to provide an alternate to the deprecated one, would it make sense to provide it via

Re: About raw string and enhanced try-with-resource

2018-05-15 Thread Daniel.Sun
Hi Jochen, I plan to work on enhanced try-with-resources recently. As for raw string, it is just on my TODO list :-) As you said, Groovy has many string(e.g. 'xxx', "xxx", '''xxx''', """xxx""", /xxx/, $/xxx/$). but they can not cover the function of raw string... Cheers, Daniel.Sun

CompilierConfiguration#CURRENT_JVM_VERSION

2018-05-15 Thread Paul King
Hi all, In CompilerConfiguration we have a public constant CURRENT_JVM_VERSION which actually represents the minimum JDK version supported by a particular version of Groovy (potentially on a particular VM runtime). I was thinking of deprecating above constant (it's not used in the Groovy

Re: CompilierConfiguration#CURRENT_JVM_VERSION

2018-05-15 Thread Daniel.Sun
+1 Cheers, Daniel.Sun -- Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html

Re: About raw string and enhanced try-with-resource

2018-05-15 Thread Jesper Steen Møller
> On 15 May 2018, at 12.14, Daniel.Sun wrote: > [..] >As you said, Groovy has many string(e.g. 'xxx', "xxx", '''xxx''', > """xxx""", /xxx/, $/xxx/$). but they can not cover the function of raw > string... > Isn't '''tripple-single-quoted''' basically the same as the raw

Fwd: groovy git commit: GROOVY-5912: Static compilation: Groovy doesn't fail compilation when accessing package scope methods, but fails at runtime

2018-05-15 Thread John Wagenleitner
Just a question, I thought that @TypeChecked is designed to work similar to dynamic mode as far as method dispatch and access (i.e., private/protected ok). If filtering methods by visibility is done in the `StaticTypeCheckingVisitor` wouldn't change that behavior. Is that something expected for

Re: FastStringUtils change

2018-05-15 Thread Paul King
I am okay with removing in 3 (maybe even 2.6) though it's through the service loader and it currently degrades gracefully on JDK9+, i.e. just won't load. I am more worried about it degrading ungracefully in the future. On Wed, May 16, 2018 at 12:09 AM, John Wagenleitner <

Re: [VOTE] Support Java-like array

2018-05-15 Thread Jochen Theodorou
Am 15.05.2018 um 08:03 schrieb mg: What I meant to say yesterday at 1am was: "On the other hand I do not get why only 2 PMC members have been voting +1 on this proposal..." I did not vote +1 because I find it surplus, on the other hand I do not really want to block it if others are eager

Re: About raw string and enhanced try-with-resource

2018-05-15 Thread Jochen Theodorou
Am 15.05.2018 um 08:42 schrieb Daniel.Sun: Hi all, Java11 will introduce raw string[1], there is no similar thing in Groovy. In order to improve the compatibility with Java, I plan to add raw string to Groovy too. Since Groovy has supported try-with-resource introduced by