Re: [VOTE] Release Apache Groovy 3.0.0-rc-1

2019-10-22 Thread Cédric Champeau
As the README says, you need to use the Gradle version which is declared in gradle.properties, which is 5.6.3 for this release. Le mar. 22 oct. 2019 à 11:51, Guillaume Laforge a écrit : > QQ, it's perhaps just a Gradle issue, but with the local version of Gradle > I have (Gradle 5.3.1), I can't

Re: [VOTE] Release Apache Groovy 3.0.0-rc-1

2019-10-22 Thread Guillaume Laforge
QQ, it's perhaps just a Gradle issue, but with the local version of Gradle I have (Gradle 5.3.1), I can't create the wrapper and I get: ↳ gradle -b wrapper.gradle wrapper FAILURE: Build failed with an exception. * Where: Settings file

[VOTE] Release Apache Groovy 3.0.0-rc-1

2019-10-22 Thread Paul King
Dear development community, I am happy to start the VOTE thread for a Groovy 3.0.0-rc-1 release! This release includes over 50 bug fixes/improvements as outlined in the changelog: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123=12345982 Groovy 3 is nearing lockdown

[CANCELLED][VOTE] Release Apache Groovy 3.0.0-rc-1

2019-10-22 Thread Paul King
We found a few issues. I'll rebuild. On Tue, Oct 22, 2019 at 7:19 PM Paul King wrote: > Dear development community, > > I am happy to start the VOTE thread for a Groovy 3.0.0-rc-1 release! > > This release includes over 50 bug fixes/improvements as outlined in the > changelog: > >

Re: [VOTE] Release Apache Groovy 3.0.0-rc-1 (take 2)

2019-10-22 Thread Daniel.Sun
+1 (binding) All tests pass on my local machine, here is the report of build scan: https://gradle.com/s/4bhflb27misl2 Also, I tested groovySh and groovyConsole manually and found no issues. Cheers, Daniel.Sun - Apache Groovy committer & PMC member Blog: http://blog.sunlan.me Twitter:

[VOTE] Release Apache Groovy 3.0.0-rc-1 (take 2)

2019-10-22 Thread Paul King
Dear development community, I am happy to start the VOTE thread for a Groovy 3.0.0-rc-1 release! This release includes 52 bug fixes/improvements as outlined in the changelog: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123=12345982 Groovy 3 is nearing lockdown status

Re: [VOTE] Release Apache Groovy 3.0.0-rc-1 (take 2)

2019-10-22 Thread Guillaume Laforge
+1 (binding) Build and tests are running fine, and I played with the Groovy console without noticing any problem. Guillaume On Tue, Oct 22, 2019 at 2:01 PM Paul King wrote: > > Dear development community, > > I am happy to start the VOTE thread for a Groovy 3.0.0-rc-1 release! > > This

Re: [VOTE] Release Apache Groovy 3.0.0-rc-1

2019-10-22 Thread Guillaume Laforge
Usually, the wrapper creation used to work across a wide range of Gradle versions. Then, once the required Gradle version is installed, we indeed use that specific version. But I was expecting that I could at least generate the wrapper as usual, regardless of the version of Gradle I had locally

Re: [VOTE] Release Apache Groovy 3.0.0-rc-1 (take 2)

2019-10-22 Thread Cédric Champeau
That's a bit surprising of a release candidate, IMO. A release candidate should mean "hey if there's no bug report, that's _exactly_ that that we publish as final". Here you're saying that in any case, you're going to change the dependency to Ivy. To me, it _implies_ that there will be a 3.0 rc2

Re: [VOTE] Release Apache Groovy 3.0.0-rc-1 (take 2)

2019-10-22 Thread Daniel.Sun
FYI. Ivy 2.5.0 is coming soon too: http://ant.1045680.n5.nabble.com/VOTE-Release-Ivy-2-5-0-based-on-RC1-td5719982.html Cheers, Daniel.Sun - Apache Groovy committer & PMC member Blog: http://blog.sunlan.me Twitter: @daniel_sun -- Sent from:

Re: [VOTE] Release Apache Groovy 3.0.0-rc-1 (take 2)

2019-10-22 Thread Daniel.Sun
Hi Cédric, > To me, it _implies_ that there will be a 3.0 rc2 for Groovy. Yep ;-) As Paul said, one part which has only recently been finished and still needs a bit more polishing is a revamped groovydoc. So 3.0.0-rc-2 will be released after groovydoc has been polished. 3.0.0-rc-1

Re: [VOTE] Release Apache Groovy 3.0.0-rc-1 (take 2)

2019-10-22 Thread Milles, Eric (TR Tech, Content & Ops)
Even if Ivy 2.5.0 is released soon, we have not tested with that version. I would not pick it up until Groovy 4. The recent change to GenericsUtils.parseClassNodesFromString assumes that you have a specific type of ParserPluginFactory set. However the CompilerConfiguration allows the user

Re: [VOTE] Release Apache Groovy 3.0.0-rc-1 (take 2)

2019-10-22 Thread Milles, Eric (TR Tech, Content & Ops)
This type of check makes an unsafe assumption. If you need a parser, the factory is there to supply one to you. That is the purpose of the factory pattern. boolean oldParserEnabled = compilationUnit.getConfiguration().getPluginFactory() instanceof AntlrParserPluginFactory;

Re: [VOTE] Release Apache Groovy 3.0.0-rc-1 (take 2)

2019-10-22 Thread Daniel.Sun
If Ivy 2.5.0 GA is not released before Groovy 3.0.0 GA, we have to downgrade Ivy to 2.4.0 GA. Cheers, Daniel.Sun - Apache Groovy committer & PMC member Blog: http://blog.sunlan.me Twitter: @daniel_sun -- Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html

Re: [VOTE] Release Apache Groovy 3.0.0-rc-1 (take 2)

2019-10-22 Thread Milles, Eric (TR Tech, Content & Ops)
Was the decision to stick with Ivy 2.5.0-rc1? There was a question of stability.

Re: [VOTE] Release Apache Groovy 3.0.0-rc-1 (take 2)

2019-10-22 Thread Cédric Champeau
Yeah I just find it funny, when you release a "release candidate" knowing it's not a release candidate :) Le mar. 22 oct. 2019 à 17:40, Daniel.Sun a écrit : > Hi Cédric, > > > To me, it _implies_ that there will be a 3.0 rc2 for Groovy. > Yep ;-) As Paul said, one part which has only

Re: [VOTE] Release Apache Groovy 3.0.0-rc-1 (take 2)

2019-10-22 Thread Daniel.Sun
Hi Eric, Could you show us the code to reproduce the following `ClassCastException`? Thanks. java.lang.ClassCastException: org.codehaus.groovy.control.ParserPluginFactory$1 cannot be cast to org.apache.groovy.parser.antlr4.Antlr4PluginFactory at

Re: [VOTE] Release Apache Groovy 3.0.0-rc-1 (take 2)

2019-10-22 Thread Milles, Eric (TR Tech, Content & Ops)
org.codehaus.groovy.control.CompilerConfiguration: public void setPluginFactory(ParserPluginFactory pluginFactory) { this.pluginFactory = pluginFactory; } You cannot control what the user sets here. The contract is that they supply a ParserPluginFactory and you use it to create

Re: [VOTE] Release Apache Groovy 3.0.0-rc-1 (take 2)

2019-10-22 Thread Daniel.Sun
I think I understand the reason why `ClassCastException` will be thrown, but it is not a common case, in other words, we usually only use `AntlrParserPluginFactory` and `Antlr4ParserPluginFactory`. Anyway, we should tweak the code. Cheers, Daniel.Sun - Apache Groovy committer & PMC member

Re: [VOTE] Release Apache Groovy 3.0.0-rc-1 (take 2)

2019-10-22 Thread Daniel.Sun
The `static` method `antlr4` only creates `Antlr4PluginFactory` instance, so I wonder how to make it create `org.codehaus.groovy.control.ParserPluginFactory$1` instance? public abstract class ParserPluginFactory { /** * creates the ANTLR 4 parser * @return the factory for the parser

Re: [VOTE] Release Apache Groovy 3.0.0-rc-1 (take 2)

2019-10-22 Thread Daniel.Sun
We create antlr4 plugin factory via the following code in `Antlr4Util`: Antlr4PluginFactory antlr4PluginFactory = (Antlr4PluginFactory) ParserPluginFactory.antlr4(configuration); The `antlr4` method is `static`, its implementation is to `new Antlr4PluginFactory` instance, and the method can