[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232526633 --- Diff: src/protocols/rdp/rdp_settings.c --- @@ -1264,6 +1281,14 @@ void guac_rdp_push_settings(guac_rdp_settings* guac_settings, freerdp*

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232525849 --- Diff: src/protocols/rdp/rdp_settings.c --- @@ -1264,6 +1281,14 @@ void guac_rdp_push_settings(guac_rdp_settings* guac_settings, freerdp*

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232507335 --- Diff: src/protocols/rdp/rdp_settings.c --- @@ -1265,6 +1281,9 @@ void guac_rdp_push_settings(guac_rdp_settings* guac_settings, freerdp*

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232507326 --- Diff: src/protocols/rdp/rdp_settings.c --- @@ -1265,6 +1277,9 @@ void guac_rdp_push_settings(guac_rdp_settings* guac_settings, freerdp*

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232506936 --- Diff: src/protocols/rdp/rdp_settings.c --- @@ -1265,6 +1277,9 @@ void guac_rdp_push_settings(guac_rdp_settings* guac_settings, freerdp*

[GitHub] guacamole-server pull request #201: GUACAMOLE-547: Add support for SSH NONE ...

2018-11-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/201#discussion_r232504541 --- Diff: src/common-ssh/ssh.c --- @@ -321,6 +321,10 @@ static int guac_common_ssh_authenticate(guac_common_ssh_session* common_session)

[GitHub] guacamole-server pull request #201: GUACAMOLE-547: Add support for SSH NONE ...

2018-11-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/201#discussion_r232504438 --- Diff: src/common-ssh/ssh.c --- @@ -321,6 +321,10 @@ static int guac_common_ssh_authenticate(guac_common_ssh_session* common_session)

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232504386 --- Diff: src/protocols/rdp/rdp_settings.c --- @@ -356,6 +357,11 @@ enum RDP_ARGS_IDX { */ IDX_PRECONNECTION_BLOB,

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232504348 --- Diff: src/protocols/rdp/rdp_settings.c --- @@ -1265,6 +1277,9 @@ void guac_rdp_push_settings(guac_rdp_settings* guac_settings, freerdp*

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232504354 --- Diff: src/protocols/ssh/ssh.c --- @@ -256,6 +256,10 @@ void* ssh_client_thread(void* data) { return NULL; }

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232504364 --- Diff: src/protocols/ssh/settings.h --- @@ -253,6 +253,10 @@ typedef struct guac_ssh_settings { * environment variable.

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-11-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r232502934 --- Diff: src/terminal/terminal/ansi_escape_codes.h --- @@ -0,0 +1,279 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-11-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r232502752 --- Diff: src/terminal/terminal/ansi_escape_codes.h --- @@ -0,0 +1,279 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-11-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r232503178 --- Diff: src/terminal/terminal/ansi_escape_codes.h --- @@ -0,0 +1,279 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] guacamole-server pull request #201: GUACAMOLE-547: Add support for SSH NONE ...

2018-11-11 Thread necouchman
GitHub user necouchman opened a pull request: https://github.com/apache/guacamole-server/pull/201 GUACAMOLE-547: Add support for SSH NONE authentication method I'm not 100% certain that this is all that's needed, because I don't have a SSH server to test this against, but,

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232502604 --- Diff: src/protocols/ssh/settings.c --- @@ -246,6 +247,15 @@ enum SSH_ARGS_IDX { * variable to be set. */

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232502635 --- Diff: src/protocols/rdp/rdp_settings.c --- @@ -356,6 +357,11 @@ enum RDP_ARGS_IDX { */ IDX_PRECONNECTION_BLOB,

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232502486 --- Diff: src/protocols/rdp/rdp_settings.c --- @@ -1265,6 +1277,9 @@ void guac_rdp_push_settings(guac_rdp_settings* guac_settings, freerdp*

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232502539 --- Diff: src/protocols/ssh/settings.h --- @@ -253,6 +253,10 @@ typedef struct guac_ssh_settings { * environment variable.

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-11-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/169#discussion_r232502496 --- Diff: src/protocols/ssh/ssh.c --- @@ -256,6 +256,10 @@ void* ssh_client_thread(void* data) { return NULL; }

Jenkins build is back to normal : guacamole-server-freerdp ยป 1.0.1,ubuntu #21

2018-11-11 Thread Apache Jenkins Server
See

[GitHub] guacamole-server pull request #200: GUACAMOLE-630: Allow font parameters of ...

2018-11-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/guacamole-server/pull/200 ---

[GitHub] guacamole-server pull request #200: GUACAMOLE-630: Allow font parameters of ...

2018-11-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/200#discussion_r232485885 --- Diff: src/protocols/ssh/argv.c --- @@ -81,16 +110,51 @@ static int guac_ssh_argv_blob_handler(guac_user* user, static int