[GitHub] guacamole-client pull request #347: GUACAMOLE-682: docker build with optiona...

2018-12-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/guacamole-client/pull/347 ---

[GitHub] guacamole-client pull request #347: GUACAMOLE-682: docker build with optiona...

2018-12-22 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/347#discussion_r243742443 --- Diff: guacamole-docker/bin/build-guacamole.sh --- @@ -41,6 +41,7 @@ BUILD_DIR="$1" DESTINATION="$2" +BUILD_PROFILE="$3"

[GitHub] guacamole-client pull request #347: GUACAMOLE-682: docker build with optiona...

2018-12-22 Thread jolentes
Github user jolentes commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/347#discussion_r243730984 --- Diff: guacamole-docker/bin/build-guacamole.sh --- @@ -107,3 +113,11 @@ tar -xzf extensions/guacamole-auth-ldap/target/*.tar.gz \

[GitHub] guacamole-client pull request #347: GUACAMOLE-682: docker build with optiona...

2018-12-21 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/347#discussion_r243608567 --- Diff: guacamole-docker/bin/build-guacamole.sh --- @@ -53,7 +54,12 @@ mkdir -p "$DESTINATION" # cd "$BUILD_DIR" -mvn

[GitHub] guacamole-client pull request #347: GUACAMOLE-682: docker build with optiona...

2018-12-21 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/347#discussion_r243608670 --- Diff: guacamole-docker/bin/build-guacamole.sh --- @@ -107,3 +113,11 @@ tar -xzf extensions/guacamole-auth-ldap/target/*.tar.gz \