[GitHub] guacamole-client pull request #289: GUACAMOLE-470: Update "color-scheme" par...

[darchons]

GitHub user darchons opened a pull request:

https://github.com/apache/guacamole-client/pull/289

GUACAMOLE-470: Update "color-scheme" parameter for SSH and Telnet.

apache/guacamole-server#132 changes the "color-scheme" parameter to be a 
configuration string instead of a simple enum, so update the protocol JSON 
accordingly.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/darchons/guacamole-client 
guac-470-configurable-terminal-colors

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/guacamole-client/pull/289.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #289


commit 4e610f2d1bda0ef073b8b9190fa2135d427f30cb
Author: Jim Chen 
Date:   2018-05-16T15:52:08Z

GUACAMOLE-470: Update "color-scheme" parameter for SSH and Telnet.

GUACAMOLE-470 changes the "color-scheme" parameter to be a configuration
string instead of a simple enum, so update the protocol JSON
accordingly.




---

[GitHub] guacamole-client pull request #288: GUACAMOLE-565: Add terminal-type paramet...

[darchons]

GitHub user darchons opened a pull request:

https://github.com/apache/guacamole-client/pull/288

GUACAMOLE-565: Add terminal-type parameter for SSH and Telnet.

Add the new terminal-type parameter (apache/guacamole-server#167) to the 
protocol JSON files.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/darchons/guacamole-client 
guac-565-add-terminal-type-parameter

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/guacamole-client/pull/288.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #288


commit 8ba43a6c57bcefc89fe3f28e1abafc4fe146b500
Author: Jim Chen 
Date:   2018-05-16T15:57:31Z

GUACAMOLE-565: Add terminal-type parameter for SSH and Telnet.

Add the new terminal-type parameter to the protocol JSON files.




---

[GitHub] guacamole-client pull request #280: GUACAMOLE-152: Allow zoom/scale to be ma...

[necouchman]

Github user necouchman commented on a diff in the pull request:

https://github.com/apache/guacamole-client/pull/280#discussion_r188652586
  
--- Diff: guacamole/src/main/webapp/app/client/templates/client.html ---
@@ -151,7 +151,12 @@ {{'CLIENT.SECTION_HEADER_DISPLAY' | 
translate}}
 
 
 
-{{formattedScale()}}%
+
+%
--- End diff --

Old (bad?) JavaScript habits. Removed.


---

[GitHub] guacamole-client pull request #280: GUACAMOLE-152: Allow zoom/scale to be ma...

[mike-jumper]

Github user mike-jumper commented on a diff in the pull request:

https://github.com/apache/guacamole-client/pull/280#discussion_r188524055
  
--- Diff: guacamole/src/main/webapp/app/client/templates/client.html ---
@@ -151,7 +151,12 @@ {{'CLIENT.SECTION_HEADER_DISPLAY' | 
translate}}
 
 
 
-{{formattedScale()}}%
+
+%
--- End diff --

Was just about to retest these changes but out of curiosity:

What is the effect of including a semicolon within the attribute of an 
AngularJS directive like this? Does Angular (intentionally) support multiple 
statements within expressions?


---