Re: [classlib] OSResourceMonitor must go

2009-10-01 Thread Alexey Petrenko
:) 2009/10/1 Tim Ellison : > On 01/Oct/2009 11:00, Alexey Petrenko wrote: >> +1 from me as well. >> >> Actually I was against this patch from the very beginning since it's useless. >> Here is the original JIRA issue: >> http://issues.apache.org/jira/browse/HARMONY-3148 > > Thanks Alexey.  It has g

Re: [classlib] OSResourceMonitor must go

2009-10-01 Thread Tim Ellison
On 01/Oct/2009 11:00, Alexey Petrenko wrote: > +1 from me as well. > > Actually I was against this patch from the very beginning since it's useless. > Here is the original JIRA issue: > http://issues.apache.org/jira/browse/HARMONY-3148 Thanks Alexey. It has gone now -- so we are all happy again

Re: [classlib] OSResourceMonitor must go

2009-10-01 Thread Tim Ellison
On 01/Oct/2009 09:55, Tim Ellison wrote: > I propose that the OSResourceMonitor abomination is removed. It sits in > front of our OSMemory.malloc() calls to check there is enough system memory. > > First, it is going to make all our regular mallocs (from Java) slow by > making these extra JNI + s

Re: [classlib] OSResourceMonitor must go

2009-10-01 Thread Alexey Petrenko
+1 from me as well. Actually I was against this patch from the very beginning since it's useless. Here is the original JIRA issue: http://issues.apache.org/jira/browse/HARMONY-3148 Alexey 2009/10/1 Tim Ellison : > I propose that the OSResourceMonitor abomination is removed.  It sits in > front o

Re: [classlib] OSResourceMonitor must go

2009-10-01 Thread Tim Ellison
On 01/Oct/2009 10:04, Mark Hindess wrote: > Harsh but fair. I'm +1 for removing it. It is a shame there isn't a public > API but this problem should be handled by applications. I'm going to take it out pronto. I realize it doesn't give people long to object, but even if the consensus is that we

Re: [classlib] OSResourceMonitor must go

2009-10-01 Thread Oliver Deakin
Yep, +1 from me as well - this code is too hacky and costly for each malloc. Regards, Oliver Mark Hindess wrote: Harsh but fair. I'm +1 for removing it. It is a shame there isn't a public API but this problem should be handled by applications. -Mark. In message <4ac46e87.3040...@gmail.com>,

Re: [classlib] OSResourceMonitor must go

2009-10-01 Thread Mark Hindess
Harsh but fair. I'm +1 for removing it. It is a shame there isn't a public API but this problem should be handled by applications. -Mark. In message <4ac46e87.3040...@gmail.com>, Tim Ellison writes: > > I propose that the OSResourceMonitor abomination is removed. It sits in > front of our OSMe

[classlib] OSResourceMonitor must go

2009-10-01 Thread Tim Ellison
I propose that the OSResourceMonitor abomination is removed. It sits in front of our OSMemory.malloc() calls to check there is enough system memory. First, it is going to make all our regular mallocs (from Java) slow by making these extra JNI + system calls. At least it should be written to kick