Re: [vmi] Retrieving system properties (was: Re: [classlib][luni] update for bootstrapClassPath causes regression on DRL VM)

2006-12-14 Thread Geir Magnusson Jr.
If that's all they are used for - the native interface to the same thing, then fine. But then write that down too in the comments that this is simply that... geir Alexey Varlamov wrote: 2006/12/14, Geir Magnusson Jr. <[EMAIL PROTECTED]>: Alexey Varlamov wrote: > 2006/12/13, Geir Magnusson

Re: [vmi] Retrieving system properties (was: Re: [classlib][luni] update for bootstrapClassPath causes regression on DRL VM)

2006-12-14 Thread Gregory Shimansky
Geir Magnusson Jr. wrote: Gregory Shimansky wrote: Tim Ellison wrote: Gregory Shimansky wrote: Tim Ellison wrote: Maybe we do, i.e. where there is no value "-Dfoobar". So perhaps we need to say that GetSystemProperty returns VMI_ERROR_NONE and sets the the *valuePtr to NULL if there is no

Re: [vmi] Retrieving system properties (was: Re: [classlib][luni] update for bootstrapClassPath causes regression on DRL VM)

2006-12-14 Thread Alexey Varlamov
2006/12/14, Geir Magnusson Jr. <[EMAIL PROTECTED]>: Alexey Varlamov wrote: > 2006/12/13, Geir Magnusson Jr. <[EMAIL PROTECTED]>: >> >> >> Gregory Shimansky wrote: >> > Alexey Varlamov wrote: >> >> 2006/12/13, Gregory Shimansky <[EMAIL PROTECTED]>: >> >>> Tim Ellison wrote: >> >>> > Alexey Varla

Re: [vmi] Retrieving system properties (was: Re: [classlib][luni] update for bootstrapClassPath causes regression on DRL VM)

2006-12-14 Thread Geir Magnusson Jr.
Alexey Varlamov wrote: 2006/12/13, Geir Magnusson Jr. <[EMAIL PROTECTED]>: Gregory Shimansky wrote: > Alexey Varlamov wrote: >> 2006/12/13, Gregory Shimansky <[EMAIL PROTECTED]>: >>> Tim Ellison wrote: >>> > Alexey Varlamov wrote: >>> >> Is there any reason to distinguish these cases? I supp

Re: [vmi] Retrieving system properties (was: Re: [classlib][luni] update for bootstrapClassPath causes regression on DRL VM)

2006-12-14 Thread Alexey Varlamov
2006/12/13, Geir Magnusson Jr. <[EMAIL PROTECTED]>: Gregory Shimansky wrote: > Alexey Varlamov wrote: >> 2006/12/13, Gregory Shimansky <[EMAIL PROTECTED]>: >>> Tim Ellison wrote: >>> > Alexey Varlamov wrote: >>> >> Is there any reason to distinguish these cases? I suppose no, then >>> >> return

Re: [vmi] Retrieving system properties (was: Re: [classlib][luni] update for bootstrapClassPath causes regression on DRL VM)

2006-12-14 Thread Geir Magnusson Jr.
Gregory Shimansky wrote: Tim Ellison wrote: Gregory Shimansky wrote: Tim Ellison wrote: Maybe we do, i.e. where there is no value "-Dfoobar". So perhaps we need to say that GetSystemProperty returns VMI_ERROR_NONE and sets the the *valuePtr to NULL if there is no value; and returns a VMI_ER

Re: [vmi] Retrieving system properties (was: Re: [classlib][luni] update for bootstrapClassPath causes regression on DRL VM)

2006-12-13 Thread Geir Magnusson Jr.
Gregory Shimansky wrote: Alexey Varlamov wrote: 2006/12/13, Gregory Shimansky <[EMAIL PROTECTED]>: Tim Ellison wrote: > Alexey Varlamov wrote: >> Is there any reason to distinguish these cases? I suppose no, then >> returned NULL is fine. > > Maybe we do, i.e. where there is no value "-Dfooba

Re: [vmi] Retrieving system properties (was: Re: [classlib][luni] update for bootstrapClassPath causes regression on DRL VM)

2006-12-13 Thread Gregory Shimansky
Tim Ellison wrote: Gregory Shimansky wrote: Tim Ellison wrote: Maybe we do, i.e. where there is no value "-Dfoobar". So perhaps we need to say that GetSystemProperty returns VMI_ERROR_NONE and sets the the *valuePtr to NULL if there is no value; and returns a VMI_ERROR_NOT_FOUND if the propert

Re: [vmi] Retrieving system properties (was: Re: [classlib][luni] update for bootstrapClassPath causes regression on DRL VM)

2006-12-13 Thread Alexey Varlamov
2006/12/13, Gregory Shimansky <[EMAIL PROTECTED]>: Alexey Varlamov wrote: > 2006/12/13, Gregory Shimansky <[EMAIL PROTECTED]>: >> Tim Ellison wrote: >> > Alexey Varlamov wrote: >> >> Is there any reason to distinguish these cases? I suppose no, then >> >> returned NULL is fine. >> > >> > Maybe we

Re: [vmi] Retrieving system properties (was: Re: [classlib][luni] update for bootstrapClassPath causes regression on DRL VM)

2006-12-13 Thread Gregory Shimansky
Alexey Varlamov wrote: 2006/12/13, Gregory Shimansky <[EMAIL PROTECTED]>: Tim Ellison wrote: > Alexey Varlamov wrote: >> Is there any reason to distinguish these cases? I suppose no, then >> returned NULL is fine. > > Maybe we do, i.e. where there is no value "-Dfoobar". So perhaps we > need to

Re: [vmi] Retrieving system properties (was: Re: [classlib][luni] update for bootstrapClassPath causes regression on DRL VM)

2006-12-13 Thread Tim Ellison
Gregory Shimansky wrote: > Tim Ellison wrote: >> Maybe we do, i.e. where there is no value "-Dfoobar". So perhaps we >> need to say that GetSystemProperty returns VMI_ERROR_NONE and sets the >> the *valuePtr to NULL if there is no value; and returns a >> VMI_ERROR_NOT_FOUND if the property is unde

Re: [vmi] Retrieving system properties (was: Re: [classlib][luni] update for bootstrapClassPath causes regression on DRL VM)

2006-12-13 Thread Alexey Varlamov
2006/12/13, Gregory Shimansky <[EMAIL PROTECTED]>: Tim Ellison wrote: > Alexey Varlamov wrote: >> Is there any reason to distinguish these cases? I suppose no, then >> returned NULL is fine. > > Maybe we do, i.e. where there is no value "-Dfoobar". So perhaps we > need to say that GetSystemPrope

Re: [vmi] Retrieving system properties (was: Re: [classlib][luni] update for bootstrapClassPath causes regression on DRL VM)

2006-12-13 Thread Gregory Shimansky
Tim Ellison wrote: Alexey Varlamov wrote: Is there any reason to distinguish these cases? I suppose no, then returned NULL is fine. Maybe we do, i.e. where there is no value "-Dfoobar". So perhaps we need to say that GetSystemProperty returns VMI_ERROR_NONE and sets the the *valuePtr to NULL

Re: [classlib][luni] update for bootstrapClassPath causes regression on DRL VM

2006-12-13 Thread Gregory Shimansky
Oliver Deakin wrote: Tim Ellison wrote: Geir Magnusson Jr. wrote: Do we really have a problem? Or is it something else? Last night, Gregory tested his fix, and I've build snapshots (r486417) on x86 linux/win and x86_64 linux and spot checked with apps and such, and things seem to work. I'n

[vmi] Retrieving system properties (was: Re: [classlib][luni] update for bootstrapClassPath causes regression on DRL VM)

2006-12-13 Thread Tim Ellison
Alexey Varlamov wrote: > Is there any reason to distinguish these cases? I suppose no, then > returned NULL is fine. Maybe we do, i.e. where there is no value "-Dfoobar". So perhaps we need to say that GetSystemProperty returns VMI_ERROR_NONE and sets the the *valuePtr to NULL if there is no valu

Re: [classlib][luni] update for bootstrapClassPath causes regression on DRL VM

2006-12-13 Thread Alexey Varlamov
2006/12/13, Oliver Deakin <[EMAIL PROTECTED]>: Tim Ellison wrote: > Geir Magnusson Jr. wrote: > >> Do we really have a problem? Or is it something else? >> >> Last night, Gregory tested his fix, and I've build snapshots (r486417) >> on x86 linux/win and x86_64 linux and spot checked with apps an

Re: [classlib][luni] update for bootstrapClassPath causes regression on DRL VM

2006-12-13 Thread Oliver Deakin
Tim Ellison wrote: Geir Magnusson Jr. wrote: Do we really have a problem? Or is it something else? Last night, Gregory tested his fix, and I've build snapshots (r486417) on x86 linux/win and x86_64 linux and spot checked with apps and such, and things seem to work. I'n posting the snapshot

Re: [classlib][luni] update for bootstrapClassPath causes regression on DRL VM

2006-12-13 Thread Tim Ellison
Geir Magnusson Jr. wrote: > Do we really have a problem? Or is it something else? > > Last night, Gregory tested his fix, and I've build snapshots (r486417) > on x86 linux/win and x86_64 linux and spot checked with apps and such, > and things seem to work. > > I'n posting the snapshots now to ~g

Re: [classlib][luni] update for bootstrapClassPath causes regression on DRL VM (was: Re: [drlvm][classlib] CC is failed to run classlib tests over the DRLVM)

2006-12-13 Thread Geir Magnusson Jr.
Do we really have a problem? Or is it something else? Last night, Gregory tested his fix, and I've build snapshots (r486417) on x86 linux/win and x86_64 linux and spot checked with apps and such, and things seem to work. I'n posting the snapshots now to ~geirm and will send a separate note

Re: [classlib][luni] update for bootstrapClassPath causes regression on DRL VM (was: Re: [drlvm][classlib] CC is failed to run classlib tests over the DRLVM)

2006-12-12 Thread Stepan Mishura
On 12/13/06, Geir Magnusson Jr. wrote: Grrr. We had a thread last night "DRLVM broken on em64t" that you should read. Sorry, I hadn't read the discussion when I wrote about regression. In the end, what I was asking is if/how the behavior of GetSystemProperty() changed with our update to th

Re: [classlib][luni] update for bootstrapClassPath causes regression on DRL VM (was: Re: [drlvm][classlib] CC is failed to run classlib tests over the DRLVM)

2006-12-12 Thread Vladimir Ivanov
On 12/13/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote: Grrr. We had a thread last night "DRLVM broken on em64t" that you should read. In the end, what I was asking is if/how the behavior of GetSystemProperty() changed with our update to the property management inside of DRLVM, and the rami

Re: [classlib][luni] update for bootstrapClassPath causes regression on DRL VM (was: Re: [drlvm][classlib] CC is failed to run classlib tests over the DRLVM)

2006-12-12 Thread Geir Magnusson Jr.
Grrr. We had a thread last night "DRLVM broken on em64t" that you should read. In the end, what I was asking is if/how the behavior of GetSystemProperty() changed with our update to the property management inside of DRLVM, and the ramifications of that. Looking at Ollie's change in r486100,