Re: About *.out files in test/feature

I think we should remove them in "make distclean/clean" and .gitigore them also. ExternalSource/ans/exttab1.ans ExternalSource/sql/exttab1.sql UDF/ans/function_creation.ans UDF/sql/function_creation.sql feature-test testlib/ans/template.ans testlib/sql/template.sql By the way, if we remove all

sanity-check before running cases in feature-test

I have >1 times to encounter some feature test failures due to reported missing stuffs. e.g. 1. I did not have pl/python installed in my hawq build so UDF/sql/function_set_returning.sql fails to "create language plpythonu" This makes this case fails. 2. Sometimes I forgot to source a

Re: About *.out files in test/feature

BTW, is there any pre-processed file with extension .source which will be converted to sql file for testing? Should we also consider these auto-generated sql files? If so, maybe we should move these intermediate files to a temp dir, so that we can distinguish them from normal sql files. On Tue,

Re: About *.out files in test/feature

Note "make installcheck-good" output files (directory results) could be removed in "make clean" or "make distclean" also. 2016-07-12 13:35 GMT+08:00 Paul Guo : > Although gnu distclean means below, but the explananation is incomplete. > Things > > could be more complex than

Re: About *.out files in test/feature

Although gnu distclean means below, but the explananation is incomplete. Things could be more complex than simple configuration & build. Besides, We are not GNU programs so we do not have to 100% follow the GNU convention. The key point is that we need a target to make repo clean.

Re: About *.out files in test/feature

I would leave .diff file at least unmasked so that people could quickly find what cases failed. 2016-07-12 11:38 GMT+08:00 陶征霖 : > Besides .out, there also exists .diff, binary which should be ignored. > > 2016-07-12 11:32 GMT+08:00 Paul Guo : > > > I'd

Re: About *.out files in test/feature

I have thought about removing git-cloned repository after "make distclean", however considering git-clone is really time-consuming for some large project, I did not adopt the idea. 2016-07-12 12:18 GMT+08:00 Hong Wu : > BTW, since the make system is a little tricky in

Re: question on pg_hba.conf updates

Hi Radar and Vineet, One more, I think it should be good make pg_hba.conf visible and editable in Amabari. And it should be synced automatically with standby when pg_hba is modified by in master via Amabari. Thought? Jiali On Tue, Jul 12, 2016 at 12:24 PM, Radar Da lei wrote:

HAWQ JIRA: Consolidate 2.0.0 to 2.0.0.0-incubating version

As I mentioned before, we had a few versions in the current HAWQ JIRA version page. Particularly, there's confusion between 2.0.0.0-incubating (upcoming release that the community is driving to ship right now) vs. 2.0.0 (used originally for features post 2.0.0.0-incubating). When we created these

Re: About *.out files in test/feature

Very cool! On Tue, Jul 12, 2016 at 12:18 PM, Hong Wu wrote: > BTW, since the make system is a little tricky in HAWQ, I think `make > distclean` should also delete third-party libraries cloned during "make" > such as orca and so on. > > In conclusion, `make` should delete

Make Fix Version/s Column mandatory for HAWQ JIRAs

Hi, As release manager for HAWQ right now, I feel it's hard to track each JIRA for specific releases when we file JIRAs without "Fix Version/s" column filled. So I want to propose to make this column mandatory. If you don't know if the JIRA you filed will make a specific release, we can default

Re: About *.out files in test/feature

BTW, since the make system is a little tricky in HAWQ, I think `make distclean` should also delete third-party libraries cloned during "make" such as orca and so on. In conclusion, `make` should delete files generated from compiling. `make distclean` should return back to the original codebase to

Re: About *.out files in test/feature

I agree with ruilong. Make clean should clean files generated only in make process. Make distclean should clean files generated in make and configure process. xunzhang Send from my iPhone 发自我的 iPhone > 在 2016年7月12日，11:40，Ruilong Huo 写道： > > I think "make clean" should only

Re: About *.out files in test/feature

I think "make clean" should only clean the files generated during compile process. The *.out files are created by feature test code with psql, so I would prefer keep them. If you would like to clean them, that should be in feature test framework, not in makefile. Any comments? Best regards,

Re: About *.out files in test/feature

Besides .out, there also exists .diff, binary which should be ignored. 2016-07-12 11:32 GMT+08:00 Paul Guo : > I'd mask the output files after running feature tests in .gitignore and > clean it up after running "make clean" or "make distclean". Anyone has any > suggestions?

Re: About *.out files in test/feature

We indeed should delete these useless files after runing make clean or make distclean. On Tue, Jul 12, 2016 at 11:35 AM, Ming Li wrote: > LGTM. +1. > > On Tue, Jul 12, 2016 at 11:32 AM, Paul Guo wrote: > > > I'd mask the output files after running feature

Re: About *.out files in test/feature

LGTM. +1. On Tue, Jul 12, 2016 at 11:32 AM, Paul Guo wrote: > I'd mask the output files after running feature tests in .gitignore and > clean it up after running "make clean" or "make distclean". Anyone has any > suggestions? Thanks. > > diff --git

Re: question on pg_hba.conf updates

Hi Radar, I think we should add the scenario Ming described in document in case when master is crashed after user add some entries in pg_hba.conf. Thought? Jiali On Tue, Jul 12, 2016 at 11:12 AM, Radar Da lei wrote: > Hi Ming, > > If user manually added some entires into

Re: question on pg_hba.conf updates

Hi Ming, If user manually added some entires into pg_hba.conf and they want it be available after activated standby, then user need to add them to standby's pg_hba.conf as well. We do not do sync things for such case. Thanks. Regards, Radar On Tue, Jul 12, 2016 at 11:05 AM, Ming Li

Re: [VOTE] HAWQ 2.0.0-incubating Release

0. Yes, RAT check failures need to be handled. I do not know much about RAT but if we could just check affect files of one patch I'd 100% agree it is in CI. 1. Those "git-cloned" repo are "git-cloned" only when necessary (i.e. when related options are specified in configure command. 2.

Re: question on pg_hba.conf updates

Hi Vineet, While doing HAWQ cluster init, we will collect master/standby/segment ip addresses and update pg_hba.conf. After hawq init, content of 'pg_hba.conf' on each node should be different. When a cluster adding a new standby, this will get pg_hba.conf updated on all the nodes. Activate

Re: question on pg_hba.conf updates

So far as I know, there is no HAWQ management tools to update $MASTER_DATA_DIRECTORY/pg_hba.conf 2016-07-12 10:08 GMT+08:00 Vineet Goel : > Hi all, > > Question related to integration with Apache Ambari. > > It would be nice to make pg_hba.conf visible and editable in Ambari,

question on pg_hba.conf updates

Hi all, Question related to integration with Apache Ambari. It would be nice to make pg_hba.conf visible and editable in Ambari, so that Ambari allows one single interface for admins to update HAWQ and System configs such as hawq-site.xml, hawq-check.conf, sysctl.conf, limits.conf,

Re: [VOTE] HAWQ 2.0.0-incubating Release

Thanks! I've also filed https://issues.apache.org/jira/browse/HAWQ-914 which I would leave up to Goden to decide how blocking for the 2.0.0.0-incubating release it really is. And also https://issues.apache.org/jira/browse/HAWQ-915 which is definitely a blocker. Thanks, Roman. On Mon, Jul 11,

[jira] [Created] (HAWQ-915) RAT is failing on the latest master

Roman Shaposhnik created HAWQ-915: - Summary: RAT is failing on the latest master Key: HAWQ-915 URL: https://issues.apache.org/jira/browse/HAWQ-915 Project: Apache HAWQ Issue Type: Bug

Re: [VOTE] HAWQ 2.0.0-incubating Release

On Mon, Jul 11, 2016 at 2:27 AM, Radar Da lei wrote: > Hi Goden, > > I have pushed commits of 'HAWQ-892 > ' and 'HAWQ-901 > ' into branch > '2.0.0.0-incubating'. Ok, with these two

Re: [Propose] More data skipping technology for IO intensive performance enhancement

It seems the Dynamic partition pruning in impala is different from the DPE (dynamic partition elimination) in HAWQ, below is the feature description from impala roadmap (http://impala.io/overview.html). - Dynamic partition pruning - to perform data elimination of queries where the