[GitHub] incubator-hawq-docs pull request #120: HAWQ-1473 - document ranger plugin se...

2017-05-26 Thread ictmalili
Github user ictmalili commented on a diff in the pull request: https://github.com/apache/incubator-hawq-docs/pull/120#discussion_r118811032 --- Diff: markdown/ranger/ranger-integration-config.html.md.erb --- @@ -129,6 +129,62 @@ Once the connection between HAWQ and Ranger

[GitHub] incubator-hawq-docs pull request #120: HAWQ-1473 - document ranger plugin se...

2017-05-26 Thread ictmalili
Github user ictmalili commented on a diff in the pull request: https://github.com/apache/incubator-hawq-docs/pull/120#discussion_r11884 --- Diff: markdown/ranger/ranger-integration-config.html.md.erb --- @@ -129,6 +129,62 @@ Once the connection between HAWQ and Ranger

[GitHub] incubator-hawq-docs pull request #120: HAWQ-1473 - document ranger plugin se...

2017-05-26 Thread ictmalili
Github user ictmalili commented on a diff in the pull request: https://github.com/apache/incubator-hawq-docs/pull/120#discussion_r118810915 --- Diff: markdown/admin/MasterMirroring.html.md.erb --- @@ -103,6 +103,8 @@ Upon activation of the standby master, HAWQ reconstructs

[GitHub] incubator-hawq-docs pull request #17: Updates for hawq register

2016-09-28 Thread ictmalili
Github user ictmalili commented on a diff in the pull request: https://github.com/apache/incubator-hawq-docs/pull/17#discussion_r81051968 --- Diff: datamgmt/load/g-register_files.html.md.erb --- @@ -0,0 +1,214 @@ +--- +title: Registering Files into HAWQ Internal Tables

[GitHub] incubator-hawq-docs pull request #17: Updates for hawq register

2016-09-28 Thread ictmalili
Github user ictmalili commented on a diff in the pull request: https://github.com/apache/incubator-hawq-docs/pull/17#discussion_r81052024 --- Diff: reference/cli/admin_utilities/hawqregister.html.md.erb --- @@ -2,102 +2,84 @@ title: hawq register --- -Loads

[GitHub] incubator-hawq issue #692: HAWQ-780. Remove quicklz compression related code...

2016-06-07 Thread ictmalili
Github user ictmalili commented on the issue: https://github.com/apache/incubator-hawq/pull/692 LGTM. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq issue #690: HAWQ-778. Refine hawq register, add sanity checks...

2016-06-06 Thread ictmalili
Github user ictmalili commented on the issue: https://github.com/apache/incubator-hawq/pull/690 Have merged this pull request to hawq master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hawq issue #690: HAWQ-778. Refine hawq register, add sanity checks...

2016-06-06 Thread ictmalili
Github user ictmalili commented on the issue: https://github.com/apache/incubator-hawq/pull/690 @GodenYao Currently the implementation is by calling "dfs mv" command, this command doesn't support moving data file between clusters. If there's need for moving from another c

[GitHub] incubator-hawq pull request #690: HAWQ-778. Refine hawq register, add sanity...

2016-06-05 Thread ictmalili
Github user ictmalili commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/690#discussion_r65832341 --- Diff: tools/bin/hawqregister --- @@ -103,6 +113,61 @@ def check_hash_type(options, databasename, tablename): sys.exit(1

[GitHub] incubator-hawq pull request #690: HAWQ-778. Refine hawq register, add sanity...

2016-06-05 Thread ictmalili
Github user ictmalili commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/690#discussion_r65832309 --- Diff: tools/bin/hawqregister --- @@ -103,6 +113,61 @@ def check_hash_type(options, databasename, tablename): sys.exit(1

[GitHub] incubator-hawq issue #679: HAWQ-760. Add hawq register to support registerin...

2016-06-02 Thread ictmalili
Github user ictmalili commented on the issue: https://github.com/apache/incubator-hawq/pull/679 @shivzone Indeed if we further need to register file from other location, simple "mv" doesn't work. But I think in hdfs it works currently now. Btw,@shivzone, @changlei

[GitHub] incubator-hawq pull request #651: HAWQ-731. Implement Data Generator

2016-06-01 Thread ictmalili
Github user ictmalili closed the pull request at: https://github.com/apache/incubator-hawq/pull/651 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq issue #685: HAWQ-772. Hotfix for HAWQ-760 build.

2016-06-01 Thread ictmalili
Github user ictmalili commented on the issue: https://github.com/apache/incubator-hawq/pull/685 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request: HAWQ-768. Refactor c++ code for src/test/featur...

2016-05-31 Thread ictmalili
Github user ictmalili commented on the pull request: https://github.com/apache/incubator-hawq/pull/683 LGTM. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-hawq pull request: HAWQ-760. Add hawq register to suppor...

2016-05-31 Thread ictmalili
Github user ictmalili commented on the pull request: https://github.com/apache/incubator-hawq/pull/679#issuecomment-222642476 LGTM. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hawq pull request: HAWQ-760. Add hawq register to suppor...

2016-05-31 Thread ictmalili
Github user ictmalili commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/679#discussion_r65126753 --- Diff: tools/doc/hawqregister_help --- @@ -0,0 +1,101 @@ +COMMAND NAME: hawq register + +Register parquet files generated by other

[GitHub] incubator-hawq pull request: HAWQ-760. Add hawq register to suppor...

2016-05-31 Thread ictmalili
Github user ictmalili commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/679#discussion_r65126779 --- Diff: tools/doc/hawqregister_help --- @@ -0,0 +1,101 @@ +COMMAND NAME: hawq register + +Register parquet files generated by other

[GitHub] incubator-hawq pull request: HAWQ-760. Add hawq register to suppor...

2016-05-31 Thread ictmalili
Github user ictmalili commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/679#discussion_r65126732 --- Diff: tools/doc/hawqregister_help --- @@ -0,0 +1,101 @@ +COMMAND NAME: hawq register + +Register parquet files generated by other

[GitHub] incubator-hawq pull request: HAWQ-760. Add hawq register to suppor...

2016-05-30 Thread ictmalili
Github user ictmalili commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/679#discussion_r65126436 --- Diff: src/test/feature/testhawqregister/test-hawq-register.cpp --- @@ -0,0 +1,80 @@ +#include + +#include "lib/comm

[GitHub] incubator-hawq pull request: HAWQ-760. Add hawq register to suppor...

2016-05-30 Thread ictmalili
Github user ictmalili commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/679#discussion_r65126284 --- Diff: src/test/feature/testhawqregister/test-hawq-register.cpp --- @@ -0,0 +1,80 @@ +#include + +#include "lib/comm

[GitHub] incubator-hawq pull request: HAWQ-753. Add parquet test using new ...

2016-05-24 Thread ictmalili
Github user ictmalili commented on the pull request: https://github.com/apache/incubator-hawq/pull/673#issuecomment-221183052 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-hawq pull request: HAWQ-731. Implement Data Generator

2016-05-11 Thread ictmalili
GitHub user ictmalili opened a pull request: https://github.com/apache/incubator-hawq/pull/651 HAWQ-731. Implement Data Generator You can merge this pull request into a Git repository by running: $ git pull https://github.com/ictmalili/incubator-hawq HAWQ-731 Alternatively

[GitHub] incubator-hawq pull request: HAWQ-731. Implement Data Generator

2016-05-11 Thread ictmalili
Github user ictmalili closed the pull request at: https://github.com/apache/incubator-hawq/pull/650 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request: HAWQ-731. Implement Data Generator

2016-05-11 Thread ictmalili
GitHub user ictmalili opened a pull request: https://github.com/apache/incubator-hawq/pull/650 HAWQ-731. Implement Data Generator You can merge this pull request into a Git repository by running: $ git pull https://github.com/ictmalili/incubator-hawq HAWQ-731 Alternatively

[GitHub] incubator-hawq pull request: HAWQ-730. Add return code for PSQL.

2016-05-11 Thread ictmalili
Github user ictmalili commented on the pull request: https://github.com/apache/incubator-hawq/pull/649#issuecomment-218381202 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-hawq pull request: HAWQ-644. Account for '\0' when dispa...

2016-04-13 Thread ictmalili
Github user ictmalili commented on the pull request: https://github.com/apache/incubator-hawq/pull/604#issuecomment-209759488 LGTM. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hawq pull request: HAWQ-652. Slicemap in dispatch is mis...

2016-04-09 Thread ictmalili
Github user ictmalili commented on the pull request: https://github.com/apache/incubator-hawq/pull/579#issuecomment-207907764 LGTM. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hawq pull request: HAWQ-650. Redundent idle qe for copy ...

2016-04-09 Thread ictmalili
Github user ictmalili commented on the pull request: https://github.com/apache/incubator-hawq/pull/578#issuecomment-207904455 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-hawq pull request: HAWQ-630. Change QD lease heart-beat ...

2016-04-05 Thread ictmalili
Github user ictmalili commented on the pull request: https://github.com/apache/incubator-hawq/pull/559#issuecomment-206130269 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hawq pull request: HAWQ-625. Fix the build failure on MA...

2016-04-05 Thread ictmalili
Github user ictmalili closed the pull request at: https://github.com/apache/incubator-hawq/pull/554 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request: HAWQ-625. Fix the build failure on MA...

2016-04-04 Thread ictmalili
GitHub user ictmalili opened a pull request: https://github.com/apache/incubator-hawq/pull/554 HAWQ-625. Fix the build failure on MAC: function referenced before de… …claration You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-hawq pull request: Fix the build failure on MAC: functio...

2016-04-04 Thread ictmalili
Github user ictmalili closed the pull request at: https://github.com/apache/incubator-hawq/pull/553 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request: Fix the build failure on MAC: functio...

2016-04-04 Thread ictmalili
GitHub user ictmalili opened a pull request: https://github.com/apache/incubator-hawq/pull/553 Fix the build failure on MAC: function referenced before declaration You can merge this pull request into a Git repository by running: $ git pull https://github.com/ictmalili

[GitHub] incubator-hawq pull request: HAWQ-616 Mininum resource needed by c...

2016-03-31 Thread ictmalili
Github user ictmalili commented on the pull request: https://github.com/apache/incubator-hawq/pull/544#issuecomment-204216293 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-hawq pull request: Hawq 607

2016-03-31 Thread ictmalili
Github user ictmalili closed the pull request at: https://github.com/apache/incubator-hawq/pull/533 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request: HAWQ-592. QD shouldn't try to reconne...

2016-03-31 Thread ictmalili
Github user ictmalili closed the pull request at: https://github.com/apache/incubator-hawq/pull/532 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request: Hawq 607

2016-03-30 Thread ictmalili
GitHub user ictmalili opened a pull request: https://github.com/apache/incubator-hawq/pull/533 Hawq 607 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ictmalili/incubator-hawq HAWQ-607 Alternatively you can review and apply

[GitHub] incubator-hawq pull request: HAWQ-572. Add fault injection in parq...

2016-03-28 Thread ictmalili
Github user ictmalili commented on the pull request: https://github.com/apache/incubator-hawq/pull/510#issuecomment-202695092 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-hawq pull request: HAWQ-568. Check validation the QD to ...

2016-03-28 Thread ictmalili
Github user ictmalili closed the pull request at: https://github.com/apache/incubator-hawq/pull/526 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request: HAWQ-591. Explain analyze doesn't ent...

2016-03-28 Thread ictmalili
Github user ictmalili closed the pull request at: https://github.com/apache/incubator-hawq/pull/509 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request: HAWQ-598. Initialize dispatchResult d...

2016-03-28 Thread ictmalili
Github user ictmalili closed the pull request at: https://github.com/apache/incubator-hawq/pull/520 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request: HAWQ-598. Initialize dispatchResult d...

2016-03-28 Thread ictmalili
GitHub user ictmalili opened a pull request: https://github.com/apache/incubator-hawq/pull/520 HAWQ-598. Initialize dispatchResult during makeCdbCopy You can merge this pull request into a Git repository by running: $ git pull https://github.com/ictmalili/incubator-hawq HAWQ

[GitHub] incubator-hawq pull request: HAWQ-559. Fix QD hang when QE is imme...

2016-03-22 Thread ictmalili
Github user ictmalili closed the pull request at: https://github.com/apache/incubator-hawq/pull/472 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request: Hawq 572

2016-03-22 Thread ictmalili
Github user ictmalili commented on the pull request: https://github.com/apache/incubator-hawq/pull/482#issuecomment-199703478 LGTM. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hawq pull request: HAWQ-574. Fix memory leak in dispatch...

2016-03-22 Thread ictmalili
GitHub user ictmalili opened a pull request: https://github.com/apache/incubator-hawq/pull/483 HAWQ-574. Fix memory leak in dispatcher You can merge this pull request into a Git repository by running: $ git pull https://github.com/ictmalili/incubator-hawq HAWQ-574

[GitHub] incubator-hawq pull request: HAWQ-566. Fix analyze and truncate hu...

2016-03-21 Thread ictmalili
Github user ictmalili commented on the pull request: https://github.com/apache/incubator-hawq/pull/476#issuecomment-199181684 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-hawq pull request: HAWQ-562. Refactor bucket number of e...

2016-03-21 Thread ictmalili
Github user ictmalili commented on the pull request: https://github.com/apache/incubator-hawq/pull/475#issuecomment-199174719 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-hawq pull request: HAWQ-544. Fixed assertion failure in ...

2016-03-20 Thread ictmalili
Github user ictmalili commented on the pull request: https://github.com/apache/incubator-hawq/pull/454#issuecomment-199085185 @foyzur , Got it. Thanks :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-hawq pull request: HAWQ-561. Wrongly check variance of n...

2016-03-19 Thread ictmalili
Github user ictmalili commented on the pull request: https://github.com/apache/incubator-hawq/pull/471#issuecomment-198244861 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-hawq pull request: HAWQ-559. Fix QD hang when QE is imme...

2016-03-19 Thread ictmalili
GitHub user ictmalili opened a pull request: https://github.com/apache/incubator-hawq/pull/472 HAWQ-559. Fix QD hang when QE is immediately killed after created Add errcode for executor after QD thread detects QE is no longer exists in function executormgr_is_dispatchable. You

[GitHub] incubator-hawq pull request: HAWQ-552. long latency of dispatching...

2016-03-19 Thread ictmalili
Github user ictmalili commented on the pull request: https://github.com/apache/incubator-hawq/pull/464#issuecomment-198157198 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-hawq pull request: HAWQ-523. Remove dead code in executo...

2016-03-16 Thread ictmalili
Github user ictmalili closed the pull request at: https://github.com/apache/incubator-hawq/pull/441 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request: HAWQ-524. Modify processing for cdbDi...

2016-03-16 Thread ictmalili
Github user ictmalili closed the pull request at: https://github.com/apache/incubator-hawq/pull/444 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request: HAWQ-509. Change pg_stat_activity def...

2016-03-16 Thread ictmalili
Github user ictmalili closed the pull request at: https://github.com/apache/incubator-hawq/pull/428 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request: HAWQ-544. Fixed assertion failure in ...

2016-03-15 Thread ictmalili
Github user ictmalili commented on the pull request: https://github.com/apache/incubator-hawq/pull/454#issuecomment-197159124 @gcaragea Does this function HandleMemoryAccountingGenerationOverflow(TopMemoryContext) consumes memory? If not, I think the modification is good to me

[GitHub] incubator-hawq pull request: HAWQ-528. Reset gp_connections_per_th...

2016-03-14 Thread ictmalili
GitHub user ictmalili opened a pull request: https://github.com/apache/incubator-hawq/pull/445 HAWQ-528. Reset gp_connections_per_thread for dispatcher guc range Reset gp_connections_per_thread for dispatcher guc range from 1 to 512, 0 is invalid. You can merge this pull request

[GitHub] incubator-hawq pull request: HAWQ-526. Resource queue total resour...

2016-03-13 Thread ictmalili
Github user ictmalili commented on the pull request: https://github.com/apache/incubator-hawq/pull/442#issuecomment-196148807 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-hawq pull request: HAWQ-523. Remove dead code in executo...

2016-03-13 Thread ictmalili
GitHub user ictmalili opened a pull request: https://github.com/apache/incubator-hawq/pull/441 HAWQ-523. Remove dead code in executormgr Remove dead code in executormgr You can merge this pull request into a Git repository by running: $ git pull https://github.com/ictmalili

[GitHub] incubator-hawq pull request: HAWQ-525. query dispatcher heart-beat...

2016-03-13 Thread ictmalili
Github user ictmalili commented on the pull request: https://github.com/apache/incubator-hawq/pull/440#issuecomment-196119814 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-hawq pull request: HAWQ-510. Change cdbProc->listenerAdd...

2016-03-10 Thread ictmalili
Github user ictmalili closed the pull request at: https://github.com/apache/incubator-hawq/pull/429 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request: HAWQ-510. Change cdbProc->listenerAdd...

2016-03-09 Thread ictmalili
GitHub user ictmalili opened a pull request: https://github.com/apache/incubator-hawq/pull/429 HAWQ-510. Change cdbProc->listenerAddr to "localhost" on entryDB when… HAWQ-510. Change cdbProc->listenerAddr to "localhost" on entryDB when it tries t

[GitHub] incubator-hawq pull request: HAWQ-509. Change pg_stat_activity def...

2016-03-09 Thread ictmalili
GitHub user ictmalili opened a pull request: https://github.com/apache/incubator-hawq/pull/428 HAWQ-509. Change pg_stat_activity definition, only returns one record… Change pg_stat_activity definition, only returns one record for one query. You can merge this pull request

[GitHub] incubator-hawq pull request: HAWQ-483. Fix bug for Error in debug1...

2016-03-02 Thread ictmalili
Github user ictmalili commented on the pull request: https://github.com/apache/incubator-hawq/pull/406#issuecomment-191592877 Looks good to me. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-hawq pull request: HAWQ-481. Optimise analyse virtual se...

2016-03-02 Thread ictmalili
Github user ictmalili commented on the pull request: https://github.com/apache/incubator-hawq/pull/403#issuecomment-191528578 Looks good to me now. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-hawq pull request: HAWQ-481. Optimise analyse virtual se...

2016-03-02 Thread ictmalili
Github user ictmalili commented on the pull request: https://github.com/apache/incubator-hawq/pull/403#issuecomment-191526684 In function calculate_virtual_segment_number , what if the former table has larger bucket num, but the latter table has smaller one? maxHashBucketNumber

[GitHub] incubator-hawq pull request: HAWQ-458. Wrongly judge validate conn...

2016-02-25 Thread ictmalili
Github user ictmalili commented on the pull request: https://github.com/apache/incubator-hawq/pull/390#issuecomment-189074728 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hawq pull request: Hawq438 EagerlyReleased hash table in...

2016-02-22 Thread ictmalili
Github user ictmalili commented on the pull request: https://github.com/apache/incubator-hawq/pull/370#issuecomment-187547345 It looks good to me. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-hawq pull request:

2016-02-19 Thread ictmalili
Github user ictmalili commented on the pull request: https://github.com/apache/incubator-hawq/commit/e427c9cddb9790f9755446c5e8105d5eb4c48b48#commitcomment-16198598 I have extracted the repeated code out of the two functions: dispatcherAYT and executormgr_validate_conn

[GitHub] incubator-hawq pull request: HAWQ-275. Add connection check when d...

2016-02-18 Thread ictmalili
Github user ictmalili commented on the pull request: https://github.com/apache/incubator-hawq/pull/357#issuecomment-186053153 Yes, I'll add that errno check errno == EWOULDBLOCK in the code. And seems that EAGAIN and EWOULDBLOCK often return same values. --- If your project is set

[GitHub] incubator-hawq pull request: HAWQ-275. Add connection check when d...

2016-02-18 Thread ictmalili
Github user ictmalili commented on the pull request: https://github.com/apache/incubator-hawq/pull/357#issuecomment-186040416 Yes, function executormgr_validate_conn and dispatcherAYT have repeated code, but I'm not sure whether we can merge the two functions into one since

[GitHub] incubator-hawq pull request: HAWQ-275. Add connection check when d...

2016-02-18 Thread ictmalili
GitHub user ictmalili opened a pull request: https://github.com/apache/incubator-hawq/pull/357 HAWQ-275. Add connection check when dispatcher wants to reuse the QE forked by former queries, and when dispather dispatches the detailed query command to QE Add connection check when