[GitHub] incubator-hawq-docs pull request #46: HAWQ-1119 - create doc content for PXF...

2017-01-13 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq-docs/pull/46#discussion_r96090205 --- Diff: markdown/pxf/HDFSWritablePXF.html.md.erb --- @@ -0,0 +1,416 @@ +--- +title: Writing Data to HDFS +--- + +The PXF

[GitHub] incubator-hawq-docs pull request #46: HAWQ-1119 - create doc content for PXF...

2017-01-13 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq-docs/pull/46#discussion_r96086612 --- Diff: markdown/pxf/HDFSWritablePXF.html.md.erb --- @@ -0,0 +1,416 @@ +--- +title: Writing Data to HDFS +--- + +The PXF

[GitHub] incubator-hawq-docs pull request #46: HAWQ-1119 - create doc content for PXF...

2017-01-13 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq-docs/pull/46#discussion_r96086235 --- Diff: markdown/pxf/HDFSWritablePXF.html.md.erb --- @@ -0,0 +1,416 @@ +--- +title: Writing Data to HDFS +--- + +The PXF

[GitHub] incubator-hawq-docs pull request #39: HAWQ-1071 - add examples for HiveText ...

2016-10-27 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq-docs/pull/39#discussion_r85378363 --- Diff: pxf/HivePXF.html.md.erb --- @@ -339,21 +601,21 @@ postgres=# CREATE EXTERNAL TABLE pxf_sales_part( delivery_state TEXT

[GitHub] incubator-hawq-docs pull request #39: HAWQ-1071 - add examples for HiveText ...

2016-10-27 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq-docs/pull/39#discussion_r85376355 --- Diff: pxf/HivePXF.html.md.erb --- @@ -2,121 +2,450 @@ title: Accessing Hive Data --- -This topic describes how to access

[GitHub] incubator-hawq-docs pull request #39: HAWQ-1071 - add examples for HiveText ...

2016-10-27 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq-docs/pull/39#discussion_r85376289 --- Diff: pxf/HivePXF.html.md.erb --- @@ -2,121 +2,450 @@ title: Accessing Hive Data --- -This topic describes how to access

[GitHub] incubator-hawq-docs pull request #33: HAWQ-1107 - enhance PXF HDFS plugin do...

2016-10-27 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq-docs/pull/33#discussion_r85375160 --- Diff: pxf/HDFSFileDataPXF.html.md.erb --- @@ -2,506 +2,449 @@ title: Accessing HDFS File Data --- -## Prerequisites

[GitHub] incubator-hawq-docs pull request #33: HAWQ-1107 - enhance PXF HDFS plugin do...

2016-10-27 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq-docs/pull/33#discussion_r85362806 --- Diff: pxf/HDFSFileDataPXF.html.md.erb --- @@ -2,506 +2,449 @@ title: Accessing HDFS File Data --- -## Prerequisites

[GitHub] incubator-hawq-docs pull request #33: HAWQ-1107 - enhance PXF HDFS plugin do...

2016-10-27 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq-docs/pull/33#discussion_r85358483 --- Diff: pxf/HDFSFileDataPXF.html.md.erb --- @@ -2,506 +2,449 @@ title: Accessing HDFS File Data --- -## Prerequisites

[GitHub] incubator-hawq-docs pull request #33: HAWQ-1107 - enhance PXF HDFS plugin do...

2016-10-27 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq-docs/pull/33#discussion_r85362384 --- Diff: pxf/HDFSFileDataPXF.html.md.erb --- @@ -2,506 +2,449 @@ title: Accessing HDFS File Data --- -## Prerequisites

[GitHub] incubator-hawq-docs pull request #33: HAWQ-1107 - enhance PXF HDFS plugin do...

2016-10-27 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq-docs/pull/33#discussion_r85361807 --- Diff: pxf/HDFSFileDataPXF.html.md.erb --- @@ -2,506 +2,449 @@ title: Accessing HDFS File Data --- -## Prerequisites

[GitHub] incubator-hawq pull request #604: HAWQ-644. Account for '\0' when dispatchin...

2016-06-07 Thread kavinderd
Github user kavinderd closed the pull request at: https://github.com/apache/incubator-hawq/pull/604 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq issue #604: HAWQ-644. Account for '\0' when dispatching names...

2016-06-07 Thread kavinderd
Github user kavinderd commented on the issue: https://github.com/apache/incubator-hawq/pull/604 Merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request: HAWQ-703. Serialize HCatalog Complex ...

2016-05-09 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/633#discussion_r62552154 --- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/HiveUtilities.java --- @@ -102,80 +103,49 @@ public static Table

[GitHub] incubator-hawq pull request: HAWQ-703. Serialize HCatalog Complex ...

2016-05-09 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/633#discussion_r62551107 --- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/EnumHiveToHawqType.java --- @@ -0,0 +1,113

[GitHub] incubator-hawq pull request: HAWQ-683. Fix param name for Protocol...

2016-04-19 Thread kavinderd
Github user kavinderd commented on the pull request: https://github.com/apache/incubator-hawq/pull/625#issuecomment-212172407 Looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hawq pull request: HAWQ-683. Fix param name for Protocol...

2016-04-19 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/625#discussion_r60330704 --- Diff: pxf/pxf-hdfs/src/main/java/org/apache/hawq/pxf/plugins/hdfs/AvroResolver.java --- @@ -152,7 +152,7 @@ boolean isAvroFile

[GitHub] incubator-hawq pull request: HAWQ-681. Removed hcatalog_enable GUC...

2016-04-18 Thread kavinderd
Github user kavinderd commented on the pull request: https://github.com/apache/incubator-hawq/pull/621#issuecomment-211606168 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hawq pull request: HAWQ-644. Account for '\0' when dispa...

2016-04-14 Thread kavinderd
Github user kavinderd commented on the pull request: https://github.com/apache/incubator-hawq/pull/604#issuecomment-210194710 @ictmalili @ztao1987 Please review use of MessageContext for `dfs_address` in `RebuildNamespace` --- If your project is set up for it, you can reply

[GitHub] incubator-hawq pull request: HAWQ-462. Dispatch dfs_address from m...

2016-04-13 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/503#discussion_r59660368 --- Diff: src/bin/gpfusion/gpbridgeapi.c --- @@ -536,3 +536,8 @@ void free_token_resources(PxfInputData *inputData) pfree(inputData

[GitHub] incubator-hawq pull request: HAWQ-462. Dispatch dfs_address from m...

2016-04-13 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/503#discussion_r59659935 --- Diff: src/bin/gpfusion/gpbridgeapi.c --- @@ -536,3 +536,8 @@ void free_token_resources(PxfInputData *inputData) pfree(inputData

[GitHub] incubator-hawq pull request: HAWQ-462. Dispatch dfs_address from m...

2016-04-13 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/503#discussion_r59659665 --- Diff: src/backend/cdb/cdbquerycontextdispatching.c --- @@ -770,6 +770,30 @@ RebuildTupleForRelation(QueryContextInfo *cxt

[GitHub] incubator-hawq pull request: HAWQ-644. Account for '\0' when dispa...

2016-04-13 Thread kavinderd
Github user kavinderd commented on the pull request: https://github.com/apache/incubator-hawq/pull/604#issuecomment-209679799 @sansanichfb We should add some, but need to run in a secure environment. --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-hawq pull request: HAWQ-644. Account for '\0' when dispa...

2016-04-13 Thread kavinderd
GitHub user kavinderd opened a pull request: https://github.com/apache/incubator-hawq/pull/604 HAWQ-644. Account for '\0' when dispatching namespace length You can merge this pull request into a Git repository by running: $ git pull https://github.com/kavinderd/incubator-hawq

[GitHub] incubator-hawq pull request: HAWQ-628. Return -1 instead of error.

2016-04-12 Thread kavinderd
Github user kavinderd commented on the pull request: https://github.com/apache/incubator-hawq/pull/595#issuecomment-209089547 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hawq pull request: HAWQ-462. Dispatch dfs_address from m...

2016-04-04 Thread kavinderd
Github user kavinderd commented on the pull request: https://github.com/apache/incubator-hawq/pull/503#issuecomment-205460332 Merged into master by @shivzone [here](https://github.com/apache/incubator-hawq/commit/59ebfa7072621117827ae3d9464c971a61919672) --- If your project is set

[GitHub] incubator-hawq pull request: Writable security fix

2016-03-25 Thread kavinderd
Github user kavinderd closed the pull request at: https://github.com/apache/incubator-hawq/pull/497 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request: Writable security fix

2016-03-25 Thread kavinderd
Github user kavinderd commented on the pull request: https://github.com/apache/incubator-hawq/pull/497#issuecomment-201477135 Closing since https://github.com/apache/incubator-hawq/pull/503 is a more complete solution --- If your project is set up for it, you can reply to this email

[GitHub] incubator-hawq pull request: HAWQ-462. Dispatch dfs_address from m...

2016-03-24 Thread kavinderd
Github user kavinderd commented on the pull request: https://github.com/apache/incubator-hawq/pull/503#issuecomment-201131567 In the non-secure case the `dfs_address` is not serialized and dispatched from the master so on the segment the global var will just be `NULL` --- If your

[GitHub] incubator-hawq pull request: HAWQ-462. Dispatch dfs_address from m...

2016-03-24 Thread kavinderd
Github user kavinderd commented on the pull request: https://github.com/apache/incubator-hawq/pull/503#issuecomment-201097871 @hornn @shivzone Alternate implementation that handles both readable and writable case by setting a global var on segment after deserialization I

[GitHub] incubator-hawq pull request: HAWQ-462. Dispatch dfs_address from m...

2016-03-24 Thread kavinderd
GitHub user kavinderd opened a pull request: https://github.com/apache/incubator-hawq/pull/503 HAWQ-462. Dispatch dfs_address from master to segment in pxf secure f… …ilesystem case Set global var dfs_address on segment after deserialization You can merge this pull

[GitHub] incubator-hawq pull request: Writable security fix

2016-03-24 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/497#discussion_r57326498 --- Diff: src/backend/gpopt/ivy.xml --- @@ -38,7 +38,7 @@ under the License. - + --- End diff

[GitHub] incubator-hawq pull request: Writable security fix

2016-03-24 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/497#discussion_r57324733 --- Diff: src/backend/cdb/cdbquerycontextdispatching.c --- @@ -102,7 +102,7 @@ int QueryContextDispatchingSizeMemoryLimit = 100 * 1024; /* KB

[GitHub] incubator-hawq pull request: Writable security fix

2016-03-24 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/497#discussion_r57322793 --- Diff: src/backend/access/external/hd_work_mgr.c --- @@ -768,6 +769,16 @@ make_allocation_output_string(List *segment_fragments

[GitHub] incubator-hawq pull request: Writable security fix

2016-03-24 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/497#discussion_r57322366 --- Diff: src/backend/access/external/fileam.c --- @@ -681,6 +687,8 @@ external_insert(ExternalInsertDesc extInsertDesc, HeapTuple instup

[GitHub] incubator-hawq pull request: Writable security fix

2016-03-24 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/497#discussion_r57322304 --- Diff: src/bin/gpupgrade/crc32c.c --- @@ -0,0 +1 @@ +../../../src/backend/utils/hash/crc32c.c --- End diff -- They're

[GitHub] incubator-hawq pull request: Writable security fix

2016-03-24 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/497#discussion_r57322156 --- Diff: src/include/access/fileam.h --- @@ -44,12 +44,13 @@ * ExternalInsertDescData is used for storing state related * to inserting

[GitHub] incubator-hawq pull request: Writable security fix

2016-03-24 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/497#discussion_r57322038 --- Diff: src/bin/gpfusion/gpbridgeapi.c --- @@ -273,6 +277,26 @@ void gpbridge_export_start(PG_FUNCTION_ARGS) } +void

[GitHub] incubator-hawq pull request: Writable security fix

2016-03-23 Thread kavinderd
Github user kavinderd commented on the pull request: https://github.com/apache/incubator-hawq/pull/497#issuecomment-200588159 @hornn please take a look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-hawq pull request: Writable security fix

2016-03-23 Thread kavinderd
GitHub user kavinderd reopened a pull request: https://github.com/apache/incubator-hawq/pull/497 Writable security fix You can merge this pull request into a Git repository by running: $ git pull https://github.com/kavinderd/incubator-hawq writable_security_fix Alternatively

[GitHub] incubator-hawq pull request: Writable security fix

2016-03-23 Thread kavinderd
Github user kavinderd closed the pull request at: https://github.com/apache/incubator-hawq/pull/497 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request: HAWQ-432. Memory leaks in pg_regress.

2016-02-22 Thread kavinderd
Github user kavinderd commented on the pull request: https://github.com/apache/incubator-hawq/pull/368#issuecomment-187453882 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hawq pull request: HAWQ-400. Support expected exit codes...

2016-02-16 Thread kavinderd
Github user kavinderd commented on the pull request: https://github.com/apache/incubator-hawq/pull/347#issuecomment-185045024 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature