Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq-docs/pull/126#discussion_r124423336
--- Diff: markdown/pxf/ReadWritePXF.html.md.erb ---
@@ -105,6 +105,18 @@ Note: The DELIMITER
parameter is mandatory
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq-docs/pull/126#discussion_r124423088
--- Diff: markdown/pxf/HivePXF.html.md.erb ---
@@ -495,9 +500,16 @@ Use the `HiveORC` profile to access ORC format data.
The `HiveORC
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq-docs/pull/126#discussion_r124423164
--- Diff: markdown/pxf/HivePXF.html.md.erb ---
@@ -565,6 +577,44 @@ In the following example, you will create a Hive table
stored in ORC
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq-docs/pull/101#discussion_r105483266
--- Diff: markdown/plext/using_plpgsql.html.md.erb ---
@@ -19,143 +19,283 @@ software distributed under the License is distributed
on an
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq-docs/pull/101#discussion_r105477434
--- Diff: markdown/plext/using_plpgsql.html.md.erb ---
@@ -19,143 +19,283 @@ software distributed under the License is distributed
on an
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq-docs/pull/94#discussion_r99970872
--- Diff: markdown/pxf/ReadWritePXF.html.md.erb ---
@@ -131,6 +149,8 @@ Note: The DELIMITER
parameter is mandatory
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq-docs/pull/63#discussion_r89021822
--- Diff: pxf/HivePXF.html.md.erb ---
@@ -553,7 +569,7 @@ Alternatively, you can use the `pxf_get_item_fields`
user-defined function (UDF
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq-docs/pull/63#discussion_r89021235
--- Diff: pxf/HivePXF.html.md.erb ---
@@ -495,24 +511,24 @@ postgres=# SELECT * FROM hcatalog.default.sales_info;
To obtain a
Github user sansanichfb commented on the pull request:
https://github.com/apache/incubator-hawq/pull/302#issuecomment-220192722
Merging this PR, will address bytea type in separate story.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/302#discussion_r63605864
--- Diff:
pxf/pxf-json/src/main/java/org/apache/hawq/pxf/plugins/json/JsonResolver.java
---
@@ -0,0 +1,256 @@
+package
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/633#discussion_r62571923
--- Diff:
pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/HiveUtilities.java
---
@@ -102,80 +103,49 @@ public static Table
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/633#discussion_r62565599
--- Diff:
pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/EnumHiveToHawqType.java
---
@@ -0,0 +1,113
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/633#discussion_r61978916
--- Diff:
pxf/pxf-service/src/test/java/org/apache/hawq/pxf/service/MetadataResponseFormatterTest.java
---
@@ -85,26 +86,45 @@ public void
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/633#discussion_r61978803
--- Diff:
pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/EnumHiveToHawqType.java
---
@@ -0,0 +1,112
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/633#discussion_r61976525
--- Diff:
pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/utilities/EnumHawqType.java
---
@@ -0,0 +1,105 @@
+/*
+ * Licensed to the
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/633#discussion_r61976195
--- Diff:
pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/HiveUtilities.java
---
@@ -186,7 +155,7 @@ public static Table
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/633#discussion_r61975914
--- Diff:
pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/HiveUtilities.java
---
@@ -88,94 +90,61 @@ public static Table
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/633#discussion_r61975316
--- Diff: pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/Metadata.java
---
@@ -67,36 +68,43 @@ public String toString
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/633#discussion_r61972982
--- Diff: pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/Metadata.java
---
@@ -67,36 +68,43 @@ public String toString
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/633#discussion_r61972977
--- Diff: pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/Metadata.java
---
@@ -67,36 +68,43 @@ public String toString
GitHub user sansanichfb opened a pull request:
https://github.com/apache/incubator-hawq/pull/633
HAWQ-703. Serialize HCatalog Complex Types to plain text (as Hive proâ¦
â¦file).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user sansanichfb opened a pull request:
https://github.com/apache/incubator-hawq/pull/628
HAWQ-705. Fixed aggregation on psql for Hive tables.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-hawq HAWQ-705
Github user sansanichfb commented on the pull request:
https://github.com/apache/incubator-hawq-site/pull/6#issuecomment-213176265
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq-site/pull/6#discussion_r60676146
--- Diff: index.html ---
@@ -233,6 +233,7 @@ Contribute to Advanced
Enterprise Technology!
— https://cwiki.apache.org
Github user sansanichfb commented on the pull request:
https://github.com/apache/incubator-hawq-site/pull/3#issuecomment-213148202
Merged, @xinzweb you can close it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user sansanichfb commented on the pull request:
https://github.com/apache/incubator-hawq-site/pull/5#issuecomment-213130367
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user sansanichfb commented on the pull request:
https://github.com/apache/incubator-hawq/pull/625#issuecomment-212172887
Might be useful to have @version tag in each file, but do not add it
manually to each class, but just substituting it on some build phase, reading
current
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/621#discussion_r60287263
--- Diff: src/test/regress/input/hcatalog_lookup.source ---
@@ -2,16 +2,9 @@
-- test hcatalog lookup
GitHub user sansanichfb opened a pull request:
https://github.com/apache/incubator-hawq/pull/621
HAWQ-681. Removed hcatalog_enable GUC.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-hawq HAWQ-681
Github user sansanichfb commented on the pull request:
https://github.com/apache/incubator-hawq/pull/604#issuecomment-209679145
Any regression tests needed to cover edge case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user sansanichfb closed the pull request at:
https://github.com/apache/incubator-hawq/pull/595
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/595#discussion_r59462863
--- Diff: src/backend/utils/adt/dbsize.c ---
@@ -180,9 +180,7 @@ calculate_database_size(Oid dbOid)
Assert(Gp_role != GP_ROLE_EXECUTE
GitHub user sansanichfb opened a pull request:
https://github.com/apache/incubator-hawq/pull/595
HAWQ-628. Return -1 instead of error.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-hawq HAWQ-628
Alternatively
Github user sansanichfb commented on the pull request:
https://github.com/apache/incubator-hawq/pull/551#issuecomment-205532919
LGTM other than small cosmetic comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/551#discussion_r58462813
--- Diff:
pxf/pxf-hive/src/test/java/org/apache/hawq/pxf/plugins/hive/HiveMetadataFetcherTest.java
---
@@ -154,6 +155,115 @@ public void
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/551#discussion_r58462587
--- Diff:
pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveMetadataFetcher.java
---
@@ -50,9 +50,21 @@ public HiveMetadataFetcher
GitHub user sansanichfb opened a pull request:
https://github.com/apache/incubator-hawq/pull/542
HAWQ-546. Implemented call of pxf_get_object_fields for Hive on psql.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache
Github user sansanichfb closed the pull request at:
https://github.com/apache/incubator-hawq/pull/529
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/529#discussion_r57978149
--- Diff: src/bin/psql/describe.c ---
@@ -1152,6 +1157,15 @@ describeTableDetails(const char *pattern, bool
verbose, bool showSystem
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/529#discussion_r57978187
--- Diff: src/bin/psql/describe.c ---
@@ -4213,3 +4227,100 @@ printACLColumn(PQExpBuffer buf, const char *colname
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/529#discussion_r57978158
--- Diff: src/bin/psql/describe.c ---
@@ -4213,3 +4227,100 @@ printACLColumn(PQExpBuffer buf, const char *colname
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/529#discussion_r57978181
--- Diff: src/bin/psql/describe.c ---
@@ -4213,3 +4227,100 @@ printACLColumn(PQExpBuffer buf, const char *colname
Github user sansanichfb commented on the pull request:
https://github.com/apache/incubator-hawq/pull/529#issuecomment-203626175
@shivzone please take a look at JIRA description -
https://issues.apache.org/jira/browse/HAWQ-546
---
If your project is set up for it, you can reply to
GitHub user sansanichfb opened a pull request:
https://github.com/apache/incubator-hawq/pull/529
Hawq 546
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-hawq HAWQ-546
Alternatively you can review and apply
Github user sansanichfb commented on the pull request:
https://github.com/apache/incubator-hawq/pull/522#issuecomment-202665815
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/522#discussion_r57663034
--- Diff:
pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/MetadataResponseFormatter.java
---
@@ -46,76 +45,49 @@
* @return
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/522#discussion_r57662935
--- Diff:
pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/MetadataResponse.java
---
@@ -0,0 +1,94 @@
+package
GitHub user sansanichfb opened a pull request:
https://github.com/apache/incubator-hawq/pull/524
HAWQ-599. Fixed coverity issues.
We were carrying character buffer size of 64k over stack which was
unnecessary because it was used in method pxfutils.process_request only, moved
it
Github user sansanichfb closed the pull request at:
https://github.com/apache/incubator-hawq/pull/479
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/479#discussion_r57248626
--- Diff: src/test/regress/output/json_load.source ---
@@ -184,7 +184,7 @@ END TRANSACTION;
-- negative test: duplicated tables
BEGIN
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/479#discussion_r57227829
--- Diff: src/backend/utils/adt/pxf_functions.c ---
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user sansanichfb commented on the pull request:
https://github.com/apache/incubator-hawq/pull/477#issuecomment-200515990
+1, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/477#discussion_r57224267
--- Diff:
pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/HiveUtilities.java
---
@@ -203,19 +205,37 @@ private static
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/479#discussion_r57223075
--- Diff: src/include/catalog/namespace.h ---
@@ -95,4 +95,6 @@ extern char *namespace_search_path;
extern List *fetch_search_path(bool
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/479#discussion_r57093559
--- Diff: src/test/unit/mock/backend/utils/adt/pxf_functions_mock.c ---
@@ -0,0 +1,58 @@
+/*
--- End diff --
Makes sense
Github user sansanichfb commented on the pull request:
https://github.com/apache/incubator-hawq/pull/479#issuecomment-200087621
@hornn we are not caching metadata in this stored procedure, we just use
the same code path as for select from Hive tables, also we made it more
generic
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/479#discussion_r57090315
--- Diff: src/backend/utils/adt/pxf_functions.c ---
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/479#discussion_r57090072
--- Diff: src/include/catalog/namespace.h ---
@@ -95,4 +95,6 @@ extern char *namespace_search_path;
extern List *fetch_search_path(bool
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/479#discussion_r57089941
--- Diff: src/backend/utils/adt/pxf_functions.c ---
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/479#discussion_r57089873
--- Diff: src/backend/utils/adt/pxf_functions.c ---
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/479#discussion_r57089759
--- Diff: src/backend/utils/adt/pxf_functions.c ---
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/479#discussion_r57089286
--- Diff: src/backend/catalog/external/externalmd.c ---
@@ -129,45 +135,45 @@ HCatalogTable *ParseHCatalogTable(struct json_object
*hcatalogMD
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/479#discussion_r57089182
--- Diff: src/backend/catalog/external/externalmd.c ---
@@ -45,22 +46,25 @@
#include "utils/numeric.h"
#include &q
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/477#discussion_r57088397
--- Diff:
pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/HiveUtilities.java
---
@@ -203,19 +205,37 @@ private static
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/479#discussion_r57063009
--- Diff: src/backend/catalog/external/externalmd.c ---
@@ -23,10 +23,12 @@
* Author: antova
*
*
- * Utilities
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/479#discussion_r57062325
--- Diff: src/backend/catalog/external/externalmd.c ---
@@ -438,18 +444,18 @@ void LoadHCatalogColumns(Oid relid, List *columns
GitHub user sansanichfb opened a pull request:
https://github.com/apache/incubator-hawq/pull/479
HAWQ-465. Implement stored procedure to return fields metainfo from PXF.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user sansanichfb commented on the pull request:
https://github.com/apache/incubator-hawq/pull/477#issuecomment-199538669
We are introducing API change, so we should bump up pxfProtocolVersion in
gradle.properties.
---
If your project is set up for it, you can reply to this
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/477#discussion_r56916362
--- Diff:
pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/utilities/ProtocolData.java
---
@@ -95,6 +95,7 @@ public ProtocolData(Map
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/477#discussion_r56916449
--- Diff: pxf/pxf-service/src/main/resources/pxf-profiles-default.xml ---
@@ -49,11 +49,12 @@ under the License
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/477#discussion_r56915071
--- Diff:
pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/HiveUtilities.java
---
@@ -225,15 +245,53 @@ private static
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/477#discussion_r56914927
--- Diff:
pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/HiveUtilities.java
---
@@ -225,15 +245,53 @@ private static
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/477#discussion_r56914675
--- Diff:
pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/HiveUtilities.java
---
@@ -203,19 +205,37 @@ private static
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/477#discussion_r56913906
--- Diff:
pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/MetadataFetcher.java ---
@@ -21,25 +26,26 @@
/**
- * Abstract
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/376#discussion_r53856404
--- Diff: src/test/regress/pg_regress.c ---
@@ -91,8 +91,8 @@ static intport = -1;
static char *user = NULL;
static char *srcdir
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/376#discussion_r53855896
--- Diff: src/test/regress/pg_regress.c ---
@@ -91,8 +91,8 @@ static intport = -1;
static char *user = NULL;
static char *srcdir
Github user sansanichfb commented on the pull request:
https://github.com/apache/incubator-hawq/pull/368#issuecomment-187429072
@shivzone I did run coverity build on local branch, not sure if this link
is accessible outside.
---
If your project is set up for it, you can reply to
GitHub user sansanichfb opened a pull request:
https://github.com/apache/incubator-hawq/pull/368
HAWQ-432. Memory leaks in pg_regress.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-hawq HAWQ-432
Alternatively
Github user sansanichfb closed the pull request at:
https://github.com/apache/incubator-hawq/pull/360
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user sansanichfb opened a pull request:
https://github.com/apache/incubator-hawq/pull/360
Hawq 400
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-hawq HAWQ-400
Alternatively you can review and apply
Github user sansanichfb commented on the pull request:
https://github.com/apache/incubator-hawq/pull/356#issuecomment-186117066
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/356#discussion_r53419960
--- Diff: pxf/build.gradle ---
@@ -434,7 +435,6 @@ task tomcatRpm(type: Rpm) {
packageName 'apache-tomcat'
Github user sansanichfb closed the pull request at:
https://github.com/apache/incubator-hawq/pull/347
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user sansanichfb commented on the pull request:
https://github.com/apache/incubator-hawq/pull/347#issuecomment-185471693
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/347#discussion_r53245058
--- Diff: src/test/regress/GNUmakefile ---
@@ -143,7 +143,7 @@ installcheck-parallel: all upg2-setup ugpart-setup
$(pg_regress_call
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/347#discussion_r53240501
--- Diff: src/test/regress/pg_regress.c ---
@@ -1672,19 +1800,9 @@ run_single_test(const char *test, test_function
tfunc)
differ
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/347#discussion_r53240486
--- Diff: src/test/regress/pg_regress.c ---
@@ -1333,32 +1455,70 @@ wait_for_tests(PID_TYPE * pids, int *statuses, char
**names, int num_tests
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/347#discussion_r53113635
--- Diff: src/test/regress/pg_regress.c ---
@@ -1931,8 +2050,8 @@ regression_main(int argc, char *argv[], init_function
ifunc, test_function
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/347#discussion_r53113151
--- Diff: src/test/regress/pg_regress.c ---
@@ -2025,20 +2144,13 @@ regression_main(int argc, char *argv[],
init_function ifunc, test_function
GitHub user sansanichfb opened a pull request:
https://github.com/apache/incubator-hawq/pull/347
HAWQ-400. Support expected exit codes for regression tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-hawq
Github user sansanichfb commented on the pull request:
https://github.com/apache/incubator-hawq/pull/338#issuecomment-182618898
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user sansanichfb commented on the pull request:
https://github.com/apache/incubator-hawq/commit/37a5043aaccfc0fd6471486fca438e8f7bfb9f79#commitcomment-15900403
@changleicn sure, I created https://issues.apache.org/jira/browse/HAWQ-400
to improve our regression test framework
Github user sansanichfb commented on the pull request:
https://github.com/apache/incubator-hawq/commit/37a5043aaccfc0fd6471486fca438e8f7bfb9f79#commitcomment-15881028
Might be looking confusing, but looks like it's limitation of regression
testing framework - we can't exp
Github user sansanichfb commented on the pull request:
https://github.com/apache/incubator-hawq/commit/37a5043aaccfc0fd6471486fca438e8f7bfb9f79#commitcomment-15880801
@ztao1987 yes, it's expected, because this command "\connect hcatalog;"
returns error of level FATAL
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/324#discussion_r51667038
--- Diff: src/backend/utils/init/postinit.c ---
@@ -368,6 +368,22 @@ InitPostgres(const char *in_dbname, Oid dboid, const
char *username
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/324#discussion_r5190
--- Diff: src/test/regress/output/hcatalog_lookup.source ---
@@ -266,6 +266,29 @@ select pg_catalog.pg_database_size('hcatalog');
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/324#discussion_r5177
--- Diff: src/test/regress/input/hcatalog_lookup.source ---
@@ -138,16 +138,49 @@ alter table test_schema.p exchange partition p1 with
table
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/324#discussion_r51666509
--- Diff: src/backend/utils/init/postinit.c ---
@@ -368,6 +368,22 @@ InitPostgres(const char *in_dbname, Oid dboid, const
char *username
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/324#discussion_r51663054
--- Diff: src/backend/utils/init/postinit.c ---
@@ -368,6 +368,22 @@ InitPostgres(const char *in_dbname, Oid dboid, const
char *username
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/324#discussion_r51662992
--- Diff: src/backend/commands/dbcommands.c ---
@@ -1533,6 +1540,15 @@ RenameDatabase(const char *oldname, const char
*newname)
cqContext
1 - 100 of 125 matches
Mail list logo
