Re: [VOTE] Backup/Restore feature for HBase 2.0, vote closing 3/11/2017

2017-03-16 Thread Stack
On Thu, Mar 16, 2017 at 10:01 AM, Vladimir Rodionov wrote: > v61 is against current master. > > It was what I thought. I got confused by the hijacker. St.Ack > On Thu, Mar 16, 2017 at 7:18 AM, Stack wrote: > > > On Wed, Mar 15, 2017 at 11:38 PM,

Re: About adding methods to an interface which is part of our public API in minor release

2017-03-16 Thread Yu Li
+1 on allow adding methods to interfaces in minor release, especially before 2.0 is out, I don't think a minor release is that "minor" (smile). Regarding refguide, shall we also remind user to check the "incompatible" changes in release note before upgrading for minor version? Best Regards, Yu

[jira] [Reopened] (HBASE-17707) New More Accurate Table Skew cost function/generator

2017-03-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu reopened HBASE-17707: > New More Accurate Table Skew cost function/generator >

Re: About adding methods to an interface which is part of our public API in minor release

2017-03-16 Thread Andrew Purtell
This sounds like a good result to me. We've sometimes provided BaseXXX implementations of interfaces for Java <= 7 but haven't been consistent. Would be good to do better. On Thu, Mar 16, 2017 at 2:18 PM, Stack wrote: > On Thu, Mar 16, 2017 at 11:02 AM, Josh Elser

[jira] [Created] (HBASE-17794) Remove lingering "violation" in favor of the accurate "snapshot"

2017-03-16 Thread Josh Elser (JIRA)
Josh Elser created HBASE-17794: -- Summary: Remove lingering "violation" in favor of the accurate "snapshot" Key: HBASE-17794 URL: https://issues.apache.org/jira/browse/HBASE-17794 Project: HBase

Re: About adding methods to an interface which is part of our public API in minor release

2017-03-16 Thread Stack
On Thu, Mar 16, 2017 at 11:02 AM, Josh Elser wrote: > +1 to the JDK8 default implementation approach. I'd say this would be good > to push forward for the future. > > For 1.x, I see no reason why we couldn't provide concrete implementations > as a stop-gap. Identifying and

[jira] [Resolved] (HBASE-17525) SecureBulkLoadEndpoint not implemented

2017-03-16 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser resolved HBASE-17525. Resolution: Won't Fix Making the call that we'll not include this -- the "standard" path forward

Re: About adding methods to an interface which is part of our public API in minor release

2017-03-16 Thread Ted Yu
+1 to what Josh and James said. On Thu, Mar 16, 2017 at 11:02 AM, Josh Elser wrote: > +1 to the JDK8 default implementation approach. I'd say this would be good > to push forward for the future. > > For 1.x, I see no reason why we couldn't provide concrete implementations >

Re: About adding methods to an interface which is part of our public API in minor release

2017-03-16 Thread Enis Söztutar
+1 for the wording in the book. Otherwise, we cannot add methods to Table / Admin in a minor release, which is very restricting. > How about the idea of HBase having base implementations for common interfaces This is only needed in JDK-7, so basically in 1.x releases. With Java-8, we are doing

Re: About adding methods to an interface which is part of our public API in minor release

2017-03-16 Thread Josh Elser
+1 to the JDK8 default implementation approach. I'd say this would be good to push forward for the future. For 1.x, I see no reason why we couldn't provide concrete implementations as a stop-gap. Identifying and creating those classes is probably the biggest barrier :). I don't think anything

[jira] [Resolved] (HBASE-17789) ZKConfig.getZKQuorumServersStringFromHbaseConfig creates a incorrect zkquorum string

2017-03-16 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser resolved HBASE-17789. Resolution: Invalid > ZKConfig.getZKQuorumServersStringFromHbaseConfig creates a incorrect

Re: [VOTE] Backup/Restore feature for HBase 2.0, vote closing 3/11/2017

2017-03-16 Thread Vladimir Rodionov
v61 is against current master. On Thu, Mar 16, 2017 at 7:18 AM, Stack wrote: > On Wed, Mar 15, 2017 at 11:38 PM, Vladimir Rodionov < > vladrodio...@gmail.com> > wrote: > > > >> I thought I was reviewing a patch that was against master > > > > Yes, it was against master. We

Successful: HBase Generate Website

2017-03-16 Thread Apache Jenkins Server
Build status: Successful If successful, the website and docs have been generated. To update the live site, follow the instructions below. If failed, skip to the bottom of this email. Use the following commands to download the patch and apply it to a clean branch based on origin/asf-site. If

Re: [VOTE] Backup/Restore feature for HBase 2.0, vote closing 3/11/2017

2017-03-16 Thread Stack
On Wed, Mar 15, 2017 at 11:38 PM, Vladimir Rodionov wrote: > >> I thought I was reviewing a patch that was against master > > Yes, it was against master. We used to develop in HBASE-7912 branch, but it > was abandoned 6-8 mo ago. > This is why the only way to merge backup

Re: Assigning regions after restart

2017-03-16 Thread Lars George
JIRA creation is done: https://issues.apache.org/jira/browse/HBASE-17791 I will have a look into it over the next few days, maybe I can come up with a patch. On Wed, Mar 15, 2017 at 6:14 AM, Stack wrote: > File a blocker please Lars. I'm pretty sure the boolean on whether we

Re: [VOTE] Backup/Restore feature for HBase 2.0, vote closing 3/11/2017

2017-03-16 Thread Vladimir Rodionov
>> I thought I was reviewing a patch that was against master Yes, it was against master. We used to develop in HBASE-7912 branch, but it was abandoned 6-8 mo ago. This is why the only way to merge backup is to apply v61 directly to master branch. -Vlad On Wed, Mar 15, 2017 at 9:17 PM, Stack

Re: About adding methods to an interface which is part of our public API in minor release

2017-03-16 Thread James Taylor
How about the idea of HBase having base implementations for common interfaces? That would often help applications built on top of HBase to maintain backward compatibility from release to release. On Wed, Mar 15, 2017 at 10:38 PM Stack wrote: > On Wed, Mar 15, 2017 at 10:28 PM,